[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 include/vcl vcl/inc vcl/source vcl/unx
Noel Grandin
noel.grandin at collabora.co.uk
Thu Sep 15 06:37:08 UTC 2016
compilerplugins/clang/countusersofdefaultparams.py | 3 +++
include/sfx2/sidebar/SidebarToolBox.hxx | 2 +-
include/vcl/animate.hxx | 4 ++--
include/vcl/bitmap.hxx | 2 +-
include/vcl/bitmapex.hxx | 4 ++--
include/vcl/btndlg.hxx | 2 +-
include/vcl/button.hxx | 2 +-
include/vcl/commandevent.hxx | 4 ++--
include/vcl/dockwin.hxx | 2 +-
include/vcl/fixed.hxx | 2 +-
include/vcl/floatwin.hxx | 4 ++--
include/vcl/gdimtf.hxx | 2 +-
include/vcl/graph.hxx | 2 +-
include/vcl/graphicfilter.hxx | 6 +++---
include/vcl/group.hxx | 2 +-
include/vcl/hatch.hxx | 2 +-
include/vcl/imgctrl.hxx | 2 +-
include/vcl/layout.hxx | 2 +-
include/vcl/lstbox.hxx | 2 +-
include/vcl/menubtn.hxx | 2 +-
include/vcl/morebtn.hxx | 2 +-
include/vcl/openglwin.hxx | 2 +-
include/vcl/outdev.hxx | 2 +-
include/vcl/pdfextoutdevdata.hxx | 2 +-
include/vcl/pdfwriter.hxx | 10 +++++-----
include/vcl/prgsbar.hxx | 5 +----
include/vcl/print.hxx | 2 +-
include/vcl/scheduler.hxx | 2 +-
include/vcl/slider.hxx | 2 +-
include/vcl/spin.hxx | 2 +-
include/vcl/spinfld.hxx | 2 +-
include/vcl/splitwin.hxx | 6 +++---
include/vcl/syschild.hxx | 2 +-
include/vcl/tabctrl.hxx | 2 +-
include/vcl/tabdlg.hxx | 2 +-
include/vcl/toolbox.hxx | 2 +-
include/vcl/vclevent.hxx | 2 +-
include/vcl/vclmedit.hxx | 2 +-
include/vcl/window.hxx | 2 +-
include/vcl/wmf.hxx | 2 +-
vcl/inc/brdwin.hxx | 4 ++--
vcl/inc/headless/svpinst.hxx | 2 +-
vcl/inc/listbox.hxx | 4 ++--
vcl/inc/salmenu.hxx | 4 ++--
vcl/inc/unx/gtk/gtkobject.hxx | 2 +-
vcl/source/filter/jpeg/JpegWriter.hxx | 2 +-
vcl/source/filter/wmf/winmtf.hxx | 6 +++---
vcl/source/fontsubset/cff.cxx | 2 +-
vcl/source/gdi/pngwrite.cxx | 2 +-
vcl/unx/generic/dtrans/X11_transferable.hxx | 2 +-
vcl/unx/generic/print/prtsetup.hxx | 2 +-
51 files changed, 70 insertions(+), 70 deletions(-)
New commits:
commit 6df2c90c08b67b943022286e7152b51d52e0ef5e
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Wed Sep 14 12:26:36 2016 +0200
loplugin:countusersofdefaultparams in vcl
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979
Reviewed-on: https://gerrit.libreoffice.org/28891
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/countusersofdefaultparams.py b/compilerplugins/clang/countusersofdefaultparams.py
index f8cda6a..06db0df 100755
--- a/compilerplugins/clang/countusersofdefaultparams.py
+++ b/compilerplugins/clang/countusersofdefaultparams.py
@@ -62,6 +62,9 @@ for k,v in callDict.iteritems():
# windows-only stuff
if "ShutdownIcon::OpenURL" in k:
continue
+ # template magic
+ if k.startswith("void VclPtr::VclPtr(const VclPtr<type-parameter-?-?> &,typename UpCast<"):
+ continue
if k in definitionToSourceLocationMap:
tmp1list.append((k, definitionToSourceLocationMap[k]))
diff --git a/include/sfx2/sidebar/SidebarToolBox.hxx b/include/sfx2/sidebar/SidebarToolBox.hxx
index 893e8ce..85290a1 100644
--- a/include/sfx2/sidebar/SidebarToolBox.hxx
+++ b/include/sfx2/sidebar/SidebarToolBox.hxx
@@ -49,7 +49,7 @@ public:
virtual void InsertItem(const OUString& rCommand,
const css::uno::Reference<css::frame::XFrame>& rFrame,
ToolBoxItemBits nBits,
- const Size& rRequestedSize = Size(),
+ const Size& rRequestedSize,
sal_uInt16 nPos = TOOLBOX_APPEND) override;
virtual bool Notify (NotifyEvent& rEvent) override;
diff --git a/include/vcl/animate.hxx b/include/vcl/animate.hxx
index f240af7..75503de 100644
--- a/include/vcl/animate.hxx
+++ b/include/vcl/animate.hxx
@@ -102,7 +102,7 @@ public:
const Point& rDestPt,
const Size& rDestSz,
long nExtraData,
- OutputDevice* pFirstFrameOutDev = nullptr);
+ OutputDevice* pFirstFrameOutDev);
void Stop( OutputDevice* pOutDev = nullptr, long nExtraData = 0 );
@@ -143,7 +143,7 @@ public:
bool Mirror( BmpMirrorFlags nMirrorFlags );
bool Adjust(
short nLuminancePercent,
- short nContrastPercent = 0,
+ short nContrastPercent,
short nChannelRPercent = 0,
short nChannelGPercent = 0,
short nChannelBPercent = 0,
diff --git a/include/vcl/bitmap.hxx b/include/vcl/bitmap.hxx
index e206700..d3035bf 100644
--- a/include/vcl/bitmap.hxx
+++ b/include/vcl/bitmap.hxx
@@ -634,7 +634,7 @@ public:
bool Vectorize(
GDIMetaFile& rMtf,
sal_uInt8 cReduce,
- const Link<long,void>* pProgress = nullptr );
+ const Link<long,void>* pProgress );
/** Change various global color characteristics
diff --git a/include/vcl/bitmapex.hxx b/include/vcl/bitmapex.hxx
index 8912eae..115e353 100644
--- a/include/vcl/bitmapex.hxx
+++ b/include/vcl/bitmapex.hxx
@@ -326,7 +326,7 @@ public:
*/
bool Adjust(
short nLuminancePercent,
- short nContrastPercent = 0,
+ short nContrastPercent,
short nChannelRPercent = 0,
short nChannelGPercent = 0,
short nChannelBPercent = 0,
@@ -409,7 +409,7 @@ public:
const basegfx::B2DHomMatrix& rTransformation,
const basegfx::B2DRange& rVisibleRange,
double fMaximumArea,
- bool bSmooth = true) const;
+ bool bSmooth) const;
/** Create ColorStack-modified version of this BitmapEx
diff --git a/include/vcl/btndlg.hxx b/include/vcl/btndlg.hxx
index fbb36e9..4d54f8e 100644
--- a/include/vcl/btndlg.hxx
+++ b/include/vcl/btndlg.hxx
@@ -50,7 +50,7 @@ namespace o3tl
class VCL_DLLPUBLIC ButtonDialog : public Dialog
{
public:
- ButtonDialog( vcl::Window* pParent, WinBits nStyle = WB_STDDIALOG );
+ ButtonDialog( vcl::Window* pParent, WinBits nStyle );
virtual ~ButtonDialog() override;
virtual void dispose() override;
diff --git a/include/vcl/button.hxx b/include/vcl/button.hxx
index 1d425de5..8350a21 100644
--- a/include/vcl/button.hxx
+++ b/include/vcl/button.hxx
@@ -523,7 +523,7 @@ class VCL_DLLPUBLIC TriStateBox : public CheckBox
TriStateBox & operator= ( const TriStateBox & ) = delete;
public:
- explicit TriStateBox( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit TriStateBox( vcl::Window* pParent, WinBits nStyle );
};
class VCL_DLLPUBLIC DisclosureButton : public CheckBox
diff --git a/include/vcl/commandevent.hxx b/include/vcl/commandevent.hxx
index eb8fab1..5b9cc09 100644
--- a/include/vcl/commandevent.hxx
+++ b/include/vcl/commandevent.hxx
@@ -151,7 +151,7 @@ public:
CommandWheelData( long nWheelDelta, long nWheelNotchDelta,
sal_uLong nScrollLines,
CommandWheelMode nWheelMode, sal_uInt16 nKeyModifier,
- bool bHorz = false, bool bDeltaIsPixel = false );
+ bool bHorz, bool bDeltaIsPixel = false );
long GetDelta() const { return mnDelta; }
long GetNotchDelta() const { return mnNotchDelta; }
@@ -208,7 +208,7 @@ class VCL_DLLPUBLIC CommandDialogData
{
ShowDialogId m_nDialogId;
public:
- CommandDialogData( ShowDialogId nDialogId = ShowDialogId::Preferences )
+ CommandDialogData( ShowDialogId nDialogId )
: m_nDialogId( nDialogId )
{}
diff --git a/include/vcl/dockwin.hxx b/include/vcl/dockwin.hxx
index 9647fc7..a3d0a7b 100644
--- a/include/vcl/dockwin.hxx
+++ b/include/vcl/dockwin.hxx
@@ -274,7 +274,7 @@ protected:
DockingWindow( WindowType nType );
public:
- DockingWindow(vcl::Window* pParent, WinBits nStyle = WB_STDDOCKWIN);
+ DockingWindow(vcl::Window* pParent, WinBits nStyle);
DockingWindow(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription,
const css::uno::Reference<css::frame::XFrame> &rFrame = css::uno::Reference<css::frame::XFrame>());
virtual ~DockingWindow() override;
diff --git a/include/vcl/fixed.hxx b/include/vcl/fixed.hxx
index 97e1e5a..85f3a23 100644
--- a/include/vcl/fixed.hxx
+++ b/include/vcl/fixed.hxx
@@ -82,7 +82,7 @@ public:
class VCL_DLLPUBLIC SelectableFixedText : public Edit
{
public:
- explicit SelectableFixedText( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit SelectableFixedText( vcl::Window* pParent, WinBits nStyle );
virtual void LoseFocus() override;
virtual void ApplySettings(vcl::RenderContext&) override;
diff --git a/include/vcl/floatwin.hxx b/include/vcl/floatwin.hxx
index 8933bf9..c1e0d30 100644
--- a/include/vcl/floatwin.hxx
+++ b/include/vcl/floatwin.hxx
@@ -126,13 +126,13 @@ public:
sal_uInt16& rArrangeIndex );
static Point ImplConvertToAbsPos(vcl::Window* pReference, const Point& rPos);
static Rectangle ImplConvertToAbsPos(vcl::Window* pReference, const Rectangle& rRect);
- SAL_DLLPRIVATE void ImplEndPopupMode( FloatWinPopupEndFlags nFlags, const VclPtr<vcl::Window>& xFocusId = nullptr );
+ SAL_DLLPRIVATE void ImplEndPopupMode( FloatWinPopupEndFlags nFlags, const VclPtr<vcl::Window>& xFocusId );
SAL_DLLPRIVATE Rectangle& ImplGetItemEdgeClipRect();
SAL_DLLPRIVATE bool ImplIsInPrivatePopupMode() const { return mbInPopupMode; }
virtual void doDeferredInit(WinBits nBits) override;
public:
- explicit FloatingWindow(vcl::Window* pParent, WinBits nStyle = WB_STDFLOATWIN);
+ explicit FloatingWindow(vcl::Window* pParent, WinBits nStyle);
explicit FloatingWindow(vcl::Window* pParent, const OString& rID, const OUString& rUIXMLDescription,
const css::uno::Reference<css::frame::XFrame> &rFrame = css::uno::Reference<css::frame::XFrame>());
virtual ~FloatingWindow() override;
diff --git a/include/vcl/gdimtf.hxx b/include/vcl/gdimtf.hxx
index 5e1567b..61d5a44 100644
--- a/include/vcl/gdimtf.hxx
+++ b/include/vcl/gdimtf.hxx
@@ -129,7 +129,7 @@ public:
*/
Rectangle GetBoundRect( OutputDevice& i_rReference, Rectangle* pHairline = nullptr ) const;
- void Adjust( short nLuminancePercent, short nContrastPercent = 0,
+ void Adjust( short nLuminancePercent, short nContrastPercent,
short nChannelRPercent = 0, short nChannelGPercent = 0,
short nChannelBPercent = 0, double fGamma = 1.0,
bool bInvert = false, bool msoBrightness = false );
diff --git a/include/vcl/graph.hxx b/include/vcl/graph.hxx
index f714062..1e8c076 100644
--- a/include/vcl/graph.hxx
+++ b/include/vcl/graph.hxx
@@ -180,7 +180,7 @@ public:
long nExtraData = 0L,
OutputDevice* pFirstFrameOutDev = nullptr );
void StopAnimation( OutputDevice* pOutputDevice,
- long nExtraData = 0L );
+ long nExtraData );
void SetAnimationNotifyHdl( const Link<Animation*,void>& rLink );
Link<Animation*,void> GetAnimationNotifyHdl() const;
diff --git a/include/vcl/graphicfilter.hxx b/include/vcl/graphicfilter.hxx
index f1e89ef..4102c84 100644
--- a/include/vcl/graphicfilter.hxx
+++ b/include/vcl/graphicfilter.hxx
@@ -190,7 +190,7 @@ public:
As some formats (Mtf's) do not have a unique header, it makes sense
to supply the file name (incl. ext.), so that the format can be
derived from the extension */
- GraphicDescriptor( SvStream& rInStream, const OUString* pPath = nullptr );
+ GraphicDescriptor( SvStream& rInStream, const OUString* pPath );
virtual ~GraphicDescriptor();
@@ -274,8 +274,8 @@ public:
bool IsExportPixelFormat( sal_uInt16 nFormat );
sal_uInt16 ExportGraphic( const Graphic& rGraphic, const INetURLObject& rPath,
- sal_uInt16 nFormat,
- const css::uno::Sequence< css::beans::PropertyValue >* pFilterData = nullptr );
+ sal_uInt16 nFormat,
+ const css::uno::Sequence< css::beans::PropertyValue >* pFilterData = nullptr );
sal_uInt16 ExportGraphic( const Graphic& rGraphic, const OUString& rPath,
SvStream& rOStm, sal_uInt16 nFormat,
const css::uno::Sequence< css::beans::PropertyValue >* pFilterData = nullptr );
diff --git a/include/vcl/group.hxx b/include/vcl/group.hxx
index 3c44b8c..a66b134 100644
--- a/include/vcl/group.hxx
+++ b/include/vcl/group.hxx
@@ -43,7 +43,7 @@ private:
GetCanonicalTextColor( const StyleSettings& _rStyle ) const override;
public:
- explicit GroupBox( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit GroupBox( vcl::Window* pParent, WinBits nStyle );
virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) override;
virtual void Draw( OutputDevice* pDev, const Point& rPos, const Size& rSize, DrawFlags nFlags ) override;
diff --git a/include/vcl/hatch.hxx b/include/vcl/hatch.hxx
index 41b9b95..3b326b4 100644
--- a/include/vcl/hatch.hxx
+++ b/include/vcl/hatch.hxx
@@ -48,7 +48,7 @@ public:
Hatch();
Hatch( const Hatch& rHatch );
- Hatch( HatchStyle eStyle, const Color& rHatchColor, long nDistance, sal_uInt16 nAngle10 = 0 );
+ Hatch( HatchStyle eStyle, const Color& rHatchColor, long nDistance, sal_uInt16 nAngle10 );
~Hatch();
Hatch& operator=( const Hatch& rHatch );
diff --git a/include/vcl/imgctrl.hxx b/include/vcl/imgctrl.hxx
index 656bc83..14fe5e6 100644
--- a/include/vcl/imgctrl.hxx
+++ b/include/vcl/imgctrl.hxx
@@ -32,7 +32,7 @@ private:
::sal_Int16 mnScaleMode;
public:
- ImageControl( vcl::Window* pParent, WinBits nStyle = 0 );
+ ImageControl( vcl::Window* pParent, WinBits nStyle );
// set/get the scale mode. This is one of the css.awt.ImageScaleMode constants
void SetScaleMode( const ::sal_Int16 _nMode );
diff --git a/include/vcl/layout.hxx b/include/vcl/layout.hxx
index 1713e64..6f75909 100644
--- a/include/vcl/layout.hxx
+++ b/include/vcl/layout.hxx
@@ -658,7 +658,7 @@ private:
void create_owned_areas();
friend class VclPtr<MessageDialog>;
- MessageDialog(vcl::Window* pParent, WinBits nStyle = WB_MOVEABLE | WB_3DLOOK | WB_CLOSEABLE);
+ MessageDialog(vcl::Window* pParent, WinBits nStyle);
public:
MessageDialog(vcl::Window* pParent,
diff --git a/include/vcl/lstbox.hxx b/include/vcl/lstbox.hxx
index aebdcb3..455a82a 100644
--- a/include/vcl/lstbox.hxx
+++ b/include/vcl/lstbox.hxx
@@ -284,7 +284,7 @@ public:
using ListBox::GetSavedValue;
using ListBox::IsValueChangedFromSaved;
- explicit MultiListBox( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit MultiListBox( vcl::Window* pParent, WinBits nStyle );
};
diff --git a/include/vcl/menubtn.hxx b/include/vcl/menubtn.hxx
index 6c628aa..535ad84 100644
--- a/include/vcl/menubtn.hxx
+++ b/include/vcl/menubtn.hxx
@@ -81,7 +81,7 @@ public:
class VCL_DLLPUBLIC MenuToggleButton : public MenuButton
{
public:
- explicit MenuToggleButton( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit MenuToggleButton( vcl::Window* pParent, WinBits nStyle );
virtual ~MenuToggleButton() override;
void SetActive( bool bSel );
diff --git a/include/vcl/morebtn.hxx b/include/vcl/morebtn.hxx
index 20a76cb..4204366 100644
--- a/include/vcl/morebtn.hxx
+++ b/include/vcl/morebtn.hxx
@@ -44,7 +44,7 @@ protected:
SAL_DLLPRIVATE void ImplInit( vcl::Window* pParent, WinBits nStyle );
public:
- explicit MoreButton( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit MoreButton( vcl::Window* pParent, WinBits nStyle );
virtual ~MoreButton() override;
virtual void dispose() override;
diff --git a/include/vcl/openglwin.hxx b/include/vcl/openglwin.hxx
index e04c098..da89831 100644
--- a/include/vcl/openglwin.hxx
+++ b/include/vcl/openglwin.hxx
@@ -33,7 +33,7 @@ public:
class VCL_DLLPUBLIC OpenGLWindow : public vcl::Window
{
public:
- OpenGLWindow(vcl::Window* pParent, bool bInit = true);
+ OpenGLWindow(vcl::Window* pParent, bool bInit);
virtual ~OpenGLWindow() override;
virtual void dispose() override;
diff --git a/include/vcl/outdev.hxx b/include/vcl/outdev.hxx
index 88b1233..2be52c3 100644
--- a/include/vcl/outdev.hxx
+++ b/include/vcl/outdev.hxx
@@ -1314,7 +1314,7 @@ private:
public:
SystemTextLayoutData GetSysTextLayoutData( const Point& rStartPt, const OUString& rStr,
- sal_Int32 nIndex, sal_Int32 nLen = -1,
+ sal_Int32 nIndex, sal_Int32 nLen,
const long* pDXAry = nullptr ) const;
SAL_DLLPRIVATE bool ImplIsAntiparallel() const ;
diff --git a/include/vcl/pdfextoutdevdata.hxx b/include/vcl/pdfextoutdevdata.hxx
index a4901ca..e6468a6 100644
--- a/include/vcl/pdfextoutdevdata.hxx
+++ b/include/vcl/pdfextoutdevdata.hxx
@@ -309,7 +309,7 @@ public:
@returns
the outline item id of the new item
*/
- sal_Int32 CreateOutlineItem( sal_Int32 nParent, const OUString& rText = OUString(), sal_Int32 nDestID = -1 );
+ sal_Int32 CreateOutlineItem( sal_Int32 nParent, const OUString& rText, sal_Int32 nDestID = -1 );
/** Create a new note on a page
diff --git a/include/vcl/pdfwriter.hxx b/include/vcl/pdfwriter.hxx
index 6255714..7775ba4 100644
--- a/include/vcl/pdfwriter.hxx
+++ b/include/vcl/pdfwriter.hxx
@@ -666,7 +666,7 @@ The following structure describes the permissions used in PDF security
Colors and other state information MUST
be set again or are undefined.
*/
- void NewPage( sal_Int32 nPageWidth, sal_Int32 nPageHeight = 0, Orientation eOrientation = Inherit );
+ void NewPage( sal_Int32 nPageWidth, sal_Int32 nPageHeight, Orientation eOrientation = Inherit );
/** Play a metafile like an outputdevice would do
*/
struct PlayMetafileContext
@@ -870,7 +870,7 @@ The following structure describes the permissions used in PDF security
the destination id (to be used in SetLinkDest) or
-1 if page id does not exist
*/
- sal_Int32 CreateNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType = XYZ );
+ sal_Int32 CreateNamedDest( const OUString& sDestName, const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType );
/** Create a new destination to be used in a link
@param rRect
@@ -887,7 +887,7 @@ The following structure describes the permissions used in PDF security
the destination id (to be used in SetLinkDest) or
-1 if page id does not exist
*/
- sal_Int32 CreateDest( const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType = XYZ );
+ sal_Int32 CreateDest( const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType );
/** Create a new link on a page
@param rRect
@@ -926,7 +926,7 @@ The following structure describes the permissions used in PDF security
@returns
the internal destination Id.
*/
- sal_Int32 RegisterDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType = XYZ );
+ sal_Int32 RegisterDestReference( sal_Int32 nDestId, const Rectangle& rRect, sal_Int32 nPageNr, DestAreaType eType );
/** Set the destination for a link
@@ -993,7 +993,7 @@ The following structure describes the permissions used in PDF security
@returns
the outline item id of the new item
*/
- sal_Int32 CreateOutlineItem( sal_Int32 nParent, const OUString& rText = OUString(), sal_Int32 nDestID = -1 );
+ sal_Int32 CreateOutlineItem( sal_Int32 nParent, const OUString& rText, sal_Int32 nDestID = -1 );
/** Set an outline item's parent
diff --git a/include/vcl/prgsbar.hxx b/include/vcl/prgsbar.hxx
index 85b1e24..364c6ea 100644
--- a/include/vcl/prgsbar.hxx
+++ b/include/vcl/prgsbar.hxx
@@ -46,9 +46,6 @@
************************************************************************/
-#define WB_STDPROGRESSBAR WB_BORDER
-
-
class VCL_DLLPUBLIC ProgressBar : public vcl::Window
{
private:
@@ -66,7 +63,7 @@ private:
SAL_DLLPRIVATE void ImplDrawProgress(vcl::RenderContext& rRenderContext, sal_uInt16 nOldPerc, sal_uInt16 nNewPerc);
public:
- ProgressBar( vcl::Window* pParent, WinBits nWinBits = WB_STDPROGRESSBAR );
+ ProgressBar( vcl::Window* pParent, WinBits nWinBits );
virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) override;
virtual void Resize() override;
diff --git a/include/vcl/print.hxx b/include/vcl/print.hxx
index 704f3514..5578615 100644
--- a/include/vcl/print.hxx
+++ b/include/vcl/print.hxx
@@ -683,7 +683,7 @@ public:
*/
static css::uno::Any setRangeControlOpt( const OUString& i_rID, const OUString& i_rTitle, const OUString& i_rHelpId,
const OUString& i_rProperty, sal_Int32 i_nValue, sal_Int32 i_nMinValue,
- sal_Int32 i_nMaxValue = -2, const UIControlOptions& i_rControlOptions = UIControlOptions());
+ sal_Int32 i_nMaxValue, const UIControlOptions& i_rControlOptions = UIControlOptions());
/** Show a string field
diff --git a/include/vcl/scheduler.hxx b/include/vcl/scheduler.hxx
index 3abd37d..ef6949d 100644
--- a/include/vcl/scheduler.hxx
+++ b/include/vcl/scheduler.hxx
@@ -64,7 +64,7 @@ protected:
virtual sal_uInt64 UpdateMinPeriod( sal_uInt64 nMinPeriod, sal_uInt64 nTimeNow ) const = 0;
public:
- Scheduler( const sal_Char *pDebugName = nullptr );
+ Scheduler( const sal_Char *pDebugName );
Scheduler( const Scheduler& rScheduler );
virtual ~Scheduler();
diff --git a/include/vcl/slider.hxx b/include/vcl/slider.hxx
index 09ead4dd..a7e94d1 100644
--- a/include/vcl/slider.hxx
+++ b/include/vcl/slider.hxx
@@ -79,7 +79,7 @@ private:
SAL_DLLPRIVATE void ImplUpdateLinkedField();
public:
- Slider( vcl::Window* pParent, WinBits nStyle = WB_HORZ );
+ Slider( vcl::Window* pParent, WinBits nStyle);
virtual ~Slider() override;
virtual void dispose() override;
virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
diff --git a/include/vcl/spin.hxx b/include/vcl/spin.hxx
index d381fd1..b616894 100644
--- a/include/vcl/spin.hxx
+++ b/include/vcl/spin.hxx
@@ -51,7 +51,7 @@ private:
DECL_DLLPRIVATE_LINK_TYPED( ImplTimeout, Timer*, void );
public:
- explicit SpinButton( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit SpinButton( vcl::Window* pParent, WinBits nStyle );
void Up();
void Down();
diff --git a/include/vcl/spinfld.hxx b/include/vcl/spinfld.hxx
index 503bcb1..552c939 100644
--- a/include/vcl/spinfld.hxx
+++ b/include/vcl/spinfld.hxx
@@ -66,7 +66,7 @@ protected:
Rectangle * ImplFindPartRect( const Point& rPt );
public:
- explicit SpinField( vcl::Window* pParent, WinBits nWinStyle = 0 );
+ explicit SpinField( vcl::Window* pParent, WinBits nWinStyle );
explicit SpinField( vcl::Window* pParent, const ResId& );
virtual ~SpinField() override;
virtual void dispose() override;
diff --git a/include/vcl/splitwin.hxx b/include/vcl/splitwin.hxx
index 1f24688..2bacd58 100644
--- a/include/vcl/splitwin.hxx
+++ b/include/vcl/splitwin.hxx
@@ -145,17 +145,17 @@ public:
virtual bool PreNotify( NotifyEvent& rNEvt ) override;
void InsertItem( sal_uInt16 nId, vcl::Window* pWindow, long nSize,
- sal_uInt16 nPos, sal_uInt16 nIntoSetId = 0,
+ sal_uInt16 nPos, sal_uInt16 nIntoSetId,
SplitWindowItemFlags nBits = SplitWindowItemFlags::NONE );
void InsertItem( sal_uInt16 nId, long nSize,
- sal_uInt16 nPos, sal_uInt16 nIntoSetId = 0,
+ sal_uInt16 nPos, sal_uInt16 nIntoSetId,
SplitWindowItemFlags nBits = SplitWindowItemFlags::NONE );
void RemoveItem( sal_uInt16 nId );
void Clear();
void SplitItem( sal_uInt16 nId, long nNewSize,
bool bPropSmall,
- bool bPropGreat = false );
+ bool bPropGreat );
void SetItemSize( sal_uInt16 nId, long nNewSize );
long GetItemSize( sal_uInt16 nId ) const;
/** Set a range that limits the (variable part of the) size with an
diff --git a/include/vcl/syschild.hxx b/include/vcl/syschild.hxx
index e4142c8..3f5ed9b 100644
--- a/include/vcl/syschild.hxx
+++ b/include/vcl/syschild.hxx
@@ -37,7 +37,7 @@ private:
SystemChildWindow & operator= (const SystemChildWindow &) = delete;
public:
- explicit SystemChildWindow( vcl::Window* pParent, WinBits nStyle = 0 );
+ explicit SystemChildWindow( vcl::Window* pParent, WinBits nStyle );
// create a SystemChildWindow using the given SystemWindowData
explicit SystemChildWindow( vcl::Window* pParent, WinBits nStyle, SystemWindowData *pData, bool bShow = true );
virtual ~SystemChildWindow() override;
diff --git a/include/vcl/tabctrl.hxx b/include/vcl/tabctrl.hxx
index ea9ea42..fcb35d3 100644
--- a/include/vcl/tabctrl.hxx
+++ b/include/vcl/tabctrl.hxx
@@ -72,7 +72,7 @@ protected:
SAL_DLLPRIVATE void ImplShowFocus();
SAL_DLLPRIVATE void ImplDrawItem(vcl::RenderContext& rRenderContext, ImplTabItem* pItem,
const Rectangle& rCurRect, bool bFirstInGroup,
- bool bLastInGroup = false, bool bIsCurrentItem = false);
+ bool bLastInGroup, bool bIsCurrentItem = false);
SAL_DLLPRIVATE void ImplFreeLayoutData();
SAL_DLLPRIVATE bool ImplHandleKeyEvent( const KeyEvent& rKeyEvent );
diff --git a/include/vcl/tabdlg.hxx b/include/vcl/tabdlg.hxx
index 0849cc8..32a34e3 100644
--- a/include/vcl/tabdlg.hxx
+++ b/include/vcl/tabdlg.hxx
@@ -39,7 +39,7 @@ private:
public:
TabDialog( vcl::Window* pParent,
- WinBits nStyle = WB_STDTABDIALOG );
+ WinBits nStyle );
TabDialog( vcl::Window* pParent, const OUString& rID, const OUString& rUIXMLDescription );
virtual ~TabDialog() override;
virtual void dispose() override;
diff --git a/include/vcl/toolbox.hxx b/include/vcl/toolbox.hxx
index ca913c8..e8c5a92 100644
--- a/include/vcl/toolbox.hxx
+++ b/include/vcl/toolbox.hxx
@@ -301,7 +301,7 @@ public:
virtual void InsertItem( const OUString& rCommand,
const css::uno::Reference<css::frame::XFrame>& rFrame,
ToolBoxItemBits nBits,
- const Size& rRequestedSize = Size(),
+ const Size& rRequestedSize,
sal_uInt16 nPos = TOOLBOX_APPEND );
void InsertItem( sal_uInt16 nItemId, const Image& rImage,
ToolBoxItemBits nBits = ToolBoxItemBits::NONE,
diff --git a/include/vcl/vclevent.hxx b/include/vcl/vclevent.hxx
index 232162b..a1c9a972 100644
--- a/include/vcl/vclevent.hxx
+++ b/include/vcl/vclevent.hxx
@@ -212,7 +212,7 @@ private:
void* pData;
public:
- VclWindowEvent( vcl::Window* pWin, sal_uLong n, void* pDat = nullptr );
+ VclWindowEvent( vcl::Window* pWin, sal_uLong n, void* pDat );
virtual ~VclWindowEvent() override;
vcl::Window* GetWindow() const { return pWindow; }
diff --git a/include/vcl/vclmedit.hxx b/include/vcl/vclmedit.hxx
index 89d07c5..c6436f9 100644
--- a/include/vcl/vclmedit.hxx
+++ b/include/vcl/vclmedit.hxx
@@ -59,7 +59,7 @@ protected:
virtual void ApplySettings(vcl::RenderContext& rRenderContext) override;
public:
VclMultiLineEdit( vcl::Window* pParent,
- WinBits nWinStyle = WB_LEFT | WB_BORDER );
+ WinBits nWinStyle );
virtual ~VclMultiLineEdit() override;
virtual void dispose() override;
diff --git a/include/vcl/window.hxx b/include/vcl/window.hxx
index e638c60..8c82fa9 100644
--- a/include/vcl/window.hxx
+++ b/include/vcl/window.hxx
@@ -1204,7 +1204,7 @@ public:
bool HandleScrollCommand( const CommandEvent& rCmd,
ScrollBar* pHScrl,
- ScrollBar* pVScrl = nullptr );
+ ScrollBar* pVScrl );
void SaveBackground( const Point& rPos, const Size& rSize,
const Point& rDestOff, VirtualDevice& rSaveDevice );
diff --git a/include/vcl/wmf.hxx b/include/vcl/wmf.hxx
index 7ee2447..bea47d2 100644
--- a/include/vcl/wmf.hxx
+++ b/include/vcl/wmf.hxx
@@ -55,7 +55,7 @@ struct WMF_EXTERNALHEADER
}
};
-bool ConvertWMFToGDIMetaFile( SvStream & rStreamWMF, GDIMetaFile & rGDIMetaFile, FilterConfigItem* pConfigItem, WMF_EXTERNALHEADER *pExtHeader = nullptr );
+bool ConvertWMFToGDIMetaFile( SvStream & rStreamWMF, GDIMetaFile & rGDIMetaFile, FilterConfigItem* pConfigItem, WMF_EXTERNALHEADER *pExtHeader );
VCL_DLLPUBLIC bool ReadWindowMetafile( SvStream& rStream, GDIMetaFile& rMTF );
diff --git a/vcl/inc/brdwin.hxx b/vcl/inc/brdwin.hxx
index c0802ed..67b900a 100644
--- a/vcl/inc/brdwin.hxx
+++ b/vcl/inc/brdwin.hxx
@@ -119,9 +119,9 @@ private:
public:
ImplBorderWindow( vcl::Window* pParent,
SystemParentData* pParentData,
- WinBits nStyle = 0,
+ WinBits nStyle,
BorderWindowStyle nTypeStyle = BorderWindowStyle::NONE );
- ImplBorderWindow( vcl::Window* pParent, WinBits nStyle = 0,
+ ImplBorderWindow( vcl::Window* pParent, WinBits nStyle,
BorderWindowStyle nTypeStyle = BorderWindowStyle::NONE );
virtual ~ImplBorderWindow() override;
virtual void dispose() override;
diff --git a/vcl/inc/headless/svpinst.hxx b/vcl/inc/headless/svpinst.hxx
index e7ed204..df550c4 100644
--- a/vcl/inc/headless/svpinst.hxx
+++ b/vcl/inc/headless/svpinst.hxx
@@ -70,7 +70,7 @@ class VCL_DLLPUBLIC SvpSalInstance : public SalGenericInstance
ImplSVEvent* m_pData;
SalEvent m_nEvent;
- SalUserEvent( const SalFrame* pFrame, ImplSVEvent* pData, SalEvent nEvent = SalEvent::UserEvent )
+ SalUserEvent( const SalFrame* pFrame, ImplSVEvent* pData, SalEvent nEvent )
: m_pFrame( pFrame ),
m_pData( pData ),
m_nEvent( nEvent )
diff --git a/vcl/inc/listbox.hxx b/vcl/inc/listbox.hxx
index 14150bc..abddd4e 100644
--- a/vcl/inc/listbox.hxx
+++ b/vcl/inc/listbox.hxx
@@ -530,7 +530,7 @@ protected:
virtual void FillLayoutData() const override;
public:
- ImplWin( vcl::Window* pParent, WinBits nWinStyle = 0 );
+ ImplWin( vcl::Window* pParent, WinBits nWinStyle );
virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
virtual void Paint( vcl::RenderContext& rRenderContext, const Rectangle& rRect ) override;
@@ -576,7 +576,7 @@ private:
Link<void*,void> maMBDownHdl;
public:
- ImplBtn( vcl::Window* pParent, WinBits nWinStyle = 0 );
+ ImplBtn( vcl::Window* pParent, WinBits nWinStyle );
virtual void MouseButtonDown( const MouseEvent& rMEvt ) override;
void MBDown();
diff --git a/vcl/inc/salmenu.hxx b/vcl/inc/salmenu.hxx
index 734518d..8b2b5e2 100644
--- a/vcl/inc/salmenu.hxx
+++ b/vcl/inc/salmenu.hxx
@@ -41,10 +41,10 @@ struct SalMenuButtonItem
{
sal_uInt16 mnId;
Image maImage;
- OUString maToolTipText;
+ OUString maToolTipText;
SalMenuButtonItem() : mnId( 0 ) {}
- SalMenuButtonItem( sal_uInt16 i_nId, const Image& rImg, const OUString& i_rTTText = OUString() )
+ SalMenuButtonItem( sal_uInt16 i_nId, const Image& rImg, const OUString& i_rTTText )
: mnId( i_nId ), maImage( rImg ), maToolTipText( i_rTTText ) {}
};
diff --git a/vcl/inc/unx/gtk/gtkobject.hxx b/vcl/inc/unx/gtk/gtkobject.hxx
index df36a85..12a9ff3 100644
--- a/vcl/inc/unx/gtk/gtkobject.hxx
+++ b/vcl/inc/unx/gtk/gtkobject.hxx
@@ -40,7 +40,7 @@ class GtkSalObject : public SalObject
static gboolean signalFocus( GtkWidget*, GdkEventFocus*, gpointer );
static void signalDestroy( GtkWidget*, gpointer );
public:
- GtkSalObject( GtkSalFrame* pParent, bool bShow = true );
+ GtkSalObject( GtkSalFrame* pParent, bool bShow );
virtual ~GtkSalObject() override;
// override all pure virtual methods
diff --git a/vcl/source/filter/jpeg/JpegWriter.hxx b/vcl/source/filter/jpeg/JpegWriter.hxx
index 77822d6..6727921 100644
--- a/vcl/source/filter/jpeg/JpegWriter.hxx
+++ b/vcl/source/filter/jpeg/JpegWriter.hxx
@@ -43,7 +43,7 @@ class JPEGWriter
public:
JPEGWriter( SvStream& rStream,
const css::uno::Sequence< css::beans::PropertyValue >* pFilterData,
- bool* pExportWasGrey = nullptr );
+ bool* pExportWasGrey );
virtual ~JPEGWriter() {};
diff --git a/vcl/source/filter/wmf/winmtf.hxx b/vcl/source/filter/wmf/winmtf.hxx
index d12a11c..45f63b9 100644
--- a/vcl/source/filter/wmf/winmtf.hxx
+++ b/vcl/source/filter/wmf/winmtf.hxx
@@ -366,7 +366,7 @@ struct WinMtfLineStyle : GDIObj
, bTransparent(bTrans)
{}
- WinMtfLineStyle( const Color& rColor, const LineInfo& rStyle, bool bTrans = false)
+ WinMtfLineStyle( const Color& rColor, const LineInfo& rStyle, bool bTrans)
: aLineColor (rColor)
, aLineInfo (rStyle)
, bTransparent(bTrans)
@@ -673,7 +673,7 @@ protected:
WinMtf(
GDIMetaFile& rGDIMetaFile,
SvStream& rStreamWMF,
- FilterConfigItem* pConfigItem = nullptr
+ FilterConfigItem* pConfigItem
);
~WinMtf();
};
@@ -742,7 +742,7 @@ private:
public:
WMFReader(SvStream& rStreamWMF, GDIMetaFile& rGDIMetaFile,
- FilterConfigItem* pConfigItem = nullptr,
+ FilterConfigItem* pConfigItem,
WMF_EXTERNALHEADER* pExtHeader = nullptr);
// read WMF file from stream and fill the GDIMetaFile
diff --git a/vcl/source/fontsubset/cff.cxx b/vcl/source/fontsubset/cff.cxx
index dfe29d8..cca14ed 100644
--- a/vcl/source/fontsubset/cff.cxx
+++ b/vcl/source/fontsubset/cff.cxx
@@ -1681,7 +1681,7 @@ const char* CffSubsetterContext::getGlyphName( int nGlyphIndex)
class Type1Emitter
{
public:
- explicit Type1Emitter( FILE* pOutFile, bool bPfbSubset = true);
+ explicit Type1Emitter( FILE* pOutFile, bool bPfbSubset);
~Type1Emitter();
void setSubsetName( const char* );
diff --git a/vcl/source/gdi/pngwrite.cxx b/vcl/source/gdi/pngwrite.cxx
index 4f61e92..a55cf09 100644
--- a/vcl/source/gdi/pngwrite.cxx
+++ b/vcl/source/gdi/pngwrite.cxx
@@ -48,7 +48,7 @@ class PNGWriterImpl
public:
PNGWriterImpl(const BitmapEx& BmpEx,
- const css::uno::Sequence<css::beans::PropertyValue>* pFilterData = nullptr);
+ const css::uno::Sequence<css::beans::PropertyValue>* pFilterData);
bool Write(SvStream& rOutStream);
diff --git a/vcl/unx/generic/dtrans/X11_transferable.hxx b/vcl/unx/generic/dtrans/X11_transferable.hxx
index 394253d..7fa9b55 100644
--- a/vcl/unx/generic/dtrans/X11_transferable.hxx
+++ b/vcl/unx/generic/dtrans/X11_transferable.hxx
@@ -33,7 +33,7 @@ namespace x11 {
SelectionManager& m_rManager;
Atom m_aSelection;
public:
- X11Transferable( SelectionManager& rManager, Atom selection = None );
+ X11Transferable( SelectionManager& rManager, Atom selection );
virtual ~X11Transferable() override;
/*
diff --git a/vcl/unx/generic/print/prtsetup.hxx b/vcl/unx/generic/print/prtsetup.hxx
index 5722510..6de4bf7 100644
--- a/vcl/unx/generic/print/prtsetup.hxx
+++ b/vcl/unx/generic/print/prtsetup.hxx
@@ -64,7 +64,7 @@ class RTSDialog : public TabDialog
// helper functions
void insertAllPPDValues( ListBox&, const psp::PPDParser*, const psp::PPDKey* );
public:
- RTSDialog(const ::psp::PrinterInfo& rJobData, vcl::Window* pParent = nullptr);
+ RTSDialog(const ::psp::PrinterInfo& rJobData, vcl::Window* pParent);
virtual ~RTSDialog() override;
virtual void dispose() override;
More information about the Libreoffice-commits
mailing list