[Libreoffice-commits] online.git: loolwsd/.clang-tidy loolwsd/.gitignore loolwsd/test

[Miklos Vajna]

 loolwsd/.clang-tidy      |    3 +++
 loolwsd/.gitignore       |    1 -
 loolwsd/test/helpers.hpp |    6 +++---
 3 files changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 27220aea3938b72d0d7c46aeb163563e27e2519c
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Thu Sep 15 10:33:18 2016 +0200

    test helpers: avoid unnecessary copies
    
    Change-Id: I014cedcc10078ce03d1f4f3ae9403b6282b7dcac

diff --git a/loolwsd/.clang-tidy b/loolwsd/.clang-tidy
new file mode 100644
index 0000000..57cd9c3
--- /dev/null
+++ b/loolwsd/.clang-tidy
@@ -0,0 +1,3 @@
+Checks: 'clang-diagnostic-*,performance-*,unused-*,misc-*,readability-redundant-*'
+WarningsAsErrors: '*'
+
diff --git a/loolwsd/.gitignore b/loolwsd/.gitignore
index 9bdd0f7..72ffdbb 100644
--- a/loolwsd/.gitignore
+++ b/loolwsd/.gitignore
@@ -36,7 +36,6 @@ test/data/hello-world.odt
 *.o
 *.exe
 cscope*
-.*
 *.orig
 
 connect
diff --git a/loolwsd/test/helpers.hpp b/loolwsd/test/helpers.hpp
index 2401243..d76fc96 100644
--- a/loolwsd/test/helpers.hpp
+++ b/loolwsd/test/helpers.hpp
@@ -311,7 +311,7 @@ std::vector<char> getResponseMessage(Poco::Net::WebSocket& ws, const std::string
 }
 
 inline
-std::vector<char> getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const std::string& prefix, const std::string name = "")
+std::vector<char> getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const std::string& prefix, const std::string& name = "")
 {
     return getResponseMessage(*ws, prefix, name);
 }
@@ -342,7 +342,7 @@ void getResponseMessage(const std::shared_ptr<Poco::Net::WebSocket>& ws, const s
 // connectLOKit ensures the websocket is connected to a kit process.
 inline
 std::shared_ptr<Poco::Net::WebSocket>
-connectLOKit(Poco::URI uri,
+connectLOKit(const Poco::URI& uri,
              Poco::Net::HTTPRequest& request,
              Poco::Net::HTTPResponse& response,
              const std::string& name = "")
@@ -409,7 +409,7 @@ std::shared_ptr<Poco::Net::WebSocket> loadDocAndGetSocket(const std::string& doc
 inline
 void SocketProcessor(const std::string& name,
                      const std::shared_ptr<Poco::Net::WebSocket>& socket,
-                     std::function<bool(const std::string& msg)> handler,
+                     const std::function<bool(const std::string& msg)>& handler,
                      const size_t timeoutMs = 10000)
 {
     socket->setReceiveTimeout(0);