[Libreoffice-commits] online.git: loolwsd/LOOLKit.cpp loolwsd/LOOLWSD.cpp
Ashod Nakashian
ashod.nakashian at collabora.co.uk
Mon Sep 19 11:59:41 UTC 2016
loolwsd/LOOLKit.cpp | 5 -----
loolwsd/LOOLWSD.cpp | 8 --------
2 files changed, 13 deletions(-)
New commits:
commit f0c09238ce0aa9772b182b1461af0a448332dda4
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date: Sat Sep 17 08:42:25 2016 -0400
loolwsd: fail fast rather than catch all
Change-Id: Ib38924bf823315d211eb467d90f364fdc225ba2e
Reviewed-on: https://gerrit.libreoffice.org/29005
Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>
Tested-by: Ashod Nakashian <ashnakash at gmail.com>
diff --git a/loolwsd/LOOLKit.cpp b/loolwsd/LOOLKit.cpp
index 2e3fdb9..74ef66b 100644
--- a/loolwsd/LOOLKit.cpp
+++ b/loolwsd/LOOLKit.cpp
@@ -289,7 +289,6 @@ public:
Util::setThreadName("kit_ws_" + _sessionId);
Log::debug("Thread started.");
-
try
{
auto queue = std::make_shared<TileQueue>();
@@ -333,10 +332,6 @@ public:
{
Log::error(std::string("Connection::run: Exception: ") + exc.what());
}
- catch (...)
- {
- Log::error("Connection::run:: Unexpected exception");
- }
Log::debug("Thread finished.");
}
diff --git a/loolwsd/LOOLWSD.cpp b/loolwsd/LOOLWSD.cpp
index 57b996b..b496a1b 100644
--- a/loolwsd/LOOLWSD.cpp
+++ b/loolwsd/LOOLWSD.cpp
@@ -995,10 +995,6 @@ public:
Log::error(std::string("ClientRequestHandler::handleRequest: Exception: ") + exc.what());
response.setStatusAndReason(HTTPResponse::HTTP_SERVICE_UNAVAILABLE);
}
- catch (...)
- {
- Log::error("ClientRequestHandler::handleRequest:: Unexpected exception");
- }
if (!responded)
{
@@ -1190,10 +1186,6 @@ public:
{
Log::error(std::string("PrisonerRequestHandler::handleRequest: Exception: ") + exc.what());
}
- catch (...)
- {
- Log::error("PrisonerRequestHandler::handleRequest:: Unexpected exception");
- }
if (!jailId.empty())
{
More information about the Libreoffice-commits
mailing list