[Libreoffice-commits] core.git: 2 commits - configure.ac

[Stephan Bergmann]

 configure.ac |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

New commits:
commit 60b6b1eae563c727160724a8671844bf8136f5d5
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Sep 20 08:06:25 2016 +0200

    Remove obsolete HAVE_GCC_VISIBILITY_FEATURE check
    
    <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=26905> "default-visibility class
    symbol improperly resolved as hidden-visibility" is fixed ever since GCC 4.2.
    
    Make this a fatal configure error for now.  The check should be removed
    completely after LO 5.3 branch-off.
    
    Change-Id: Ie365d5a0e2217a4efd1e8e2642963738ae7d20b1
    Reviewed-on: https://gerrit.libreoffice.org/29072
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
    Tested-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/configure.ac b/configure.ac
index 37d5145..ae9e83b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6608,9 +6608,7 @@ _ACEOF
 
         AC_MSG_RESULT([$gccvisbroken])
         if test "$gccvisbroken" = "yes"; then
-            AC_MSG_WARN([Your gcc is not -fvisibility=hidden safe. Disabling visibility])
-            add_warning "Your gcc is not -fvisibility=hidden safe. Disabling visibility"
-            unset HAVE_GCC_VISIBILITY_FEATURE
+            AC_MSG_ERROR([Your gcc is not -fvisibility=hidden safe. This is no longer supported.])
         fi
     fi
 
commit 8af35c9590262965c603d8609b57cc76d23e8506
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Sep 20 08:01:13 2016 +0200

    Remove obsolete HAVE_GCC_VISIBILITY_FEATURE check
    
    <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=19664> "libstdc++ headers should
    have pop/push of the visibility around the declarations" (aka gcc#22482,
    rhbz#162935) is fixed ever since GCC 4.2.
    
    Make this a fatal configure error for now.  The check should be removed
    completely after LO 5.3 branch-off.
    
    Change-Id: I3e8fde187b4b20652ee3164485ef868a9bf5a7ce
    Reviewed-on: https://gerrit.libreoffice.org/29071
    Tested-by: Stephan Bergmann <sbergman at redhat.com>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/configure.ac b/configure.ac
index f4b91fb..37d5145 100644
--- a/configure.ac
+++ b/configure.ac
@@ -6494,9 +6494,7 @@ if test \( "$_os" != "WINNT" -o "$WITH_MINGW" = "yes" \); then
         AC_EGREP_HEADER(visibility push, string, stlvisok=yes, stlvisok=no)
         AC_MSG_RESULT([$stlvisok])
         if test "$stlvisok" = "no"; then
-            AC_MSG_WARN([Your libstdc++ headers are not visibility safe. Disabling visibility])
-            add_warning "Your libstdc++ headers are not visibility safe. Disabling visibility"
-            unset HAVE_GCC_VISIBILITY_FEATURE
+            AC_MSG_ERROR([Your libstdc++ headers are not visibility safe. This is no longer supported.])
         fi
     fi