[Libreoffice-commits] core.git: svl/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Thu Sep 22 19:08:33 UTC 2016


 svl/source/inc/poolio.hxx     |    4 +---
 svl/source/items/itempool.cxx |    4 ++--
 2 files changed, 3 insertions(+), 5 deletions(-)

New commits:
commit d141d5b3bd11ba6154b5d064fb69900405724b13
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Thu Sep 22 13:58:14 2016 +0200

    remove SfxPoolItemArrayBase_Impl typedef
    
    Change-Id: Id4d3f80b3906395838afaffb2b0d00437d17f6dd
    Reviewed-on: https://gerrit.libreoffice.org/29182
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svl/source/inc/poolio.hxx b/svl/source/inc/poolio.hxx
index 627fd6b..ec3ec83 100644
--- a/svl/source/inc/poolio.hxx
+++ b/svl/source/inc/poolio.hxx
@@ -58,8 +58,6 @@ struct SfxPoolVersion_Impl
                     {}
 };
 
-typedef std::vector<SfxPoolItem*> SfxPoolItemArrayBase_Impl;
-
 typedef std::shared_ptr< SfxPoolVersion_Impl > SfxPoolVersion_ImplPtr;
 
 /**
@@ -112,7 +110,7 @@ struct SfxItemPool_Impl
     bool                            mbPersistentRefCounts;
 
     SfxItemPool_Impl( SfxItemPool* pMaster, const OUString& rName, sal_uInt16 nStart, sal_uInt16 nEnd )
-        : maPoolItems(nEnd - nStart + 1, static_cast<SfxPoolItemArray_Impl*>(nullptr))
+        : maPoolItems(nEnd - nStart + 1)
         , aName(rName)
         , maPoolDefaults(nEnd - nStart + 1)
         , ppStaticDefaults(nullptr)
diff --git a/svl/source/items/itempool.cxx b/svl/source/items/itempool.cxx
index 6f4a6f2..7a38d45 100644
--- a/svl/source/items/itempool.cxx
+++ b/svl/source/items/itempool.cxx
@@ -646,7 +646,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich
         pItemArr = pImpl->maPoolItems[nIndex];
     }
 
-    SfxPoolItemArrayBase_Impl::iterator ppFree;
+    std::vector<SfxPoolItem*>::iterator ppFree;
     bool ppFreeIsSet = false;
 
     // Is this a 'poolable' item - ie. should we re-use and return
@@ -693,7 +693,7 @@ const SfxPoolItem& SfxItemPool::Put( const SfxPoolItem& rItem, sal_uInt16 nWhich
         // Unconditionally insert; check for a recently freed place
         if (pItemArr->maFree.size() > 0)
         {
-            SfxPoolItemArrayBase_Impl::iterator itr = pItemArr->begin();
+            auto itr = pItemArr->begin();
             sal_uInt32 nIdx = pItemArr->maFree.back();
             pItemArr->maFree.pop_back();
 


More information about the Libreoffice-commits mailing list