[Libreoffice-commits] core.git: sc/qa

Luke Deller luke at deller.id.au
Sun Sep 25 12:04:54 UTC 2016


 sc/qa/extras/testdocuments/window2.xls |binary
 1 file changed

New commits:
commit 8dc46fc45b5c7d833caca331a9045167d1794f1a
Author: Luke Deller <luke at deller.id.au>
Date:   Wed Sep 21 12:00:02 2016 +1000

    Avoid failure in VBA test when window is too small
    
    The VBA test case "SplitRow" in window2.xls requires the spreadsheet
    window to be large enough.  It looks like this has been discovered
    previously and some of the assertions commented out with a note about
    the window size requirement.  However we bumped into a failure in one of
    the remaining assertions on one of our tinderboxes.
    
    To resolve:
    
     - Maximize the window at the start of this test case
    
     - Skip the test if the window size is still too small
    
     - Re-enable assertions which had been commented out due to this issue.
       (Note that VBA which reads Window.SplitRow appears to be broken in
        LO, so I have left two assertions here commented out with a FIXME)
    
    Change-Id: I5e87a360958f665457bbf8ec9c703a99794a62dc
    Reviewed-on: https://gerrit.libreoffice.org/29110
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/qa/extras/testdocuments/window2.xls b/sc/qa/extras/testdocuments/window2.xls
index e9deceb..306f5d0 100644
Binary files a/sc/qa/extras/testdocuments/window2.xls and b/sc/qa/extras/testdocuments/window2.xls differ


More information about the Libreoffice-commits mailing list