[Libreoffice-commits] core.git: Branch 'libreoffice-5-1' - sc/source

Markus Mohrhard markus.mohrhard at googlemail.com
Tue Sep 27 09:50:06 UTC 2016


 sc/source/core/data/colorscale.cxx |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit 6d66c353fb7ea7d47af2404e7e66cef0f6a690c3
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Tue Sep 27 00:11:32 2016 +0200

    tdf#101104 this paranoid safety check actually causes a bug
    
    Change-Id: Id31f98f5f84eabf603045e4d9f7ebd448689eed5
    Reviewed-on: https://gerrit.libreoffice.org/29308
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/data/colorscale.cxx b/sc/source/core/data/colorscale.cxx
index 42904e1..f71aa96 100644
--- a/sc/source/core/data/colorscale.cxx
+++ b/sc/source/core/data/colorscale.cxx
@@ -994,10 +994,6 @@ ScIconSetInfo* ScIconSetFormat::GetIconSetInfo(const ScAddress& rAddr) const
     double nMin = GetMinValue();
     double nMax = GetMaxValue();
 
-    // this check is for safety
-    if(nMin > nMax)
-        return nullptr;
-
     sal_Int32 nIndex = 0;
     const_iterator itr = begin();
     ++itr;


More information about the Libreoffice-commits mailing list