[Libreoffice-commits] core.git: sc/source

Tor Lillqvist tml at collabora.com
Wed Apr 5 09:52:53 UTC 2017


 sc/source/core/opencl/formulagroupcl.cxx |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

New commits:
commit 770a970aaec0aa9069f1ba3d7e408d95145e57b2
Author: Tor Lillqvist <tml at collabora.com>
Date:   Wed Apr 5 12:51:17 2017 +0300

    Add FIXME
    
    Change-Id: I84c6e605f012dd563f41631bc3c2b8631c1428e8

diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index a1112e499dbc..3024f4dc172d 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -1,4 +1,4 @@
-/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
 /*
  * This file is part of the LibreOffice project.
  *
@@ -30,7 +30,11 @@
 #include "op_spreadsheet.hxx"
 #include "op_addin.hxx"
 
-/// CONFIGURATIONS
+// FIXME: The idea that somebody would bother to (now and then? once a year? once a month?) manually
+// edit a source file and change the value of some #defined constant and run some ill-defined
+// "correctness test" is of course ludicrous. Either things are checked in normal unit tests, in
+// every 'make check', or not at all. The below comments are ridiculous.
+
 #define REDUCE_THRESHOLD 201  // set to 4 for correctness testing. priority 1
 #define UNROLLING_FACTOR 16  // set to 4 for correctness testing (if no reduce)
 


More information about the Libreoffice-commits mailing list