[Libreoffice-commits] online.git: Makefile.am wsd/DocumentBroker.cpp wsd/Storage.cpp

Jan Holesovsky kendy at collabora.com
Thu Apr 6 08:23:18 UTC 2017


 Makefile.am            |    5 +++--
 wsd/DocumentBroker.cpp |    6 ------
 wsd/Storage.cpp        |    5 ++++-
 3 files changed, 7 insertions(+), 9 deletions(-)

New commits:
commit fa042ed0e3f9a543ec075c6530ff5ce701c0be5d
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Wed Apr 5 20:20:47 2017 +0200

    Make the callgrinding possible again.
    
    Change-Id: I9e8e0e3d088c4af29f2701a0318a508f14327fff

diff --git a/Makefile.am b/Makefile.am
index 1f091c27..05ea8a67 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -251,8 +251,9 @@ run-callgrind: all @JAILS_PATH@ @SYSTEMPLATE_PATH@/system_stamp
 	@echo "Launching loolwsd under valgrind (but not forkit/loolkit, yet)"
 	@fc-cache "@LO_PATH@"/share/fonts/truetype
 	@cp $(abs_top_srcdir)/test/data/hello.odt $(abs_top_srcdir)/test/data/hello-world.odt
-	valgrind --tool=callgrind --simulate-cache=yes --dump-instr=yes --num-callers=50 --error-limit=no \
-		./loolwsd --o:sys_template_path="@SYSTEMPLATE_PATH@" --o:lo_template_path="@LO_PATH@" \
+	valgrind --tool=callgrind --simulate-cache=yes --dump-instr=yes --num-callers=50 --error-limit=no --trace-children=yes \
+		./loolwsd --nocaps \
+			  --o:sys_template_path="@SYSTEMPLATE_PATH@" --o:lo_template_path="@LO_PATH@" \
 			  --o:child_root_path="@JAILS_PATH@" --o:storage.filesystem[@allow]=true \
 			  --o:ssl.cert_file_path="$(abs_top_srcdir)/etc/cert.pem" \
 			  --o:ssl.key_file_path="$(abs_top_srcdir)/etc/key.pem" \
diff --git a/wsd/DocumentBroker.cpp b/wsd/DocumentBroker.cpp
index 1b6f5d45..a5a995df 100644
--- a/wsd/DocumentBroker.cpp
+++ b/wsd/DocumentBroker.cpp
@@ -348,12 +348,6 @@ bool DocumentBroker::load(const std::shared_ptr<ClientSession>& session, const s
     // user/doc/jailId
     const auto jailPath = Poco::Path(JAILED_DOCUMENT_ROOT, jailId);
     std::string jailRoot = getJailRoot();
-#ifndef KIT_IN_PROCESS
-    if (LOOLWSD::NoCapsForKit)
-    {
-        jailRoot = jailPath.toString() + "/" + getJailRoot();
-    }
-#endif
 
     LOG_INF("jailPath: " << jailPath.toString() << ", jailRoot: " << jailRoot);
 
diff --git a/wsd/Storage.cpp b/wsd/Storage.cpp
index 94a01c93..a125c1d7 100644
--- a/wsd/Storage.cpp
+++ b/wsd/Storage.cpp
@@ -248,7 +248,10 @@ std::string LocalStorage::loadStorageFileToLocal()
     _isLoaded = true;
     // Now return the jailed path.
 #ifndef KIT_IN_PROCESS
-    return Poco::Path(_jailPath, filename).toString();
+    if (LOOLWSD::NoCapsForKit)
+        return _jailedFilePath;
+    else
+        return Poco::Path(_jailPath, filename).toString();
 #else
     return _jailedFilePath;
 #endif


More information about the Libreoffice-commits mailing list