[Libreoffice-commits] core.git: xmlsecurity/source

Miklos Vajna vmiklos at collabora.co.uk
Thu Apr 6 12:27:50 UTC 2017


 xmlsecurity/source/helper/xmlsignaturehelper2.cxx |    6 ------
 xmlsecurity/source/helper/xmlsignaturehelper2.hxx |    4 ----
 2 files changed, 10 deletions(-)

New commits:
commit 653588e1bbad1e4d954afa4b12325996fd1cceb7
Author: Miklos Vajna <vmiklos at collabora.co.uk>
Date:   Thu Apr 6 09:46:34 2017 +0200

    xmlsecurity: remove unused ImplXMLSignatureListener::signatureCreated()
    
    ImplXMLSignatureListener doesn't have to implement
    XSignatureCreationResultListener, signatureCreated() is only called at
    SignatureCreatorImpl::notifyResultListener(), on an object set by
    SignatureCreatorImpl::addSignatureCreationResultListener(). But
    addSignatureCreationResultListener() is only called from
    XSecController::prepareSignatureToWrite() where the argument is of type
    XSecController.
    
    Change-Id: I378bda8b1ffdebb4305bec9eebe093aa2443b4e7

diff --git a/xmlsecurity/source/helper/xmlsignaturehelper2.cxx b/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
index 2879336a0c55..f8e2dfc73242 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper2.cxx
@@ -47,12 +47,6 @@ void ImplXMLSignatureListener::setNextHandler(
     m_xNextHandler = xNextHandler;
 }
 
-void SAL_CALL ImplXMLSignatureListener::signatureCreated( sal_Int32 securityId, css::xml::crypto::SecurityOperationStatus nResult )
-{
-    XMLSignatureCreationResult aResult( securityId, nResult );
-    m_rXMLSignatureHelper.SignatureCreationResultListener(aResult);
-}
-
 void SAL_CALL ImplXMLSignatureListener::signatureVerified( sal_Int32 securityId, css::xml::crypto::SecurityOperationStatus nResult )
 {
     XMLSignatureVerifyResult aResult( securityId, nResult );
diff --git a/xmlsecurity/source/helper/xmlsignaturehelper2.hxx b/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
index 98f9eae06389..0a560cab7e97 100644
--- a/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
+++ b/xmlsecurity/source/helper/xmlsignaturehelper2.hxx
@@ -46,7 +46,6 @@ namespace embed {
 
 class ImplXMLSignatureListener : public cppu::WeakImplHelper
 <
-    css::xml::crypto::sax::XSignatureCreationResultListener,
     css::xml::crypto::sax::XSignatureVerifyResultListener,
     css::xml::sax::XDocumentHandler
 >
@@ -63,9 +62,6 @@ public:
 
     void setNextHandler(const css::uno::Reference< css::xml::sax::XDocumentHandler >& xNextHandler);
 
-    // css::xml::crypto::sax::XSignatureCreationResultListener
-    virtual void SAL_CALL signatureCreated( sal_Int32 securityId, css::xml::crypto::SecurityOperationStatus creationResult ) override;
-
     // css::xml::crypto::sax::XSignatureVerifyResultListener
     virtual void SAL_CALL signatureVerified( sal_Int32 securityId, css::xml::crypto::SecurityOperationStatus verifyResult ) override;
 


More information about the Libreoffice-commits mailing list