[Libreoffice-commits] online.git: loleaflet/src

Pranav Kant pranavk at collabora.co.uk
Wed Apr 19 12:41:37 UTC 2017


 loleaflet/src/layer/AnnotationManager.js |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 0fb2c1901423be43967f879961c40c70b2bc8d59
Author: Pranav Kant <pranavk at collabora.co.uk>
Date:   Wed Apr 19 18:06:24 2017 +0530

    loleaflet: Animate child elements together with their parent
    
    Create the new L.PosAnimation object everytime you want to animate, not
    just use the same everytime which has the limitation that animation
    doesn't happen simultaneously.
    
    Change-Id: If5f63702afe0fee7f44c8cf4605179d68de289e8

diff --git a/loleaflet/src/layer/AnnotationManager.js b/loleaflet/src/layer/AnnotationManager.js
index d662bb48..d29b2d46 100644
--- a/loleaflet/src/layer/AnnotationManager.js
+++ b/loleaflet/src/layer/AnnotationManager.js
@@ -270,7 +270,7 @@ L.AnnotationManager = L.Class.extend({
 				this._items[selectIndexFirst]._data.anchorPix = this._map._docLayer._twipsToPixels(this._items[selectIndexFirst]._data.anchorPos.min);
 			}
 			latlng = this._map.unproject(L.point(docRight.x, this._items[selectIndexFirst]._data.anchorPix.y));
-			this._animation.run(this._items[selectIndexFirst]._container, this._map.latLngToLayerPoint(latlng));
+			(new L.PosAnimation()).run(this._items[selectIndexFirst]._container, this._map.latLngToLayerPoint(latlng));
 			this._items[selectIndexFirst].setLatLng(latlng);
 			layoutBounds = this._items[selectIndexFirst].getBounds();
 
@@ -281,8 +281,7 @@ L.AnnotationManager = L.Class.extend({
 				}
 
 				latlng = this._map.layerPointToLatLng(layoutBounds.getBottomLeft());
-				// FIXME: Enabling animation of these children misbehaves
-				//this._animation.run(this._items[idx]._container, layoutBounds.getBottomLeft());
+				(new L.PosAnimation()).run(this._items[idx]._container, layoutBounds.getBottomLeft());
 				this._items[idx].setLatLng(latlng);
 
 				var commentBounds = this._items[idx].getBounds();


More information about the Libreoffice-commits mailing list