[Libreoffice-commits] online.git: loleaflet/src
Pranav Kant
pranavk at collabora.co.uk
Thu Apr 27 05:27:30 UTC 2017
loleaflet/src/layer/tile/CalcTileLayer.js | 4 ++++
1 file changed, 4 insertions(+)
New commits:
commit b49fd14f91c908f8bb1465fa569a5a5acc3a054f
Author: Pranav Kant <pranavk at collabora.co.uk>
Date: Thu Apr 27 10:53:53 2017 +0530
loleaflet: Pass author name field everytime editing cell annotation
Unlike writer and impress, editing annotation in calc creates a new note
without inheriting the author value from the previous cell annotation.
If we don't send the author field here while editing annotation, no
author would be set for the annotation resulting in empty string in the
UI, which looks quite incomplete and ugly.
It should be noted that the new author that is being sent to core
corresponds the current view now. So if cell annotation was added by
someone else and we are trying to edit it, we'd be the new author. This
is contrary to the behavior in writer and impress where author name
persists even if someone else edits the annotation.
Change-Id: I3bfbb34cef304687e42f4ee422d89c5a240834f0
diff --git a/loleaflet/src/layer/tile/CalcTileLayer.js b/loleaflet/src/layer/tile/CalcTileLayer.js
index b495b467..c154d7a4 100644
--- a/loleaflet/src/layer/tile/CalcTileLayer.js
+++ b/loleaflet/src/layer/tile/CalcTileLayer.js
@@ -153,6 +153,10 @@ L.CalcTileLayer = L.TileLayer.extend({
Text: {
type: 'string',
value: e.annotation._data.text
+ },
+ Author: {
+ type: 'string',
+ value: this._map.getViewName(this._viewId)
}
};
this._map.sendUnoCommand('.uno:EditAnnotation', comment);
More information about the Libreoffice-commits
mailing list