[Libreoffice-commits] core.git: compilerplugins/clang include/sfx2 sfx2/source
Noel Grandin
noel.grandin at collabora.co.uk
Fri Apr 28 09:00:11 UTC 2017
compilerplugins/clang/unusedfields.untouched.results | 46 ++++-----
compilerplugins/clang/unusedfields.writeonly.results | 94 +++++++++----------
include/sfx2/sidebar/ControllerItem.hxx | 1
sfx2/source/sidebar/ControllerItem.cxx | 1
4 files changed, 71 insertions(+), 71 deletions(-)
New commits:
commit 6ac7dfdba4deb6b8fd96d0df18d1c1102aace64a
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Fri Apr 28 08:38:29 2017 +0200
loplugin:unusedfields
Change-Id: I67a0372d6982648717651f736c51e447d0b7d6a2
Reviewed-on: https://gerrit.libreoffice.org/37047
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index ace930062cc7..19c98abb39c3 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -36,7 +36,7 @@ compilerplugins/clang/test/salbool.cxx:15
S b sal_Bool
compilerplugins/clang/test/unnecessaryoverride-dtor.hxx:42
IncludedDerived3 m rtl::Reference<Incomplete>
-connectivity/source/drivers/mork/MDatabaseMetaData.hxx:28
+connectivity/source/drivers/mork/MDatabaseMetaData.hxx:29
connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr<MDatabaseMetaDataHelper>
connectivity/source/inc/OTypeInfo.hxx:31
connectivity::OTypeInfo aTypeName class rtl::OUString
@@ -86,17 +86,11 @@ extensions/source/scanner/scanner.hxx:46
ScannerManager maProtector osl::Mutex
framework/inc/dispatch/oxt_handler.hxx:95
framework::Oxt_Handler m_xSelfHold css::uno::Reference<css::uno::XInterface>
-i18nutil/source/utility/unicode.cxx:40
- DefaultScriptTypeList from com::sun::star::i18n::UnicodeScript
-i18nutil/source/utility/unicode.cxx:41
- DefaultScriptTypeList to com::sun::star::i18n::UnicodeScript
-i18nutil/source/utility/unicode.cxx:42
- DefaultScriptTypeList value com::sun::star::i18n::UnicodeScript
include/comphelper/MasterPropertySet.hxx:38
comphelper::SlaveData mxSlave css::uno::Reference<css::beans::XPropertySet>
include/drawinglayer/primitive2d/textlayoutdevice.hxx:61
drawinglayer::primitive2d::TextLayouterDevice maSolarGuard class SolarMutexGuard
-include/editeng/unotext.hxx:605
+include/editeng/unotext.hxx:606
SvxUnoTextRangeEnumeration mxParentText css::uno::Reference<css::text::XText>
include/LibreOfficeKit/LibreOfficeKitGtk.h:33
_LOKDocView aDrawingArea GtkDrawingArea
@@ -124,23 +118,23 @@ pyuno/source/module/pyuno_impl.hxx:226
pyuno::(anonymous) ob_base PyObject
pyuno/source/module/pyuno_impl.hxx:326
pyuno::stRuntimeImpl ob_base PyObject
-reportdesign/source/ui/inc/ReportWindow.hxx:53
+reportdesign/source/ui/inc/ReportWindow.hxx:54
rptui::OReportWindow m_pObjFac ::std::unique_ptr<DlgEdFactory>
-sal/osl/unx/thread.cxx:93
+sal/osl/unx/thread.cxx:97
osl_thread_priority_st m_Highest int
-sal/osl/unx/thread.cxx:94
+sal/osl/unx/thread.cxx:98
osl_thread_priority_st m_Above_Normal int
-sal/osl/unx/thread.cxx:95
+sal/osl/unx/thread.cxx:99
osl_thread_priority_st m_Normal int
-sal/osl/unx/thread.cxx:96
+sal/osl/unx/thread.cxx:100
osl_thread_priority_st m_Below_Normal int
-sal/osl/unx/thread.cxx:97
+sal/osl/unx/thread.cxx:101
osl_thread_priority_st m_Lowest int
-sal/osl/unx/thread.cxx:115
+sal/osl/unx/thread.cxx:119
osl_thread_global_st m_priority struct osl_thread_priority_st
sc/qa/unit/ucalc_column.cxx:103
aInputs aName const char *
-sc/source/filter/inc/sheetdatacontext.hxx:60
+sc/source/filter/inc/sheetdatacontext.hxx:61
oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
sc/source/ui/inc/docsh.hxx:441
ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
@@ -148,25 +142,31 @@ sd/source/ui/remotecontrol/ZeroconfService.hxx:36
sd::ZeroconfService port uint
sd/source/ui/table/TableDesignPane.hxx:110
sd::TableDesignPane aImpl class sd::TableDesignWidget
-sd/source/ui/view/DocumentRenderer.cxx:1334
+sd/source/ui/view/DocumentRenderer.cxx:1335
sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
-sd/source/ui/view/viewshel.cxx:1234
- sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1235
- sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
+ sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1236
- sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+ sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
sd/source/ui/view/viewshel.cxx:1237
+ sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+sd/source/ui/view/viewshel.cxx:1238
sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
-sd/source/ui/view/ViewShellBase.cxx:207
+sd/source/ui/view/ViewShellBase.cxx:201
sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
sfx2/source/doc/doctempl.cxx:118
DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
starmath/inc/view.hxx:224
SmViewShell maGraphicController class SmGraphicController
+svtools/source/svhtml/htmlkywd.cxx:558
+ HTML_OptionEntry union HTML_OptionEntry::(anonymous at /home/noel/libo3/svtools/source/svhtml/htmlkywd.cxx:558:5)
+svtools/source/svhtml/htmlkywd.cxx:560
+ HTML_OptionEntry::(anonymous) sToken const sal_Char *
+svtools/source/svhtml/htmlkywd.cxx:561
+ HTML_OptionEntry::(anonymous) pUToken const class rtl::OUString *
sw/source/core/crsr/crbm.cxx:64
(anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState
-sw/source/core/frmedt/fetab.cxx:89
+sw/source/core/frmedt/fetab.cxx:90
TableWait m_pWait const std::unique_ptr<SwWait>
sw/source/core/layout/dbg_lay.cxx:164
SwImplEnterLeave nAction enum DbgAction
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index cf91be5c33eb..8a4650b7b5db 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -76,7 +76,7 @@ compilerplugins/clang/test/salbool.cxx:15
S b sal_Bool
compilerplugins/clang/test/unnecessaryoverride-dtor.hxx:42
IncludedDerived3 m rtl::Reference<Incomplete>
-connectivity/source/drivers/mork/MDatabaseMetaData.hxx:28
+connectivity/source/drivers/mork/MDatabaseMetaData.hxx:29
connectivity::mork::ODatabaseMetaData m_pMetaDataHelper std::unique_ptr<MDatabaseMetaDataHelper>
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.hxx:55
connectivity::mozab::ProfileStruct product enum com::sun::star::mozilla::MozillaProductType
@@ -200,7 +200,7 @@ filter/source/graphicfilter/icgm/chart.hxx:46
DataNode nBoxX2 sal_Int16
filter/source/graphicfilter/icgm/chart.hxx:47
DataNode nBoxY2 sal_Int16
-formula/source/core/api/FormulaCompiler.cxx:50
+formula/source/core/api/FormulaCompiler.cxx:49
formula::(anonymous namespace)::FormulaCompilerRecursionGuard rRecursion short &
framework/inc/dispatch/oxt_handler.hxx:95
framework::Oxt_Handler m_xSelfHold css::uno::Reference<css::uno::XInterface>
@@ -288,19 +288,13 @@ hwpfilter/source/hbox.h:581
(anonymous) picole struct PicDefOle
hwpfilter/source/hpara.h:70
LineInfo softbreak unsigned short
-i18nutil/source/utility/unicode.cxx:40
- DefaultScriptTypeList from com::sun::star::i18n::UnicodeScript
-i18nutil/source/utility/unicode.cxx:41
- DefaultScriptTypeList to com::sun::star::i18n::UnicodeScript
-i18nutil/source/utility/unicode.cxx:42
- DefaultScriptTypeList value com::sun::star::i18n::UnicodeScript
include/comphelper/MasterPropertySet.hxx:38
comphelper::SlaveData mxSlave css::uno::Reference<css::beans::XPropertySet>
include/drawinglayer/primitive2d/textlayoutdevice.hxx:61
drawinglayer::primitive2d::TextLayouterDevice maSolarGuard class SolarMutexGuard
-include/editeng/outliner.hxx:404
+include/editeng/outliner.hxx:405
DrawPortionInfo mnPara sal_Int32
-include/editeng/unotext.hxx:605
+include/editeng/unotext.hxx:606
SvxUnoTextRangeEnumeration mxParentText css::uno::Reference<css::text::XText>
include/filter/msfilter/svdfppt.hxx:865
ImplPPTParaPropSet nDontKnow1 sal_uInt32
@@ -316,6 +310,8 @@ include/sfx2/msg.hxx:116
SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:118
SfxType0 nAttribs sal_uInt16
+include/sfx2/sidebar/ControllerItem.hxx:91
+ sfx2::sidebar::ControllerItem mxFrame css::uno::Reference<css::frame::XFrame>
include/svtools/genericunodialog.hxx:170
svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard
include/svtools/unoevent.hxx:159
@@ -358,19 +354,19 @@ pyuno/source/module/pyuno_impl.hxx:226
pyuno::(anonymous) ob_base PyObject
pyuno/source/module/pyuno_impl.hxx:326
pyuno::stRuntimeImpl ob_base PyObject
-reportdesign/source/ui/inc/ReportWindow.hxx:53
+reportdesign/source/ui/inc/ReportWindow.hxx:54
rptui::OReportWindow m_pObjFac ::std::unique_ptr<DlgEdFactory>
-sal/osl/unx/thread.cxx:93
+sal/osl/unx/thread.cxx:97
osl_thread_priority_st m_Highest int
-sal/osl/unx/thread.cxx:94
+sal/osl/unx/thread.cxx:98
osl_thread_priority_st m_Above_Normal int
-sal/osl/unx/thread.cxx:95
+sal/osl/unx/thread.cxx:99
osl_thread_priority_st m_Normal int
-sal/osl/unx/thread.cxx:96
+sal/osl/unx/thread.cxx:100
osl_thread_priority_st m_Below_Normal int
-sal/osl/unx/thread.cxx:97
+sal/osl/unx/thread.cxx:101
osl_thread_priority_st m_Lowest int
-sal/osl/unx/thread.cxx:115
+sal/osl/unx/thread.cxx:119
osl_thread_global_st m_priority struct osl_thread_priority_st
sc/inc/compiler.hxx:258
ScCompiler::AddInMap pODFF const char *
@@ -384,47 +380,47 @@ sc/source/core/data/document.cxx:1248
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aSwitch sc::AutoCalcSwitch
sc/source/core/data/document.cxx:1249
(anonymous namespace)::BroadcastRecalcOnRefMoveHandler aBulk class ScBulkBroadcast
-sc/source/core/data/formulacell.cxx:1782
+sc/source/core/data/formulacell.cxx:1778
StackCleaner pInt class ScInterpreter *
-sc/source/filter/inc/sheetdatacontext.hxx:60
+sc/source/filter/inc/sheetdatacontext.hxx:61
oox::xls::SheetDataContext aReleaser class SolarMutexReleaser
sc/source/ui/inc/docsh.hxx:441
ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
-scaddins/source/analysis/analysishelper.hxx:204
- sca::analysis::FuncDataBase nUINameID sal_uInt16
scaddins/source/analysis/analysishelper.hxx:205
- sca::analysis::FuncDataBase nDescrID sal_uInt16
+ sca::analysis::FuncDataBase nUINameID sal_uInt16
scaddins/source/analysis/analysishelper.hxx:206
- sca::analysis::FuncDataBase bDouble _Bool
+ sca::analysis::FuncDataBase nDescrID sal_uInt16
scaddins/source/analysis/analysishelper.hxx:207
+ sca::analysis::FuncDataBase bDouble _Bool
+scaddins/source/analysis/analysishelper.hxx:208
sca::analysis::FuncDataBase bWithOpt _Bool
-scaddins/source/analysis/analysishelper.hxx:209
- sca::analysis::FuncDataBase nNumOfParams sal_uInt16
scaddins/source/analysis/analysishelper.hxx:210
+ sca::analysis::FuncDataBase nNumOfParams sal_uInt16
+scaddins/source/analysis/analysishelper.hxx:211
sca::analysis::FuncDataBase eCat enum sca::analysis::FDCategory
-scaddins/source/datefunc/datefunc.hxx:59
+scaddins/source/datefunc/datefunc.hxx:58
ScaFuncDataBase nUINameID sal_uInt16
-scaddins/source/datefunc/datefunc.hxx:60
+scaddins/source/datefunc/datefunc.hxx:59
ScaFuncDataBase nDescrID sal_uInt16
-scaddins/source/datefunc/datefunc.hxx:62
+scaddins/source/datefunc/datefunc.hxx:61
ScaFuncDataBase nParamCount sal_uInt16
-scaddins/source/datefunc/datefunc.hxx:63
+scaddins/source/datefunc/datefunc.hxx:62
ScaFuncDataBase eCat enum ScaCategory
-scaddins/source/datefunc/datefunc.hxx:64
+scaddins/source/datefunc/datefunc.hxx:63
ScaFuncDataBase bDouble _Bool
-scaddins/source/datefunc/datefunc.hxx:65
+scaddins/source/datefunc/datefunc.hxx:64
ScaFuncDataBase bWithOpt _Bool
-scaddins/source/pricing/pricing.hxx:69
+scaddins/source/pricing/pricing.hxx:68
sca::pricing::ScaFuncDataBase nUINameID sal_uInt16
-scaddins/source/pricing/pricing.hxx:70
+scaddins/source/pricing/pricing.hxx:69
sca::pricing::ScaFuncDataBase nDescrID sal_uInt16
-scaddins/source/pricing/pricing.hxx:72
+scaddins/source/pricing/pricing.hxx:71
sca::pricing::ScaFuncDataBase nParamCount sal_uInt16
-scaddins/source/pricing/pricing.hxx:73
+scaddins/source/pricing/pricing.hxx:72
sca::pricing::ScaFuncDataBase eCat enum sca::pricing::ScaCategory
-scaddins/source/pricing/pricing.hxx:74
+scaddins/source/pricing/pricing.hxx:73
sca::pricing::ScaFuncDataBase bDouble _Bool
-scaddins/source/pricing/pricing.hxx:75
+scaddins/source/pricing/pricing.hxx:74
sca::pricing::ScaFuncDataBase bWithOpt _Bool
sd/source/ui/remotecontrol/ZeroconfService.hxx:36
sd::ZeroconfService port uint
@@ -432,17 +428,17 @@ sd/source/ui/slidesorter/inc/controller/SlsVisibleAreaManager.hxx:64
sd::slidesorter::controller::VisibleAreaManager::TemporaryDisabler mrVisibleAreaManager class sd::slidesorter::controller::VisibleAreaManager &
sd/source/ui/table/TableDesignPane.hxx:110
sd::TableDesignPane aImpl class sd::TableDesignWidget
-sd/source/ui/view/DocumentRenderer.cxx:1334
+sd/source/ui/view/DocumentRenderer.cxx:1335
sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
-sd/source/ui/view/viewshel.cxx:1234
- sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1235
- sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
+ sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
sd/source/ui/view/viewshel.cxx:1236
- sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+ sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
sd/source/ui/view/viewshel.cxx:1237
+ sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+sd/source/ui/view/viewshel.cxx:1238
sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
-sd/source/ui/view/ViewShellBase.cxx:207
+sd/source/ui/view/ViewShellBase.cxx:201
sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
sfx2/source/doc/doctempl.cxx:118
DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
@@ -466,13 +462,19 @@ slideshow/source/inc/transitioninfo.hxx:119
slideshow::internal::TransitionInfo mbScaleIsotrophically _Bool
starmath/inc/view.hxx:224
SmViewShell maGraphicController class SmGraphicController
-svtools/source/uno/treecontrolpeer.cxx:68
+svtools/source/svhtml/htmlkywd.cxx:558
+ HTML_OptionEntry union HTML_OptionEntry::(anonymous at /home/noel/libo3/svtools/source/svhtml/htmlkywd.cxx:558:5)
+svtools/source/svhtml/htmlkywd.cxx:560
+ HTML_OptionEntry::(anonymous) sToken const sal_Char *
+svtools/source/svhtml/htmlkywd.cxx:561
+ HTML_OptionEntry::(anonymous) pUToken const class rtl::OUString *
+svtools/source/uno/treecontrolpeer.cxx:69
LockGuard mrLock sal_Int32 &
-sw/qa/extras/uiwriter/uiwriter.cxx:3478
+sw/qa/extras/uiwriter/uiwriter.cxx:3503
PortionItem msText class rtl::OUString
sw/source/core/crsr/crbm.cxx:64
(anonymous namespace)::CursorStateHelper m_aSaveState class SwCursorSaveState
-sw/source/core/frmedt/fetab.cxx:89
+sw/source/core/frmedt/fetab.cxx:90
TableWait m_pWait const std::unique_ptr<SwWait>
sw/source/core/layout/dbg_lay.cxx:164
SwImplEnterLeave nAction enum DbgAction
diff --git a/include/sfx2/sidebar/ControllerItem.hxx b/include/sfx2/sidebar/ControllerItem.hxx
index c02509934e23..82e003117510 100644
--- a/include/sfx2/sidebar/ControllerItem.hxx
+++ b/include/sfx2/sidebar/ControllerItem.hxx
@@ -88,7 +88,6 @@ protected:
private:
ItemUpdateReceiverInterface& mrItemUpdateReceiver;
- css::uno::Reference<css::frame::XFrame> mxFrame;
css::uno::Reference<css::lang::XComponent> mxFrameActionListener;
const ::rtl::OUString msCommandName;
};
diff --git a/sfx2/source/sidebar/ControllerItem.cxx b/sfx2/source/sidebar/ControllerItem.cxx
index a468c2129bb5..32518f4af802 100644
--- a/sfx2/source/sidebar/ControllerItem.cxx
+++ b/sfx2/source/sidebar/ControllerItem.cxx
@@ -43,7 +43,6 @@ ControllerItem::ControllerItem (
ItemUpdateReceiverInterface& rItemUpdateReceiver)
: SfxControllerItem(nSlotId, rBindings),
mrItemUpdateReceiver(rItemUpdateReceiver),
- mxFrame(),
mxFrameActionListener(),
msCommandName()
{
More information about the Libreoffice-commits
mailing list