[Libreoffice-commits] core.git: sc/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Sun Aug 6 15:29:04 UTC 2017


 sc/source/filter/xml/xmlmappingi.cxx |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit 09c938c131da60054e42cf6d84c48c04d6f74da4
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Sun Aug 6 15:48:59 2017 +0200

    cppcheck: knownConditionTrueFalse
    
    copy&paste from ~ScXMLMappingsContext
    
    Change-Id: I1dfb764639c86e2f57211867a4042e8ea917f198
    Reviewed-on: https://gerrit.libreoffice.org/40807
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/filter/xml/xmlmappingi.cxx b/sc/source/filter/xml/xmlmappingi.cxx
index f65c929c070c..426de53670e6 100644
--- a/sc/source/filter/xml/xmlmappingi.cxx
+++ b/sc/source/filter/xml/xmlmappingi.cxx
@@ -128,12 +128,7 @@ ScXMLMappingContext::~ScXMLMappingContext()
 uno::Reference< xml::sax::XFastContextHandler > SAL_CALL ScXMLMappingContext::createFastChildContext(
     sal_Int32 /*nElement*/, const uno::Reference< xml::sax::XFastAttributeList >& /*xAttrList*/ )
 {
-    SvXMLImportContext *pContext = nullptr;
-
-    if( !pContext )
-        pContext = new SvXMLImportContext( GetImport() );
-
-    return pContext;
+    return new SvXMLImportContext( GetImport() );
 }
 
 void SAL_CALL ScXMLMappingContext::endFastElement( sal_Int32 /*nElement*/ )


More information about the Libreoffice-commits mailing list