[Libreoffice-commits] core.git: qadevOOo/Jar_OOoRunner.mk qadevOOo/objdsc qadevOOo/tests

Jens Carl j.carl43 at gmx.de
Sun Aug 6 22:51:09 UTC 2017


 qadevOOo/Jar_OOoRunner.mk                                     |    1 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv |    5 
 qadevOOo/tests/java/ifc/sheet/_XViewPane.java                 |  124 ----------
 3 files changed, 130 deletions(-)

New commits:
commit 00a87bab22eff26df423001897afc79009593d42
Author: Jens Carl <j.carl43 at gmx.de>
Date:   Sat Aug 5 05:19:50 2017 +0000

    tdf#45905 Remove/disable obsolete _XViewPane Java tests
    
    The _XViewPane tests are already written in C++ since commit
    e7f55f15ccd97bc92e1400bc5862171a621da3e2.
    
    Change-Id: Idae4e0e0560d67d9f808cb2177a9c9401cec0392
    Reviewed-on: https://gerrit.libreoffice.org/40784
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/qadevOOo/Jar_OOoRunner.mk b/qadevOOo/Jar_OOoRunner.mk
index 3804778bf22e..89a0f231264a 100644
--- a/qadevOOo/Jar_OOoRunner.mk
+++ b/qadevOOo/Jar_OOoRunner.mk
@@ -654,7 +654,6 @@ $(eval $(call gb_Jar_add_sourcefiles,OOoRunner,\
     qadevOOo/tests/java/ifc/sheet/_XUniqueCellFormatRangesSupplier \
     qadevOOo/tests/java/ifc/sheet/_XUsedAreaCursor \
     qadevOOo/tests/java/ifc/sheet/_XViewFreezable \
-    qadevOOo/tests/java/ifc/sheet/_XViewPane \
     qadevOOo/tests/java/ifc/sheet/_XViewSplitable \
     qadevOOo/tests/java/ifc/style/_CharacterProperties \
     qadevOOo/tests/java/ifc/style/_CharacterPropertiesAsian \
diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv
index c798590316a9..1e7c4d6bb130 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScViewPaneObj.csv
@@ -1,8 +1,3 @@
-"ScViewPaneObj";"com::sun::star::sheet::XViewPane";"getFirstVisibleColumn()"
-"ScViewPaneObj";"com::sun::star::sheet::XViewPane";"setFirstVisibleColumn()"
-"ScViewPaneObj";"com::sun::star::sheet::XViewPane";"getFirstVisibleRow()"
-"ScViewPaneObj";"com::sun::star::sheet::XViewPane";"setFirstVisibleRow()"
-"ScViewPaneObj";"com::sun::star::sheet::XViewPane";"getVisibleRange()"
 "ScViewPaneObj";"com::sun::star::sheet::XCellRangeReferrer";"getReferredCells()"
 "ScViewPaneObj";"com::sun::star::view::XControlAccess#optional";"getControl()"
 "ScViewPaneObj";"com::sun::star::view::XFormLayerAccess#optional";"getFromController()"
diff --git a/qadevOOo/tests/java/ifc/sheet/_XViewPane.java b/qadevOOo/tests/java/ifc/sheet/_XViewPane.java
deleted file mode 100644
index ff438f1fc5c7..000000000000
--- a/qadevOOo/tests/java/ifc/sheet/_XViewPane.java
+++ /dev/null
@@ -1,124 +0,0 @@
-/*
- * This file is part of the LibreOffice project.
- *
- * This Source Code Form is subject to the terms of the Mozilla Public
- * License, v. 2.0. If a copy of the MPL was not distributed with this
- * file, You can obtain one at http://mozilla.org/MPL/2.0/.
- *
- * This file incorporates work covered by the following license notice:
- *
- *   Licensed to the Apache Software Foundation (ASF) under one or more
- *   contributor license agreements. See the NOTICE file distributed
- *   with this work for additional information regarding copyright
- *   ownership. The ASF licenses this file to you under the Apache
- *   License, Version 2.0 (the "License"); you may not use this file
- *   except in compliance with the License. You may obtain a copy of
- *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
- */
-
-package ifc.sheet;
-
-import lib.MultiMethodTest;
-
-import com.sun.star.sheet.XViewPane;
-import com.sun.star.table.CellRangeAddress;
-
-/**
-* Testing <code>com.sun.star.sheet.XViewPane</code>
-* interface methods :
-* <ul>
-*  <li><code> getFirstVisibleColumn()</code></li>
-*  <li><code> setFirstVisibleColumn()</code></li>
-*  <li><code> getFirstVisibleRow()</code></li>
-*  <li><code> setFirstVisibleRow()</code></li>
-*  <li><code> getVisibleRange()</code></li>
-* </ul> <p>
-* @see com.sun.star.sheet.XViewPane
-*/
-public class _XViewPane extends MultiMethodTest {
-
-    public XViewPane oObj = null;
-    int row = 3;
-    int col = 5;
-
-    /**
-    * Test calls the method and checks returned value. <p>
-    * Has <b> OK </b> status if returned value is equal to value that was set
-    * by method <code>setFirstVisibleColumn()</code>. <p>
-    * The following method tests are to be completed successfully before :
-    * <ul>
-    *  <li> <code> setFirstVisibleColumn() </code> : to set specific value
-    *  of the first column that is visible in the pane </li>
-    * </ul>
-    */
-    public void _getFirstVisibleColumn() {
-        requiredMethod("setFirstVisibleColumn()");
-        boolean result = col == oObj.getFirstVisibleColumn();
-        tRes.tested("getFirstVisibleColumn()", result);
-    }
-
-    /**
-    * Test calls the method and checks returned value. <p>
-    * Has <b> OK </b> status if returned value is equal to value that was set
-    * by method <code>setFirstVisibleRow()</code>. <p>
-    * The following method tests are to be completed successfully before :
-    * <ul>
-    *  <li> <code> setFirstVisibleRow() </code> : to set specific value of
-    *  the first row that is visible in the pane </li>
-    * </ul>
-    */
-    public void _getFirstVisibleRow() {
-        requiredMethod("setFirstVisibleRow()");
-        boolean result = row == oObj.getFirstVisibleRow();
-        tRes.tested("getFirstVisibleRow()", result);
-    }
-
-    /**
-    * Test just calls the method. <p>
-    * Has <b> OK </b> status if the method successfully returns. <p>
-    */
-    public void _setFirstVisibleColumn() {
-        oObj.setFirstVisibleColumn(col);
-        tRes.tested("setFirstVisibleColumn()", true);
-    }
-
-    /**
-    * Test just calls the method. <p>
-    * Has <b> OK </b> status if the method successfully returns. <p>
-    */
-    public void _setFirstVisibleRow() {
-        oObj.setFirstVisibleRow(row);
-        tRes.tested("setFirstVisibleRow()", true);
-    }
-
-    /**
-    * Test calls the method, checks returned value and adds object relation
-    * 'DATAAREA' to test environment. <p>
-    * Has <b> OK </b> status if returned value isn't null and if start row and
-    * start column are equal to values that was set by methods
-    * <code>setFirstVisibleRow</code> and <code>setFirstVisibleColumn</code>.<p>
-    * The following method tests are to be completed successfully before :
-    * <ul>
-    *  <li> <code> setFirstVisibleRow() </code> : to set specific value of
-    *  the first row that is visible in the pane </li>
-    *  <li> <code> setFirstVisibleColumn() </code> : to set specific value of
-    *  the first column that is visible in the pane </li>
-    * </ul>
-    */
-    public void _getVisibleRange() {
-        requiredMethod("setFirstVisibleRow()");
-        requiredMethod("setFirstVisibleColumn()");
-
-        CellRangeAddress RA = oObj.getVisibleRange();
-        boolean result = RA != null;
-        if (result) {
-            result &= RA.Sheet == 0;
-            result &= RA.StartRow == row;
-            result &= RA.StartColumn == col;
-            tEnv.addObjRelation("DATAAREA", RA);
-        }
-
-        tRes.tested("getVisibleRange()", result);
-    }
-}
-


More information about the Libreoffice-commits mailing list