[Libreoffice-commits] core.git: compilerplugins/clang include/drawinglayer include/svl sw/inc
Noel Grandin
noel.grandin at collabora.co.uk
Tue Aug 8 10:33:39 UTC 2017
compilerplugins/clang/unnecessaryvirtual.results | 36 ++++++-------
include/drawinglayer/primitive2d/borderlineprimitive2d.hxx | 4 -
include/svl/itempool.hxx | 2
sw/inc/SwNumberTree.hxx | 3 -
4 files changed, 22 insertions(+), 23 deletions(-)
New commits:
commit 40ea896e5c378c36ab41dbbbb06b43b8ec2c231f
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Tue Aug 8 11:12:18 2017 +0200
loplugin:unnecessaryvirtual
Change-Id: I7aa23e56f2c126bf505262454408340b557f13cf
Reviewed-on: https://gerrit.libreoffice.org/40865
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unnecessaryvirtual.results b/compilerplugins/clang/unnecessaryvirtual.results
index 58f637945925..c277376715c1 100644
--- a/compilerplugins/clang/unnecessaryvirtual.results
+++ b/compilerplugins/clang/unnecessaryvirtual.results
@@ -26,13 +26,7 @@ basic/source/comp/codegen.cxx:539
BufferTransformer::void-end()
chart2/source/inc/WeakListenerAdapter.hxx:58
chart::WeakListenerAdapter::void-disposing(const css::lang::EventObject &,)
-connectivity/source/drivers/evoab2/NConnection.hxx:69
- connectivity::evoab::OEvoabConnection::void-construct(const class rtl::OUString &,const css::uno::Sequence<css::beans::PropertyValue> &,)
-connectivity/source/drivers/evoab2/NConnection.hxx:88
- connectivity::evoab::OEvoabConnection::css::uno::Reference<css::sdbcx::XTablesSupplier>-createCatalog()
-connectivity/source/drivers/firebird/SubComponent.hxx:72
- connectivity::firebird::OPropertyArrayUsageHelper::void-~OPropertyArrayUsageHelper<TYPE>()
-extensions/source/dbpilots/unoautopilot.hxx:100
+extensions/source/dbpilots/unoautopilot.hxx:99
dbp::OUnoAutoPilot::::cppu::IPropertyArrayHelper *-createArrayHelper()const
extensions/source/propctrlr/commoncontrol.hxx:127
pcr::CommonBehaviourControl::::sal_Int16-getControlType()
@@ -48,8 +42,6 @@ extensions/source/propctrlr/commoncontrol.hxx:137
pcr::CommonBehaviourControl::void-notifyModifiedValue()
extensions/source/propctrlr/commoncontrol.hxx:141
pcr::CommonBehaviourControl::void-disposing()
-forms/source/inc/InterfaceContainer.hxx:70
- frm::ElementDescription::void-~ElementDescription()
forms/source/xforms/collection.hxx:130
Collection::_Bool-isValid(const Collection::T &,)const
forms/source/xforms/collection.hxx:139
@@ -76,8 +68,6 @@ forms/source/xforms/namedcollection.hxx:108
NamedCollection::css::uno::Sequence<OUString>-getElementNames()
forms/source/xforms/namedcollection.hxx:113
NamedCollection::sal_Bool-hasByName(const class rtl::OUString &,)
-include/comphelper/componentmodule.hxx:142
- comphelper::OModule::void-onLastClient()
include/comphelper/IdPropArrayHelper.hxx:53
comphelper::OIdPropertyArrayUsageHelper::void-~OIdPropertyArrayUsageHelper<TYPE>()
include/comphelper/interaction.hxx:55
@@ -102,6 +92,10 @@ include/comphelper/unique_disposing_ptr.hxx:168
comphelper::unique_disposing_solar_mutex_reset_ptr::void-reset(T *,)
include/comphelper/weakeventlistener.hxx:118
comphelper::OWeakListenerAdapter::void-disposing(const css::lang::EventObject &,)
+include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:58
+ drawinglayer::primitive2d::BorderLine::void-~BorderLine()
+include/drawinglayer/primitive2d/borderlineprimitive2d.hxx:66
+ drawinglayer::primitive2d::BorderLine::_Bool-operator==(const class drawinglayer::primitive2d::BorderLine &,)const
include/sfx2/controlwrapper.hxx:257
sfx::MetricFieldWrapper::_Bool-IsControlDontKnow()const
include/sfx2/controlwrapper.hxx:258
@@ -136,12 +130,16 @@ include/sfx2/itemwrapper.hxx:156
sfx::IdentItemWrapper::const ItemT &-GetItemValue(const ItemT &,)const
include/sfx2/itemwrapper.hxx:158
sfx::IdentItemWrapper::void-SetItemValue(ItemT &,const ItemT &,)const
+include/svl/itempool.hxx:171
+ SfxItemPool::class SvStream &-Store(class SvStream &,)const
include/svl/svdde.hxx:307
DdeService::void-~DdeService()
+include/svtools/svparser.hxx:91
+ SvParser::void-NextToken(T,)
+include/svtools/svparser.hxx:127
+ SvParser::void-Continue(T,)
include/toolkit/controls/geometrycontrolmodel.hxx:192
OGeometryControlModel::void-fillProperties(css::uno::Sequence<css::beans::Property> &,css::uno::Sequence<css::beans::Property> &,)const
-include/unotools/fontcvt.hxx:55
- StarSymbolToMSMultiFont::void-~StarSymbolToMSMultiFont()
include/vbahelper/vbacollectionimpl.hxx:291
ScVbaCollectionBase::::sal_Int32-getCount()
include/vbahelper/vbacollectionimpl.hxx:296
@@ -282,6 +280,8 @@ sw/inc/flypos.hxx:37
SwPosFlyFrame::void-~SwPosFlyFrame()
sw/inc/ring.hxx:45
sw::Ring::void-~Ring<value_type>()
+sw/inc/SwNumberTree.hxx:399
+ SwNumberTreeNode::void-IsSane(_Bool,std::vector<const SwNumberTreeNode *>,)const
vcl/inc/opengl/BufferObject.hxx:31
vcl::BufferObject::void-~BufferObject<TYPE, BUFFER_TYPE>()
vcl/inc/salframe.hxx:178
@@ -320,15 +320,15 @@ vcl/inc/unx/saldisp.hxx:392
SalX11Display::void-Yield()
vcl/inc/unx/salinst.h:47
X11SalInstance::class SalX11Display *-CreateDisplay()const
-writerfilter/source/ooxml/OOXMLFactory.hxx:69
- writerfilter::ooxml::OOXMLFactory_ns::void-startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
writerfilter/source/ooxml/OOXMLFactory.hxx:70
- writerfilter::ooxml::OOXMLFactory_ns::void-charactersAction(class writerfilter::ooxml::OOXMLFastContextHandler *,const class rtl::OUString &,)
+ writerfilter::ooxml::OOXMLFactory_ns::void-startAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
writerfilter/source/ooxml/OOXMLFactory.hxx:71
- writerfilter::ooxml::OOXMLFactory_ns::void-endAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
+ writerfilter::ooxml::OOXMLFactory_ns::void-charactersAction(class writerfilter::ooxml::OOXMLFastContextHandler *,const class rtl::OUString &,)
writerfilter/source/ooxml/OOXMLFactory.hxx:72
+ writerfilter::ooxml::OOXMLFactory_ns::void-endAction(class writerfilter::ooxml::OOXMLFastContextHandler *,)
+writerfilter/source/ooxml/OOXMLFactory.hxx:73
writerfilter::ooxml::OOXMLFactory_ns::void-attributeAction(class writerfilter::ooxml::OOXMLFastContextHandler *,writerfilter::Token_t,const class OOXMLValue::Pointer_t &,)
-writerfilter/source/ooxml/OOXMLFactory.hxx:75
+writerfilter/source/ooxml/OOXMLFactory.hxx:76
writerfilter::ooxml::OOXMLFactory_ns::void-~OOXMLFactory_ns()
writerperfect/inc/ImportFilter.hxx:178
writerperfect::detail::ImportFilterImpl::void-doRegisterHandlers(Generator &,)
diff --git a/include/drawinglayer/primitive2d/borderlineprimitive2d.hxx b/include/drawinglayer/primitive2d/borderlineprimitive2d.hxx
index 24916190757e..2eba13fee917 100644
--- a/include/drawinglayer/primitive2d/borderlineprimitive2d.hxx
+++ b/include/drawinglayer/primitive2d/borderlineprimitive2d.hxx
@@ -55,7 +55,7 @@ namespace drawinglayer
const basegfx::BColor& rRGBColor,
double fExtendStart = 0.0,
double fExtendEnd = 0.0);
- virtual ~BorderLine();
+ ~BorderLine();
double getWidth() const { return mfWidth; }
const basegfx::BColor& getRGBColor() const { return maRGBColor; }
@@ -63,7 +63,7 @@ namespace drawinglayer
double getExtendEnd() const { return mfExtendEnd; }
/// compare operator
- virtual bool operator==(const BorderLine& rBorderLine) const;
+ bool operator==(const BorderLine& rBorderLine) const;
};
/** BorderLinePrimitive2D class
diff --git a/include/svl/itempool.hxx b/include/svl/itempool.hxx
index f9285f9612bf..37f8d535756a 100644
--- a/include/svl/itempool.hxx
+++ b/include/svl/itempool.hxx
@@ -168,7 +168,7 @@ public:
const SfxPoolItem *pItem ) const;
SvStream & Load(SvStream &);
- virtual SvStream & Store(SvStream &) const;
+ SvStream & Store(SvStream &) const;
void LoadCompleted();
sal_uInt16 GetFirstWhich() const;
diff --git a/sw/inc/SwNumberTree.hxx b/sw/inc/SwNumberTree.hxx
index f87c82c6d549..283956f681e2 100644
--- a/sw/inc/SwNumberTree.hxx
+++ b/sw/inc/SwNumberTree.hxx
@@ -396,8 +396,7 @@ protected:
@param bRecursive descend to children
@param rParents vector for recording path
*/
- virtual void IsSane
- (bool bRecursive, std::vector<const SwNumberTreeNode *> rParents) const;
+ void IsSane(bool bRecursive, std::vector<const SwNumberTreeNode *> rParents) const;
#endif // DBG_UTIL
/**
More information about the Libreoffice-commits
mailing list