[Libreoffice-commits] core.git: Branch 'libreoffice-5-4' - sc/source

Noel Grandin noel.grandin at collabora.co.uk
Wed Aug 23 09:20:45 UTC 2017


 sc/source/core/data/table5.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 47d3917662ab1f3e3dde93b283a8513fadc8cacc
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Aug 23 08:54:01 2017 +0200

    fix bug in ScTable::LastHiddenColRow
    
    found by inspection, noticed that the for loop is not actually using
    it's index variable
    
    introduced in
    
        commit b3579d71c6536ab1d03cc47249d582a574fd054a
        koheirowlimitperf: #i109369# #i109373# #i109384# #i109385# #i109386#
    million, and integrated lots of speed optimization and bug fixes to
    ensure Calc remains usable after the row limit increase.
    
    Change-Id: Icfee19ddb051e8d4333ed4c91d384379bf494444
    Reviewed-on: https://gerrit.libreoffice.org/41439
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    (cherry picked from commit 4feccde59797200f8a5f640b452a411f903e604a)
    Reviewed-on: https://gerrit.libreoffice.org/41446
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sc/source/core/data/table5.cxx b/sc/source/core/data/table5.cxx
index c7a3b7938b68..81ad0057e68b 100644
--- a/sc/source/core/data/table5.cxx
+++ b/sc/source/core/data/table5.cxx
@@ -764,8 +764,8 @@ SCCOLROW ScTable::LastHiddenColRow(SCCOLROW nPos, bool bCol) const
         {
             for (SCCOL i = nCol+1; i <= MAXCOL; ++i)
             {
-                if (!ColHidden(nCol))
-                    return nCol - 1;
+                if (!ColHidden(i))
+                    return i - 1;
             }
         }
     }


More information about the Libreoffice-commits mailing list