[Libreoffice-commits] core.git: sc/source

[Mike Kaganski]

 sc/source/core/data/conditio.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 50acacae130fcc795c8bd1cc9e829d8332149390
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Fri Dec 1 10:12:02 2017 +0200

    Remove nonsensical loop
    
    The comphelper::ContainerUniquePtrEquals loops through containers itself
    
    Change-Id: I78181d9b4b951bebcd31f40abedcda0cd3e91973
    Reviewed-on: https://gerrit.libreoffice.org/45634
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/sc/source/core/data/conditio.cxx b/sc/source/core/data/conditio.cxx
index 5be3688bfe6a..7bb41c29575d 100644
--- a/sc/source/core/data/conditio.cxx
+++ b/sc/source/core/data/conditio.cxx
@@ -1750,9 +1750,8 @@ bool ScConditionalFormat::EqualEntries( const ScConditionalFormat& r ) const
         return false;
 
     //TODO: Test for same entries in reverse order?
-    for (size_t i=0; i<size(); i++)
-        if ( ! ::comphelper::ContainerUniquePtrEquals(maEntries, r.maEntries) )
-            return false;
+    if ( ! ::comphelper::ContainerUniquePtrEquals(maEntries, r.maEntries) )
+        return false;
 
     // right now don't check for same range
     // we only use this method to merge same conditional formats from