[Libreoffice-commits] core.git: basic/qa

[Zdeněk Crhonek]

 basic/qa/vba_tests/atn.vb   |    2 +-
 basic/qa/vba_tests/cdate.vb |    4 ++--
 basic/qa/vba_tests/cos.vb   |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 9d3b73c8351dcb534580f14c44a8387b16ba763a
Author: Zdeněk Crhonek <zcrhonek at gmail.com>
Date:   Fri Nov 24 22:21:07 2017 +0100

    VBA tests - repair tests (Don't pass when all tests fail)
    
    Change-Id: I70bfb8b909f9f7033cd1eb374db0fe710fd2a0c3
    Reviewed-on: https://gerrit.libreoffice.org/45260
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Zdenek Crhonek <zcrhonek at gmail.com>

diff --git a/basic/qa/vba_tests/atn.vb b/basic/qa/vba_tests/atn.vb
index 4155a1cb2b93..145584ee6bd2 100644
--- a/basic/qa/vba_tests/atn.vb
+++ b/basic/qa/vba_tests/atn.vb
@@ -6,7 +6,7 @@ Dim result As String
 
 Function doUnitTest() As String
 result = verify_testATN()
-If failCount <> 0 And passCount > 0 Then
+If failCount <> 0 or passCount = 0 Then
     doUnitTest = result
 Else
     doUnitTest = "OK"
diff --git a/basic/qa/vba_tests/cdate.vb b/basic/qa/vba_tests/cdate.vb
index 718712e93c04..d04ecc0043a0 100644
--- a/basic/qa/vba_tests/cdate.vb
+++ b/basic/qa/vba_tests/cdate.vb
@@ -6,7 +6,7 @@ Dim result As String
 
 Function doUnitTest() As String
 result = verify_testCDate()
-If failCount <> 0 And passCount > 0 Then
+If failCount <> 0 or passCount = 0 Then
     doUnitTest = result
 Else
     doUnitTest = "OK"
@@ -28,7 +28,7 @@ Function verify_testCDate() As String
     On Error GoTo errorHandler
 
     date2 = 25246
-    date1 = CDate("12.2.1969") '2/12/1969
+    date1 = CDate("12/02/1969") '02/12/1969
     TestLog_ASSERT date1 = date2, "the return CDate is: " & date1
 
     date2 = 28313
diff --git a/basic/qa/vba_tests/cos.vb b/basic/qa/vba_tests/cos.vb
index 4f9d725742db..993794b70f8c 100644
--- a/basic/qa/vba_tests/cos.vb
+++ b/basic/qa/vba_tests/cos.vb
@@ -6,7 +6,7 @@ Dim result As String
 
 Function doUnitTest() As String
 result = verify_testCOS()
-If failCount <> 0 And passCount > 0 Then
+If failCount <> 0 or passCount = 0 Then
     doUnitTest = result
 Else
     doUnitTest = "OK"