[Libreoffice-commits] core.git: cui/source
Noel Grandin
noel.grandin at collabora.co.uk
Wed Dec 6 09:35:47 UTC 2017
cui/source/customize/SvxMenuConfigPage.cxx | 2 +-
cui/source/customize/SvxToolbarConfigPage.cxx | 2 +-
cui/source/customize/cfg.cxx | 18 +++++++++---------
cui/source/dialogs/screenshotannotationdlg.cxx | 2 +-
cui/source/inc/CommandCategoryListBox.hxx | 2 +-
cui/source/inc/bbdlg.hxx | 4 ++--
cui/source/inc/cfg.hxx | 6 +++---
cui/source/inc/cfgutil.hxx | 4 ++--
cui/source/inc/cuitabline.hxx | 4 ++--
cui/source/inc/dlgname.hxx | 2 +-
cui/source/inc/dstribut.hxx | 8 ++++----
cui/source/inc/hltpbase.hxx | 2 +-
cui/source/inc/insdlg.hxx | 2 +-
cui/source/inc/labdlg.hxx | 2 +-
cui/source/inc/linkdlg.hxx | 2 +-
cui/source/inc/numpages.hxx | 2 +-
cui/source/inc/postdlg.hxx | 2 +-
cui/source/inc/transfrm.hxx | 2 +-
cui/source/inc/treeopt.hxx | 2 +-
cui/source/options/optaboutconfig.cxx | 2 +-
cui/source/options/optaboutconfig.hxx | 2 +-
21 files changed, 37 insertions(+), 37 deletions(-)
New commits:
commit 31b89aaeacff570017c3344195af6d075d7ec73c
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Wed Dec 6 09:09:46 2017 +0200
loplugin:countusersofdefaultparams in cui
Change-Id: Id3258a664c2ea740419331877f7ce6af5e2559e7
Reviewed-on: https://gerrit.libreoffice.org/45922
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/cui/source/customize/SvxMenuConfigPage.cxx b/cui/source/customize/SvxMenuConfigPage.cxx
index aa885a206609..b167e5259465 100644
--- a/cui/source/customize/SvxMenuConfigPage.cxx
+++ b/cui/source/customize/SvxMenuConfigPage.cxx
@@ -378,7 +378,7 @@ IMPL_LINK( SvxMenuConfigPage, InsertHdl, MenuButton *, pButton, void )
pNameDialog->GetName(aNewName);
SvxConfigEntry* pNewEntryData =
- new SvxConfigEntry( aNewName, aNewName, true );
+ new SvxConfigEntry( aNewName, aNewName, true, /*bParentData*/false );
pNewEntryData->SetName( aNewName );
pNewEntryData->SetUserDefined();
diff --git a/cui/source/customize/SvxToolbarConfigPage.cxx b/cui/source/customize/SvxToolbarConfigPage.cxx
index 72e4675b0336..4ee96a3ef0af 100644
--- a/cui/source/customize/SvxToolbarConfigPage.cxx
+++ b/cui/source/customize/SvxToolbarConfigPage.cxx
@@ -381,7 +381,7 @@ IMPL_LINK_NOARG( SvxToolbarConfigPage, AddToolbarHdl, Button *, void )
}
SvxConfigEntry* pToolbar =
- new SvxConfigEntry( aNewName, aNewURL, true );
+ new SvxConfigEntry( aNewName, aNewURL, true, /*bParentData*/false );
pToolbar->SetUserDefined();
pToolbar->SetMain();
diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 83e3be792433..8420ada0049a 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -429,7 +429,7 @@ MenuSaveInData::GetEntries()
{
if ( pRootEntry == nullptr )
{
- pRootEntry.reset( new SvxConfigEntry( "MainMenus", OUString(), true) );
+ pRootEntry.reset( new SvxConfigEntry( "MainMenus", OUString(), true, /*bParentData*/false) );
if ( m_xMenuSettings.is() )
{
@@ -528,7 +528,7 @@ bool SaveInData::LoadSubMenus( const uno::Reference< container::XIndexAccess >&
}
SvxConfigEntry* pEntry = new SvxConfigEntry(
- aLabel, aCommandURL, xSubMenu.is() );
+ aLabel, aCommandURL, xSubMenu.is(), /*bParentData*/false );
pEntry->SetUserDefined( bIsUserDefined );
if ( !bUseDefaultLabel )
@@ -769,7 +769,7 @@ SvxEntries* ContextMenuSaveInData::GetEntries()
typedef std::unordered_map< OUString, bool > MenuInfo;
MenuInfo aMenuInfo;
- m_pRootEntry.reset( new SvxConfigEntry( "ContextMenus", OUString(), true ) );
+ m_pRootEntry.reset( new SvxConfigEntry( "ContextMenus", OUString(), true, /*bParentData*/false ) );
css::uno::Sequence< css::uno::Sequence< css::beans::PropertyValue > > aElementsInfo;
try
{
@@ -808,7 +808,7 @@ SvxEntries* ContextMenuSaveInData::GetEntries()
// Menus without UI name aren't supposed to be customized.
continue;
- SvxConfigEntry* pEntry = new SvxConfigEntry( aUIMenuName, aUrl, true );
+ SvxConfigEntry* pEntry = new SvxConfigEntry( aUIMenuName, aUrl, true, /*bParentData*/false );
pEntry->SetMain();
m_pRootEntry->GetEntries()->push_back( pEntry );
LoadSubMenus( xPopupMenu, aUIMenuName, pEntry, true );
@@ -1643,7 +1643,7 @@ SvTreeListEntry* SvxConfigPage::AddFunction(
aDisplayName = vcl::CommandInfoProvider::GetLabelForCommand( aURL, aModuleId );
SvxConfigEntry* pNewEntryData =
- new SvxConfigEntry( aDisplayName, aURL, false );
+ new SvxConfigEntry( aDisplayName, aURL, false, /*bParentData*/false );
pNewEntryData->SetUserDefined();
if ( aDisplayName.isEmpty() )
@@ -1949,7 +1949,7 @@ SvxMainMenuOrganizerDialog::SvxMainMenuOrganizerDialog(
OUString newurl = SvxConfigPageHelper::generateCustomMenuURL( mpEntries );
SvxConfigEntry* pNewEntryData =
- new SvxConfigEntry( newname, newurl, true );
+ new SvxConfigEntry( newname, newurl, true, /*bParentData*/false );
pNewEntryData->SetName( newname );
pNewEntryData->SetUserDefined();
pNewEntryData->SetMain();
@@ -2258,7 +2258,7 @@ SvxEntries* ToolbarSaveInData::GetEntries()
if ( pRootEntry == nullptr )
{
- pRootEntry.reset( new SvxConfigEntry( "MainToolbars", OUString(), true) );
+ pRootEntry.reset( new SvxConfigEntry( "MainToolbars", OUString(), true, /*bParentData*/false) );
uno::Sequence< uno::Sequence < beans::PropertyValue > > info =
GetConfigManager()->getUIElementsInfo(
@@ -2302,7 +2302,7 @@ SvxEntries* ToolbarSaveInData::GetEntries()
}
SvxConfigEntry* pEntry = new SvxConfigEntry(
- uiname, url, true );
+ uiname, url, true, /*bParentData*/false );
pEntry->SetMain();
pEntry->SetStyle( GetSystemStyle( url ) );
@@ -2791,7 +2791,7 @@ void ToolbarSaveInData::LoadToolbar(
}
SvxConfigEntry* pEntry = new SvxConfigEntry(
- aLabel, aCommandURL, false );
+ aLabel, aCommandURL, false, /*bParentData*/false );
pEntry->SetUserDefined( bIsUserDefined );
pEntry->SetVisible( bIsVisible );
diff --git a/cui/source/dialogs/screenshotannotationdlg.cxx b/cui/source/dialogs/screenshotannotationdlg.cxx
index 49ffbc98e2ca..42e22182cd1f 100644
--- a/cui/source/dialogs/screenshotannotationdlg.cxx
+++ b/cui/source/dialogs/screenshotannotationdlg.cxx
@@ -150,7 +150,7 @@ private:
const ControlDataEntry& rEntry,
const Color& rColor,
double fLineWidth,
- double fTransparency = 0.0);
+ double fTransparency);
void RepaintToBuffer(
bool bUseDimmed = false,
bool bPaintHilight = false);
diff --git a/cui/source/inc/CommandCategoryListBox.hxx b/cui/source/inc/CommandCategoryListBox.hxx
index 8149cc6f261c..62423d0dac99 100644
--- a/cui/source/inc/CommandCategoryListBox.hxx
+++ b/cui/source/inc/CommandCategoryListBox.hxx
@@ -52,7 +52,7 @@ public:
void FillFunctionsList(
const css::uno::Sequence< css::frame::DispatchInformation >& xCommands,
const VclPtr<SfxConfigFunctionListBox>& pFunctionListBox,
- const OUString& filterTerm = OUString() );
+ const OUString& filterTerm );
OUString MapCommand2UIName(const OUString& sCommand);
/**
diff --git a/cui/source/inc/bbdlg.hxx b/cui/source/inc/bbdlg.hxx
index 750a1f0bdd80..1a3a2afa3da6 100644
--- a/cui/source/inc/bbdlg.hxx
+++ b/cui/source/inc/bbdlg.hxx
@@ -30,8 +30,8 @@ class SvxBorderBackgroundDlg: public SfxTabDialog
public:
SvxBorderBackgroundDlg(vcl::Window *pParent,
const SfxItemSet& rCoreSet,
- bool bEnableSelector = false,
- bool bEnableDrawingLayerFillStyles = false);
+ bool bEnableSelector,
+ bool bEnableDrawingLayerFillStyles);
protected:
virtual void PageCreated( sal_uInt16 nPageId, SfxTabPage& rTabPage ) override;
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index 445b860a7f74..5e65de3a830a 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -274,8 +274,8 @@ public:
SvxConfigEntry( const OUString& rDisplayName,
const OUString& rCommandURL,
- bool bPopup = false,
- bool bParentData = false );
+ bool bPopup,
+ bool bParentData );
SvxConfigEntry()
:
@@ -512,7 +512,7 @@ class SvxMainMenuOrganizerDialog : public ModalDialog
public:
SvxMainMenuOrganizerDialog (
vcl::Window*, SvxEntries*,
- SvxConfigEntry const *, bool bCreateMenu = false );
+ SvxConfigEntry const *, bool bCreateMenu );
virtual ~SvxMainMenuOrganizerDialog() override;
virtual void dispose() override;
diff --git a/cui/source/inc/cfgutil.hxx b/cui/source/inc/cfgutil.hxx
index 413de4e25c83..ff9ca2896976 100644
--- a/cui/source/inc/cfgutil.hxx
+++ b/cui/source/inc/cfgutil.hxx
@@ -199,8 +199,8 @@ class SvxScriptSelectorDialog : public ModalDialog
public:
SvxScriptSelectorDialog (
- vcl::Window* pParent = nullptr,
- bool bShowSlots = false,
+ vcl::Window* pParent,
+ bool bShowSlots,
const css::uno::Reference< css::frame::XFrame >& xFrame = nullptr
);
virtual ~SvxScriptSelectorDialog() override;
diff --git a/cui/source/inc/cuitabline.hxx b/cui/source/inc/cuitabline.hxx
index 5fabc21eada0..8f6fc3fe44bf 100644
--- a/cui/source/inc/cuitabline.hxx
+++ b/cui/source/inc/cuitabline.hxx
@@ -63,8 +63,8 @@ class SvxLineTabDialog final : public SfxTabDialog
public:
SvxLineTabDialog( vcl::Window* pParent, const SfxItemSet* pAttr,
- SdrModel* pModel, const SdrObject* pObj = nullptr,
- bool bHasObj = true );
+ SdrModel* pModel, const SdrObject* pObj,
+ bool bHasObj );
void SetNewDashList( XDashListRef const & pInLst)
{ pNewDashList = pInLst; }
diff --git a/cui/source/inc/dlgname.hxx b/cui/source/inc/dlgname.hxx
index e1ffd2a1e338..689008e38849 100644
--- a/cui/source/inc/dlgname.hxx
+++ b/cui/source/inc/dlgname.hxx
@@ -142,7 +142,7 @@ private:
DECL_LINK(Button2Hdl, Button*, void);
public:
- SvxMessDialog( vcl::Window* pWindow, const OUString& rText, const OUString& rDesc, Image const * pImg = nullptr );
+ SvxMessDialog( vcl::Window* pWindow, const OUString& rText, const OUString& rDesc, Image const * pImg );
virtual ~SvxMessDialog() override;
virtual void dispose() override;
diff --git a/cui/source/inc/dstribut.hxx b/cui/source/inc/dstribut.hxx
index 55fb09410185..0923746a2eca 100644
--- a/cui/source/inc/dstribut.hxx
+++ b/cui/source/inc/dstribut.hxx
@@ -42,8 +42,8 @@ class SvxDistributePage : public SvxTabPage
public:
SvxDistributePage(vcl::Window* pWindow, const SfxItemSet& rInAttrs,
- SvxDistributeHorizontal eHor = SvxDistributeHorizontal::NONE,
- SvxDistributeVertical eVer = SvxDistributeVertical::NONE);
+ SvxDistributeHorizontal eHor,
+ SvxDistributeVertical eVer);
virtual ~SvxDistributePage() override;
virtual void dispose() override;
@@ -61,8 +61,8 @@ class SvxDistributeDialog : public SfxSingleTabDialog
public:
SvxDistributeDialog(vcl::Window* pParent, const SfxItemSet& rAttr,
- SvxDistributeHorizontal eHor = SvxDistributeHorizontal::NONE,
- SvxDistributeVertical eVer = SvxDistributeVertical::NONE);
+ SvxDistributeHorizontal eHor,
+ SvxDistributeVertical eVer);
virtual ~SvxDistributeDialog() override;
virtual void dispose() override;
diff --git a/cui/source/inc/hltpbase.hxx b/cui/source/inc/hltpbase.hxx
index edf2546cf217..4c78d1223d60 100644
--- a/cui/source/inc/hltpbase.hxx
+++ b/cui/source/inc/hltpbase.hxx
@@ -53,7 +53,7 @@ protected:
virtual sal_Int8 ExecuteDrop( const ExecuteDropEvent& rEvt ) override;
public:
- SvxHyperURLBox( vcl::Window* pParent, INetProtocol eSmart = INetProtocol::File );
+ SvxHyperURLBox( vcl::Window* pParent, INetProtocol eSmart );
};
diff --git a/cui/source/inc/insdlg.hxx b/cui/source/inc/insdlg.hxx
index 4b4277495004..102eb19d421f 100644
--- a/cui/source/inc/insdlg.hxx
+++ b/cui/source/inc/insdlg.hxx
@@ -79,7 +79,7 @@ class SvInsertOleDlg : public InsertObjectDialog_Impl
public:
SvInsertOleDlg( vcl::Window* pParent,
const css::uno::Reference < css::embed::XStorage >& xStorage,
- const SvObjectServerList* pServers = nullptr );
+ const SvObjectServerList* pServers );
virtual ~SvInsertOleDlg() override;
virtual void dispose() override;
virtual short Execute() override;
diff --git a/cui/source/inc/labdlg.hxx b/cui/source/inc/labdlg.hxx
index 7935a9f75a76..3fa0179d91d7 100644
--- a/cui/source/inc/labdlg.hxx
+++ b/cui/source/inc/labdlg.hxx
@@ -113,7 +113,7 @@ private:
public:
SvxCaptionTabDialog(vcl::Window* pParent, const SdrView* pView,
- SvxAnchorIds nAnchorTypes = SvxAnchorIds::NONE);
+ SvxAnchorIds nAnchorTypes);
/// link for the Writer to validate positions
void SetValidateFramePosLink( const Link<SvxSwFrameValidation&,void>& rLink );
diff --git a/cui/source/inc/linkdlg.hxx b/cui/source/inc/linkdlg.hxx
index 15fcb6f7a8d9..3db4f16401eb 100644
--- a/cui/source/inc/linkdlg.hxx
+++ b/cui/source/inc/linkdlg.hxx
@@ -81,7 +81,7 @@ class SvBaseLinksDlg : public ModalDialog
void SetManager( sfx2::LinkManager* );
public:
- SvBaseLinksDlg( vcl::Window * pParent, sfx2::LinkManager*, bool bHtml = false );
+ SvBaseLinksDlg( vcl::Window * pParent, sfx2::LinkManager*, bool bHtml );
virtual ~SvBaseLinksDlg() override;
virtual void dispose() override;
void SetActLink( sfx2::SvBaseLink const * pLink );
diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx
index e8d85cf9113c..8732edb2b8d4 100644
--- a/cui/source/inc/numpages.hxx
+++ b/cui/source/inc/numpages.hxx
@@ -55,7 +55,7 @@ class SvxNumberingPreview : public vcl::Window
virtual void Paint( vcl::RenderContext& rRenderContext, const ::tools::Rectangle& rRect ) override;
public:
- SvxNumberingPreview(vcl::Window* pParent, WinBits nWinBits = WB_BORDER);
+ SvxNumberingPreview(vcl::Window* pParent, WinBits nWinBits);
void SetNumRule(const SvxNumRule* pNum)
{pActNum = pNum; Invalidate();};
diff --git a/cui/source/inc/postdlg.hxx b/cui/source/inc/postdlg.hxx
index 23c9ca17b04f..678602a85feb 100644
--- a/cui/source/inc/postdlg.hxx
+++ b/cui/source/inc/postdlg.hxx
@@ -43,7 +43,7 @@ class SvxPostItDialog : public SfxModalDialog
{
public:
SvxPostItDialog(vcl::Window* pParent, const SfxItemSet& rCoreSet,
- bool bPrevNext = false);
+ bool bPrevNext);
virtual ~SvxPostItDialog() override;
virtual void dispose() override;
diff --git a/cui/source/inc/transfrm.hxx b/cui/source/inc/transfrm.hxx
index 1728a30c9b60..7222f09f92b4 100644
--- a/cui/source/inc/transfrm.hxx
+++ b/cui/source/inc/transfrm.hxx
@@ -55,7 +55,7 @@ public:
SvxTransformTabDialog( vcl::Window* pParent, const SfxItemSet* pAttr,
const SdrView* pView,
- SvxAnchorIds nAnchorTypes = SvxAnchorIds::NONE);
+ SvxAnchorIds nAnchorTypes);
//link for the Writer to validate positions
void SetValidateFramePosLink( const Link<SvxSwFrameValidation&,void>& rLink );
diff --git a/cui/source/inc/treeopt.hxx b/cui/source/inc/treeopt.hxx
index efad9eb74137..274076d9d99f 100644
--- a/cui/source/inc/treeopt.hxx
+++ b/cui/source/inc/treeopt.hxx
@@ -176,7 +176,7 @@ private:
public:
OfaTreeOptionsDialog( vcl::Window* pParent,
const css::uno::Reference< css::frame::XFrame >& _xFrame,
- bool bActivateLastSelection = true );
+ bool bActivateLastSelection );
OfaTreeOptionsDialog( vcl::Window* pParent, const OUString& rExtensionId );
virtual ~OfaTreeOptionsDialog() override;
virtual void dispose() override;
diff --git a/cui/source/options/optaboutconfig.cxx b/cui/source/options/optaboutconfig.cxx
index ca6ca3673353..bb9e2275ed90 100644
--- a/cui/source/options/optaboutconfig.cxx
+++ b/cui/source/options/optaboutconfig.cxx
@@ -69,7 +69,7 @@ struct UserData
, aLineage(0)
{}
- explicit UserData( Reference<XNameAccess> const & rXNameAccess, int rIndex = 0 )
+ explicit UserData( Reference<XNameAccess> const & rXNameAccess, int rIndex )
: bIsPropertyPath( false )
, aLineage(rIndex)
, aXNameAccess( rXNameAccess )
diff --git a/cui/source/options/optaboutconfig.hxx b/cui/source/options/optaboutconfig.hxx
index 5efef99828e0..dcb6b6c0971a 100644
--- a/cui/source/options/optaboutconfig.hxx
+++ b/cui/source/options/optaboutconfig.hxx
@@ -86,7 +86,7 @@ private:
VclPtr<CuiCustomMultilineEdit> m_pEDValue;
public:
- CuiAboutConfigValueDialog( vcl::Window* pWindow, const OUString& rValue , int limit = 0);
+ CuiAboutConfigValueDialog( vcl::Window* pWindow, const OUString& rValue , int limit);
virtual ~CuiAboutConfigValueDialog() override;
virtual void dispose() override;
More information about the Libreoffice-commits
mailing list