[Libreoffice-commits] core.git: 2 commits - basctl/source basegfx/source basic/source cppuhelper/source include/basegfx include/comphelper
Noel Grandin
noel.grandin at collabora.co.uk
Thu Dec 7 06:22:40 UTC 2017
basctl/source/basicide/documentenumeration.hxx | 2 +-
basctl/source/basicide/macrodlg.hxx | 2 +-
basctl/source/basicide/unomodel.hxx | 2 +-
basegfx/source/inc/hommatrixtemplate.hxx | 2 +-
basegfx/source/polygon/b2dtrapezoid.cxx | 2 +-
basic/source/inc/expr.hxx | 2 +-
basic/source/runtime/inputbox.cxx | 2 +-
cppuhelper/source/factory.cxx | 4 ++--
include/basegfx/polygon/b2dlinegeometry.hxx | 4 ++--
include/basegfx/polygon/b3dpolygontools.hxx | 6 +++---
include/basegfx/polygon/b3dpolypolygontools.hxx | 8 ++++----
include/comphelper/ChainablePropertySet.hxx | 2 +-
include/comphelper/MasterPropertySet.hxx | 2 +-
13 files changed, 20 insertions(+), 20 deletions(-)
New commits:
commit c947a25b3a785f8d43160671f79e3bb503dfb1ae
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Wed Dec 6 15:02:40 2017 +0200
loplugin:countusersofdefaultparams in basctl..basegfx
Change-Id: I515acfb9de1f6dff1de94a60055c5b600e5e5241
Reviewed-on: https://gerrit.libreoffice.org/45957
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/basctl/source/basicide/documentenumeration.hxx b/basctl/source/basicide/documentenumeration.hxx
index 964a2c8c4d92..2dbe7b6621f3 100644
--- a/basctl/source/basicide/documentenumeration.hxx
+++ b/basctl/source/basicide/documentenumeration.hxx
@@ -70,7 +70,7 @@ namespace basctl { namespace docs {
class DocumentEnumeration
{
public:
- DocumentEnumeration( css::uno::Reference< css::uno::XComponentContext > const & _rContext, const IDocumentDescriptorFilter* _pFilter = nullptr );
+ DocumentEnumeration( css::uno::Reference< css::uno::XComponentContext > const & _rContext, const IDocumentDescriptorFilter* _pFilter );
~DocumentEnumeration();
/** retrieves a list of all currently known documents in the application
diff --git a/basctl/source/basicide/macrodlg.hxx b/basctl/source/basicide/macrodlg.hxx
index dee445ab9701..8a0e1ff16a93 100644
--- a/basctl/source/basicide/macrodlg.hxx
+++ b/basctl/source/basicide/macrodlg.hxx
@@ -90,7 +90,7 @@ private:
void RestoreMacroDescription();
public:
- MacroChooser( vcl::Window* pParent, const ::css::uno::Reference< ::css::frame::XFrame >& xDocFrame, bool bCreateEntries = true );
+ MacroChooser( vcl::Window* pParent, const ::css::uno::Reference< ::css::frame::XFrame >& xDocFrame, bool bCreateEntries );
virtual ~MacroChooser() override;
virtual void dispose() override;
diff --git a/basctl/source/basicide/unomodel.hxx b/basctl/source/basicide/unomodel.hxx
index e4d92351347a..3d5fa6966cc6 100644
--- a/basctl/source/basicide/unomodel.hxx
+++ b/basctl/source/basicide/unomodel.hxx
@@ -31,7 +31,7 @@ class SIDEModel : public SfxBaseModel,
/// @throws css::io::IOException
static void notImplemented();
public:
- explicit SIDEModel(SfxObjectShell *pObjSh = nullptr);
+ explicit SIDEModel(SfxObjectShell *pObjSh);
virtual ~SIDEModel() override;
//XInterface
diff --git a/basegfx/source/inc/hommatrixtemplate.hxx b/basegfx/source/inc/hommatrixtemplate.hxx
index 08c5b538f995..b30ca3b1ba3b 100644
--- a/basegfx/source/inc/hommatrixtemplate.hxx
+++ b/basegfx/source/inc/hommatrixtemplate.hxx
@@ -46,7 +46,7 @@ namespace basegfx
{
}
- explicit ImplMatLine(sal_uInt16 nRow, ImplMatLine< RowSize >* pToBeCopied = nullptr)
+ explicit ImplMatLine(sal_uInt16 nRow, ImplMatLine< RowSize >* pToBeCopied)
{
if(pToBeCopied)
{
diff --git a/basegfx/source/polygon/b2dtrapezoid.cxx b/basegfx/source/polygon/b2dtrapezoid.cxx
index 76f4700c2b79..0916099a8c4c 100644
--- a/basegfx/source/polygon/b2dtrapezoid.cxx
+++ b/basegfx/source/polygon/b2dtrapezoid.cxx
@@ -98,7 +98,7 @@ namespace basegfx
TrDeEdgeEntry(
const B2DPoint* pStart,
const B2DPoint* pEnd,
- sal_uInt32 nSortValue = 0)
+ sal_uInt32 nSortValue)
: TrDeSimpleEdge(pStart, pEnd),
mnSortValue(nSortValue)
{
diff --git a/basic/source/inc/expr.hxx b/basic/source/inc/expr.hxx
index cefad1957a25..cc1d82ac2347 100644
--- a/basic/source/inc/expr.hxx
+++ b/basic/source/inc/expr.hxx
@@ -175,7 +175,7 @@ protected:
public:
SbiExpression( SbiParser*, SbiExprType = SbSTDEXPR,
SbiExprMode eMode = EXPRMODE_STANDARD, const KeywordSymbolInfo* pKeywordSymbolInfo = nullptr ); // parsing Ctor
- SbiExpression( SbiParser*, double, SbxDataType = SbxDOUBLE );
+ SbiExpression( SbiParser*, double, SbxDataType );
SbiExpression( SbiParser*, const SbiSymDef&, SbiExprListPtr = nullptr );
~SbiExpression();
OUString& GetName() { return aArgName; }
diff --git a/basic/source/runtime/inputbox.cxx b/basic/source/runtime/inputbox.cxx
index 1d0e4e335e3c..2fdb4e057752 100644
--- a/basic/source/runtime/inputbox.cxx
+++ b/basic/source/runtime/inputbox.cxx
@@ -45,7 +45,7 @@ class SvRTLInputBox : public ModalDialog
public:
SvRTLInputBox( vcl::Window* pParent, const OUString& rPrompt, const OUString& rTitle,
- const OUString& rDefault, long nXTwips = -1, long nYTwips = -1 );
+ const OUString& rDefault, long nXTwips, long nYTwips );
virtual ~SvRTLInputBox() override { disposeOnce(); }
virtual void dispose() override;
OUString GetText() const override { return aText; }
diff --git a/include/basegfx/polygon/b2dlinegeometry.hxx b/include/basegfx/polygon/b2dlinegeometry.hxx
index 8a9cef193cd3..441e65ffc079 100644
--- a/include/basegfx/polygon/b2dlinegeometry.hxx
+++ b/include/basegfx/polygon/b2dlinegeometry.hxx
@@ -75,7 +75,7 @@ namespace basegfx
bool bStart,
double fWidth,
double fCandidateLength, // 0.0 -> calculate self
- double fDockingPosition = 0.5, // 0->top, 1->bottom
+ double fDockingPosition, // 0->top, 1->bottom
double* pConsumedLength = nullptr,
double fShift = 0.0);
@@ -133,7 +133,7 @@ namespace basegfx
const B2DPolygon& rCandidate,
double fHalfLineWidth,
B2DLineJoin eJoin,
- css::drawing::LineCap eCap = css::drawing::LineCap_BUTT,
+ css::drawing::LineCap eCap,
double fMaxAllowedAngle = (12.5 * F_PI180),
double fMaxPartOfEdge = 0.4,
double fMiterMinimumAngle = (15.0 * F_PI180));
diff --git a/include/basegfx/polygon/b3dpolygontools.hxx b/include/basegfx/polygon/b3dpolygontools.hxx
index 5b54a112c2d8..c097f86961c0 100644
--- a/include/basegfx/polygon/b3dpolygontools.hxx
+++ b/include/basegfx/polygon/b3dpolygontools.hxx
@@ -65,7 +65,7 @@ namespace basegfx
const B3DPolygon& rCandidate,
const ::std::vector<double>& rDotDashArray,
B3DPolyPolygon* pLineTarget,
- double fFullDashDotLen = 0.0);
+ double fFullDashDotLen);
/** Create/replace normals for given 3d geometry with default normals from given center to outside.
rCandidate: the 3d geometry to change
@@ -82,14 +82,14 @@ namespace basegfx
If bChangeX, x texture coordinate will be recalculated.
If bChangeY, y texture coordinate will be recalculated.
*/
- BASEGFX_DLLPUBLIC B3DPolygon applyDefaultTextureCoordinatesParallel( const B3DPolygon& rCandidate, const B3DRange& rRange, bool bChangeX, bool bChangeY = true);
+ BASEGFX_DLLPUBLIC B3DPolygon applyDefaultTextureCoordinatesParallel( const B3DPolygon& rCandidate, const B3DRange& rRange, bool bChangeX, bool bChangeY);
/** Create/replace texture coordinates for given 3d geometry with spherical one
rCenter: the centre of the used 3d geometry
If bChangeX, x texture coordinate will be recalculated.
If bChangeY, y texture coordinate will be recalculated.
*/
- BASEGFX_DLLPUBLIC B3DPolygon applyDefaultTextureCoordinatesSphere( const B3DPolygon& rCandidate, const B3DPoint& rCenter, bool bChangeX, bool bChangeY = true);
+ BASEGFX_DLLPUBLIC B3DPolygon applyDefaultTextureCoordinatesSphere( const B3DPolygon& rCandidate, const B3DPoint& rCenter, bool bChangeX, bool bChangeY);
// isInside tests for B3DPoint. On border is not inside as long as not true is given in bWithBorder flag.
BASEGFX_DLLPUBLIC bool isInside(const B3DPolygon& rCandidate, const B3DPoint& rPoint, bool bWithBorder);
diff --git a/include/basegfx/polygon/b3dpolypolygontools.hxx b/include/basegfx/polygon/b3dpolypolygontools.hxx
index b3105e21398b..48fad7ecc0c2 100644
--- a/include/basegfx/polygon/b3dpolypolygontools.hxx
+++ b/include/basegfx/polygon/b3dpolypolygontools.hxx
@@ -64,7 +64,7 @@ namespace basegfx
With VerStart, VerStop and hor range in cartesian may be specified to create a partial sphere only.
*/
BASEGFX_DLLPUBLIC B3DPolyPolygon createUnitSpherePolyPolygon(
- sal_uInt32 nHorSeg, sal_uInt32 nVerSeg = 0,
+ sal_uInt32 nHorSeg, sal_uInt32 nVerSeg,
double fVerStart = F_PI2, double fVerStop = -F_PI2,
double fHorStart = 0.0, double fHorStop = F_2PI);
@@ -74,7 +74,7 @@ namespace basegfx
*/
BASEGFX_DLLPUBLIC B3DPolyPolygon createSpherePolyPolygonFromB3DRange(
const B3DRange& rRange,
- sal_uInt32 nHorSeg, sal_uInt32 nVerSeg = 0,
+ sal_uInt32 nHorSeg, sal_uInt32 nVerSeg,
double fVerStart = F_PI2, double fVerStop = -F_PI2,
double fHorStart = 0.0, double fHorStop = F_2PI);
@@ -82,7 +82,7 @@ namespace basegfx
There is one extra, the bool bNormals defines if normals will be set, default is false
*/
BASEGFX_DLLPUBLIC B3DPolyPolygon createUnitSphereFillPolyPolygon(
- sal_uInt32 nHorSeg, sal_uInt32 nVerSeg = 0,
+ sal_uInt32 nHorSeg, sal_uInt32 nVerSeg,
bool bNormals = false,
double fVerStart = F_PI2, double fVerStop = -F_PI2,
double fHorStart = 0.0, double fHorStop = F_2PI);
@@ -92,7 +92,7 @@ namespace basegfx
*/
BASEGFX_DLLPUBLIC B3DPolyPolygon createSphereFillPolyPolygonFromB3DRange(
const B3DRange& rRange,
- sal_uInt32 nHorSeg, sal_uInt32 nVerSeg = 0,
+ sal_uInt32 nHorSeg, sal_uInt32 nVerSeg,
bool bNormals = false,
double fVerStart = F_PI2, double fVerStop = -F_PI2,
double fHorStart = 0.0, double fHorStop = F_2PI);
commit f7a57f3a1b3bf357b8dd9401b6d5d2525497967e
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Wed Dec 6 13:45:08 2017 +0200
loplugin:countusersofdefaultparams in comphelper
Change-Id: Idb704adbe78a42bf2f2aaf7f6110698d5559e836
Reviewed-on: https://gerrit.libreoffice.org/45936
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/cppuhelper/source/factory.cxx b/cppuhelper/source/factory.cxx
index 21ae1f398d4b..2503245330b8 100644
--- a/cppuhelper/source/factory.cxx
+++ b/cppuhelper/source/factory.cxx
@@ -242,7 +242,7 @@ public:
ComponentInstantiation pCreateFunction_,
ComponentFactoryFunc fptr,
const Sequence< OUString > * pServiceNames_,
- bool bOneInstance_ = false )
+ bool bOneInstance_ )
: OComponentHelper( aMutex )
, OSingleFactoryHelper( rServiceManager, rImplementationName_, pCreateFunction_, fptr, pServiceNames_ )
, bOneInstance( bOneInstance_ )
@@ -438,7 +438,7 @@ public:
const Reference<XMultiServiceFactory > & rServiceManager,
const OUString & rImplementationName_,
const Reference<XRegistryKey > & xImplementationKey_,
- bool bOneInstance_ = false )
+ bool bOneInstance_ )
: OFactoryComponentHelper(
rServiceManager, rImplementationName_, nullptr, nullptr, nullptr, bOneInstance_ ),
OPropertySetHelper( OComponentHelper::rBHelper ),
diff --git a/include/comphelper/ChainablePropertySet.hxx b/include/comphelper/ChainablePropertySet.hxx
index 6926f6b902e2..a306850caf18 100644
--- a/include/comphelper/ChainablePropertySet.hxx
+++ b/include/comphelper/ChainablePropertySet.hxx
@@ -107,7 +107,7 @@ namespace comphelper
virtual void _postGetValues () = 0;
public:
- ChainablePropertySet( comphelper::ChainablePropertySetInfo* pInfo, SolarMutex* pMutex = nullptr )
+ ChainablePropertySet( comphelper::ChainablePropertySetInfo* pInfo, SolarMutex* pMutex )
throw();
virtual ~ChainablePropertySet()
throw() override;
diff --git a/include/comphelper/MasterPropertySet.hxx b/include/comphelper/MasterPropertySet.hxx
index 81249fbc6ebd..4fe94ac90267 100644
--- a/include/comphelper/MasterPropertySet.hxx
+++ b/include/comphelper/MasterPropertySet.hxx
@@ -98,7 +98,7 @@ namespace comphelper
virtual void _postGetValues () = 0;
public:
- MasterPropertySet( comphelper::MasterPropertySetInfo* pInfo, SolarMutex* pMutex = nullptr )
+ MasterPropertySet( comphelper::MasterPropertySetInfo* pInfo, SolarMutex* pMutex )
throw();
virtual ~MasterPropertySet()
throw();
More information about the Libreoffice-commits
mailing list