[Libreoffice-commits] core.git: connectivity/source

[Tamas Bunth]

 connectivity/source/drivers/firebird/PreparedStatement.cxx |   11 -----------
 1 file changed, 11 deletions(-)

New commits:
commit 9585521c28b74dec36522a6501ca670b8e14c7ca
Author: Tamas Bunth <tamas.bunth at collabora.co.uk>
Date:   Sat Dec 9 00:47:13 2017 +0100

    tdf#70425 do not close cursor explicitly
    
    A cursor need only be closed in this manner if it was previously
    opened and associated with stmt_handle by isc_dsql_set_cursor_name()
    
    See Interbase API Guide: isc_dsql_free_statement
    
    Change-Id: Iadb0dcf83ee58b6196112c44d922528a3f56f7ea
    Reviewed-on: https://gerrit.libreoffice.org/46132
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Tamás Bunth <btomi96 at gmail.com>

diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index 3dfb092d12e7..cf4823f1dfbc 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -250,17 +250,6 @@ sal_Bool SAL_CALL OPreparedStatement::execute()
     if (m_xResultSet.is()) // Checks whether we have already run the statement.
     {
         disposeResultSet();
-        // Closes the cursor from the last run.
-        // This doesn't actually free the statement -- using DSQL_close closes
-        // the cursor and keeps the statement, using DSQL_drop frees the statement
-        // (and associated cursors).
-        aErr = isc_dsql_free_statement(m_statusVector,
-                                       &m_aStatementHandle,
-                                       DSQL_close);
-        if (aErr)
-            evaluateStatusVector(m_statusVector,
-                                 "isc_dsql_free_statement: close cursor",
-                                 *this);
     }
 
     aErr = isc_dsql_execute(m_statusVector,