[Libreoffice-commits] core.git: compilerplugins/clang

Stephan Bergmann sbergman at redhat.com
Sat Dec 9 12:19:02 UTC 2017


 compilerplugins/clang/salcall.cxx |   11 -----------
 1 file changed, 11 deletions(-)

New commits:
commit 959ecc99634d9e52db33d0032744547fead3bdec
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Fri Dec 8 19:32:15 2017 +0100

    No more issues with these source files
    
    ...after a31267be1bb42e8a5f80a3b660bbf969eeb5b647 "Fix isSalCallFunction so it
    also works on Windows"
    
    Change-Id: Ic770230f2dd6183f5937801f27e929ebfd39bb4a
    Reviewed-on: https://gerrit.libreoffice.org/46111
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/compilerplugins/clang/salcall.cxx b/compilerplugins/clang/salcall.cxx
index 8bdac1256759..6cfe7adc8cbd 100644
--- a/compilerplugins/clang/salcall.cxx
+++ b/compilerplugins/clang/salcall.cxx
@@ -12,7 +12,6 @@
 
 #include <algorithm>
 #include <set>
-#include <string>
 #include <utility>
 #include <vector>
 
@@ -60,16 +59,6 @@ public:
 
     virtual void run() override
     {
-        std::string fn(compiler.getSourceManager()
-                           .getFileEntryForID(compiler.getSourceManager().getMainFileID())
-                           ->getName());
-        loplugin::normalizeDotDotInFilePath(fn);
-        // ignore this one. I can't get accurate source code from getCharacterData() for it.
-        if (fn == SRCDIR "/sal/rtl/string.cxx")
-            return;
-        // clang returns completely bogus source range for something in this file
-        if (fn == SRCDIR "/sd/source/ui/unoidl/unomodel.cxx")
-            return;
         m_phase = PluginPhase::FindAddressOf;
         TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
         m_phase = PluginPhase::Warning;


More information about the Libreoffice-commits mailing list