[Libreoffice-commits] core.git: sc/source

Caolán McNamara caolanm at redhat.com
Wed Dec 20 14:28:57 UTC 2017


 sc/source/filter/orcus/interface.cxx |   38 ++++++++++++++++++++++++++---------
 1 file changed, 29 insertions(+), 9 deletions(-)

New commits:
commit 15a744bc09d8e6a14fe9179640a1257515f45d13
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Wed Dec 20 14:25:05 2017 +0000

    coverity#1426736 Uninitialized scalar field
    
    and
    
    coverity#1426737 Uninitialized scalar field
    coverity#1426740 Uninitialized scalar field
    coverity#1426741 Uninitialized scalar field
    coverity#1426743 Uninitialized scalar field
    
    Change-Id: I770b03e54758178f8fdf7128644ddb8c37bf1e83

diff --git a/sc/source/filter/orcus/interface.cxx b/sc/source/filter/orcus/interface.cxx
index 6809aae2599a..e3a82305f90c 100644
--- a/sc/source/filter/orcus/interface.cxx
+++ b/sc/source/filter/orcus/interface.cxx
@@ -177,24 +177,44 @@ void ScOrcusNamedExpression::define_name(const char* p_name, size_t n_name, cons
     pNames->insert(pRange, false);
 }
 
-ScOrcusFactory::CellStoreToken::CellStoreToken( const ScAddress& rPos, Type eType ) :
-    maPos(rPos), meType(eType)
+ScOrcusFactory::CellStoreToken::CellStoreToken(const ScAddress& rPos, Type eType)
+    : maPos(rPos)
+    , meType(eType)
+    , mnIndex1(0)
+    , mnIndex2(0)
+    , meGrammar(formula::FormulaGrammar::GRAM_UNSPECIFIED)
 {
     rtl::math::setNan(&mfValue);
 }
 
-ScOrcusFactory::CellStoreToken::CellStoreToken( const ScAddress& rPos, double fValue ) :
-    maPos(rPos), meType(Type::Numeric), mfValue(fValue) {}
+ScOrcusFactory::CellStoreToken::CellStoreToken(const ScAddress& rPos, double fValue)
+    : maPos(rPos)
+    , meType(Type::Numeric)
+    , mfValue(fValue)
+    , mnIndex1(0)
+    , mnIndex2(0)
+    , meGrammar(formula::FormulaGrammar::GRAM_UNSPECIFIED)
+{
+}
 
-ScOrcusFactory::CellStoreToken::CellStoreToken( const ScAddress& rPos, uint32_t nIndex ) :
-    maPos(rPos), meType(Type::String), mnIndex1(nIndex)
+ScOrcusFactory::CellStoreToken::CellStoreToken(const ScAddress& rPos, uint32_t nIndex)
+    : maPos(rPos)
+    , meType(Type::String)
+    , mnIndex1(nIndex)
+    , mnIndex2(0)
+    , meGrammar(formula::FormulaGrammar::GRAM_UNSPECIFIED)
 {
     rtl::math::setNan(&mfValue);
 }
 
-ScOrcusFactory::CellStoreToken::CellStoreToken(
-    const ScAddress& rPos, const OUString& rFormula, formula::FormulaGrammar::Grammar eGrammar ) :
-    maPos(rPos), meType(Type::Formula), maStr1(rFormula), meGrammar(eGrammar)
+ScOrcusFactory::CellStoreToken::CellStoreToken(const ScAddress& rPos, const OUString& rFormula,
+        formula::FormulaGrammar::Grammar eGrammar)
+    : maPos(rPos)
+    , meType(Type::Formula)
+    , maStr1(rFormula)
+    , mnIndex1(0)
+    , mnIndex2(0)
+    , meGrammar(eGrammar)
 {
     rtl::math::setNan(&mfValue);
 }


More information about the Libreoffice-commits mailing list