[Libreoffice-commits] core.git: Changes to 'private/lmamane/validation'
Lionel Elie Mamane
lionel at mamane.lu
Sun Dec 24 22:41:46 UTC 2017
New branch 'private/lmamane/validation' available with the following commits:
commit 196c9bab6aaf91e30a6e275b84d21d0c9869306c
Author: Lionel Elie Mamane <lionel at mamane.lu>
Date: Thu Aug 3 16:42:01 2017 +0200
form controls: validate *before* propagating value, but only on commit
*Before* propagating, because after it is propagated it is too late!
Only on commit (unless the control is not commitable), because
validating each time the control value changes leads to a validator
being called each time the user enters a character of the value.
So each validator necessarily has to accept any prefix of a valid
value, which often defeats the purpose. E.g. one cannot do a valiator
that enforces a minimum length, or minimum password complexity.
So validating on commit makes much more sense. That's when the user
is trying to actually set the value as a complete value.
Change-Id: Id3142367bacd81e07d093c8bee97d518df28cafe
More information about the Libreoffice-commits
mailing list