[Libreoffice-commits] core.git: basegfx/source include/basegfx slideshow/source xmlhelp/source
Noel Grandin
noel.grandin at collabora.co.uk
Fri Dec 29 09:56:05 UTC 2017
basegfx/source/polygon/b3dpolygon.cxx | 2 +-
include/basegfx/polygon/b3dpolygon.hxx | 2 +-
slideshow/source/engine/animationnodes/animationbasenode.cxx | 2 +-
slideshow/source/engine/animationnodes/animationbasenode.hxx | 2 +-
slideshow/source/engine/opengl/TransitionerImpl.cxx | 2 +-
slideshow/source/engine/slide/userpaintoverlay.cxx | 2 +-
slideshow/source/engine/slide/userpaintoverlay.hxx | 2 +-
slideshow/source/engine/smilfunctionparser.cxx | 4 ++--
slideshow/source/inc/smilfunctionparser.hxx | 4 ++--
xmlhelp/source/cxxhelp/provider/urlparameter.cxx | 2 +-
xmlhelp/source/cxxhelp/provider/urlparameter.hxx | 2 +-
11 files changed, 13 insertions(+), 13 deletions(-)
New commits:
commit e21ae87458b0b6e0ad4cc9b41ed02fc8b6a20736
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Fri Dec 29 09:20:44 2017 +0200
loplugin:passstuffbyref improved return in xmlhelp,slideshow
Change-Id: I57e235ecec733f1b5dd03f95f4e022769a369ae2
Reviewed-on: https://gerrit.libreoffice.org/47165
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/basegfx/source/polygon/b3dpolygon.cxx b/basegfx/source/polygon/b3dpolygon.cxx
index d28d31c7f2d8..ed564228e0fb 100644
--- a/basegfx/source/polygon/b3dpolygon.cxx
+++ b/basegfx/source/polygon/b3dpolygon.cxx
@@ -1548,7 +1548,7 @@ namespace basegfx
mpPolygon->clearBColors();
}
- B3DVector B3DPolygon::getNormal() const
+ B3DVector const & B3DPolygon::getNormal() const
{
return mpPolygon->getNormal();
}
diff --git a/include/basegfx/polygon/b3dpolygon.hxx b/include/basegfx/polygon/b3dpolygon.hxx
index 765762730f20..1d3dd515b757 100644
--- a/include/basegfx/polygon/b3dpolygon.hxx
+++ b/include/basegfx/polygon/b3dpolygon.hxx
@@ -79,7 +79,7 @@ namespace basegfx
void clearBColors();
// Normals interface
- B3DVector getNormal() const; // plane normal
+ B3DVector const & getNormal() const; // plane normal
B3DVector getNormal(sal_uInt32 nIndex) const; // normal in each point
void setNormal(sal_uInt32 nIndex, const B3DVector& rValue);
void transformNormals(const B3DHomMatrix& rMatrix);
diff --git a/slideshow/source/engine/animationnodes/animationbasenode.cxx b/slideshow/source/engine/animationnodes/animationbasenode.cxx
index 678c4a51a9ff..6c7eebed0ad1 100644
--- a/slideshow/source/engine/animationnodes/animationbasenode.cxx
+++ b/slideshow/source/engine/animationnodes/animationbasenode.cxx
@@ -465,7 +465,7 @@ AnimationBaseNode::fillCommonParameters() const
getSlideSize());
}
-AttributableShapeSharedPtr AnimationBaseNode::getShape() const
+AttributableShapeSharedPtr const & AnimationBaseNode::getShape() const
{
// any subsetting at all?
if (mpShapeSubset)
diff --git a/slideshow/source/engine/animationnodes/animationbasenode.hxx b/slideshow/source/engine/animationnodes/animationbasenode.hxx
index d2c03a4ec4d3..84b3d5a82b5e 100644
--- a/slideshow/source/engine/animationnodes/animationbasenode.hxx
+++ b/slideshow/source/engine/animationnodes/animationbasenode.hxx
@@ -56,7 +56,7 @@ protected:
/// Create parameter struct for ActivitiesFactory
ActivitiesFactory::CommonParameters fillCommonParameters() const;
::basegfx::B2DVector const& getSlideSize() const { return maSlideSize; }
- AttributableShapeSharedPtr getShape() const;
+ AttributableShapeSharedPtr const & getShape() const;
private:
virtual bool hasPendingAnimation() const override;
diff --git a/slideshow/source/engine/opengl/TransitionerImpl.cxx b/slideshow/source/engine/opengl/TransitionerImpl.cxx
index f8018c0275e6..8e21e6768616 100644
--- a/slideshow/source/engine/opengl/TransitionerImpl.cxx
+++ b/slideshow/source/engine/opengl/TransitionerImpl.cxx
@@ -808,7 +808,7 @@ namespace
}
};
- uno::Reference<rendering::XIntegerBitmapColorSpace>
+ uno::Reference<rendering::XIntegerBitmapColorSpace> const &
getOGLColorSpace()
{
return OGLColorSpaceHolder::get();
diff --git a/slideshow/source/engine/slide/userpaintoverlay.cxx b/slideshow/source/engine/slide/userpaintoverlay.cxx
index f1a1789ad8c9..096efe6b1284 100644
--- a/slideshow/source/engine/slide/userpaintoverlay.cxx
+++ b/slideshow/source/engine/slide/userpaintoverlay.cxx
@@ -468,7 +468,7 @@ namespace slideshow
mrMultiplexer.addUserPaintHandler(mpHandler);
}
- PolyPolygonVector UserPaintOverlay::getPolygons()
+ PolyPolygonVector const & UserPaintOverlay::getPolygons()
{
return mpHandler->getPolygons();
}
diff --git a/slideshow/source/engine/slide/userpaintoverlay.hxx b/slideshow/source/engine/slide/userpaintoverlay.hxx
index 4c2e16288c88..3dc6fa976a7f 100644
--- a/slideshow/source/engine/slide/userpaintoverlay.hxx
+++ b/slideshow/source/engine/slide/userpaintoverlay.hxx
@@ -65,7 +65,7 @@ namespace slideshow
~UserPaintOverlay();
UserPaintOverlay(const UserPaintOverlay&) = delete;
UserPaintOverlay& operator=(const UserPaintOverlay&) = delete;
- PolyPolygonVector getPolygons();
+ PolyPolygonVector const & getPolygons();
void drawPolygons();
private:
diff --git a/slideshow/source/engine/smilfunctionparser.cxx b/slideshow/source/engine/smilfunctionparser.cxx
index 8b25d849c5cc..3755a7cb1a16 100644
--- a/slideshow/source/engine/smilfunctionparser.cxx
+++ b/slideshow/source/engine/smilfunctionparser.cxx
@@ -525,7 +525,7 @@ namespace slideshow
}
}
- std::shared_ptr<ExpressionNode> SmilFunctionParser::parseSmilValue( const OUString& rSmilValue,
+ std::shared_ptr<ExpressionNode> const & SmilFunctionParser::parseSmilValue( const OUString& rSmilValue,
const ::basegfx::B2DRectangle& rRelativeShapeBounds )
{
// TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_*
@@ -570,7 +570,7 @@ namespace slideshow
return pContext->maOperandStack.top();
}
- std::shared_ptr<ExpressionNode> SmilFunctionParser::parseSmilFunction( const OUString& rSmilFunction,
+ std::shared_ptr<ExpressionNode> const & SmilFunctionParser::parseSmilFunction( const OUString& rSmilFunction,
const ::basegfx::B2DRectangle& rRelativeShapeBounds )
{
// TODO(Q1): Check if a combination of the RTL_UNICODETOTEXT_FLAGS_*
diff --git a/slideshow/source/inc/smilfunctionparser.hxx b/slideshow/source/inc/smilfunctionparser.hxx
index 236dce4fdfbd..59e9157d1a4c 100644
--- a/slideshow/source/inc/smilfunctionparser.hxx
+++ b/slideshow/source/inc/smilfunctionparser.hxx
@@ -95,7 +95,7 @@ namespace slideshow
@return the generated function object.
*/
- static std::shared_ptr<ExpressionNode> parseSmilValue( const OUString& rSmilValue,
+ static std::shared_ptr<ExpressionNode> const & parseSmilValue( const OUString& rSmilValue,
const ::basegfx::B2DRectangle& rRelativeShapeBounds ); // throw ParseError
/** Parse a string containing a SMIL function.
@@ -143,7 +143,7 @@ namespace slideshow
@return the generated function object.
*/
- static std::shared_ptr<ExpressionNode> parseSmilFunction( const OUString& rSmilFunction,
+ static std::shared_ptr<ExpressionNode> const & parseSmilFunction( const OUString& rSmilFunction,
const ::basegfx::B2DRectangle& rRelativeShapeBounds ); // throw ParseError
};
diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
index 3ae9330d084d..5a93c3075b5c 100644
--- a/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
+++ b/xmlhelp/source/cxxhelp/provider/urlparameter.cxx
@@ -198,7 +198,7 @@ OUString URLParameter::get_the_tag()
}
-OUString URLParameter::get_path()
+OUString const & URLParameter::get_path()
{
if(m_bUseDB) {
if( ! m_bHelpDataFileRead )
diff --git a/xmlhelp/source/cxxhelp/provider/urlparameter.hxx b/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
index 29edea3d30db..2c339a5d072a 100644
--- a/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
+++ b/xmlhelp/source/cxxhelp/provider/urlparameter.hxx
@@ -124,7 +124,7 @@ namespace chelp {
// Not called for an directory
- OUString get_path();
+ OUString const & get_path();
const OUString& get_eid() const { return m_aEid; }
More information about the Libreoffice-commits
mailing list