[Libreoffice-commits] core.git: dbaccess/source

Julien Nabet serval2412 at yahoo.fr
Sat Dec 30 09:55:12 UTC 2017


 dbaccess/source/core/api/CacheSet.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 84466e76a9a23a07227fa1da132b4bef83edec6e
Author: Julien Nabet <serval2412 at yahoo.fr>
Date:   Sat Dec 30 08:42:26 2017 +0100

    Incrementing end iterator has undefined behavior (dbaccess/cacheset)
    
    Change-Id: I9f4cdacd87cc4802b13c99c15e1d24d11285a375
    Reviewed-on: https://gerrit.libreoffice.org/47188
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/dbaccess/source/core/api/CacheSet.cxx b/dbaccess/source/core/api/CacheSet.cxx
index 785cba2a69cc..46eb35cefce4 100644
--- a/dbaccess/source/core/api/CacheSet.cxx
+++ b/dbaccess/source/core/api/CacheSet.cxx
@@ -233,7 +233,7 @@ void OCacheSet::fillParameters( const ORowSetRow& _rRow
     OUString sIsNull(" IS NULL");
     OUString sParam(" = ?");
     ORowVector< ORowSetValue >::Vector::const_iterator aIter = _rRow->get().begin()+1;
-    ORowVector< ORowSetValue >::Vector::const_iterator aEnd = _rRow->get().end()+1;
+    ORowVector< ORowSetValue >::Vector::const_iterator aEnd = _rRow->get().end();
     for(; aIter != aEnd;++aIter,++nCheckCount,++i)
     {
         aColumnName = m_xSetMetaData->getColumnName(i);


More information about the Libreoffice-commits mailing list