[Libreoffice-commits] core.git: compilerplugins/clang vcl/inc

Noel Grandin noel.grandin at collabora.co.uk
Thu Feb 9 10:09:31 UTC 2017


 compilerplugins/clang/unusedenumconstants.py |    1 +
 vcl/inc/CommonSalLayout.hxx                  |    2 ++
 2 files changed, 3 insertions(+)

New commits:
commit 3e33fbd269e9ad3c2e72fe6f6780a77f4a5b3c78
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed Feb 8 13:37:50 2017 +0200

    restore constant to VerticalOrientation
    
    Removed in commit f4826959c1a5b0e6d2849d4240668b2087582848
    "new loplugin:unusedenumconstants".
    And add a comment.
    
    Change-Id: I63d6f46aa92e31db08e51e47a62104dc7d3d3359
    Reviewed-on: https://gerrit.libreoffice.org/34057
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedenumconstants.py b/compilerplugins/clang/unusedenumconstants.py
index 9b4a821..df7c885 100755
--- a/compilerplugins/clang/unusedenumconstants.py
+++ b/compilerplugins/clang/unusedenumconstants.py
@@ -105,6 +105,7 @@ for d in definitionSet:
          "vcl/source/filter/jpeg/transupp.h",
          "include/vcl/bitmapex.hxx", # TransparentType
          "vcl/inc/sft.hxx", # CompositeFlags, WidthClass, WeightClass
+         "vcl/inc/CommonSalLayout.hxx", # VerticalOrientation
         # unit test code
          "cppu/source/uno/check.cxx",
         # general weird nonsense going on
diff --git a/vcl/inc/CommonSalLayout.hxx b/vcl/inc/CommonSalLayout.hxx
index 0521048..c9af545 100644
--- a/vcl/inc/CommonSalLayout.hxx
+++ b/vcl/inc/CommonSalLayout.hxx
@@ -90,8 +90,10 @@ public:
     bool                    IsKashidaPosValid(int nCharPos) const final override;
 };
 
+// these must match the values in vcl/source/gdi/VerticalOrientationData.cxx
 enum class VerticalOrientation {
     Upright            = 0,
+    Rotated            = 1,
     TransformedUpright = 2,
     TransformedRotated = 3
 };


More information about the Libreoffice-commits mailing list