[Libreoffice-commits] core.git: sw/source

Arnold Dumas arnold at dumas.at
Sun Feb 12 17:06:15 UTC 2017


 sw/source/ui/config/optcomp.cxx  |    2 +-
 sw/source/uibase/inc/optcomp.hxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit ff2927095ed64851f4418cc8daa534e2581da537
Author: Arnold Dumas <arnold at dumas.at>
Date:   Sun Feb 12 10:51:31 2017 +0100

    tdf#89329: Use unique_ptr for pImpl in optcomp
    
    Change-Id: I0f6ec9c2bab27dc4c6fe5e94bd3c05319f246b35
    Reviewed-on: https://gerrit.libreoffice.org/34171
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sw/source/ui/config/optcomp.cxx b/sw/source/ui/config/optcomp.cxx
index 59d7143..3dc5d37 100644
--- a/sw/source/ui/config/optcomp.cxx
+++ b/sw/source/ui/config/optcomp.cxx
@@ -92,7 +92,7 @@ SwCompatibilityOptPage::~SwCompatibilityOptPage()
 
 void SwCompatibilityOptPage::dispose()
 {
-    delete m_pImpl;
+    m_pImpl.reset();
     m_pMain.clear();
     m_pFormattingLB.clear();
     m_pOptionsLB.clear();
diff --git a/sw/source/uibase/inc/optcomp.hxx b/sw/source/uibase/inc/optcomp.hxx
index 370abbd..83d74ba 100644
--- a/sw/source/uibase/inc/optcomp.hxx
+++ b/sw/source/uibase/inc/optcomp.hxx
@@ -45,7 +45,7 @@ private:
     // shell of the current document
     SwWrtShell*             m_pWrtShell;
     // impl object
-    SwCompatibilityOptPage_Impl* m_pImpl;
+    std::unique_ptr<SwCompatibilityOptPage_Impl> m_pImpl;
     // saved options after "Reset"; used in "FillItemSet" for comparison
     sal_uLong                   m_nSavedOptions;
 


More information about the Libreoffice-commits mailing list