[Libreoffice-commits] core.git: sd/source

yellowflash104 udit.sharma104 at gmail.com
Mon Feb 13 07:35:19 UTC 2017


 sd/source/ui/dlg/dlgctrls.cxx |    2 +-
 sd/source/ui/inc/dlgctrls.hxx |    3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

New commits:
commit a512feac63b43ab87411f8579169d85af80acb7f
Author: yellowflash104 <udit.sharma104 at gmail.com>
Date:   Mon Feb 13 01:38:39 2017 +0530

    tdf#89329: use unique_ptr for pImpl in dlgctrls
    
    Change-Id: Id7294b5b3b72b873184d55db64a3477fc56a5485
    Reviewed-on: https://gerrit.libreoffice.org/34182
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/source/ui/dlg/dlgctrls.cxx b/sd/source/ui/dlg/dlgctrls.cxx
index 7d48a88..30fc287 100644
--- a/sd/source/ui/dlg/dlgctrls.cxx
+++ b/sd/source/ui/dlg/dlgctrls.cxx
@@ -47,7 +47,7 @@ FadeEffectLB::~FadeEffectLB()
 
 void FadeEffectLB::dispose()
 {
-    delete mpImpl;
+    mpImpl.reset();
     ListBox::dispose();
 }
 
diff --git a/sd/source/ui/inc/dlgctrls.hxx b/sd/source/ui/inc/dlgctrls.hxx
index bbc76b6..b6ac2169 100644
--- a/sd/source/ui/inc/dlgctrls.hxx
+++ b/sd/source/ui/inc/dlgctrls.hxx
@@ -26,6 +26,7 @@
 #include "sdresid.hxx"
 #include "fadedef.h"
 #include "sddllapi.h"
+#include <memory>
 
 /**
  * FadeEffectLB
@@ -39,7 +40,7 @@ public:
     virtual ~FadeEffectLB() override;
     virtual void dispose() override;
 
-    FadeEffectLBImpl*           mpImpl;
+    std::unique_ptr<FadeEffectLBImpl> mpImpl;
 };
 
 #endif // INCLUDED_SD_SOURCE_UI_INC_DLGCTRLS_HXX


More information about the Libreoffice-commits mailing list