[Libreoffice-commits] core.git: sc/source

[Jochen Nitschke]

 sc/source/filter/oox/formulabase.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit deff2acd61de53e29a8cf1eed7f8db458244dab0
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Wed Feb 15 16:19:00 2017 +0100

    tdf#105909 auto filter state lost on xlsx import
    
    in commit 77dc03c29501234bb07170004a7b8204987bad0c
    the new variant of FormulaProcessorBase::extractCellRange(..)
    replaced a CellRangeAddress& ApiCellRangeList::front() with
    ScAddress& ApiCellRangeList::getBaseAddress() which returned only
    the start address of the front range. This went unnoticed because
    ScRange has a non explicit constructor from ScAddress.
    
    later ApiCellRangeList::getBaseAddress() got replaced
    by ScRangeList::GetTopLeftCorner().
    
    use ScRangeList::front() to fix this regression.
    
    Change-Id: I338e5d3054b62d5dd191492a38451d0adc85ae0d
    Reviewed-on: https://gerrit.libreoffice.org/34304
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>

diff --git a/sc/source/filter/oox/formulabase.cxx b/sc/source/filter/oox/formulabase.cxx
index d0e73d5..fa096ca 100644
--- a/sc/source/filter/oox/formulabase.cxx
+++ b/sc/source/filter/oox/formulabase.cxx
@@ -1603,7 +1603,7 @@ bool FormulaProcessorBase::extractCellRange( ScRange& orRange,
     lclProcessRef( aRanges, extractReference( rTokens ), bAllowRelative, -1 );
     if( !aRanges.empty() )
     {
-        orRange = aRanges.GetTopLeftCorner();
+        orRange = *aRanges.front();
         return true;
     }
     return false;