[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - svx/source

Caolán McNamara caolanm at redhat.com
Tue Feb 21 13:43:18 UTC 2017


 svx/source/svdraw/svdmark.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 213c129049f0bfa36a843f59be8614e4fc5fc362
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Feb 20 14:52:52 2017 +0000

    Resolves: tdf#106105 duplicate marks not merged when they are at the start
    
    i.e. initial mark isn't compared which goes on to crash under some circumstances
    
    regression from...
    
    commit aa11e7bae89fe691f914abb27d1c4a03d27a7ee5
    Date:   Tue Aug 14 16:31:53 2012 +0200
    
        Convert maList in SdrMarkList from Container to std::vector
    
    Change-Id: Ib3e9b02aad91c14971656af171d48154507da127
    (cherry picked from commit 35bb22c1a834b306c910cb065bc006818c9fa9b3)
    Reviewed-on: https://gerrit.libreoffice.org/34477
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/svx/source/svdraw/svdmark.cxx b/svx/source/svdraw/svdmark.cxx
index 66e5f6e..6cf64c9 100644
--- a/svx/source/svdraw/svdmark.cxx
+++ b/svx/source/svdraw/svdmark.cxx
@@ -179,8 +179,9 @@ void SdrMarkList::ImpForceSort()
             if(maList.size() > 1)
             {
                 SdrMark* pAkt = maList.back();
-                for (size_t i = maList.size() - 2; i; --i)
+                for (size_t count = maList.size() - 1; count; --count)
                 {
+                    size_t i = count - 1;
                     SdrMark* pCmp = maList[i];
                     if(pAkt->GetMarkedSdrObj() == pCmp->GetMarkedSdrObj() && pAkt->GetMarkedSdrObj())
                     {


More information about the Libreoffice-commits mailing list