[Libreoffice-commits] core.git: sc/qa

Eike Rathke erack at redhat.com
Tue Feb 21 22:15:16 UTC 2017


 sc/qa/unit/ucalc.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 50d9da073d34ea6a223d39538ec37a646f8d276e
Author: Eike Rathke <erack at redhat.com>
Date:   Tue Feb 21 23:14:06 2017 +0100

    do not test for different caption pointers ...
    
    ... if it's not guaranteed they may not be identical.
    
    Change-Id: Ieb4b0eb07a1b1832df65dde3c2e5a92b5121a162

diff --git a/sc/qa/unit/ucalc.cxx b/sc/qa/unit/ucalc.cxx
index 3703696..f2a0196 100644
--- a/sc/qa/unit/ucalc.cxx
+++ b/sc/qa/unit/ucalc.cxx
@@ -5376,7 +5376,9 @@ void Test::testNoteLifeCycle()
         CPPUNIT_ASSERT_MESSAGE("Failed to paste cell comment at B5.", pNoteB5);
         const SdrCaptionObj* pCaptionB5 = pNoteB5->GetOrCreateCaption(aPosB5);
         CPPUNIT_ASSERT_MESSAGE("No caption at pasted B5.", pCaptionB5);
-        CPPUNIT_ASSERT_MESSAGE("Captions not different after Paste.", pCaptionB5 != pOtherCaptionB5);
+        // Do not test if  pCaptionB5 != pOtherCaptionB5  because since pDoc2
+        // has been closed and the caption been deleted objects *may* be
+        // allocated at the very same memory location.
     }
 
     m_pDoc->DeleteTab(0);


More information about the Libreoffice-commits mailing list