[Libreoffice-commits] core.git: sw/inc

Stephan Bergmann sbergman at redhat.com
Thu Feb 23 11:15:38 UTC 2017


 sw/inc/unocrsr.hxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 73a9502ce8d06d729d8070721c4fc53c4e2b13dd
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Thu Feb 23 12:12:53 2017 +0100

    Don't pass shared_ptr by value
    
    ...to avoid having to generate a temporary in e.g.
    SwXParagraphEnumeration::Create (sw/source/core/unocore/unoobj2.cxx), and thus
    to avoid <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=79679> "[7 Regression]
    [C++17] Missing destruction of temporary within constructor's
    mem-initializer-list"
    
    Change-Id: Ifaa5a6d0e9baa77a19752f54e7765783139bea95

diff --git a/sw/inc/unocrsr.hxx b/sw/inc/unocrsr.hxx
index 9ef5204..d789bed 100644
--- a/sw/inc/unocrsr.hxx
+++ b/sw/inc/unocrsr.hxx
@@ -111,7 +111,7 @@ namespace sw
             UnoCursorPointer()
                 : m_pCursor(nullptr)
            {}
-            UnoCursorPointer(std::shared_ptr<SwUnoCursor> pCursor)
+            UnoCursorPointer(std::shared_ptr<SwUnoCursor> const & pCursor)
                 : m_pCursor(pCursor)
             {
                 StartListening(m_pCursor->m_aNotifier);


More information about the Libreoffice-commits mailing list