[Libreoffice-commits] core.git: hwpfilter/source

Caolán McNamara caolanm at redhat.com
Sun Feb 26 21:21:48 UTC 2017


 hwpfilter/source/hwpfile.cxx |    8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

New commits:
commit 0a5f97f2985ec8e51910770d1748203cd4cd49c7
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun Feb 26 21:19:59 2017 +0000

    ofz#691 leak of emblist data
    
    Change-Id: Ic4231b93fafe73bf87995f226def64f7c9e131c3

diff --git a/hwpfilter/source/hwpfile.cxx b/hwpfilter/source/hwpfile.cxx
index 060312a..5f6fe55 100644
--- a/hwpfilter/source/hwpfile.cxx
+++ b/hwpfilter/source/hwpfile.cxx
@@ -74,11 +74,13 @@ HWPFile::~HWPFile()
     for (; tbl != tables.end(); ++tbl)
         delete *tbl;
 
-    std::list < HyperText* >::iterator hyp = hyperlist.begin();
+    std::list<EmPicture*>::iterator emb = emblist.begin();
+    for (; emb != emblist.end(); ++emb)
+        delete *emb;
+
+    std::list<HyperText*>::iterator hyp = hyperlist.begin();
     for (; hyp != hyperlist.end(); ++hyp)
-    {
         delete *hyp;
-    }
 }
 
 int HWPFile::ReadHwpFile(HStream * stream)


More information about the Libreoffice-commits mailing list