[Libreoffice-commits] core.git: Branch 'libreoffice-5-3' - sd/source

Matúš Kukan matus.kukan at gmail.com
Mon Feb 27 11:20:57 UTC 2017


 sd/source/filter/eppt/pptx-epptooxml.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit bc3b23f9c07aa2916c648abf1ca8c2af297250d4
Author: Matúš Kukan <matus.kukan at gmail.com>
Date:   Sat Feb 11 16:24:37 2017 +0100

    tdf#104222: Put expensive debug code behind #if again
    
    dump_pset calls very expensive SdGenericDrawPage::getPropertyValue
    doing something with GDIMetaFiles.
    
    (regression from 5c7ce42dfc35d9cceef5f05a96e813b4e3913d38)
    
    (cherry picked from commit 9cbe69f1950115e47af693bd78fc78f96f9b508e)
    
    Change-Id: If39e9a451c87754343d77c8a1f840153c6b9de80
    Reviewed-on: https://gerrit.libreoffice.org/34643
    Reviewed-by: Michael Stahl <mstahl at redhat.com>
    Tested-by: Michael Stahl <mstahl at redhat.com>

diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx b/sd/source/filter/eppt/pptx-epptooxml.cxx
index 8069c7a..03ddcd0 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -93,7 +93,10 @@ using ::com::sun::star::container::XIndexAccess;
 using ::sax_fastparser::FSHelperPtr;
 
 
+#if OSL_DEBUG_LEVEL > 1
 void dump_pset(Reference< XPropertySet > const & rXPropSet);
+#endif
+
 #define IDS(x) OString(OStringLiteral(#x " ") + OString::number( mnShapeIdMax++ )).getStr()
 
 namespace oox {
@@ -1788,7 +1791,9 @@ void PowerPointExport::ImplWritePPTXLayout( sal_Int32 nOffset, sal_uInt32 nMaste
 
     Reference< beans::XPropertySet > xPropSet( xSlide, uno::UNO_QUERY );
     xPropSet->setPropertyValue( "Layout", makeAny( short( aLayoutInfo[ nOffset ].nType ) ) );
+#if OSL_DEBUG_LEVEL > 1
     dump_pset(xPropSet);
+#endif
     mXPagePropSet.set( xSlide, UNO_QUERY );
     mXShapes.set( xSlide, UNO_QUERY );
 
@@ -2329,6 +2334,7 @@ SAL_DLLPUBLIC_EXPORT void* SAL_CALL sdfilt_component_getFactory( const sal_Char*
 
 }
 
+#if OSL_DEBUG_LEVEL > 1
 void dump_pset(Reference< XPropertySet > const & rXPropSet)
 {
     Reference< XPropertySetInfo > info = rXPropSet->getPropertySetInfo ();
@@ -2356,5 +2362,6 @@ void dump_pset(Reference< XPropertySet > const & rXPropSet)
             SAL_INFO("sd.eppt", "???          <unhandled type>");
     }
 }
+#endif
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list