[Libreoffice-commits] core.git: Branch 'libreoffice-5-3-1' - sd/source

Markus Mohrhard markus.mohrhard at googlemail.com
Tue Feb 28 11:54:29 UTC 2017


 sd/source/ui/sidebar/SlideBackground.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9e587239f5fb2089549e72d2c99cbc493459d984
Author: Markus Mohrhard <markus.mohrhard at googlemail.com>
Date:   Thu Feb 23 00:32:12 2017 +0100

    fix crash in the sidebar code
    
    The check should be for xPanel and not xPanels.
    
    See
    http://crashreport.libreoffice.org/stats/signature/sfx2::sidebar::Panel::GetTitleBar()
    
    Change-Id: I745d6d8abbfc68e86ed812460faa551867ddec43
    Reviewed-on: https://gerrit.libreoffice.org/34560
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    (cherry picked from commit 0407200401358d3d565438800f55b61fc1a61794)
    Reviewed-on: https://gerrit.libreoffice.org/34563
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    (cherry picked from commit ed8b8f59e1a85b455a2f8daebd2c1f6fb59faeaa)
    Reviewed-on: https://gerrit.libreoffice.org/34624

diff --git a/sd/source/ui/sidebar/SlideBackground.cxx b/sd/source/ui/sidebar/SlideBackground.cxx
index 71d2541..309185f 100644
--- a/sd/source/ui/sidebar/SlideBackground.cxx
+++ b/sd/source/ui/sidebar/SlideBackground.cxx
@@ -295,7 +295,7 @@ void SlideBackground::SetPanelTitle( const OUString& rTitle )
         return;
 
     Reference<ui::XPanel> xPanel ( xPanels->getByName("SlideBackgroundPanel"), uno::UNO_QUERY);
-    if ( !xPanels.is() )
+    if ( !xPanel.is() )
         return;
 
     xPanel->setTitle( rTitle );


More information about the Libreoffice-commits mailing list