[Libreoffice-commits] core.git: sc/source
Winfried Donkers
winfrieddonkers at libreoffice.org
Tue Jan 3 21:31:33 UTC 2017
sc/source/core/tool/interpr3.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
New commits:
commit 25625f18a282209235214674f2b81604ecd067ad
Author: Winfried Donkers <winfrieddonkers at libreoffice.org>
Date: Sun Jan 1 11:57:34 2017 +0100
tdf#105026 Remove wrong constraint in PERMUTATIONA.
With permutations with repetitions, argument selection may
be larger than argument elements.
Probably inadvertently copied from PERMUT; has been there from
pre-git.
Change-Id: Icdee18eca647fb278f140630e45844684a1e3046
Reviewed-on: https://gerrit.libreoffice.org/32569
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Eike Rathke <erack at redhat.com>
diff --git a/sc/source/core/tool/interpr3.cxx b/sc/source/core/tool/interpr3.cxx
index c0ac545..1d90d22 100644
--- a/sc/source/core/tool/interpr3.cxx
+++ b/sc/source/core/tool/interpr3.cxx
@@ -1209,7 +1209,7 @@ void ScInterpreter::ScPermutationA()
{
double k = ::rtl::math::approxFloor(GetDouble());
double n = ::rtl::math::approxFloor(GetDouble());
- if (n < 0.0 || k < 0.0 || k > n)
+ if (n < 0.0 || k < 0.0)
PushIllegalArgument();
else
PushDouble(pow(n,k));
More information about the Libreoffice-commits
mailing list