[Libreoffice-commits] core.git: 2 commits - external/breakpad sc/source

[Caolán McNamara]

 external/breakpad/README                  |   22 +++++++++++++++++++++-
 sc/source/ui/condformat/condformatdlg.cxx |    8 ++++++++
 sc/source/ui/inc/condformatdlg.hxx        |    1 +
 3 files changed, 30 insertions(+), 1 deletion(-)

New commits:
commit ac561ab34ea9d26243fe3791f624c440dcf7ae6d
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri Jan 6 16:18:37 2017 +0000

    Resolves: tdf#105061 Only one text box shown in case of 'between'
    
    non-layout ScCondFormatList widget not responding to layout child change
    
    Change-Id: I7edd4fc54de9e71fb86b47a9b182bfc22fa4af25

diff --git a/sc/source/ui/condformat/condformatdlg.cxx b/sc/source/ui/condformat/condformatdlg.cxx
index 22bd55a..b6e2191 100644
--- a/sc/source/ui/condformat/condformatdlg.cxx
+++ b/sc/source/ui/condformat/condformatdlg.cxx
@@ -157,6 +157,14 @@ void ScCondFormatList::Resize()
     RecalcAll();
 }
 
+void ScCondFormatList::queue_resize(StateChangedType eReason)
+{
+    Control::queue_resize(eReason);
+    if (!mpDialogParent) //detects that this is during dispose
+        return;
+    RecalcAll();
+}
+
 ScConditionalFormat* ScCondFormatList::GetConditionalFormat() const
 {
     if(maEntries.empty())
diff --git a/sc/source/ui/inc/condformatdlg.hxx b/sc/source/ui/inc/condformatdlg.hxx
index 62f3758..a79ae0d 100644
--- a/sc/source/ui/inc/condformatdlg.hxx
+++ b/sc/source/ui/inc/condformatdlg.hxx
@@ -66,6 +66,7 @@ public:
         condformat::dialog::ScCondFormatDialogType eType);
 
     virtual Size GetOptimalSize() const override;
+    virtual void queue_resize(StateChangedType eReason = StateChangedType::Layout) override;
     virtual void Resize() override;
 
     ScConditionalFormat* GetConditionalFormat() const;
commit abf38a157eabe867fb23a85901e149a50e6782cd
Author: Michael Stahl <mstahl at redhat.com>
Date:   Fri Jan 6 17:15:17 2017 +0100

    breakpad: document how to read mini-dumps locally
    
    Change-Id: I888930079fc93c609769ac31a025c410b9adad96

diff --git a/external/breakpad/README b/external/breakpad/README
index 41fbde6..dfd2bf9 100644
--- a/external/breakpad/README
+++ b/external/breakpad/README
@@ -1 +1,21 @@
-Render glTF 3D models.
+Google breakpad crash-reporting library
+
+https://chromium.googlesource.com/breakpad/breakpad
+
+When this is enabled and soffice.bin crashes, a "mini-dump" file is written
+as "instdir/crash/*.dmp".
+
+There is an UI to upload the mini-dump to a TDF server but of course
+that only makes sense if the server has symbols available that match
+the build, which is not the case if you have built LO yourself.
+
+If you want to get the backtrace from local mini-dump files:
+
+* with Visual Studio:
+  1. open the *.dmp file from the Visual Studio IDE File->Open->File
+  2. then click "Debug Native Only"
+
+* otherwise:
+  1. run "make symbols" to extract the debuginfo from the binaries
+  2. run "workdir/UnpackedTarball/breakpad/src/processor/minidump_stackwalk foo.dmp workdir/symbols"
+