[Libreoffice-commits] core.git: sc/source

Tamás Zolnai tamas.zolnai at collabora.com
Sun Jan 8 06:11:43 UTC 2017


 sc/source/core/data/dpobject.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit ad86820a2bc99ede49875f8b03d6e64624e7b5f4
Author: Tamás Zolnai <tamas.zolnai at collabora.com>
Date:   Sun Jan 8 05:04:19 2017 +0100

    PivotTable: Avoid adding useless 'Data' column field to table layout
    
    Layout dialog adds this column field by default, but it has
    no actual meaning or functionality. It must be added because
    of this broken logic here (adding a field only when its hidden?).
    This 'Data' field must be related to OOXML format see
    OOX_PT_DATALAYOUTFIELD, but might be deprecated actually.
    
    Change-Id: I90f00ef6290b343f84e40e5c94fd0e29a328329b

diff --git a/sc/source/core/data/dpobject.cxx b/sc/source/core/data/dpobject.cxx
index ab220f1..e9b321b 100644
--- a/sc/source/core/data/dpobject.cxx
+++ b/sc/source/core/data/dpobject.cxx
@@ -2308,7 +2308,7 @@ void ScDPObject::FillOldParam(ScPivotParam& rParam) const
     rParam.nTab = aOutRange.aStart.Tab();
     // ppLabelArr / nLabels is not changed
 
-    bool bAddData = ( lcl_GetDataGetOrientation( xSource ) == sheet::DataPilotFieldOrientation_HIDDEN );
+    bool bAddData = ( lcl_GetDataGetOrientation( xSource ) != sheet::DataPilotFieldOrientation_HIDDEN );
     lcl_FillOldFields(
         rParam.maPageFields, xSource, sheet::DataPilotFieldOrientation_PAGE, false);
     lcl_FillOldFields(


More information about the Libreoffice-commits mailing list