[Libreoffice-commits] core.git: xmloff/source

Caolán McNamara caolanm at redhat.com
Sat Jan 28 12:27:40 UTC 2017


 xmloff/source/transform/TransformerBase.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a5233e51123ebbbe4e112cdfe796e08b8e3fee47
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sat Jan 28 12:26:36 2017 +0000

    Resolves: coverity#1399594 Unchecked dynamic_cast
    
    Change-Id: I6aae2d451db218a53931df1982a5412923dd42c1

diff --git a/xmloff/source/transform/TransformerBase.cxx b/xmloff/source/transform/TransformerBase.cxx
index 92c569a..d32197c 100644
--- a/xmloff/source/transform/TransformerBase.cxx
+++ b/xmloff/source/transform/TransformerBase.cxx
@@ -424,8 +424,8 @@ void SAL_CALL XMLTransformerBase::initialize( const Sequence< Any >& aArguments
         {
             m_xHandler.set( *pAny, UNO_QUERY );
             m_xFastHandler.set( m_xHandler.get(), UNO_QUERY );
-            if ( (dynamic_cast< SvXMLImport* >( m_xFastHandler.get() ) ) )
-                m_xNamespaceHandler = (dynamic_cast< SvXMLImport* >( m_xFastHandler.get() ) )->getNamespaceHandler();
+            if (SvXMLImport *pFastHandler = dynamic_cast<SvXMLImport*>(m_xFastHandler.get()))
+                m_xNamespaceHandler = pFastHandler->getNamespaceHandler();
         }
 
         // property set to transport data across


More information about the Libreoffice-commits mailing list