[Libreoffice-commits] core.git: 51 commits - accessibility/source avmedia/source basctl/source basegfx/source basegfx/test basic/inc basic/source canvas/source chart2/source comphelper/source connectivity/source cppuhelper/source cppu/qa cui/source dbaccess/source desktop/source editeng/source extensions/source forms/source formula/source framework/source helpcompiler/source include/canvas include/comphelper include/cppuhelper include/vcl include/xmloff l10ntools/inc l10ntools/source linguistic/source oox/source package/source reportdesign/source sal/osl sal/qa sal/rtl sax/source sc/qa scripting/source sc/source sdext/source sd/qa sd/source sfx2/source slideshow/source solenv/bin starmath/source stoc/source store/source svl/qa svl/source svtools/source svx/source sw/qa sw/source test/source toolkit/source tools/source unotools/source unoxml/source vcl/inc vcl/source vcl/unx writerfilter/source xmlhelp/source xmloff/source xmlscript/source
Stephan Bergmann
sbergman at redhat.com
Sun Jul 2 20:36:57 UTC 2017
accessibility/source/extended/AccessibleGridControlHeader.cxx | 3
accessibility/source/extended/AccessibleGridControlTable.cxx | 7
accessibility/source/extended/accessibleeditbrowseboxcell.cxx | 3
avmedia/source/framework/soundhandler.cxx | 3
basctl/source/basicide/basdoc.cxx | 1
basctl/source/basicide/basicbox.cxx | 3
basctl/source/basicide/baside2.cxx | 5
basctl/source/basicide/baside2.hxx | 2
basctl/source/basicide/basides1.cxx | 2
basctl/source/basicide/bastypes.cxx | 3
basctl/source/basicide/iderdll.cxx | 6
basctl/source/basicide/localizationmgr.cxx | 1
basctl/source/basicide/moduldlg.cxx | 1
basctl/source/basicide/scriptdocument.cxx | 1
basegfx/source/range/b2drangeclipper.cxx | 2
basegfx/source/tools/keystoplerp.cxx | 3
basegfx/test/basegfx2d.cxx | 12 -
basic/inc/sbstdobj.hxx | 6
basic/source/basmgr/basmgr.cxx | 31 ---
basic/source/classes/eventatt.cxx | 5
basic/source/classes/propacc.cxx | 29 --
basic/source/classes/sbunoobj.cxx | 61 +-----
basic/source/classes/sbxmod.cxx | 6
basic/source/comp/dim.cxx | 9
basic/source/inc/eventatt.hxx | 3
basic/source/inc/parser.hxx | 2
basic/source/inc/propacc.hxx | 3
basic/source/inc/sbunoobj.hxx | 18 -
basic/source/runtime/iosys.cxx | 4
basic/source/runtime/methods.cxx | 7
basic/source/runtime/methods1.cxx | 33 +--
basic/source/runtime/props.cxx | 1
basic/source/runtime/stdobj1.cxx | 18 -
basic/source/sbx/sbxdec.cxx | 54 ++---
basic/source/uno/scriptcont.cxx | 25 --
canvas/source/tools/verifyinput.cxx | 24 --
canvas/source/vcl/canvasfont.cxx | 3
canvas/source/vcl/textlayout.cxx | 41 ----
canvas/source/vcl/textlayout.hxx | 1
chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx | 1
chart2/source/controller/dialogs/DataBrowserModel.cxx | 8
chart2/source/controller/main/DrawCommandDispatch.cxx | 2
chart2/source/controller/main/ShapeController.cxx | 4
chart2/source/model/main/Axis.cxx | 1
chart2/source/model/main/ChartModel.cxx | 4
chart2/source/model/main/UndoManager.cxx | 3
chart2/source/tools/DiagramHelper.cxx | 1
chart2/source/tools/LifeTime.cxx | 2
chart2/source/tools/WrappedPropertySet.cxx | 1
chart2/source/view/main/ChartView.cxx | 1
comphelper/source/container/embeddedobjectcontainer.cxx | 1
comphelper/source/misc/logging.cxx | 9
connectivity/source/commontools/paramwrapper.cxx | 1
connectivity/source/drivers/dbase/DTable.cxx | 12 -
connectivity/source/drivers/firebird/Connection.cxx | 3
connectivity/source/drivers/firebird/DatabaseMetaData.cxx | 100 ++--------
connectivity/source/drivers/firebird/Driver.cxx | 3
connectivity/source/drivers/firebird/PreparedStatement.cxx | 31 ---
connectivity/source/drivers/firebird/ResultSet.cxx | 20 --
connectivity/source/drivers/firebird/ResultSetMetaData.cxx | 30 +--
connectivity/source/drivers/firebird/Statement.cxx | 3
connectivity/source/drivers/firebird/StatementCommonBase.cxx | 18 -
connectivity/source/drivers/firebird/Table.cxx | 3
connectivity/source/drivers/firebird/User.cxx | 12 -
connectivity/source/drivers/firebird/User.hxx | 7
connectivity/source/drivers/firebird/Users.cxx | 11 -
connectivity/source/drivers/hsqldb/HDriver.cxx | 3
connectivity/source/drivers/jdbc/JStatement.cxx | 3
connectivity/source/drivers/mork/MConnection.cxx | 3
connectivity/source/drivers/mork/MConnection.hxx | 2
connectivity/source/drivers/mork/MDriver.cxx | 11 -
connectivity/source/drivers/mozab/bootstrap/MMozillaBootstrap.cxx | 11 -
connectivity/source/drivers/mozab/bootstrap/MNSProfileDiscover.cxx | 4
connectivity/source/drivers/odbc/OConnection.cxx | 1
connectivity/source/drivers/postgresql/pq_databasemetadata.cxx | 37 +--
connectivity/source/drivers/postgresql/pq_driver.cxx | 6
connectivity/source/drivers/postgresql/pq_preparedstatement.cxx | 38 +--
connectivity/source/drivers/postgresql/pq_resultsetmetadata.cxx | 18 -
connectivity/source/drivers/postgresql/pq_xindexcolumns.cxx | 6
connectivity/source/drivers/postgresql/pq_xindexes.cxx | 5
connectivity/source/drivers/postgresql/pq_xkeycolumns.cxx | 6
connectivity/source/drivers/postgresql/pq_xuser.cxx | 12 -
connectivity/source/parse/sqliterator.cxx | 1
cppu/qa/test_reference.cxx | 8
cppuhelper/source/propshlp.cxx | 1
cui/source/customize/cfg.cxx | 26 --
cui/source/customize/macropg.cxx | 1
cui/source/dialogs/hyphen.cxx | 3
cui/source/inc/cfg.hxx | 2
cui/source/options/optjava.cxx | 8
cui/source/tabpages/tpcolor.cxx | 1
dbaccess/source/core/api/HelperCollections.cxx | 1
dbaccess/source/core/api/RowSetBase.cxx | 1
dbaccess/source/core/api/SingleSelectQueryComposer.cxx | 6
dbaccess/source/core/api/TableDeco.cxx | 3
dbaccess/source/core/api/query.cxx | 1
dbaccess/source/core/dataaccess/ModelImpl.cxx | 4
dbaccess/source/core/dataaccess/documentdefinition.cxx | 4
dbaccess/source/core/recovery/settingsimport.cxx | 6
dbaccess/source/core/recovery/subcomponentrecovery.cxx | 21 --
dbaccess/source/ext/macromigration/migrationlog.cxx | 2
dbaccess/source/ui/browser/brwctrlr.cxx | 1
dbaccess/source/ui/browser/sbagrid.cxx | 3
dbaccess/source/ui/control/opendoccontrols.cxx | 10 -
dbaccess/source/ui/dlg/UserAdminDlg.cxx | 5
dbaccess/source/ui/dlg/advancedsettings.cxx | 5
dbaccess/source/ui/dlg/dbadmin.cxx | 5
dbaccess/source/ui/dlg/dbfindex.cxx | 4
dbaccess/source/ui/dlg/directsql.cxx | 1
dbaccess/source/ui/misc/UITools.cxx | 3
dbaccess/source/ui/misc/WTypeSelect.cxx | 1
dbaccess/source/ui/misc/dbaundomanager.cxx | 3
dbaccess/source/ui/querydesign/QueryDesignView.cxx | 7
desktop/source/app/check_ext_deps.cxx | 1
desktop/source/app/opencl.cxx | 1
desktop/source/deployment/manager/dp_activepackages.cxx | 2
desktop/source/deployment/misc/dp_update.cxx | 2
desktop/source/deployment/registry/component/dp_component.cxx | 1
desktop/source/deployment/registry/help/dp_help.cxx | 6
desktop/source/migration/migration.cxx | 1
editeng/source/accessibility/AccessibleEditableTextPara.cxx | 23 --
editeng/source/accessibility/AccessibleImageBullet.cxx | 4
editeng/source/editeng/editeng.cxx | 3
editeng/source/editeng/edtspell.cxx | 1
editeng/source/editeng/impedit3.cxx | 2
editeng/source/xml/xmltxtexp.cxx | 7
extensions/source/abpilot/datasourcehandling.cxx | 1
extensions/source/bibliography/bibview.cxx | 7
extensions/source/bibliography/formcontrolcontainer.cxx | 3
extensions/source/bibliography/general.cxx | 3
extensions/source/propctrlr/browserlistbox.cxx | 1
extensions/source/propctrlr/eformspropertyhandler.cxx | 1
extensions/source/propctrlr/eventhandler.cxx | 1
extensions/source/propctrlr/selectlabeldialog.cxx | 2
extensions/source/propctrlr/submissionhandler.cxx | 1
extensions/source/propctrlr/taborder.cxx | 6
extensions/source/scanner/sane.cxx | 2
extensions/source/update/check/download.cxx | 5
extensions/source/update/check/updatecheck.cxx | 3
forms/source/component/Columns.cxx | 2
forms/source/component/FormComponent.cxx | 4
forms/source/component/FormattedField.cxx | 3
forms/source/component/ListBox.cxx | 3
forms/source/helper/windowstateguard.cxx | 1
forms/source/misc/InterfaceContainer.cxx | 2
forms/source/richtext/attributedispatcher.cxx | 4
forms/source/richtext/parametrizedattributedispatcher.cxx | 1
forms/source/richtext/rtattributehandler.cxx | 3
forms/source/richtext/specialdispatchers.cxx | 2
forms/source/runtime/formoperations.cxx | 3
formula/source/ui/dlg/formula.cxx | 2
framework/source/accelerators/presethandler.cxx | 2
framework/source/fwe/helper/documentundoguard.cxx | 36 +--
framework/source/fwi/jobs/configaccess.cxx | 1
framework/source/helper/ocomponentenumeration.cxx | 1
helpcompiler/source/HelpLinker.cxx | 5
include/canvas/verifyinput.hxx | 3
include/comphelper/sequence.hxx | 1
include/cppuhelper/weak.hxx | 8
include/vcl/ITiledRenderable.hxx | 31 ---
include/vcl/outdev.hxx | 2
include/xmloff/SettingsExportHelper.hxx | 2
l10ntools/inc/helpmerge.hxx | 5
l10ntools/source/helpex.cxx | 4
l10ntools/source/helpmerge.cxx | 5
linguistic/source/gciterator.cxx | 6
oox/source/core/contexthandler2.cxx | 2
oox/source/core/recordparser.cxx | 1
oox/source/drawingml/diagram/diagram.cxx | 2
package/source/zippackage/ZipPackageFolder.cxx | 3
reportdesign/source/core/api/ReportEngineJFree.cxx | 3
reportdesign/source/core/misc/conditionalexpression.cxx | 5
reportdesign/source/core/sdr/PropertyForward.cxx | 3
reportdesign/source/core/sdr/RptPage.cxx | 3
reportdesign/source/filter/xml/xmlfilter.cxx | 1
reportdesign/source/ui/dlg/AddField.cxx | 1
reportdesign/source/ui/report/ReportControllerObserver.cxx | 2
reportdesign/source/ui/report/ReportWindow.cxx | 3
reportdesign/source/ui/report/dlgedfunc.cxx | 1
sal/osl/all/loadmodulerelative.cxx | 1
sal/osl/unx/file.cxx | 3
sal/osl/unx/pipe.cxx | 3
sal/osl/unx/profile.cxx | 6
sal/osl/unx/security.cxx | 78 -------
sal/qa/osl/file/osl_File.cxx | 3
sal/rtl/bootstrap.cxx | 1
sax/source/tools/fastserializer.cxx | 1
sc/qa/unit/opencl-test.cxx | 6
sc/source/core/data/dpobject.cxx | 1
sc/source/filter/excel/xelink.cxx | 2
sc/source/filter/excel/xestream.cxx | 2
sc/source/filter/excel/xipivot.cxx | 1
sc/source/filter/inc/worksheetsettings.hxx | 2
sc/source/filter/oox/formulabase.cxx | 1
sc/source/filter/oox/worksheetfragment.cxx | 4
sc/source/filter/oox/worksheetsettings.cxx | 5
sc/source/filter/xml/XMLStylesImportHelper.cxx | 1
sc/source/filter/xml/xmldpimp.cxx | 4
sc/source/filter/xml/xmlexprt.cxx | 1
sc/source/ui/Accessibility/DrawModelBroadcaster.cxx | 1
sc/source/ui/drawfunc/drawsh2.cxx | 4
sc/source/ui/sidebar/AlignmentPropertyPanel.cxx | 10 -
sc/source/ui/sidebar/CellAppearancePropertyPanel.cxx | 10 -
sc/source/ui/sidebar/NumberFormatPropertyPanel.cxx | 10 -
sc/source/ui/undo/undoutil.cxx | 1
sc/source/ui/unoobj/celllistsource.cxx | 1
sc/source/ui/unoobj/cellvaluebinding.cxx | 1
sc/source/ui/vba/vbarange.cxx | 5
sc/source/ui/view/drawview.cxx | 1
scripting/source/basprov/basmethnode.cxx | 21 --
scripting/source/dlgprov/dlgprov.cxx | 3
scripting/source/protocolhandler/scripthandler.cxx | 17 -
scripting/source/provider/BrowseNodeFactoryImpl.cxx | 1
scripting/source/provider/MasterScriptProvider.cxx | 1
scripting/source/stringresource/stringresource.cxx | 11 -
sd/qa/unit/import-tests.cxx | 9
sd/source/core/sdpage2.cxx | 1
sd/source/core/stlpool.cxx | 1
sd/source/ui/animations/CustomAnimationPane.cxx | 3
sd/source/ui/animations/SlideTransitionPane.cxx | 3
sd/source/ui/app/optsitem.cxx | 1
sd/source/ui/controller/slidelayoutcontroller.cxx | 3
sd/source/ui/dlg/RemoteDialogClientBox.cxx | 6
sd/source/ui/dlg/sdtreelb.cxx | 5
sd/source/ui/framework/configuration/Configuration.cxx | 4
sd/source/ui/framework/configuration/ConfigurationControllerResourceManager.cxx | 5
sd/source/ui/framework/configuration/GenericConfigurationChangeRequest.cxx | 3
sd/source/ui/framework/configuration/UpdateRequest.cxx | 6
sd/source/ui/framework/factories/BasicToolBarFactory.cxx | 8
sd/source/ui/framework/factories/BasicToolBarFactory.hxx | 4
sd/source/ui/framework/factories/BasicViewFactory.cxx | 8
sd/source/ui/framework/factories/BasicViewFactory.hxx | 4
sd/source/ui/framework/factories/PresentationFactory.cxx | 25 --
sd/source/ui/framework/factories/ViewShellWrapper.cxx | 16 -
sd/source/ui/framework/tools/FrameworkHelper.cxx | 6
sd/source/ui/presenter/PresenterCanvas.cxx | 19 -
sd/source/ui/presenter/PresenterHelper.cxx | 9
sd/source/ui/presenter/PresenterPreviewCache.cxx | 11 -
sd/source/ui/presenter/PresenterPreviewCache.hxx | 3
sd/source/ui/presenter/PresenterTextView.cxx | 7
sd/source/ui/presenter/PresenterTextView.hxx | 6
sd/source/ui/presenter/SlideRenderer.cxx | 7
sd/source/ui/presenter/SlideRenderer.hxx | 3
sd/source/ui/remotecontrol/BluetoothServer.cxx | 4
sd/source/ui/remotecontrol/Listener.cxx | 25 --
sd/source/ui/sidebar/MasterPageContainerProviders.cxx | 20 --
sd/source/ui/sidebar/NavigatorWrapper.cxx | 4
sd/source/ui/sidebar/SlideBackground.cxx | 4
sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx | 4
sd/source/ui/slidesorter/model/SlsPageEnumerationProvider.cxx | 3
sd/source/ui/slidesorter/shell/SlideSorterService.cxx | 14 -
sd/source/ui/slidesorter/view/SlsInsertionIndicatorOverlay.cxx | 4
sd/source/ui/slidesorter/view/SlsLayouter.cxx | 8
sd/source/ui/tools/PropertySet.cxx | 12 -
sd/source/ui/unoidl/SdUnoDrawView.cxx | 12 -
sd/source/ui/unoidl/SdUnoOutlineView.cxx | 12 -
sd/source/ui/unoidl/SdUnoSlideView.cxx | 16 -
sd/source/ui/unoidl/UnoDocumentSettings.cxx | 3
sd/source/ui/view/DocumentRenderer.cxx | 37 +--
sd/source/ui/view/drviewsa.cxx | 1
sdext/source/minimizer/configurationaccess.cxx | 1
sdext/source/pdfimport/pdfiadaptor.cxx | 1
sdext/source/presenter/PresenterAccessibility.cxx | 44 +---
sdext/source/presenter/PresenterAccessibility.hxx | 4
sdext/source/presenter/PresenterButton.cxx | 30 +--
sdext/source/presenter/PresenterController.cxx | 44 ----
sdext/source/presenter/PresenterCurrentSlideObserver.cxx | 18 -
sdext/source/presenter/PresenterHelpView.cxx | 12 -
sdext/source/presenter/PresenterNotesView.cxx | 23 --
sdext/source/presenter/PresenterPane.cxx | 5
sdext/source/presenter/PresenterPaneBase.cxx | 12 -
sdext/source/presenter/PresenterPaneBorderPainter.cxx | 2
sdext/source/presenter/PresenterProtocolHandler.cxx | 23 --
sdext/source/presenter/PresenterProtocolHandler.hxx | 2
sdext/source/presenter/PresenterScreen.cxx | 4
sdext/source/presenter/PresenterScrollBar.cxx | 46 +---
sdext/source/presenter/PresenterSlidePreview.cxx | 17 -
sdext/source/presenter/PresenterSlideShowView.cxx | 15 -
sdext/source/presenter/PresenterSlideSorter.cxx | 37 +--
sdext/source/presenter/PresenterSpritePane.cxx | 7
sdext/source/presenter/PresenterTimer.cxx | 4
sdext/source/presenter/PresenterToolBar.cxx | 38 +--
sdext/source/presenter/PresenterViewFactory.cxx | 6
sdext/source/presenter/PresenterViewFactory.hxx | 3
sdext/source/presenter/PresenterWindowManager.cxx | 23 --
sfx2/source/appl/shutdownicon.cxx | 4
sfx2/source/control/statcach.cxx | 2
sfx2/source/control/thumbnailviewacc.cxx | 3
sfx2/source/doc/Metadatable.cxx | 1
sfx2/source/doc/docundomanager.cxx | 3
sfx2/source/doc/objstor.cxx | 2
sfx2/source/sidebar/Deck.cxx | 3
sfx2/source/sidebar/Panel.cxx | 3
sfx2/source/sidebar/SidebarPanelBase.cxx | 8
sfx2/source/sidebar/TitleBar.cxx | 1
slideshow/source/engine/animationnodes/basenode.cxx | 1
slideshow/source/engine/animationnodes/basenode.hxx | 1
slideshow/source/engine/animationnodes/paralleltimecontainer.cxx | 1
slideshow/source/engine/rehearsetimingsactivity.cxx | 1
slideshow/source/engine/slide/layermanager.cxx | 2
slideshow/source/engine/slideview.cxx | 2
solenv/bin/concat-deps.c | 9
starmath/source/cfgitem.cxx | 1
stoc/source/proxy_factory/proxyfac.cxx | 1
stoc/source/security/lru_cache.h | 3
store/source/lockbyte.cxx | 1
store/source/storcach.cxx | 1
svl/qa/unit/items/test_IndexedStyleSheets.cxx | 3
svl/qa/unit/notify/test_SfxBroadcaster.cxx | 3
svl/source/misc/filenotation.cxx | 1
svl/source/numbers/zforfind.cxx | 3
svl/source/numbers/zforlist.cxx | 1
svl/source/undo/undo.cxx | 6
svtools/source/misc/acceleratorexecute.cxx | 4
svtools/source/table/gridtablerenderer.cxx | 19 -
svtools/source/table/mousefunction.cxx | 1
svtools/source/table/tablecontrol.cxx | 21 --
svtools/source/table/tablecontrol_impl.cxx | 23 --
svx/source/accessibility/AccessibleControlShape.cxx | 6
svx/source/accessibility/ShapeTypeHandler.cxx | 5
svx/source/fmcomp/fmgridif.cxx | 6
svx/source/fmcomp/gridcell.cxx | 8
svx/source/form/datanavi.cxx | 3
svx/source/form/fmpgeimp.cxx | 3
svx/source/form/fmsrcimp.cxx | 2
svx/source/form/fmtextcontrolshell.cxx | 5
svx/source/form/formcontroller.cxx | 1
svx/source/form/formfeaturedispatcher.cxx | 3
svx/source/sdr/contact/viewobjectcontactofgraphic.cxx | 2
svx/source/sidebar/graphic/GraphicPropertyPanel.cxx | 4
svx/source/sidebar/paragraph/ParaPropertyPanel.cxx | 9
svx/source/sidebar/possize/PosSizePropertyPanel.cxx | 4
svx/source/svdraw/svdmrkv.cxx | 8
svx/source/svdraw/svdundo.cxx | 1
svx/source/table/tablelayouter.cxx | 6
svx/source/table/tablemodel.cxx | 6
svx/source/table/tablertfexporter.cxx | 6
svx/source/table/tablertfimporter.cxx | 3
svx/source/unodraw/unoshape.cxx | 20 --
svx/source/xml/xmleohlp.cxx | 4
svx/source/xml/xmlxtimp.cxx | 54 +----
sw/qa/core/Test-BigPtrArray.cxx | 70 -------
sw/qa/core/test_ToxTextGenerator.cxx | 11 -
sw/qa/extras/ooxmlexport/ooxmlexport.cxx | 1
sw/source/core/access/accmap.cxx | 35 ---
sw/source/core/crsr/crsrsh.cxx | 1
sw/source/core/doc/DocumentRedlineManager.cxx | 8
sw/source/core/doc/docbm.cxx | 3
sw/source/core/doc/docfld.cxx | 3
sw/source/core/doc/number.cxx | 3
sw/source/core/docnode/nodes.cxx | 1
sw/source/core/edit/eddel.cxx | 2
sw/source/core/edit/edfld.cxx | 1
sw/source/core/edit/editsh.cxx | 1
sw/source/core/fields/docufld.cxx | 1
sw/source/core/frmedt/feflyole.cxx | 1
sw/source/core/inc/ftnfrm.hxx | 5
sw/source/core/layout/atrfrm.cxx | 2
sw/source/core/layout/flylay.cxx | 2
sw/source/core/layout/frmtool.cxx | 1
sw/source/core/layout/ftnfrm.cxx | 30 ---
sw/source/core/objectpositioning/anchoredobjectposition.cxx | 1
sw/source/core/text/EnhancedPDFExportHelper.cxx | 1
sw/source/core/text/porrst.cxx | 3
sw/source/core/text/wrong.cxx | 1
sw/source/core/tox/txmsrt.cxx | 1
sw/source/core/txtnode/fntcache.cxx | 1
sw/source/core/txtnode/thints.cxx | 1
sw/source/core/undo/undobj1.cxx | 3
sw/source/core/unocore/unochart.cxx | 4
sw/source/core/unocore/unocrsrhelper.cxx | 5
sw/source/core/unocore/unoobj.cxx | 4
sw/source/core/unocore/unoobj2.cxx | 1
sw/source/core/unocore/unotext.cxx | 40 ----
sw/source/filter/html/htmlcss1.cxx | 1
sw/source/filter/ww8/WW8TableInfo.cxx | 4
sw/source/filter/ww8/ww8par2.cxx | 1
sw/source/filter/ww8/ww8par3.cxx | 1
sw/source/filter/ww8/ww8par6.cxx | 1
sw/source/filter/xml/swxml.cxx | 3
sw/source/filter/xml/xmltbli.cxx | 1
sw/source/ui/dbui/mmresultdialogs.cxx | 1
sw/source/ui/frmdlg/frmpage.cxx | 5
sw/source/uibase/sidebar/PageFooterPanel.cxx | 4
sw/source/uibase/sidebar/PageFormatPanel.cxx | 4
sw/source/uibase/sidebar/PageHeaderPanel.cxx | 4
sw/source/uibase/sidebar/PageStylesPanel.cxx | 4
sw/source/uibase/sidebar/WrapPropertyPanel.cxx | 4
sw/source/uibase/uno/unotxdoc.cxx | 1
sw/source/uibase/web/wdocsh.cxx | 1
test/source/bootstrapfixture.cxx | 6
toolkit/source/awt/vclxdevice.cxx | 4
toolkit/source/awt/vclxwindows.cxx | 8
toolkit/source/controls/dialogcontrol.cxx | 10 -
toolkit/source/controls/tabpagemodel.cxx | 15 -
toolkit/source/controls/tree/treecontrol.cxx | 2
toolkit/source/controls/unocontrolmodel.cxx | 1
tools/source/generic/poly.cxx | 1
tools/source/rc/resmgr.cxx | 1
unotools/source/misc/closeveto.cxx | 14 -
unoxml/source/rdf/librdf_repository.cxx | 4
vcl/inc/headless/svpframe.hxx | 4
vcl/inc/unx/gtk/gtkgdi.hxx | 5
vcl/source/app/salvtables.cxx | 2
vcl/source/fontsubset/cff.cxx | 12 -
vcl/source/fontsubset/fontsubset.cxx | 3
vcl/source/image/ImplImageTree.cxx | 2
vcl/source/outdev/map.cxx | 2
vcl/unx/generic/print/genpspgraphics.cxx | 12 -
vcl/unx/gtk/gtkinst.cxx | 4
vcl/unx/gtk/gtksalframe.cxx | 3
vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx | 23 --
writerfilter/source/dmapper/CellColorHandler.cxx | 5
writerfilter/source/dmapper/CellMarginHandler.cxx | 2
writerfilter/source/dmapper/DomainMapper.cxx | 10 -
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 21 --
writerfilter/source/dmapper/MeasureHandler.cxx | 6
writerfilter/source/dmapper/OLEHandler.cxx | 1
writerfilter/source/dmapper/PropertyMap.cxx | 3
writerfilter/source/dmapper/PropertyMapHelper.cxx | 3
writerfilter/source/dmapper/SettingsTable.cxx | 1
writerfilter/source/dmapper/StyleSheetTable.cxx | 3
writerfilter/source/dmapper/TDefTableHandler.cxx | 2
writerfilter/source/dmapper/TrackChangesHandler.cxx | 6
writerfilter/source/dmapper/util.cxx | 3
writerfilter/source/ooxml/qnametostrcore.cxx | 4
xmlhelp/source/cxxhelp/inc/tvread.hxx | 18 -
xmlhelp/source/cxxhelp/provider/content.cxx | 12 -
xmlhelp/source/cxxhelp/provider/databases.cxx | 3
xmlhelp/source/cxxhelp/provider/provider.hxx | 20 --
xmlhelp/source/cxxhelp/provider/resultsetbase.cxx | 22 --
xmlhelp/source/cxxhelp/provider/urlparameter.cxx | 18 -
xmlhelp/source/cxxhelp/provider/urlparameter.hxx | 12 -
xmlhelp/source/treeview/tvread.cxx | 4
xmloff/source/core/SettingsExportHelper.cxx | 7
xmloff/source/core/xmlexp.cxx | 3
xmloff/source/core/xmlimp.cxx | 4
xmloff/source/forms/layerexport.cxx | 8
xmloff/source/forms/propertyimport.cxx | 1
xmloff/source/meta/xmlmetae.cxx | 6
xmloff/source/style/PagePropertySetContext.cxx | 2
xmloff/source/table/XMLTableImport.cxx | 2
xmloff/source/text/XMLTextListItemContext.cxx | 1
xmloff/source/transform/TransformerBase.cxx | 3
xmloff/source/xforms/xformsapi.cxx | 1
xmlscript/source/xml_helper/xml_element.cxx | 1
xmlscript/source/xml_helper/xml_impctx.cxx | 2
447 files changed, 830 insertions(+), 2448 deletions(-)
New commits:
commit a04ccfed42b41e3753f11dc93b2da3ba1e1ed24a
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:36:06 2017 +0200
loplugin:casttovoid: accessibility
Change-Id: I397c1c51c166d57917d2a412ec8f59c8a24936f2
diff --git a/accessibility/source/extended/AccessibleGridControlHeader.cxx b/accessibility/source/extended/AccessibleGridControlHeader.cxx
index f6a4cb177043..6e861ba398c0 100644
--- a/accessibility/source/extended/AccessibleGridControlHeader.cxx
+++ b/accessibility/source/extended/AccessibleGridControlHeader.cxx
@@ -159,9 +159,8 @@ sal_Bool SAL_CALL AccessibleGridControlHeader::isAccessibleRowSelected( sal_Int3
return false;
}
//columns aren't selectable
-sal_Bool SAL_CALL AccessibleGridControlHeader::isAccessibleColumnSelected( sal_Int32 nColumn )
+sal_Bool SAL_CALL AccessibleGridControlHeader::isAccessibleColumnSelected( sal_Int32 )
{
- (void)nColumn;
return false;
}
//not implemented
diff --git a/accessibility/source/extended/AccessibleGridControlTable.cxx b/accessibility/source/extended/AccessibleGridControlTable.cxx
index f22a8db0ff0a..ac758232ab0b 100644
--- a/accessibility/source/extended/AccessibleGridControlTable.cxx
+++ b/accessibility/source/extended/AccessibleGridControlTable.cxx
@@ -184,9 +184,8 @@ sal_Bool SAL_CALL AccessibleGridControlTable::isAccessibleRowSelected( sal_Int32
}
//columns aren't selectable
-sal_Bool SAL_CALL AccessibleGridControlTable::isAccessibleColumnSelected( sal_Int32 nColumn )
+sal_Bool SAL_CALL AccessibleGridControlTable::isAccessibleColumnSelected( sal_Int32 )
{
- (void) nColumn;
return false;
}
@@ -220,7 +219,6 @@ sal_Bool SAL_CALL AccessibleGridControlTable::isAccessibleSelected(
ensureIsAlive();
ensureIsValidAddress( nRow, nColumn );
- (void) nColumn;
//selection of single cells not possible, so if row is selected, the cell will be selected too
return isAccessibleRowSelected(nRow);
}
@@ -282,12 +280,11 @@ AccessibleGridControlTable::getSelectedAccessibleChild( sal_Int32 nSelectedChild
}
//not implemented yet, because only row selection possible
void SAL_CALL AccessibleGridControlTable::deselectAccessibleChild(
- sal_Int32 nSelectedChildIndex )
+ sal_Int32 )
{
SolarMutexGuard aSolarGuard;
ensureIsAlive();
- (void)nSelectedChildIndex;
}
// XInterface -----------------------------------------------------------------
diff --git a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
index acb2935f3d8a..8f240b20795f 100644
--- a/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
+++ b/accessibility/source/extended/accessibleeditbrowseboxcell.cxx
@@ -226,9 +226,8 @@ namespace accessibility
{
xMyContext->dispose();
}
- catch( const Exception& e )
+ catch( const Exception& )
{
- (void)e;
OSL_FAIL( "EditBrowseBoxTableCellAccess::disposing: caught an exception while disposing the context!" );
}
}
commit bd50d82d6fee6788420099ac973ea0782b015fa4
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:35:58 2017 +0200
loplugin:casttovoid: avmedia
Change-Id: I38a63a672de06b5f75370e0d08ce96d85cdb1cb3
diff --git a/avmedia/source/framework/soundhandler.cxx b/avmedia/source/framework/soundhandler.cxx
index 45f1b61132f7..94c940846f45 100644
--- a/avmedia/source/framework/soundhandler.cxx
+++ b/avmedia/source/framework/soundhandler.cxx
@@ -224,10 +224,9 @@ void SAL_CALL SoundHandler::dispatchWithNotification(const css::util::URL&
m_aUpdateIdle.SetPriority( TaskPriority::LOWER );
m_aUpdateIdle.Start();
}
- catch( css::uno::Exception& e )
+ catch( css::uno::Exception& )
{
m_bError = true;
- (void)e;
m_xPlayer.clear();
}
commit 509fd38fba550b554217cd67061e8571486d0f9b
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:35:53 2017 +0200
loplugin:casttovoid: basctl
Change-Id: I3a8222d39ed02fc048dab1dc6f8dd0ac48857b3e
diff --git a/basctl/source/basicide/basdoc.cxx b/basctl/source/basicide/basdoc.cxx
index 8006a0550604..7d9f76f9305a 100644
--- a/basctl/source/basicide/basdoc.cxx
+++ b/basctl/source/basicide/basdoc.cxx
@@ -79,7 +79,6 @@ void DocShell::SetPrinter( SfxPrinter* pPr )
void DocShell::FillClass( SvGlobalName*, SotClipboardFormatId*, OUString*, OUString*, OUString*, sal_Int32, bool bTemplate) const
{
- (void)bTemplate;
DBG_ASSERT( !bTemplate, "No template for Basic" );
}
diff --git a/basctl/source/basicide/basicbox.cxx b/basctl/source/basicide/basicbox.cxx
index 7d97fe6d5bd2..b048169038a0 100644
--- a/basctl/source/basicide/basicbox.cxx
+++ b/basctl/source/basicide/basicbox.cxx
@@ -337,9 +337,8 @@ LanguageBoxControl::LanguageBoxControl( sal_uInt16 nSlotId, sal_uInt16 nId, Tool
{
}
-void LanguageBoxControl::StateChanged( sal_uInt16 nID, SfxItemState eState, const SfxPoolItem* pItem )
+void LanguageBoxControl::StateChanged( sal_uInt16, SfxItemState eState, const SfxPoolItem* pItem )
{
- (void)nID;
if (LanguageBox* pBox = static_cast<LanguageBox*>(GetToolBox().GetItemWindow(GetId())))
{
if (eState != SfxItemState::DEFAULT)
diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index 1d2c0cf8dbdf..e40583f82e80 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -622,11 +622,8 @@ bool ModulWindow::BasicErrorHdl( StarBASIC * pBasic )
return false;
}
-BasicDebugFlags ModulWindow::BasicBreakHdl( StarBASIC* pBasic )
+BasicDebugFlags ModulWindow::BasicBreakHdl()
{
- // #i69280 Required in Window despite normal usage in next command!
- (void)pBasic;
-
// Return value: sal_uInt16 => see SB-Debug-Flags
sal_uInt16 nErrorLine = StarBASIC::GetLine();
diff --git a/basctl/source/basicide/baside2.hxx b/basctl/source/basicide/baside2.hxx
index f27997ddc15c..06539527200b 100644
--- a/basctl/source/basicide/baside2.hxx
+++ b/basctl/source/basicide/baside2.hxx
@@ -362,7 +362,7 @@ public:
void BasicAddWatch();
bool BasicErrorHdl( StarBASIC* pBasic );
- BasicDebugFlags BasicBreakHdl( StarBASIC* pBasic );
+ BasicDebugFlags BasicBreakHdl();
void AssertValidEditEngine();
void LoadBasic();
diff --git a/basctl/source/basicide/basides1.cxx b/basctl/source/basicide/basides1.cxx
index a9c9187a5ad4..2a015cc7cce2 100644
--- a/basctl/source/basicide/basides1.cxx
+++ b/basctl/source/basicide/basides1.cxx
@@ -1182,7 +1182,7 @@ BasicDebugFlags Shell::CallBasicBreakHdl( StarBASIC* pBasic )
BasicStopped( &bAppWindowDisabled, &bDispatcherLocked,
&nWaitCount, &pSWActionCount, &pSWLockViewCount );
- nRet = pModWin->BasicBreakHdl( pBasic );
+ nRet = pModWin->BasicBreakHdl();
if ( StarBASIC::IsRunning() ) // if cancelled...
{
diff --git a/basctl/source/basicide/bastypes.cxx b/basctl/source/basicide/bastypes.cxx
index e82202a00768..9750d2490b00 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -209,9 +209,8 @@ SearchOptionFlags BaseWindow::GetSearchOptions()
return SearchOptionFlags::NONE;
}
-sal_uInt16 BaseWindow::StartSearchAndReplace (SvxSearchItem const&, bool bFromStart)
+sal_uInt16 BaseWindow::StartSearchAndReplace (SvxSearchItem const&, bool)
{
- static_cast<void>(bFromStart);
return 0;
}
diff --git a/basctl/source/basicide/iderdll.cxx b/basctl/source/basicide/iderdll.cxx
index 275ec980903b..fc890c3aee0f 100644
--- a/basctl/source/basicide/iderdll.cxx
+++ b/basctl/source/basicide/iderdll.cxx
@@ -114,19 +114,17 @@ namespace
Dll::Dll () :
m_pShell(nullptr)
{
- SfxObjectFactory* pFact = &DocShell::Factory();
- (void)pFact;
+ SfxObjectFactory& rFactory = DocShell::Factory();
ResMgr* pMgr = ResMgr::CreateResMgr(
"basctl", Application::GetSettings().GetUILanguageTag());
- auto pModule = o3tl::make_unique<Module>( pMgr, &DocShell::Factory() );
+ auto pModule = o3tl::make_unique<Module>( pMgr, &rFactory );
SfxModule* pMod = pModule.get();
SfxApplication::SetModule(SfxToolsModule::Basic, std::move(pModule));
GetExtraData(); // to cause GlobalErrorHdl to be set
- SfxObjectFactory& rFactory = DocShell::Factory();
rFactory.SetDocumentServiceName( "com.sun.star.script.BasicIDE" );
DocShell::RegisterInterface( pMod );
diff --git a/basctl/source/basicide/localizationmgr.cxx b/basctl/source/basicide/localizationmgr.cxx
index 436a75a4580e..18b64c4f5a04 100644
--- a/basctl/source/basicide/localizationmgr.cxx
+++ b/basctl/source/basicide/localizationmgr.cxx
@@ -711,7 +711,6 @@ void LocalizationMgr::handleRemoveLocales( const Sequence< Locale >& aLocaleSeq
DBG_ASSERT( bConsistant,
"LocalizationMgr::handleRemoveLocales(): sequence contains unsupported locales" );
- (void)bConsistant;
}
void LocalizationMgr::handleSetDefaultLocale(const Locale& rLocale)
diff --git a/basctl/source/basicide/moduldlg.cxx b/basctl/source/basicide/moduldlg.cxx
index a9f64dcc2212..0e02742d6d07 100644
--- a/basctl/source/basicide/moduldlg.cxx
+++ b/basctl/source/basicide/moduldlg.cxx
@@ -309,7 +309,6 @@ void Shell::CopyDialogResources(
TriState ExtTreeListBox::NotifyCopyingMoving( SvTreeListEntry* pTarget, SvTreeListEntry* pEntry,
SvTreeListEntry*& rpNewParent, sal_uLong& rNewChildPos, bool bMove )
{
- (void)pEntry;
DBG_ASSERT( pEntry, "No entry?" ); // ASS is ok here, should not be reached
DBG_ASSERT( pTarget, "No target?" ); // with NULL (right at the beginning)
sal_uInt16 nDepth = GetModel()->GetDepth( pTarget );
diff --git a/basctl/source/basicide/scriptdocument.cxx b/basctl/source/basicide/scriptdocument.cxx
index abbb47cad672..9272d204b943 100644
--- a/basctl/source/basicide/scriptdocument.cxx
+++ b/basctl/source/basicide/scriptdocument.cxx
@@ -1032,7 +1032,6 @@ namespace basctl
:m_pImpl( new Impl( Reference< XModel >() ) )
{
OSL_ENSURE( _eType == NoDocument, "ScriptDocument::ScriptDocument: unknown SpecialDocument type!" );
- (void)_eType;
}
commit 806a2609e5a1436667a6ad4aa93d14dbdd61c302
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:35:46 2017 +0200
loplugin:casttovoid: basegfx
Change-Id: I5a7723a9b0ce64969a96a3bccb47b380a138b69c
diff --git a/basegfx/source/range/b2drangeclipper.cxx b/basegfx/source/range/b2drangeclipper.cxx
index a8492698ba16..936e31823283 100644
--- a/basegfx/source/range/b2drangeclipper.cxx
+++ b/basegfx/source/range/b2drangeclipper.cxx
@@ -345,8 +345,6 @@ namespace basegfx
rActiveEdge.getEdgeDirection() == ActiveEdge::PROCEED_LEFT);
const bool isSweepLineEnteringRect(
rEvent.getEdgeType() == SweepLineEvent::STARTING_EDGE);
- (void)isActiveEdgeProceedLeft;
- (void)isSweepLineEnteringRect;
OSL_ENSURE( isSweepLineEnteringRect == isActiveEdgeProceedLeft,
"ImplPolygon::intersect(): sweep initial own edge hit: wrong polygon order" );
diff --git a/basegfx/source/tools/keystoplerp.cxx b/basegfx/source/tools/keystoplerp.cxx
index 2ffede92ef9a..e68bb1b60bf6 100644
--- a/basegfx/source/tools/keystoplerp.cxx
+++ b/basegfx/source/tools/keystoplerp.cxx
@@ -25,7 +25,6 @@
static void validateInput(const std::vector<double>& rKeyStops)
{
- (void)rKeyStops;
#ifdef DBG_UTIL
OSL_ENSURE( rKeyStops.size() > 1,
"KeyStopLerp::KeyStopLerp(): key stop vector must have two entries or more" );
@@ -36,6 +35,8 @@ static void validateInput(const std::vector<double>& rKeyStops)
if( rKeyStops[i-1] > rKeyStops[i] )
OSL_FAIL( "KeyStopLerp::KeyStopLerp(): time vector is not sorted in ascending order!" );
}
+#else
+ (void)rKeyStops;
#endif
}
diff --git a/basegfx/test/basegfx2d.cxx b/basegfx/test/basegfx2d.cxx
index 829040e1442f..f5cc617ddbc2 100644
--- a/basegfx/test/basegfx2d.cxx
+++ b/basegfx/test/basegfx2d.cxx
@@ -959,10 +959,6 @@ public:
Type aRange5(5,6);
aRange.intersect(aRange5);
CPPUNIT_ASSERT_MESSAGE("range intersection is yielding nonempty range!", aRange.isEmpty());
-
- // just so that this compiles -
- Type aRange6( aRange );
- (void)aRange6;
}
void check()
@@ -997,10 +993,6 @@ public:
CPPUNIT_ASSERT_MESSAGE("(11,11) is inside range!",
tools::getCohenSutherlandClipFlags(B2IPoint(11,11),aRange) ==
(tools::RectClipFlags::RIGHT|tools::RectClipFlags::BOTTOM));
-
- // just so that this compiles -
- Type aRange1( aRange );
- (void)aRange1;
}
void check()
@@ -1036,10 +1028,6 @@ public:
CPPUNIT_ASSERT_EQUAL_MESSAGE("(10,10) is inside range!",
tools::RectClipFlags::RIGHT|tools::RectClipFlags::BOTTOM,
tools::getCohenSutherlandClipFlags(B2IPoint(10,10),aBox));
-
- // just so that this compiles -
- B2IBox aBox1( aBox );
- (void)aBox1;
}
// Change the following lines only, if you add, remove or rename
commit c8fd385d6100d7b0ef2db3c5f4f1871470c65689
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:35:38 2017 +0200
loplugin:casttovoid: basic
Change-Id: I4e70accf67d4d812b8998b0baa07cd04c27216ad
diff --git a/basic/inc/sbstdobj.hxx b/basic/inc/sbstdobj.hxx
index d306c3d81e97..210d3f7a26c4 100644
--- a/basic/inc/sbstdobj.hxx
+++ b/basic/inc/sbstdobj.hxx
@@ -102,11 +102,11 @@ protected:
virtual void Notify( SfxBroadcaster& rBC, const SfxHint& rHint ) override;
static void MethClear( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
- static void MethGetData( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
+ static void MethGetData( SbxArray* pPar_, bool bWrite );
static void MethGetFormat( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
static void MethGetText( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
- static void MethSetData( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
- static void MethSetText( SbxVariable* pVar, SbxArray* pPar_, bool bWrite );
+ static void MethSetData( SbxArray* pPar_, bool bWrite );
+ static void MethSetText( SbxArray* pPar_, bool bWrite );
public:
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 2b71f0439003..762ac7a70ef3 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -212,10 +212,7 @@ void BasMgrContainerListenerImpl::addLibraryModulesImpl( BasicManager* pMgr,
// XEventListener
-void SAL_CALL BasMgrContainerListenerImpl::disposing( const lang::EventObject& Source )
-{
- (void)Source;
-}
+void SAL_CALL BasMgrContainerListenerImpl::disposing( const lang::EventObject& ) {}
// XContainerListener
@@ -1926,9 +1923,8 @@ void DialogContainer_Impl::replaceByName( const OUString& aName, const uno::Any&
// Methods XNameContainer
-void DialogContainer_Impl::insertByName( const OUString& aName, const uno::Any& aElement )
+void DialogContainer_Impl::insertByName( const OUString&, const uno::Any& aElement )
{
- (void)aName;
uno::Type aModuleType = cppu::UnoType<script::XStarBasicDialogInfo>::get();
const uno::Type& aAnyType = aElement.getValueType();
if( aModuleType != aAnyType )
@@ -1943,7 +1939,6 @@ void DialogContainer_Impl::insertByName( const OUString& aName, const uno::Any&
void DialogContainer_Impl::removeByName( const OUString& Name )
{
- (void)Name;
SbxVariable* pVar = mpLib->GetObjects()->Find( Name, SbxClassType::DontCare );
SbxObject* pObj = dynamic_cast<SbxObject*>(pVar);
if( !( pObj && ( pObj->GetSbxId() == SBXID_DIALOG ) ) )
@@ -2063,10 +2058,8 @@ void LibraryContainer_Impl::replaceByName( const OUString& aName, const uno::Any
}
// Methods XNameContainer
-void LibraryContainer_Impl::insertByName( const OUString& aName, const uno::Any& aElement )
+void LibraryContainer_Impl::insertByName( const OUString&, const uno::Any& )
{
- (void)aName;
- (void)aElement;
// TODO: Insert a complete Library?!
}
@@ -2116,11 +2109,10 @@ void SAL_CALL StarBasicAccess_Impl::createLibrary
(
const OUString& LibName,
const OUString& Password,
- const OUString& ExternalSourceURL,
+ const OUString&,
const OUString& LinkTargetURL
)
{
- (void)ExternalSourceURL;
StarBASIC* pLib = mpMgr->CreateLib( LibName, Password, LinkTargetURL );
DBG_ASSERT( pLib, "XML Import: Basic library could not be created");
}
@@ -2129,11 +2121,10 @@ void SAL_CALL StarBasicAccess_Impl::addModule
(
const OUString& LibraryName,
const OUString& ModuleName,
- const OUString& Language,
+ const OUString&,
const OUString& Source
)
{
- (void)Language;
StarBASIC* pLib = mpMgr->GetLib( LibraryName );
DBG_ASSERT( pLib, "XML Import: Lib for module unknown");
if( pLib )
@@ -2144,15 +2135,11 @@ void SAL_CALL StarBasicAccess_Impl::addModule
void SAL_CALL StarBasicAccess_Impl::addDialog
(
- const OUString& LibraryName,
- const OUString& DialogName,
- const uno::Sequence< sal_Int8 >& Data
+ const OUString&,
+ const OUString&,
+ const uno::Sequence< sal_Int8 >&
)
-{
- (void)LibraryName;
- (void)DialogName;
- (void)Data;
-}
+{}
// Basic XML Import/Export
uno::Reference< script::XStarBasicAccess > getStarBasicAccess( BasicManager* pMgr )
diff --git a/basic/source/classes/eventatt.cxx b/basic/source/classes/eventatt.cxx
index 1eb725e0c176..bd81d108cfb6 100644
--- a/basic/source/classes/eventatt.cxx
+++ b/basic/source/classes/eventatt.cxx
@@ -401,11 +401,8 @@ css::uno::Reference< css::container::XNameContainer > implFindDialogLibForDialog
return aDlgLib;
}
-void RTL_Impl_CreateUnoDialog( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreateUnoDialog( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
Reference< XComponentContext > xContext( comphelper::getProcessComponentContext() );
// We need at least 1 parameter
diff --git a/basic/source/classes/propacc.cxx b/basic/source/classes/propacc.cxx
index 1dc958879ddf..0e9cd5e5298c 100644
--- a/basic/source/classes/propacc.cxx
+++ b/basic/source/classes/propacc.cxx
@@ -112,35 +112,27 @@ Any SbPropertyValues::getPropertyValue(
void SbPropertyValues::addPropertyChangeListener(
- const OUString& aPropertyName,
+ const OUString&,
const Reference< XPropertyChangeListener >& )
-{
- (void)aPropertyName;
-}
+{}
void SbPropertyValues::removePropertyChangeListener(
- const OUString& aPropertyName,
+ const OUString&,
const Reference< XPropertyChangeListener >& )
-{
- (void)aPropertyName;
-}
+{}
void SbPropertyValues::addVetoableChangeListener(
- const OUString& aPropertyName,
+ const OUString&,
const Reference< XVetoableChangeListener >& )
-{
- (void)aPropertyName;
-}
+{}
void SbPropertyValues::removeVetoableChangeListener(
- const OUString& aPropertyName,
+ const OUString&,
const Reference< XVetoableChangeListener >& )
-{
- (void)aPropertyName;
-}
+{}
Sequence< PropertyValue > SbPropertyValues::getPropertyValues()
@@ -162,11 +154,8 @@ void SbPropertyValues::setPropertyValues(const Sequence< PropertyValue >& rPrope
}
-void RTL_Impl_CreatePropertySet( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreatePropertySet( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need at least one parameter
// TODO: In this case < 2 is not correct ;-)
if ( rPar.Count() < 2 )
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index bc70879aecea..0a74cf022eea 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -2902,11 +2902,8 @@ void createAllObjectProperties( SbxObject* pObj )
}
-void RTL_Impl_CreateUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreateUnoStruct( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need 1 parameter minimum
if ( rPar.Count() < 2 )
{
@@ -2928,11 +2925,8 @@ void RTL_Impl_CreateUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
refVar->PutObject( xUnoObj.get() );
}
-void RTL_Impl_CreateUnoService( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreateUnoService( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need 1 Parameter minimum
if ( rPar.Count() < 2 )
{
@@ -2976,11 +2970,8 @@ void RTL_Impl_CreateUnoService( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
}
}
-void RTL_Impl_CreateUnoServiceWithArguments( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreateUnoServiceWithArguments( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need 2 parameter minimum
if ( rPar.Count() < 3 )
{
@@ -3028,11 +3019,8 @@ void RTL_Impl_CreateUnoServiceWithArguments( StarBASIC* pBasic, SbxArray& rPar,
}
}
-void RTL_Impl_GetProcessServiceManager( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_GetProcessServiceManager( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
SbxVariableRef refVar = rPar.Get(0);
// get the global service manager
@@ -3043,11 +3031,8 @@ void RTL_Impl_GetProcessServiceManager( StarBASIC* pBasic, SbxArray& rPar, bool
refVar->PutObject( xUnoObj.get() );
}
-void RTL_Impl_HasInterfaces( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_HasInterfaces( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need 2 parameter minimum
sal_uInt16 nParCount = rPar.Count();
if( nParCount < 3 )
@@ -3104,11 +3089,8 @@ void RTL_Impl_HasInterfaces( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
refVar->PutBool( true );
}
-void RTL_Impl_IsUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_IsUnoStruct( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// We need 1 parameter minimum
if ( rPar.Count() < 2 )
{
@@ -3141,11 +3123,8 @@ void RTL_Impl_IsUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
}
-void RTL_Impl_EqualUnoObjects( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_EqualUnoObjects( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
if ( rPar.Count() < 3 )
{
StarBASIC::Error( ERRCODE_BASIC_BAD_ARGUMENT );
@@ -3963,11 +3942,8 @@ Reference< XIntrospectionAccess > SAL_CALL InvocationToAllListenerMapper::getInt
Any SAL_CALL InvocationToAllListenerMapper::invoke(const OUString& FunctionName, const Sequence< Any >& Params,
- Sequence< sal_Int16 >& OutParamIndex, Sequence< Any >& OutParam)
+ Sequence< sal_Int16 >&, Sequence< Any >&)
{
- (void)OutParamIndex;
- (void)OutParam ;
-
Any aRet;
// Check if to firing or approveFiring has to be called
@@ -4014,17 +3990,12 @@ Any SAL_CALL InvocationToAllListenerMapper::invoke(const OUString& FunctionName,
}
-void SAL_CALL InvocationToAllListenerMapper::setValue(const OUString& PropertyName, const Any& Value)
-{
- (void)PropertyName;
- (void)Value;
-}
+void SAL_CALL InvocationToAllListenerMapper::setValue(const OUString&, const Any&)
+{}
-Any SAL_CALL InvocationToAllListenerMapper::getValue(const OUString& PropertyName)
+Any SAL_CALL InvocationToAllListenerMapper::getValue(const OUString&)
{
- (void)PropertyName;
-
return Any();
}
@@ -4107,11 +4078,8 @@ RTLFUNC(CreateUnoListener)
// Represents the DefaultContext property of the ProcessServiceManager
// in the Basic runtime system.
-void RTL_Impl_GetDefaultContext( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_GetDefaultContext( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
SbxVariableRef refVar = rPar.Get(0);
Any aContextAny( comphelper::getProcessComponentContext() );
@@ -4123,11 +4091,8 @@ void RTL_Impl_GetDefaultContext( StarBASIC* pBasic, SbxArray& rPar, bool bWrite
// Creates a Basic wrapper object for a strongly typed Uno value
// 1. parameter: Uno type as full qualified type name, e.g. "byte[]"
-void RTL_Impl_CreateUnoValue( StarBASIC* pBasic, SbxArray& rPar, bool bWrite )
+void RTL_Impl_CreateUnoValue( SbxArray& rPar )
{
- (void)pBasic;
- (void)bWrite;
-
// 2 parameters needed
if ( rPar.Count() != 3 )
{
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index d56894fffe3d..61e1cfd7da6e 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -1344,8 +1344,6 @@ void SbModule::implClearIfVarDependsOnDeletedBasic( SbxVariable* pVar, StarBASIC
void SbModule::ClearVarsDependingOnDeletedBasic( StarBASIC* pDeletedBasic )
{
- (void)pDeletedBasic;
-
for( sal_uInt16 i = 0 ; i < pProps->Count() ; i++ )
{
SbProperty* p = dynamic_cast<SbProperty*>( pProps->Get( i ) );
@@ -1915,10 +1913,8 @@ SbJScriptModule::SbJScriptModule()
{
}
-bool SbJScriptModule::LoadData( SvStream& rStrm, sal_uInt16 nVer )
+bool SbJScriptModule::LoadData( SvStream& rStrm, sal_uInt16 )
{
- (void)nVer;
-
Clear();
if( !SbxObject::LoadData( rStrm, 1 ) )
return false;
diff --git a/basic/source/comp/dim.cxx b/basic/source/comp/dim.cxx
index a5d5380a53ed..73862b3bf26a 100644
--- a/basic/source/comp/dim.cxx
+++ b/basic/source/comp/dim.cxx
@@ -271,7 +271,7 @@ void SbiParser::DefVar( SbiOpcode eOp, bool bStatic )
else if( eCurTok == TYPE )
{
Next();
- DefType( bPrivate );
+ DefType(); // TODO: Use bPrivate in DefType()
return;
}
}
@@ -562,14 +562,11 @@ void SbiParser::Erase()
void SbiParser::Type()
{
- DefType( false );
+ DefType();
}
-void SbiParser::DefType( bool bPrivate )
+void SbiParser::DefType()
{
- // TODO: Use bPrivate
- (void)bPrivate;
-
// Read the new Token lesen. It had to be a symbol
if (!TestSymbol())
return;
diff --git a/basic/source/inc/eventatt.hxx b/basic/source/inc/eventatt.hxx
index 881290814787..fbe0104db00f 100644
--- a/basic/source/inc/eventatt.hxx
+++ b/basic/source/inc/eventatt.hxx
@@ -23,12 +23,11 @@
#include <sal/config.h>
class SbxArray;
-class StarBASIC;
// Instantiate "com.sun.star.awt.UnoControlDialog" on basis
// of a DialogLibrary entry: Convert from XML-ByteSequence
// and attach events.
-void RTL_Impl_CreateUnoDialog( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
+void RTL_Impl_CreateUnoDialog( SbxArray& rPar );
#endif
diff --git a/basic/source/inc/parser.hxx b/basic/source/inc/parser.hxx
index a2138283bb22..4ff5baf83518 100644
--- a/basic/source/inc/parser.hxx
+++ b/basic/source/inc/parser.hxx
@@ -54,7 +54,7 @@ class SbiParser : public SbiTokenizer
void CloseBlock();
bool Channel( bool bAlways=false ); // parse channel number
void StmntBlock( SbiToken );
- void DefType( bool bPrivate ); // Parse type declaration
+ void DefType(); // Parse type declaration
void DefEnum( bool bPrivate ); // Parse enum declaration
void DefDeclare( bool bPrivate );
void EnableCompatibility();
diff --git a/basic/source/inc/propacc.hxx b/basic/source/inc/propacc.hxx
index e1fd4802ce12..0e174b2ef713 100644
--- a/basic/source/inc/propacc.hxx
+++ b/basic/source/inc/propacc.hxx
@@ -71,10 +71,9 @@ public:
virtual void SAL_CALL setPropertyValues(const css::uno::Sequence< css::beans::PropertyValue >& PropertyValues_) override;
};
-class StarBASIC;
class SbxArray;
-void RTL_Impl_CreatePropertySet( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
+void RTL_Impl_CreatePropertySet( SbxArray& rPar );
#endif
diff --git a/basic/source/inc/sbunoobj.hxx b/basic/source/inc/sbunoobj.hxx
index a707d72a1d1e..bbb8f08f42cd 100644
--- a/basic/source/inc/sbunoobj.hxx
+++ b/basic/source/inc/sbunoobj.hxx
@@ -327,15 +327,15 @@ public:
class StarBASIC;
// Impl-methods for RTL
-void RTL_Impl_CreateUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_CreateUnoService( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_CreateUnoServiceWithArguments( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_CreateUnoValue( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_GetProcessServiceManager( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_HasInterfaces( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_IsUnoStruct( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_EqualUnoObjects( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
-void RTL_Impl_GetDefaultContext( StarBASIC* pBasic, SbxArray& rPar, bool bWrite );
+void RTL_Impl_CreateUnoStruct( SbxArray& rPar );
+void RTL_Impl_CreateUnoService( SbxArray& rPar );
+void RTL_Impl_CreateUnoServiceWithArguments( SbxArray& rPar );
+void RTL_Impl_CreateUnoValue( SbxArray& rPar );
+void RTL_Impl_GetProcessServiceManager( SbxArray& rPar );
+void RTL_Impl_HasInterfaces( SbxArray& rPar );
+void RTL_Impl_IsUnoStruct( SbxArray& rPar );
+void RTL_Impl_EqualUnoObjects( SbxArray& rPar );
+void RTL_Impl_GetDefaultContext( SbxArray& rPar );
void disposeComVariablesForBasic( StarBASIC* pBasic );
void clearNativeObjectWrapperVector();
diff --git a/basic/source/runtime/iosys.cxx b/basic/source/runtime/iosys.cxx
index dce5777e14af..11c2806a4632 100644
--- a/basic/source/runtime/iosys.cxx
+++ b/basic/source/runtime/iosys.cxx
@@ -438,10 +438,8 @@ void UCBStream::FlushData()
}
}
-void UCBStream::SetSize( sal_uInt64 nSize )
+void UCBStream::SetSize( sal_uInt64 )
{
- (void)nSize;
-
SAL_WARN("basic", "UCBStream::SetSize not allowed to call from basic" );
SetError( ERRCODE_IO_GENERAL );
}
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index 1ca9282f5468..aca8c7be6ae7 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -608,9 +608,6 @@ RTLFUNC(Kill)
RTLFUNC(MkDir)
{
- (void)pBasic;
- (void)bWrite;
-
rPar.Get(0)->PutEmpty();
if (rPar.Count() == 2)
{
@@ -1182,7 +1179,6 @@ RTLFUNC(LTrim)
RTLFUNC(Mid)
{
(void)pBasic;
- (void)bWrite;
int nArgCount = rPar.Count()-1;
if ( nArgCount < 2 )
@@ -1450,7 +1446,6 @@ RTLFUNC(Right)
RTLFUNC(RTL)
{
- (void)pBasic;
(void)bWrite;
rPar.Get( 0 )->PutObject( pBasic->getRTL().get() );
@@ -2521,7 +2516,6 @@ RTLFUNC(Timer)
RTLFUNC(Date)
{
(void)pBasic;
- (void)bWrite;
if ( !bWrite )
{
@@ -4735,7 +4729,6 @@ RTLFUNC(Reset)
RTLFUNC(DumpAllObjects)
{
- (void)pBasic;
(void)bWrite;
sal_uInt16 nArgCount = rPar.Count();
diff --git a/basic/source/runtime/methods1.cxx b/basic/source/runtime/methods1.cxx
index d6badbf225c9..4344dfaacf17 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -670,7 +670,6 @@ RTLFUNC(DoEvents)
{
(void)pBasic;
(void)bWrite;
- (void)rPar;
// don't understand what upstream are up to
// we already process application events etc. in between
// basic runtime pcode ( on a timed basis )
@@ -1084,11 +1083,8 @@ static bool lcl_WriteSbxVariable( const SbxVariable& rVar, SvStream* pStrm,
}
static bool lcl_ReadSbxVariable( SbxVariable& rVar, SvStream* pStrm,
- bool bBinary, short nBlockLen, bool bIsArray )
+ bool bBinary, short nBlockLen )
{
- (void)bBinary;
- (void)bIsArray;
-
double aDouble;
sal_uInt64 const nFPos = pStrm->Tell();
@@ -1215,7 +1211,7 @@ static bool lcl_WriteReadSbxArray( SbxDimArray& rArr, SvStream* pStrm,
if( bWrite )
bRet = lcl_WriteSbxVariable(*pVar, pStrm, bBinary, 0, true );
else
- bRet = lcl_ReadSbxVariable(*pVar, pStrm, bBinary, 0, true );
+ bRet = lcl_ReadSbxVariable(*pVar, pStrm, bBinary, 0 );
if( !bRet )
return false;
}
@@ -1292,7 +1288,7 @@ void PutGet( SbxArray& rPar, bool bPut )
if( bPut )
bRet = lcl_WriteSbxVariable(*pVar, pStrm, !bRandom, nBlockLen, false);
else
- bRet = lcl_ReadSbxVariable(*pVar, pStrm, !bRandom, nBlockLen, false);
+ bRet = lcl_ReadSbxVariable(*pVar, pStrm, !bRandom, nBlockLen);
}
if( !bRet || pStrm->GetErrorCode() )
StarBASIC::Error( ERRCODE_BASIC_IO_ERROR );
@@ -1532,7 +1528,7 @@ RTLFUNC(CreateUnoStruct)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreateUnoStruct( pBasic, rPar, bWrite );
+ RTL_Impl_CreateUnoStruct( rPar );
}
@@ -1542,7 +1538,7 @@ RTLFUNC(CreateUnoService)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreateUnoService( pBasic, rPar, bWrite );
+ RTL_Impl_CreateUnoService( rPar );
}
RTLFUNC(CreateUnoServiceWithArguments)
@@ -1550,7 +1546,7 @@ RTLFUNC(CreateUnoServiceWithArguments)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreateUnoServiceWithArguments( pBasic, rPar, bWrite );
+ RTL_Impl_CreateUnoServiceWithArguments( rPar );
}
@@ -1559,7 +1555,7 @@ RTLFUNC(CreateUnoValue)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreateUnoValue( pBasic, rPar, bWrite );
+ RTL_Impl_CreateUnoValue( rPar );
}
@@ -1569,7 +1565,7 @@ RTLFUNC(GetProcessServiceManager)
(void)pBasic;
(void)bWrite;
- RTL_Impl_GetProcessServiceManager( pBasic, rPar, bWrite );
+ RTL_Impl_GetProcessServiceManager( rPar );
}
@@ -1579,7 +1575,7 @@ RTLFUNC(CreatePropertySet)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreatePropertySet( pBasic, rPar, bWrite );
+ RTL_Impl_CreatePropertySet( rPar );
}
@@ -1589,7 +1585,7 @@ RTLFUNC(HasUnoInterfaces)
(void)pBasic;
(void)bWrite;
- RTL_Impl_HasInterfaces( pBasic, rPar, bWrite );
+ RTL_Impl_HasInterfaces( rPar );
}
@@ -1598,7 +1594,7 @@ RTLFUNC(IsUnoStruct)
(void)pBasic;
(void)bWrite;
- RTL_Impl_IsUnoStruct( pBasic, rPar, bWrite );
+ RTL_Impl_IsUnoStruct( rPar );
}
@@ -1607,7 +1603,7 @@ RTLFUNC(EqualUnoObjects)
(void)pBasic;
(void)bWrite;
- RTL_Impl_EqualUnoObjects( pBasic, rPar, bWrite );
+ RTL_Impl_EqualUnoObjects( rPar );
}
RTLFUNC(CreateUnoDialog)
@@ -1615,13 +1611,12 @@ RTLFUNC(CreateUnoDialog)
(void)pBasic;
(void)bWrite;
- RTL_Impl_CreateUnoDialog( pBasic, rPar, bWrite );
+ RTL_Impl_CreateUnoDialog( rPar );
}
// Return the application standard lib as root scope
RTLFUNC(GlobalScope)
{
- (void)pBasic;
(void)bWrite;
SbxObject* p = pBasic;
@@ -1689,7 +1684,7 @@ RTLFUNC(GetDefaultContext)
(void)pBasic;
(void)bWrite;
- RTL_Impl_GetDefaultContext( pBasic, rPar, bWrite );
+ RTL_Impl_GetDefaultContext( rPar );
}
RTLFUNC(Join)
diff --git a/basic/source/runtime/props.cxx b/basic/source/runtime/props.cxx
index ce994947389e..7c77a34ceb0d 100644
--- a/basic/source/runtime/props.cxx
+++ b/basic/source/runtime/props.cxx
@@ -40,7 +40,6 @@ RTLFUNC(Erl)
RTLFUNC(Err)
{
(void)pBasic;
- (void)bWrite;
if( SbiRuntime::isVBAEnabled() )
{
diff --git a/basic/source/runtime/stdobj1.cxx b/basic/source/runtime/stdobj1.cxx
index 861617b7df77..d0dedad8961f 100644
--- a/basic/source/runtime/stdobj1.cxx
+++ b/basic/source/runtime/stdobj1.cxx
@@ -287,10 +287,8 @@ void SbStdClipboard::MethClear( SbxVariable*, SbxArray* pPar_, bool )
}
-void SbStdClipboard::MethGetData( SbxVariable* pVar, SbxArray* pPar_, bool )
+void SbStdClipboard::MethGetData( SbxArray* pPar_, bool )
{
- (void)pVar;
-
if( !pPar_ || (pPar_->Count() != 2) )
{
StarBASIC::Error( ERRCODE_BASIC_BAD_NUMBER_OF_ARGS );
@@ -335,10 +333,8 @@ void SbStdClipboard::MethGetText( SbxVariable* pVar, SbxArray* pPar_, bool )
pVar->PutString( OUString() );
}
-void SbStdClipboard::MethSetData( SbxVariable* pVar, SbxArray* pPar_, bool )
+void SbStdClipboard::MethSetData( SbxArray* pPar_, bool )
{
- (void)pVar;
-
if( !pPar_ || (pPar_->Count() != 3) )
{
StarBASIC::Error( ERRCODE_BASIC_BAD_NUMBER_OF_ARGS );
@@ -354,10 +350,8 @@ void SbStdClipboard::MethSetData( SbxVariable* pVar, SbxArray* pPar_, bool )
}
-void SbStdClipboard::MethSetText( SbxVariable* pVar, SbxArray* pPar_, bool )
+void SbStdClipboard::MethSetText( SbxArray* pPar_, bool )
{
- (void)pVar;
-
if( !pPar_ || (pPar_->Count() != 2) )
{
StarBASIC::Error( ERRCODE_BASIC_BAD_NUMBER_OF_ARGS );
@@ -420,11 +414,11 @@ void SbStdClipboard::Notify( SfxBroadcaster& rBC, const SfxHint& rHint )
switch( nWhich )
{
case METH_CLEAR: MethClear( pVar, pPar_, bWrite ); return;
- case METH_GETDATA: MethGetData( pVar, pPar_, bWrite ); return;
+ case METH_GETDATA: MethGetData( pPar_, bWrite ); return;
case METH_GETFORMAT: MethGetFormat( pVar, pPar_, bWrite ); return;
case METH_GETTEXT: MethGetText( pVar, pPar_, bWrite ); return;
- case METH_SETDATA: MethSetData( pVar, pPar_, bWrite ); return;
- case METH_SETTEXT: MethSetText( pVar, pPar_, bWrite ); return;
+ case METH_SETDATA: MethSetData( pPar_, bWrite ); return;
+ case METH_SETTEXT: MethSetText( pPar_, bWrite ); return;
}
SbxObject::Notify( rBC, rHint );
diff --git a/basic/source/sbx/sbxdec.cxx b/basic/source/sbx/sbxdec.cxx
index d429ea9ca433..b0b7381a39eb 100644
--- a/basic/source/sbx/sbxdec.cxx
+++ b/basic/source/sbx/sbxdec.cxx
@@ -290,27 +290,23 @@ bool SbxDecimal::getDouble( double& rVal )
#else
// !WIN32
-bool SbxDecimal::operator -= ( const SbxDecimal &r )
+bool SbxDecimal::operator -= ( const SbxDecimal & )
{
- (void)r;
return false;
}
-bool SbxDecimal::operator += ( const SbxDecimal &r )
+bool SbxDecimal::operator += ( const SbxDecimal & )
{
- (void)r;
return false;
}
-bool SbxDecimal::operator /= ( const SbxDecimal &r )
+bool SbxDecimal::operator /= ( const SbxDecimal & )
{
- (void)r;
return false;
}
-bool SbxDecimal::operator *= ( const SbxDecimal &r )
+bool SbxDecimal::operator *= ( const SbxDecimal & )
{
- (void)r;
return false;
}
@@ -324,32 +320,30 @@ bool SbxDecimal::isZero()
return false;
}
-SbxDecimal::CmpResult compare( const SbxDecimal &rLeft, const SbxDecimal &rRight )
+SbxDecimal::CmpResult compare( SAL_UNUSED_PARAMETER const SbxDecimal &, SAL_UNUSED_PARAMETER const SbxDecimal & )
{
- (void)rLeft;
- (void)rRight;
return SbxDecimal::CmpResult::LT;
}
-void SbxDecimal::setChar( sal_Unicode val ) { (void)val; }
-void SbxDecimal::setByte( sal_uInt8 val ) { (void)val; }
-void SbxDecimal::setShort( sal_Int16 val ) { (void)val; }
-void SbxDecimal::setLong( sal_Int32 val ) { (void)val; }
-void SbxDecimal::setUShort( sal_uInt16 val ) { (void)val; }
-void SbxDecimal::setULong( sal_uInt32 val ) { (void)val; }
-bool SbxDecimal::setSingle( float val ) { (void)val; return false; }
-bool SbxDecimal::setDouble( double val ) { (void)val; return false; }
-void SbxDecimal::setInt( int val ) { (void)val; }
-void SbxDecimal::setUInt( unsigned int val ) { (void)val; }
-bool SbxDecimal::setString( OUString* pOUString ) { (void)pOUString; return false; }
-
-bool SbxDecimal::getChar( sal_Unicode& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getShort( sal_Int16& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getLong( sal_Int32& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getUShort( sal_uInt16& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getULong( sal_uInt32& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getSingle( float& rVal ) { (void)rVal; return false; }
-bool SbxDecimal::getDouble( double& rVal ) { (void)rVal; return false; }
+void SbxDecimal::setChar( SAL_UNUSED_PARAMETER sal_Unicode ) {}
+void SbxDecimal::setByte( SAL_UNUSED_PARAMETER sal_uInt8 ) {}
+void SbxDecimal::setShort( SAL_UNUSED_PARAMETER sal_Int16 ) {}
+void SbxDecimal::setLong( SAL_UNUSED_PARAMETER sal_Int32 ) {}
+void SbxDecimal::setUShort( SAL_UNUSED_PARAMETER sal_uInt16 ) {}
+void SbxDecimal::setULong( SAL_UNUSED_PARAMETER sal_uInt32 ) {}
+bool SbxDecimal::setSingle( SAL_UNUSED_PARAMETER float ) { return false; }
+bool SbxDecimal::setDouble( SAL_UNUSED_PARAMETER double ) { return false; }
+void SbxDecimal::setInt( SAL_UNUSED_PARAMETER int ) {}
+void SbxDecimal::setUInt( SAL_UNUSED_PARAMETER unsigned int ) {}
+bool SbxDecimal::setString( SAL_UNUSED_PARAMETER OUString* ) { return false; }
+
+bool SbxDecimal::getChar( SAL_UNUSED_PARAMETER sal_Unicode& ) { return false; }
+bool SbxDecimal::getShort( SAL_UNUSED_PARAMETER sal_Int16& ) { return false; }
+bool SbxDecimal::getLong( SAL_UNUSED_PARAMETER sal_Int32& ) { return false; }
+bool SbxDecimal::getUShort( SAL_UNUSED_PARAMETER sal_uInt16& ) { return false; }
+bool SbxDecimal::getULong( SAL_UNUSED_PARAMETER sal_uInt32& ) { return false; }
+bool SbxDecimal::getSingle( SAL_UNUSED_PARAMETER float& ) { return false; }
+bool SbxDecimal::getDouble( SAL_UNUSED_PARAMETER double& ) { return false; }
#endif
diff --git a/basic/source/uno/scriptcont.cxx b/basic/source/uno/scriptcont.cxx
index 44ee7c787244..6f14015a0d9e 100644
--- a/basic/source/uno/scriptcont.cxx
+++ b/basic/source/uno/scriptcont.cxx
@@ -117,19 +117,17 @@ SfxScriptLibraryContainer::SfxScriptLibraryContainer( const uno::Reference< embe
}
// Methods to get library instances of the correct type
-SfxLibrary* SfxScriptLibraryContainer::implCreateLibrary( const OUString& aName )
+SfxLibrary* SfxScriptLibraryContainer::implCreateLibrary( const OUString& )
{
- (void)aName; // Only needed for SfxDialogLibrary
SfxLibrary* pRet = new SfxScriptLibrary( maModifiable, mxSFI );
return pRet;
}
-SfxLibrary* SfxScriptLibraryContainer::implCreateLibraryLink( const OUString& aName,
+SfxLibrary* SfxScriptLibraryContainer::implCreateLibraryLink( const OUString&,
const OUString& aLibInfoFileURL,
const OUString& StorageURL,
bool ReadOnly )
{
- (void)aName; // Only needed for SfxDialogLibrary
SfxLibrary* pRet = new SfxScriptLibrary( maModifiable, mxSFI,
aLibInfoFileURL, StorageURL, ReadOnly );
return pRet;
@@ -1172,25 +1170,18 @@ void SfxScriptLibrary::storeResources()
// No resources
}
-void SfxScriptLibrary::storeResourcesToURL( const OUString& URL,
- const Reference< task::XInteractionHandler >& Handler )
-{
- (void)URL;
- (void)Handler;
-}
+void SfxScriptLibrary::storeResourcesToURL( const OUString&,
+ const Reference< task::XInteractionHandler >& )
+{}
void SfxScriptLibrary::storeResourcesAsURL
- ( const OUString& URL, const OUString& NewName )
-{
- (void)URL;
- (void)NewName;
-}
+ ( const OUString&, const OUString& )
+{}
void SfxScriptLibrary::storeResourcesToStorage( const css::uno::Reference
- < css::embed::XStorage >& xStorage )
+ < css::embed::XStorage >& )
{
// No resources
- (void)xStorage;
}
bool SfxScriptLibrary::containsValidModule(const Any& rElement)
commit aa2b7d55c6f8e1d8390b0e820b1e5586bb5a7d4c
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:35:01 2017 +0200
loplugin:casttovoid: canvas
Change-Id: I2b719ff5fc03a74ba0f657351343462aaa9c7296
diff --git a/canvas/source/tools/verifyinput.cxx b/canvas/source/tools/verifyinput.cxx
index 595d5dd0c6f0..5d9716ef50a6 100644
--- a/canvas/source/tools/verifyinput.cxx
+++ b/canvas/source/tools/verifyinput.cxx
@@ -63,8 +63,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
#if OSL_DEBUG_LEVEL > 0
if( !::rtl::math::isFinite( rPoint.X ) )
{
@@ -80,6 +78,7 @@ namespace canvas
xIf, nArgPos );
}
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
if( !::rtl::math::isFinite( rPoint.X ) ||
!::rtl::math::isFinite( rPoint.Y ) )
{
@@ -93,8 +92,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
#if OSL_DEBUG_LEVEL > 0
if( !::rtl::math::isFinite( rSegment.Px ) )
{
@@ -144,6 +141,7 @@ namespace canvas
xIf, nArgPos );
}
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
if( !::rtl::math::isFinite( rSegment.Px ) ||
!::rtl::math::isFinite( rSegment.Py ) ||
!::rtl::math::isFinite( rSegment.C1x ) ||
@@ -161,8 +159,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
#if OSL_DEBUG_LEVEL > 0
if( !::rtl::math::isFinite( rRect.X1 ) )
{
@@ -196,6 +192,7 @@ namespace canvas
xIf, nArgPos );
}
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
if( !::rtl::math::isFinite( rRect.X1 ) ||
!::rtl::math::isFinite( rRect.Y1 ) ||
!::rtl::math::isFinite( rRect.X2 ) ||
@@ -211,8 +208,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
#if OSL_DEBUG_LEVEL > 0
const sal_Int32 nBinaryState(
100000 * int(!::rtl::math::isFinite( matrix.m00 )) +
@@ -231,6 +226,7 @@ namespace canvas
xIf, nArgPos );
}
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
if( !::rtl::math::isFinite( matrix.m00 ) ||
!::rtl::math::isFinite( matrix.m01 ) ||
!::rtl::math::isFinite( matrix.m02 ) ||
@@ -248,8 +244,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
#if OSL_DEBUG_LEVEL > 0
const sal_Int32 nBinaryState(
1000 * int(!::rtl::math::isFinite( matrix.m00 )) +
@@ -266,6 +260,7 @@ namespace canvas
xIf, nArgPos );
}
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
if( !::rtl::math::isFinite( matrix.m00 ) ||
!::rtl::math::isFinite( matrix.m01 ) ||
!::rtl::math::isFinite( matrix.m10 ) ||
@@ -519,8 +514,6 @@ namespace canvas
const uno::Reference< uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
if( bitmapLayout.ScanLines < 0 )
{
#if OSL_DEBUG_LEVEL > 0
@@ -529,6 +522,7 @@ namespace canvas
": verifyInput(): bitmap layout's ScanLines is negative",
xIf, nArgPos );
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
throw lang::IllegalArgumentException();
#endif
}
@@ -674,8 +668,6 @@ namespace canvas
const char* pStr,
const uno::Reference< uno::XInterface >& xIf )
{
- (void)pStr; (void)xIf;
-
if( size.Width <= 0 )
{
#if OSL_DEBUG_LEVEL > 0
@@ -685,6 +677,7 @@ namespace canvas
OUString::number(size.Width) + ")",
xIf, 0 );
#else
+ (void)pStr; (void)xIf;
throw lang::IllegalArgumentException();
#endif
}
@@ -708,8 +701,6 @@ namespace canvas
const char* pStr,
const uno::Reference< uno::XInterface >& xIf )
{
- (void)pStr; (void)xIf;
-
if( size.Width <= 0.0 )
{
#if OSL_DEBUG_LEVEL > 0
@@ -719,6 +710,7 @@ namespace canvas
OUString::number(size.Width) + ")",
xIf, 0 );
#else
+ (void)pStr; (void)xIf;
throw lang::IllegalArgumentException();
#endif
}
diff --git a/canvas/source/vcl/canvasfont.cxx b/canvas/source/vcl/canvasfont.cxx
index 94798710f829..2f1dabfe8216 100644
--- a/canvas/source/vcl/canvasfont.cxx
+++ b/canvas/source/vcl/canvasfont.cxx
@@ -92,7 +92,7 @@ namespace vclcanvas
mpRefDevice.clear();
}
- uno::Reference< rendering::XTextLayout > SAL_CALL CanvasFont::createTextLayout( const rendering::StringContext& aText, sal_Int8 nDirection, sal_Int64 nRandomSeed )
+ uno::Reference< rendering::XTextLayout > SAL_CALL CanvasFont::createTextLayout( const rendering::StringContext& aText, sal_Int8 nDirection, sal_Int64 )
{
SolarMutexGuard aGuard;
@@ -101,7 +101,6 @@ namespace vclcanvas
return new TextLayout( aText,
nDirection,
- nRandomSeed,
Reference( this ),
mpRefDevice,
mpOutDevProvider);
diff --git a/canvas/source/vcl/textlayout.cxx b/canvas/source/vcl/textlayout.cxx
index 03f2fbaebd24..1a52371029a4 100644
--- a/canvas/source/vcl/textlayout.cxx
+++ b/canvas/source/vcl/textlayout.cxx
@@ -74,7 +74,6 @@ namespace vclcanvas
TextLayout::TextLayout( const rendering::StringContext& aText,
sal_Int8 nDirection,
- sal_Int64 nRandomSeed,
const CanvasFont::Reference& rFont,
const uno::Reference<rendering::XGraphicDevice>& xDevice,
const OutDevProviderSharedPtr& rOutDev ) :
@@ -85,9 +84,7 @@ namespace vclcanvas
mxDevice( xDevice ),
mpOutDevProvider( rOutDev ),
mnTextDirection( nDirection )
- {
- (void)nRandomSeed;
- }
+ {}
void SAL_CALL TextLayout::disposing()
{
@@ -262,65 +259,45 @@ namespace vclcanvas
}
}
- double SAL_CALL TextLayout::justify( double nSize )
+ double SAL_CALL TextLayout::justify( double )
{
- (void)nSize;
-
// TODO(F1)
return 0.0;
}
- double SAL_CALL TextLayout::combinedJustify( const uno::Sequence< uno::Reference< rendering::XTextLayout > >& aNextLayouts,
- double nSize )
+ double SAL_CALL TextLayout::combinedJustify( const uno::Sequence< uno::Reference< rendering::XTextLayout > >&,
+ double )
{
- (void)aNextLayouts;
- (void)nSize;
-
// TODO(F1)
return 0.0;
}
- rendering::TextHit SAL_CALL TextLayout::getTextHit( const geometry::RealPoint2D& aHitPoint )
+ rendering::TextHit SAL_CALL TextLayout::getTextHit( const geometry::RealPoint2D& )
{
- (void)aHitPoint;
-
// TODO(F1)
return rendering::TextHit();
}
- rendering::Caret SAL_CALL TextLayout::getCaret( sal_Int32 nInsertionIndex, sal_Bool bExcludeLigatures )
+ rendering::Caret SAL_CALL TextLayout::getCaret( sal_Int32, sal_Bool )
{
- (void)nInsertionIndex;
- (void)bExcludeLigatures;
-
// TODO(F1)
return rendering::Caret();
}
- sal_Int32 SAL_CALL TextLayout::getNextInsertionIndex( sal_Int32 nStartIndex, sal_Int32 nCaretAdvancement, sal_Bool bExcludeLigatures )
+ sal_Int32 SAL_CALL TextLayout::getNextInsertionIndex( sal_Int32, sal_Int32, sal_Bool )
{
- (void)nStartIndex;
- (void)nCaretAdvancement;
- (void)bExcludeLigatures;
-
// TODO(F1)
return 0;
}
- uno::Reference< rendering::XPolyPolygon2D > SAL_CALL TextLayout::queryVisualHighlighting( sal_Int32 nStartIndex, sal_Int32 nEndIndex )
+ uno::Reference< rendering::XPolyPolygon2D > SAL_CALL TextLayout::queryVisualHighlighting( sal_Int32, sal_Int32 )
{
- (void)nStartIndex;
- (void)nEndIndex;
-
// TODO(F1)
return uno::Reference< rendering::XPolyPolygon2D >();
}
- uno::Reference< rendering::XPolyPolygon2D > SAL_CALL TextLayout::queryLogicalHighlighting( sal_Int32 nStartIndex, sal_Int32 nEndIndex )
+ uno::Reference< rendering::XPolyPolygon2D > SAL_CALL TextLayout::queryLogicalHighlighting( sal_Int32, sal_Int32 )
{
- (void)nStartIndex;
- (void)nEndIndex;
-
// TODO(F1)
return uno::Reference< rendering::XPolyPolygon2D >();
}
diff --git a/canvas/source/vcl/textlayout.hxx b/canvas/source/vcl/textlayout.hxx
index 9994ac70ff6d..e6a661331101 100644
--- a/canvas/source/vcl/textlayout.hxx
+++ b/canvas/source/vcl/textlayout.hxx
@@ -50,7 +50,6 @@ namespace vclcanvas
TextLayout( const css::rendering::StringContext& aText,
sal_Int8 nDirection,
- sal_Int64 nRandomSeed,
const CanvasFont::Reference& rFont,
const css::uno::Reference<
css::rendering::XGraphicDevice>& xDevice,
diff --git a/include/canvas/verifyinput.hxx b/include/canvas/verifyinput.hxx
index d8e95ac5f9a1..067083d436af 100644
--- a/include/canvas/verifyinput.hxx
+++ b/include/canvas/verifyinput.hxx
@@ -352,8 +352,6 @@ namespace canvas
const css::uno::Reference< css::uno::XInterface >& xIf,
::sal_Int16 nArgPos )
{
- (void)pStr; (void)xIf; (void)nArgPos;
-
if( !rRef.is() )
{
#if OSL_DEBUG_LEVEL > 0
@@ -362,6 +360,7 @@ namespace canvas
xIf,
nArgPos );
#else
+ (void)pStr; (void)xIf; (void)nArgPos;
throw css::lang::IllegalArgumentException();
#endif
}
commit 88b4ec9afb1e5f7864b570beef1cd3e62a191942
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:34:55 2017 +0200
loplugin:casttovoid: chart2
Change-Id: I63a2429860bf0ac3d80a8a43bcbde8b8f00f533f
diff --git a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
index 3d4f789169d7..e1d872866b21 100644
--- a/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
+++ b/chart2/source/controller/chartapiwrapper/ChartDocumentWrapper.cxx
@@ -1351,7 +1351,6 @@ uno::Reference< uno::XInterface > SAL_CALL ChartDocumentWrapper::createInstanceW
const uno::Sequence< uno::Any >& Arguments )
{
OSL_ENSURE( Arguments.getLength(), "createInstanceWithArguments: Warning: Arguments are ignored" );
- (void)(Arguments);
return createInstance( ServiceSpecifier );
}
diff --git a/chart2/source/controller/dialogs/DataBrowserModel.cxx b/chart2/source/controller/dialogs/DataBrowserModel.cxx
index 875137f1f576..f1d4c9dccf2d 100644
--- a/chart2/source/controller/dialogs/DataBrowserModel.cxx
+++ b/chart2/source/controller/dialogs/DataBrowserModel.cxx
@@ -686,9 +686,8 @@ bool DataBrowserModel::setCellAny( sal_Int32 nAtColumn, sal_Int32 nAtRow, const
if( xModifiable.is() )
xModifiable->setModified(true);
}
- catch( const uno::Exception & ex )
+ catch( const uno::Exception & )
{
- (void)(ex);
bResult = false;
}
}
@@ -899,10 +898,7 @@ void DataBrowserModel::updateFromModel()
Reference< beans::XPropertySet > xProp( aCooSysSeq[nCooSysIdx], uno::UNO_QUERY );
xProp->getPropertyValue( "SwapXAndYAxis" ) >>= bSwapXAndYAxis;
}
- catch( const beans::UnknownPropertyException & ex )
- {
- (void)ex;
- }
+ catch( const beans::UnknownPropertyException & ) {}
// add ranges for error bars if present for a series
if( StatisticsHelper::usesErrorBarRanges( aSeries[nSeriesIdx] ))
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx b/chart2/source/controller/main/DrawCommandDispatch.cxx
index 9c328a0887de..2fb5b4863051 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -279,8 +279,6 @@ FeatureState DrawCommandDispatch::getState( const OUString& rCommand )
void DrawCommandDispatch::execute( const OUString& rCommand, const Sequence< beans::PropertyValue>& rArgs )
{
- (void)rArgs;
-
ChartDrawMode eDrawMode = CHARTDRAW_SELECT;
SdrObjKind eKind = OBJ_NONE;
diff --git a/chart2/source/controller/main/ShapeController.cxx b/chart2/source/controller/main/ShapeController.cxx
index 5404eb6df464..792e6f627687 100644
--- a/chart2/source/controller/main/ShapeController.cxx
+++ b/chart2/source/controller/main/ShapeController.cxx
@@ -141,10 +141,8 @@ FeatureState ShapeController::getState( const OUString& rCommand )
return aReturn;
}
-void ShapeController::execute( const OUString& rCommand, const Sequence< beans::PropertyValue>& rArgs )
+void ShapeController::execute( const OUString& rCommand, const Sequence< beans::PropertyValue>& )
{
- (void)rArgs;
-
SupportedFeatures::const_iterator aIter = m_aSupportedFeatures.find( rCommand );
if ( aIter != m_aSupportedFeatures.end() )
{
diff --git a/chart2/source/model/main/Axis.cxx b/chart2/source/model/main/Axis.cxx
index 69ac5871f21e..c76ef479dd6a 100644
--- a/chart2/source/model/main/Axis.cxx
+++ b/chart2/source/model/main/Axis.cxx
@@ -332,7 +332,6 @@ void lcl_CloneSubGrids(
++pDestIt;
}
OSL_ASSERT( pDestIt == pDestEnd );
- (void)(pDestEnd); // avoid warning
}
} // anonymous namespace
diff --git a/chart2/source/model/main/ChartModel.cxx b/chart2/source/model/main/ChartModel.cxx
index 9aaf10fdd46e..c3ebd9d794b4 100644
--- a/chart2/source/model/main/ChartModel.cxx
+++ b/chart2/source/model/main/ChartModel.cxx
@@ -1011,7 +1011,6 @@ awt::Size SAL_CALL ChartModel::getVisualAreaSize( ::sal_Int64 nAspect )
{
OSL_ENSURE( nAspect == embed::Aspects::MSOLE_CONTENT,
"No aspects other than content are supported" );
- (void)(nAspect); // avoid warning in non-debug builds
// other possible aspects are MSOLE_THUMBNAIL, MSOLE_ICON and MSOLE_DOCPRINT
return m_aVisualAreaSize;
@@ -1021,7 +1020,6 @@ embed::VisualRepresentation SAL_CALL ChartModel::getPreferredVisualRepresentatio
{
OSL_ENSURE( nAspect == embed::Aspects::MSOLE_CONTENT,
"No aspects other than content are supported" );
- (void)(nAspect); // avoid warning in non-debug builds
embed::VisualRepresentation aResult;
@@ -1059,7 +1057,6 @@ embed::VisualRepresentation SAL_CALL ChartModel::getPreferredVisualRepresentatio
{
OSL_ENSURE( nAspect == embed::Aspects::MSOLE_CONTENT,
"No aspects other than content are supported" );
- (void)(nAspect); // avoid warning in non-debug builds
return embed::EmbedMapUnits::ONE_100TH_MM;
}
@@ -1194,7 +1191,6 @@ Reference< uno::XInterface > SAL_CALL ChartModel::createInstanceWithArguments(
const OUString& rServiceSpecifier , const Sequence< Any >& Arguments )
{
OSL_ENSURE( Arguments.getLength(), "createInstanceWithArguments: Warning: Arguments are ignored" );
- (void)(Arguments); // avoid warning in non-debug builds
return createInstance( rServiceSpecifier );
}
diff --git a/chart2/source/model/main/UndoManager.cxx b/chart2/source/model/main/UndoManager.cxx
index ab6ed77744ef..7e5894b012cb 100644
--- a/chart2/source/model/main/UndoManager.cxx
+++ b/chart2/source/model/main/UndoManager.cxx
@@ -322,10 +322,9 @@ namespace chart
return *&m_pImpl->getParent();
}
- void SAL_CALL UndoManager::setParent( const Reference< XInterface >& i_parent )
+ void SAL_CALL UndoManager::setParent( const Reference< XInterface >& )
{
UndoManagerMethodGuard aGuard( *m_pImpl );
- (void)i_parent;
throw NoSupportException( OUString(), m_pImpl->getThis() );
}
diff --git a/chart2/source/tools/DiagramHelper.cxx b/chart2/source/tools/DiagramHelper.cxx
index ff2004b8c899..12f53fedc294 100644
--- a/chart2/source/tools/DiagramHelper.cxx
+++ b/chart2/source/tools/DiagramHelper.cxx
@@ -381,7 +381,6 @@ StackMode DiagramHelper::getStackModeFromChartType(
// property is not MAYBEVOID
bool bSuccess = ( xProp->getPropertyValue( "StackingDirection" ) >>= eCurrentDirection );
OSL_ASSERT( bSuccess );
- (void)(bSuccess); // avoid warning in non-debug builds
if( ! bDirectionInitialized )
{
eCommonDirection = eCurrentDirection;
diff --git a/chart2/source/tools/LifeTime.cxx b/chart2/source/tools/LifeTime.cxx
index f24facbab19c..5df9f8f4715c 100644
--- a/chart2/source/tools/LifeTime.cxx
+++ b/chart2/source/tools/LifeTime.cxx
@@ -57,7 +57,6 @@ bool LifeTimeManager::impl_isDisposed( bool bAssert )
if( bAssert )
{
OSL_FAIL( "This component is already disposed " );
- (void)(bAssert);
}
return true;
}
@@ -181,7 +180,6 @@ bool CloseableLifeTimeManager::impl_isDisposedOrClosed( bool bAssert )
if( bAssert )
{
OSL_FAIL( "This object is already closed" );
- (void)(bAssert);//avoid warnings
}
return true;
}
diff --git a/chart2/source/tools/WrappedPropertySet.cxx b/chart2/source/tools/WrappedPropertySet.cxx
index f2881c3efd83..401b63e8f35b 100644
--- a/chart2/source/tools/WrappedPropertySet.cxx
+++ b/chart2/source/tools/WrappedPropertySet.cxx
@@ -244,7 +244,6 @@ void SAL_CALL WrappedPropertySet::setPropertyValues( const Sequence< OUString >&
}
//todo: store unknown properties elsewhere
OSL_ENSURE(!bUnknownProperty,"unknown property");
- (void)bUnknownProperty;
// if( bUnknownProperty )
// throw beans::UnknownPropertyException();
}
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index 570dd20f9011..2629e998f0f9 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -3129,7 +3129,6 @@ Reference< uno::XInterface > ChartView::createInstance( const OUString& aService
Reference< uno::XInterface > ChartView::createInstanceWithArguments( const OUString& ServiceSpecifier, const uno::Sequence< uno::Any >& Arguments )
{
OSL_ENSURE( Arguments.getLength(), "ChartView::createInstanceWithArguments: arguments are ignored" );
- (void) Arguments; // avoid warning
return createInstance( ServiceSpecifier );
}
commit 2b1c731f3c69c1fa1af68e01683711ceda585e07
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:34:18 2017 +0200
loplugin:casttovoid: comphelper
Change-Id: I28752323d31320141a537c0e108c911cef09c10a
diff --git a/comphelper/source/container/embeddedobjectcontainer.cxx b/comphelper/source/container/embeddedobjectcontainer.cxx
index 2a045edf863c..c5d7b031ded6 100644
--- a/comphelper/source/container/embeddedobjectcontainer.cxx
+++ b/comphelper/source/container/embeddedobjectcontainer.cxx
@@ -1041,7 +1041,6 @@ bool EmbeddedObjectContainer::RemoveEmbeddedObject( const uno::Reference < embed
}
SAL_WARN_IF( !bFound,"comphelper.container", "Object not found for removal!" );
- (void)bFound;
if ( xPersist.is() && bKeepToTempStorage ) // #i119941#
{
// remove replacement image (if there is one)
diff --git a/comphelper/source/misc/logging.cxx b/comphelper/source/misc/logging.cxx
index 6df71c3d01bf..3744d9580727 100644
--- a/comphelper/source/misc/logging.cxx
+++ b/comphelper/source/misc/logging.cxx
@@ -63,9 +63,8 @@ namespace comphelper
else
m_xLogger = xPool->getDefaultLogger();
}
- catch( const Exception& e )
+ catch( const Exception& )
{
- (void)e;
OSL_FAIL( "EventLogger_Impl::impl_createLogger_nothrow: caught an exception!" );
}
}
@@ -90,9 +89,8 @@ namespace comphelper
{
return m_pImpl->getLogger()->isLoggable( _nLogLevel );
}
- catch( const Exception& e )
+ catch( const Exception& )
{
- (void)e;
OSL_FAIL( "EventLogger::isLoggable: caught an exception!" );
}
@@ -157,9 +155,8 @@ namespace comphelper
xLogger->log( _nLogLevel, sMessage );
}
}
- catch( const Exception& e )
+ catch( const Exception& )
{
- (void)e;
OSL_FAIL( "EventLogger::impl_log: caught an exception!" );
}
diff --git a/include/comphelper/sequence.hxx b/include/comphelper/sequence.hxx
index 26d08c993c1e..c3bddb28aaa9 100644
--- a/include/comphelper/sequence.hxx
+++ b/include/comphelper/sequence.hxx
@@ -174,7 +174,6 @@ namespace comphelper
css::uno::Sequence< TYPE > aContainer;
bool bSuccess = _rSequenceAny >>= aContainer;
OSL_ENSURE(bSuccess, "OSequenceIterator::OSequenceIterator: invalid Any!");
- (void)bSuccess;
construct(aContainer);
}
commit 41dbfa9ec7380e082279f1b01bfd323d23134b7d
Author: Stephan Bergmann <sbergman at redhat.com>
Date: Sun Jul 2 22:34:08 2017 +0200
loplugin:casttovoid: connectivity
Change-Id: I03127890499dac67816bb43a8c3fb9dd87eefcab
diff --git a/connectivity/source/commontools/paramwrapper.cxx b/connectivity/source/commontools/paramwrapper.cxx
index 5e115fd5b3e0..8185b34ce2eb 100644
--- a/connectivity/source/commontools/paramwrapper.cxx
+++ b/connectivity/source/commontools/paramwrapper.cxx
@@ -181,7 +181,6 @@ namespace param
sal_Bool ParameterWrapper::convertFastPropertyValue(Any& rConvertedValue, Any& rOldValue, sal_Int32 nHandle, const Any& rValue)
{
OSL_ENSURE( PROPERTY_ID_VALUE == nHandle, "ParameterWrapper::convertFastPropertyValue: the only non-readonly prop should be our PROPERTY_VALUE!" );
- (void)nHandle;
// we're lazy here ...
rOldValue = m_aValue.makeAny();
diff --git a/connectivity/source/drivers/dbase/DTable.cxx b/connectivity/source/drivers/dbase/DTable.cxx
index 3e14a594bbb7..66f676bf19eb 100644
--- a/connectivity/source/drivers/dbase/DTable.cxx
+++ b/connectivity/source/drivers/dbase/DTable.cxx
@@ -1160,10 +1160,8 @@ bool ODbaseTable::CreateFile(const INetURLObject& aFile, bool& bCreateMemo)
} // switch (getINT32(xCol->getPropertyValue(sPropType)))
}
}
- catch ( const Exception& e )
+ catch ( const Exception& )
{
- (void)e;
-
try
{
// we have to drop the file because it is corrupted now
@@ -1356,10 +1354,8 @@ bool ODbaseTable::CreateFile(const INetURLObject& aFile, bool& bCreateMemo)
(*m_pFileStream).WriteUChar( dBaseIIIMemo );
} // if (bCreateMemo)
}
- catch ( const Exception& e )
+ catch ( const Exception& )
{
- (void)e;
-
try
{
// we have to drop the file because it is corrupted now
@@ -2515,11 +2511,11 @@ void ODbaseTable::copyData(ODbaseTable* _pNewTable,sal_Int32 _nPos)
}
}
bOk = _pNewTable->InsertRow(*aInsertRow,_pNewTable->m_pColumns);
- SAL_WARN_IF(!bOk, "connectivity.drivers", "Row could not be inserted!"); (void)bOk;
+ SAL_WARN_IF(!bOk, "connectivity.drivers", "Row could not be inserted!");
}
else
{
- SAL_WARN_IF(!bOk, "connectivity.drivers", "Row could not be fetched!"); (void)bOk;
+ SAL_WARN_IF(!bOk, "connectivity.drivers", "Row could not be fetched!");
}
}
else
diff --git a/connectivity/source/drivers/firebird/Connection.cxx b/connectivity/source/drivers/firebird/Connection.cxx
index a17222f52f31..0511391ebc32 100644
--- a/connectivity/source/drivers/firebird/Connection.cxx
+++ b/connectivity/source/drivers/firebird/Connection.cxx
@@ -792,10 +792,9 @@ Reference< XNameAccess > SAL_CALL Connection::getTypeMap()
return nullptr;
}
-void SAL_CALL Connection::setTypeMap(const Reference< XNameAccess >& typeMap)
+void SAL_CALL Connection::setTypeMap(const Reference< XNameAccess >&)
{
::dbtools::throwFeatureNotImplementedSQLException( "XConnection::setTypeMap", *this );
- (void) typeMap;
}
//----- XCloseable -----------------------------------------------------------
diff --git a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
index 6bfa79c9794d..db6609f722ee 100644
--- a/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
+++ b/connectivity/source/drivers/firebird/DatabaseMetaData.cxx
@@ -315,11 +315,9 @@ sal_Bool SAL_CALL ODatabaseMetaData::allTablesAreSelectable()
return true;
}
-sal_Bool SAL_CALL ODatabaseMetaData::supportsConvert(sal_Int32 fromType,
- sal_Int32 toType)
+sal_Bool SAL_CALL ODatabaseMetaData::supportsConvert(sal_Int32,
+ sal_Int32)
{
- (void) fromType;
- (void) toType;
return false;
}
@@ -718,57 +716,48 @@ sal_Bool SAL_CALL ODatabaseMetaData::supportsResultSetConcurrency(
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::ownUpdatesAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::ownUpdatesAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::ownDeletesAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::ownDeletesAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::ownInsertsAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::ownInsertsAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::othersUpdatesAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::othersUpdatesAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::othersDeletesAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::othersDeletesAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::othersInsertsAreVisible( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::othersInsertsAreVisible( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::updatesAreDetected( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::updatesAreDetected( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::deletesAreDetected( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::deletesAreDetected( sal_Int32 )
{
- (void) setType;
return false;
}
-sal_Bool SAL_CALL ODatabaseMetaData::insertsAreDetected( sal_Int32 setType )
+sal_Bool SAL_CALL ODatabaseMetaData::insertsAreDetected( sal_Int32 )
{
- (void) setType;
return false;
}
@@ -1412,65 +1401,49 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTables(
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getProcedureColumns(
- const Any& catalog, const OUString& schemaPattern,
- const OUString& procedureNamePattern, const OUString& columnNamePattern )
+ const Any&, const OUString&,
+ const OUString&, const OUString& )
{
SAL_WARN("connectivity.firebird", "Not yet implemented");
- (void) catalog;
- (void) schemaPattern;
- (void) procedureNamePattern;
- (void) columnNamePattern;
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eProcedureColumns);
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getProcedures(
- const Any& catalog, const OUString& schemaPattern,
- const OUString& procedureNamePattern )
+ const Any&, const OUString&,
+ const OUString& )
{
SAL_WARN("connectivity.firebird", "Not yet implemented");
- (void) catalog;
- (void) schemaPattern;
- (void) procedureNamePattern;
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eProcedures);
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getVersionColumns(
- const Any& catalog, const OUString& schema, const OUString& table )
+ const Any&, const OUString&, const OUString& )
{
SAL_WARN("connectivity.firebird", "Not yet implemented");
- (void) catalog;
- (void) schema;
- (void) table;
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eVersionColumns);
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getExportedKeys(
- const Any& catalog, const OUString& schema, const OUString& table )
+ const Any&, const OUString&, const OUString& )
{
// List the columns in a table which are foreign keys. This is actually
// never used anywhere in the LO codebase currently. Retrieval from firebird
// requires using a 5-table join.
SAL_WARN("connectivity.firebird", "Not yet implemented");
- (void) catalog;
- (void) schema;
- (void) table;
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eExportedKeys);
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getImportedKeys(
- const Any& catalog, const OUString& schema, const OUString& table )
+ const Any&, const OUString&, const OUString& table )
{
- (void) catalog;
- (void) schema;
-
ODatabaseMetaDataResultSet* pResultSet = new
ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eImportedKeys);
uno::Reference< XResultSet > xResultSet = pResultSet;
@@ -1619,7 +1592,8 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getIndexInfo(
const OUString& /*sSchema*/,
const OUString& sTable,
sal_Bool bIsUnique,
- sal_Bool bIsApproximate)
+ sal_Bool) // TODO: what is bIsApproximate?
+
{
// Apparently this method can also return a "tableIndexStatistic"
// However this is only mentioned in XDatabaseMetaData.idl (whose comments
@@ -1648,9 +1622,6 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getIndexInfo(
if (bIsUnique)
aQueryBuf.append("AND (indices.RDB$UNIQUE_FLAG = 1) ");
- // TODO: what is bIsApproximate?
- (void) bIsApproximate;
-
OUString sQuery = aQueryBuf.makeStringAndClear();
uno::Reference< XStatement > xStatement = m_pConnection->createStatement();
@@ -1708,14 +1679,9 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getIndexInfo(
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getBestRowIdentifier(
- const Any& catalog, const OUString& schema, const OUString& table, sal_Int32 scope,
- sal_Bool nullable )
-{
- (void) catalog;
- (void) schema;
- (void) table;
- (void) scope;
- (void) nullable;
+ const Any&, const OUString&, const OUString&, sal_Int32,
+ sal_Bool )
+{
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eBestRowIdentifier);
@@ -1789,27 +1755,17 @@ uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getTablePrivileges(
}
uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getCrossReference(
- const Any& primaryCatalog, const OUString& primarySchema,
- const OUString& primaryTable, const Any& foreignCatalog,
- const OUString& foreignSchema, const OUString& foreignTable )
-{
- (void) primaryCatalog;
- (void) primarySchema;
- (void) primaryTable;
- (void) foreignCatalog;
- (void) foreignSchema;
- (void) foreignTable;
+ const Any&, const OUString&,
+ const OUString&, const Any&,
+ const OUString&, const OUString& )
+{
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eCrossReference);
}
-uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getUDTs( const Any& catalog, const OUString& schemaPattern, const OUString& typeNamePattern, const Sequence< sal_Int32 >& types )
+uno::Reference< XResultSet > SAL_CALL ODatabaseMetaData::getUDTs( const Any&, const OUString&, const OUString&, const Sequence< sal_Int32 >& )
{
- (void) catalog;
- (void) schemaPattern;
- (void) typeNamePattern;
- (void) types;
OSL_FAIL("Not implemented yet!");
// TODO implement
return new ODatabaseMetaDataResultSet(ODatabaseMetaDataResultSet::eUDTs);
diff --git a/connectivity/source/drivers/firebird/Driver.cxx b/connectivity/source/drivers/firebird/Driver.cxx
index e3bdc3540cf0..399afad3ddb5 100644
--- a/connectivity/source/drivers/firebird/Driver.cxx
+++ b/connectivity/source/drivers/firebird/Driver.cxx
@@ -205,9 +205,8 @@ sal_Bool SAL_CALL FirebirdDriver::acceptsURL( const OUString& url )
}
Sequence< DriverPropertyInfo > SAL_CALL FirebirdDriver::getPropertyInfo(
- const OUString& url, const Sequence< PropertyValue >& info )
+ const OUString& url, const Sequence< PropertyValue >& )
{
- (void) info;
if ( ! acceptsURL(url) )
{
::connectivity::SharedResources aResources;
diff --git a/connectivity/source/drivers/firebird/PreparedStatement.cxx b/connectivity/source/drivers/firebird/PreparedStatement.cxx
index 89e1650e5213..400b6c147cf8 100644
--- a/connectivity/source/drivers/firebird/PreparedStatement.cxx
+++ b/connectivity/source/drivers/firebird/PreparedStatement.cxx
@@ -482,10 +482,8 @@ void OPreparedStatement::closeBlobAfterWriting(isc_blob_handle& rBlobHandle)
}
}
-void SAL_CALL OPreparedStatement::setClob( sal_Int32 parameterIndex, const Reference< XClob >& x )
+void SAL_CALL OPreparedStatement::setClob( sal_Int32, const Reference< XClob >& )
{
- (void) parameterIndex;
- (void) x;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
@@ -542,20 +540,16 @@ void SAL_CALL OPreparedStatement::setBlob(sal_Int32 nParameterIndex,
}
-void SAL_CALL OPreparedStatement::setArray( sal_Int32 parameterIndex, const Reference< XArray >& x )
+void SAL_CALL OPreparedStatement::setArray( sal_Int32, const Reference< XArray >& )
{
- (void) parameterIndex;
- (void) x;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
}
-void SAL_CALL OPreparedStatement::setRef( sal_Int32 parameterIndex, const Reference< XRef >& x )
+void SAL_CALL OPreparedStatement::setRef( sal_Int32, const Reference< XRef >& )
{
- (void) parameterIndex;
- (void) x;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
@@ -646,21 +640,16 @@ void SAL_CALL OPreparedStatement::setObjectWithInfo( sal_Int32 parameterIndex, c
}
-void SAL_CALL OPreparedStatement::setObjectNull( sal_Int32 parameterIndex, sal_Int32 sqlType, const ::rtl::OUString& typeName )
+void SAL_CALL OPreparedStatement::setObjectNull( sal_Int32, sal_Int32, const ::rtl::OUString& )
{
- (void) parameterIndex;
- (void) sqlType;
- (void) typeName;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
}
-void SAL_CALL OPreparedStatement::setObject( sal_Int32 parameterIndex, const Any& x )
+void SAL_CALL OPreparedStatement::setObject( sal_Int32, const Any& )
{
- (void) parameterIndex;
- (void) x;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
@@ -714,22 +703,16 @@ void SAL_CALL OPreparedStatement::setBytes(sal_Int32 nParameterIndex,
}
-void SAL_CALL OPreparedStatement::setCharacterStream( sal_Int32 parameterIndex, const Reference< css::io::XInputStream >& x, sal_Int32 length )
+void SAL_CALL OPreparedStatement::setCharacterStream( sal_Int32, const Reference< css::io::XInputStream >&, sal_Int32 )
{
- (void) parameterIndex;
- (void) x;
- (void) length;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
}
-void SAL_CALL OPreparedStatement::setBinaryStream( sal_Int32 parameterIndex, const Reference< css::io::XInputStream >& x, sal_Int32 length )
+void SAL_CALL OPreparedStatement::setBinaryStream( sal_Int32, const Reference< css::io::XInputStream >&, sal_Int32 )
{
- (void) parameterIndex;
- (void) x;
- (void) length;
::osl::MutexGuard aGuard( m_aMutex );
checkDisposed(OStatementCommonBase_Base::rBHelper.bDisposed);
diff --git a/connectivity/source/drivers/firebird/ResultSet.cxx b/connectivity/source/drivers/firebird/ResultSet.cxx
index fb3e72675fab..6d28111c36e4 100644
--- a/connectivity/source/drivers/firebird/ResultSet.cxx
+++ b/connectivity/source/drivers/firebird/ResultSet.cxx
@@ -339,18 +339,16 @@ sal_Int32 SAL_CALL OResultSet::findColumn(const OUString& rColumnName)
return 0; // Never reached
}
-uno::Reference< XInputStream > SAL_CALL OResultSet::getBinaryStream( sal_Int32 columnIndex )
+uno::Reference< XInputStream > SAL_CALL OResultSet::getBinaryStream( sal_Int32 )
{
- (void) columnIndex;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
return nullptr;
}
-uno::Reference< XInputStream > SAL_CALL OResultSet::getCharacterStream( sal_Int32 columnIndex )
+uno::Reference< XInputStream > SAL_CALL OResultSet::getCharacterStream( sal_Int32 )
{
- (void) columnIndex;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
@@ -659,9 +657,8 @@ sal_Int8 SAL_CALL OResultSet::getByte(sal_Int32 nColumnIndex)
return safelyRetrieveValue< ORowSetValue >(nColumnIndex);
}
-Sequence< sal_Int8 > SAL_CALL OResultSet::getBytes(sal_Int32 columnIndex)
+Sequence< sal_Int8 > SAL_CALL OResultSet::getBytes(sal_Int32)
{
- (void) columnIndex;
return Sequence< sal_Int8 >(); // TODO: implement
//return safelyRetrieveValue(columnIndex);
}
@@ -724,9 +721,8 @@ uno::Reference< XResultSetMetaData > SAL_CALL OResultSet::getMetaData( )
return m_xMetaData;
}
-uno::Reference< XArray > SAL_CALL OResultSet::getArray( sal_Int32 columnIndex )
+uno::Reference< XArray > SAL_CALL OResultSet::getArray( sal_Int32 )
{
- (void) columnIndex;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
@@ -736,7 +732,6 @@ uno::Reference< XArray > SAL_CALL OResultSet::getArray( sal_Int32 columnIndex )
uno::Reference< XClob > SAL_CALL OResultSet::getClob( sal_Int32 columnIndex )
{
- (void) columnIndex;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
@@ -765,9 +760,8 @@ uno::Reference< XBlob > SAL_CALL OResultSet::getBlob(sal_Int32 columnIndex)
}
-uno::Reference< XRef > SAL_CALL OResultSet::getRef( sal_Int32 columnIndex )
+uno::Reference< XRef > SAL_CALL OResultSet::getRef( sal_Int32 )
{
- (void) columnIndex;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
@@ -775,10 +769,8 @@ uno::Reference< XRef > SAL_CALL OResultSet::getRef( sal_Int32 columnIndex )
}
-Any SAL_CALL OResultSet::getObject( sal_Int32 columnIndex, const uno::Reference< css::container::XNameAccess >& typeMap )
+Any SAL_CALL OResultSet::getObject( sal_Int32, const uno::Reference< css::container::XNameAccess >& )
{
- (void) columnIndex;
- (void) typeMap;
MutexGuard aGuard(m_rMutex);
checkDisposed(OResultSet_BASE::rBHelper.bDisposed);
diff --git a/connectivity/source/drivers/firebird/ResultSetMetaData.cxx b/connectivity/source/drivers/firebird/ResultSetMetaData.cxx
index 498bbaee3087..e5ba68a3bd72 100644
--- a/connectivity/source/drivers/firebird/ResultSetMetaData.cxx
+++ b/connectivity/source/drivers/firebird/ResultSetMetaData.cxx
@@ -67,20 +67,18 @@ sal_Int32 SAL_CALL OResultSetMetaData::getColumnType(sal_Int32 column)
return getColumnTypeFromFBType(aType, aSubType, aScale);
}
-sal_Bool SAL_CALL OResultSetMetaData::isCaseSensitive(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isCaseSensitive(sal_Int32)
{
// Firebird is generally case sensitive when using quoted identifiers.
// IF THIS CHANGES make ResultSet::findColumn to be case-insensitive as needed.
// Generally names that are entirely UPPERCASE are case insensitive, however
// there remains some ambiguity if there is another mixed-case-named column
// of the same name. For safety always assume case insensitive.
- (void) column;
return true;
}
-OUString SAL_CALL OResultSetMetaData::getSchemaName(sal_Int32 column)
+OUString SAL_CALL OResultSetMetaData::getSchemaName(sal_Int32)
{
- (void) column;
return OUString(); // Schemas supported by firebird
}
@@ -102,9 +100,8 @@ OUString SAL_CALL OResultSetMetaData::getTableName(sal_Int32 column)
RTL_TEXTENCODING_UTF8);
}
-OUString SAL_CALL OResultSetMetaData::getCatalogName(sal_Int32 column)
+OUString SAL_CALL OResultSetMetaData::getCatalogName(sal_Int32)
{
- (void) column;
return OUString(); // Catalogs not supported by firebird
}
@@ -130,16 +127,14 @@ OUString SAL_CALL OResultSetMetaData::getColumnLabel(sal_Int32 column)
return sRet;
}
-OUString SAL_CALL OResultSetMetaData::getColumnServiceName(sal_Int32 column)
+OUString SAL_CALL OResultSetMetaData::getColumnServiceName(sal_Int32)
{
// TODO: implement
- (void) column;
return OUString();
}
-sal_Bool SAL_CALL OResultSetMetaData::isCurrency(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isCurrency(sal_Int32)
{
- (void) column;
return false;
}
@@ -179,10 +174,9 @@ sal_Bool SAL_CALL OResultSetMetaData::isAutoIncrement(sal_Int32 column)
}
-sal_Bool SAL_CALL OResultSetMetaData::isSigned(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isSigned(sal_Int32)
{
// Unsigned values aren't supported in firebird.
- (void) column;
return true;
}
@@ -234,28 +228,24 @@ sal_Int32 SAL_CALL OResultSetMetaData::isNullable(sal_Int32 column)
return ColumnValue::NO_NULLS;
}
-sal_Bool SAL_CALL OResultSetMetaData::isSearchable(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isSearchable(sal_Int32)
{
// TODO: Can the column be used as part of a where clause? Assume yes
- (void) column;
return true;
}
-sal_Bool SAL_CALL OResultSetMetaData::isReadOnly(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isReadOnly(sal_Int32)
{
- (void) column;
return m_pConnection->isReadOnly(); // Readonly only available on db level
}
-sal_Bool SAL_CALL OResultSetMetaData::isDefinitelyWritable(sal_Int32 column)
+sal_Bool SAL_CALL OResultSetMetaData::isDefinitelyWritable(sal_Int32)
{
- (void) column;
return !m_pConnection->isReadOnly();
}
-sal_Bool SAL_CALL OResultSetMetaData::isWritable( sal_Int32 column )
+sal_Bool SAL_CALL OResultSetMetaData::isWritable( sal_Int32 )
{
- (void) column;
return !m_pConnection->isReadOnly();
}
diff --git a/connectivity/source/drivers/firebird/Statement.cxx b/connectivity/source/drivers/firebird/Statement.cxx
index 671f50107542..62bff6d0aa28 100644
--- a/connectivity/source/drivers/firebird/Statement.cxx
+++ b/connectivity/source/drivers/firebird/Statement.cxx
@@ -50,9 +50,8 @@ using namespace ::osl;
using namespace ::std;
// ---- XBatchExecution - UNSUPPORTED ----------------------------------------
-void SAL_CALL OStatement::addBatch(const OUString& sql)
+void SAL_CALL OStatement::addBatch(const OUString&)
{
- (void) sql;
}
void SAL_CALL OStatement::clearBatch()
diff --git a/connectivity/source/drivers/firebird/StatementCommonBase.cxx b/connectivity/source/drivers/firebird/StatementCommonBase.cxx
index cc0e417f19db..58b5a635ea7b 100644
--- a/connectivity/source/drivers/firebird/StatementCommonBase.cxx
+++ b/connectivity/source/drivers/firebird/StatementCommonBase.cxx
@@ -293,22 +293,17 @@ void SAL_CALL OStatementCommonBase::clearWarnings()
}
sal_Bool OStatementCommonBase::convertFastPropertyValue(
- Any & rConvertedValue,
- Any & rOldValue,
- sal_Int32 nHandle,
- const Any& rValue )
+ Any &,
+ Any &,
+ sal_Int32,
+ const Any& )
{
- (void) rConvertedValue;
- (void) rOldValue;
- (void) nHandle;
- (void) rValue;
// here we have to try to convert
return false;
}
-void OStatementCommonBase::setFastPropertyValue_NoBroadcast(sal_Int32 nHandle,const Any& rValue)
+void OStatementCommonBase::setFastPropertyValue_NoBroadcast(sal_Int32 nHandle,const Any&)
{
- (void) rValue;
// set the value to what ever is necessary
switch(nHandle)
{
@@ -327,9 +322,8 @@ void OStatementCommonBase::setFastPropertyValue_NoBroadcast(sal_Int32 nHandle,co
}
}
-void OStatementCommonBase::getFastPropertyValue(Any& rValue,sal_Int32 nHandle) const
+void OStatementCommonBase::getFastPropertyValue(Any&,sal_Int32 nHandle) const
{
- (void) rValue;
switch(nHandle)
{
case PROPERTY_ID_QUERYTIMEOUT:
diff --git a/connectivity/source/drivers/firebird/Table.cxx b/connectivity/source/drivers/firebird/Table.cxx
index bf441792555d..e16d3089a0a0 100644
--- a/connectivity/source/drivers/firebird/Table.cxx
+++ b/connectivity/source/drivers/firebird/Table.cxx
@@ -222,9 +222,8 @@ void SAL_CALL Table::alterColumnByName(const OUString& rColName,
}
// ----- XRename --------------------------------------------------------------
-void SAL_CALL Table::rename(const OUString& rName)
+void SAL_CALL Table::rename(const OUString&)
{
- (void) rName;
throw RuntimeException(); // Firebird doesn't support this.
}
diff --git a/connectivity/source/drivers/firebird/User.cxx b/connectivity/source/drivers/firebird/User.cxx
index 1e3399f5716d..024d7eb4958a 100644
--- a/connectivity/source/drivers/firebird/User.cxx
+++ b/connectivity/source/drivers/firebird/User.cxx
@@ -16,18 +16,14 @@ using namespace ::connectivity::sdbcx;
using namespace ::com::sun::star;
using namespace ::com::sun::star::sdbc;
-User::User(const uno::Reference< XConnection >& rConnection):
+User::User():
OUser(true) // Case Sensitive
-{
- (void) rConnection;
-}
+{}
-User::User(const uno::Reference< XConnection >& rConnection, const OUString& rName):
+User::User(const OUString& rName):
OUser(rName,
true) // Case Sensitive
-{
- (void) rConnection;
-}
+{}
//----- IRefreshableGroups ----------------------------------------------------
void User::refreshGroups()
diff --git a/connectivity/source/drivers/firebird/User.hxx b/connectivity/source/drivers/firebird/User.hxx
index 3d2e8db0ea41..8ff9155a14af 100644
--- a/connectivity/source/drivers/firebird/User.hxx
+++ b/connectivity/source/drivers/firebird/User.hxx
@@ -12,8 +12,6 @@
#include <connectivity/sdbcx/VUser.hxx>
-#include <com/sun/star/sdbc/XConnection.hpp>
-
namespace connectivity
{
namespace firebird
@@ -29,12 +27,11 @@ namespace connectivity
/**
* Create a "new" descriptor, which isn't yet in the database.
*/
- explicit User(const css::uno::Reference< css::sdbc::XConnection >& rConnection);
+ User();
/**
* For a user that already exists in the db.
*/
- User(const css::uno::Reference< css::sdbc::XConnection >& rConnection,
- const ::rtl::OUString& rName);
+ User(const ::rtl::OUString& rName);
// IRefreshableGroups::
virtual void refreshGroups() override;
diff --git a/connectivity/source/drivers/firebird/Users.cxx b/connectivity/source/drivers/firebird/Users.cxx
index 832872c51e66..c0103368c377 100644
--- a/connectivity/source/drivers/firebird/Users.cxx
+++ b/connectivity/source/drivers/firebird/Users.cxx
@@ -47,7 +47,7 @@ void Users::impl_refresh()
ObjectType Users::createObject(const OUString& rName)
{
- return new User(m_xMetaData->getConnection(), rName);
+ return new User(rName);
}
uno::Reference< XPropertySet > Users::createDescriptor()
@@ -55,16 +55,14 @@ uno::Reference< XPropertySet > Users::createDescriptor()
// There is some internal magic so that the same class can be used as either
// a descriptor or as a normal user. See VUser.cxx for the details. In our
// case we just need to ensure we use the correct constructor.
- return new User(m_xMetaData->getConnection());
+ return new User;
}
//----- XAppend ---------------------------------------------------------------
ObjectType Users::appendObject(const OUString& rName,
- const uno::Reference< XPropertySet >& rDescriptor)
+ const uno::Reference< XPropertySet >&)
{
// TODO: set sSql as appropriate
- (void) rName;
- (void) rDescriptor;
OUString sSql;
m_xMetaData->getConnection()->createStatement()->execute(sSql);
@@ -72,13 +70,12 @@ ObjectType Users::appendObject(const OUString& rName,
}
//----- XDrop -----------------------------------------------------------------
-void Users::dropObject(sal_Int32 nPosition, const OUString& sName)
+void Users::dropObject(sal_Int32 nPosition, const OUString&)
{
uno::Reference< XPropertySet > xUser(getObject(nPosition));
if (!ODescriptor::isNew(xUser))
{
- (void) sName;
// TODO: drop me
}
}
diff --git a/connectivity/source/drivers/hsqldb/HDriver.cxx b/connectivity/source/drivers/hsqldb/HDriver.cxx
index a60f32766e26..5face6249692 100644
--- a/connectivity/source/drivers/hsqldb/HDriver.cxx
+++ b/connectivity/source/drivers/hsqldb/HDriver.cxx
@@ -328,10 +328,9 @@ namespace connectivity
{
xOrig = xDriver->connect( sConnectURL, aConnectionArgs );
}
- catch(const Exception& e)
+ catch(const Exception&)
{
StorageContainer::revokeStorage(sKey,nullptr);
- (void)e;
throw;
}
diff --git a/connectivity/source/drivers/jdbc/JStatement.cxx b/connectivity/source/drivers/jdbc/JStatement.cxx
index 4b1534a0bad0..2ae4364d9c2d 100644
--- a/connectivity/source/drivers/jdbc/JStatement.cxx
+++ b/connectivity/source/drivers/jdbc/JStatement.cxx
@@ -133,9 +133,8 @@ Sequence< Type > SAL_CALL java_sql_Statement_Base::getTypes( )
Sequence< Type > aOldTypes = java_sql_Statement_BASE::getTypes();
if ( m_pConnection.is() && !m_pConnection->isAutoRetrievingEnabled() )
{
- auto it = std::remove(aOldTypes.getArray(),aOldTypes.getArray() + aOldTypes.getLength(),
+ (void) std::remove(aOldTypes.getArray(),aOldTypes.getArray() + aOldTypes.getLength(),
cppu::UnoType<XGeneratedResultSet>::get());
- (void)it;
aOldTypes.realloc(aOldTypes.getLength() - 1);
}
diff --git a/connectivity/source/drivers/mork/MConnection.cxx b/connectivity/source/drivers/mork/MConnection.cxx
index b11808da879a..0f6fb73b1a34 100644
--- a/connectivity/source/drivers/mork/MConnection.cxx
+++ b/connectivity/source/drivers/mork/MConnection.cxx
@@ -61,9 +61,8 @@ void SAL_CALL OConnection::release() throw()
}
-void OConnection::construct(const OUString& url,const Sequence< PropertyValue >& info)
+void OConnection::construct(const OUString& url)
{
- (void) info; // avoid warnings
SAL_INFO("connectivity.mork", "=> OConnection::construct()" );
// open file
setURL(url);
diff --git a/connectivity/source/drivers/mork/MConnection.hxx b/connectivity/source/drivers/mork/MConnection.hxx
index 37606ea0387b..d53b5671cb99 100644
--- a/connectivity/source/drivers/mork/MConnection.hxx
+++ b/connectivity/source/drivers/mork/MConnection.hxx
@@ -49,7 +49,7 @@ namespace connectivity
public:
/// @throws css::sdbc::SQLException
- void construct( const OUString& url,const css::uno::Sequence< css::beans::PropertyValue >& info);
+ void construct( const OUString& url);
explicit OConnection(MorkDriver* const driver);
virtual ~OConnection() override;
diff --git a/connectivity/source/drivers/mork/MDriver.cxx b/connectivity/source/drivers/mork/MDriver.cxx
index a45f149f6a33..58b714c72df7 100644
--- a/connectivity/source/drivers/mork/MDriver.cxx
+++ b/connectivity/source/drivers/mork/MDriver.cxx
@@ -45,12 +45,10 @@ css::uno::Sequence< OUString > MorkDriver::getSupportedServiceNames()
css::uno::Reference< css::sdbc::XConnection > MorkDriver::connect(
OUString const & url,
- css::uno::Sequence< css::beans::PropertyValue > const & info)
+ css::uno::Sequence< css::beans::PropertyValue > const &)
{
SAL_INFO("connectivity.mork", "=> MorkDriver::connect()" );
- (void) url; (void) info; // avoid warnings
-
// Profile discovery
css::uno::Reference<css::uno::XInterface> xInstance = context_->getServiceManager()->createInstanceWithContext("com.sun.star.mozilla.MozillaBootstrap", context_);
OSL_ENSURE( xInstance.is(), "failed to create instance" );
@@ -72,7 +70,7 @@ css::uno::Reference< css::sdbc::XConnection > MorkDriver::connect(
css::uno::Reference< css::sdbc::XConnection > xCon;
OConnection* pCon = new OConnection(this);
... etc. - the rest is truncated
More information about the Libreoffice-commits
mailing list