[Libreoffice-commits] core.git: sc/source

Stephan Bergmann sbergman at redhat.com
Tue Jul 4 15:18:04 UTC 2017


 sc/source/filter/excel/xelink.cxx |    7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

New commits:
commit b93abe9e724092222b9bfec23c1090cfab0c6f9d
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue Jul 4 17:15:55 2017 +0200

    Fix "TODO: remove?"
    
    ...from previous 18713e10451b017784c7a1f783612074c5f84c42
    "XclExpXct::StoreCell(Range) rToken param is unused", according to Eike's
    replies at <https://gerrit.libreoffice.org/#/c/39456/3>
    
    Change-Id: I525b428eb6853bc19be9f9c3cd08a206d031ed51

diff --git a/sc/source/filter/excel/xelink.cxx b/sc/source/filter/excel/xelink.cxx
index 1e51bcf160cc..b2e8c329f323 100644
--- a/sc/source/filter/excel/xelink.cxx
+++ b/sc/source/filter/excel/xelink.cxx
@@ -1866,11 +1866,6 @@ void XclExpSupbookBuffer::StoreCell( sal_uInt16 nFileId, const OUString& rTabNam
         nSupbookId = Append(xSupbook);
     }
 
-    //TODO: remove?
-    ScExternalRefCache::TokenRef pToken = pRefMgr->getSingleRefToken(nFileId, rTabName, rCell, nullptr, nullptr);
-    if (!pToken.get())
-        return;
-
     sal_uInt16 nSheetId = xSupbook->GetTabIndex(rTabName);
     if (nSheetId == EXC_NOTAB)
         // specified table name not found in this SUPBOOK.
@@ -1907,7 +1902,7 @@ void XclExpSupbookBuffer::StoreCellRange( sal_uInt16 nFileId, const OUString& rT
 
     // If this is a multi-table range, get token for each table.
     using namespace ::formula;
-    SCTAB aMatrixListSize = 0; //TODO: remove?
+    SCTAB aMatrixListSize = 0;
 
     // This is a new'ed instance, so we must manage its life cycle here.
     ScExternalRefCache::TokenArrayRef pArray = pRefMgr->getDoubleRefTokens(nFileId, rTabName, rRange, nullptr);


More information about the Libreoffice-commits mailing list