[Libreoffice-commits] core.git: xmlsecurity/source

[Samuel Mehrbrodt]

 xmlsecurity/source/component/documentdigitalsignatures.cxx |   10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

New commits:
commit 229c21779190bf11142d5a9347b2ecbe37952898
Author: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
Date:   Mon Jul 17 09:50:21 2017 +0200

    We no longer patch libxmlsec for this
    
    Change-Id: I0e817499e80d2b7292833f5e734974b05ef579b6
    Reviewed-on: https://gerrit.libreoffice.org/40041
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/xmlsecurity/source/component/documentdigitalsignatures.cxx b/xmlsecurity/source/component/documentdigitalsignatures.cxx
index 9d94b1845fd9..6e84163c4e84 100644
--- a/xmlsecurity/source/component/documentdigitalsignatures.cxx
+++ b/xmlsecurity/source/component/documentdigitalsignatures.cxx
@@ -335,13 +335,9 @@ DocumentDigitalSignatures::ImplVerifySignatures(
                     rSigInfo.Signer = xSecEnv->getCertificate( rInfo.ouX509IssuerName,
                                                                xmlsecurity::numericStringToBigInteger( rInfo.ouX509SerialNumber ) );
 
-                // Verify certificate
-                //We have patched our version of libxmlsec, so that it does not verify the certificates. This has two
-                //reasons. First we want two separate status for signature and certificate. Second libxmlsec calls
-                //CERT_VerifyCertificate (Solaris, Linux) falsely, so that it always regards the certificate as valid.
-                //On Windows the checking of the certificate path is buggy. It does name matching (issuer, subject name)
-                //to find the parent certificate. It does not take into account that there can be several certificates
-                //with the same subject name.
+                // On Windows checking the certificate path is buggy. It does name matching (issuer, subject name)
+                // to find the parent certificate. It does not take into account that there can be several certificates
+                // with the same subject name.
 
                 try {
                     rSigInfo.CertificateStatus = xSecEnv->verifyCertificate(rSigInfo.Signer,