[Libreoffice-commits] core.git: svgio/inc svgio/qa svgio/source

Noel Grandin noel.grandin at collabora.co.uk
Fri Jul 21 06:37:58 UTC 2017


 svgio/inc/svgpatternnode.hxx                  |    2 +-
 svgio/inc/svgstyleattributes.hxx              |    2 +-
 svgio/inc/svgtextnode.hxx                     |    2 +-
 svgio/inc/svgtools.hxx                        |    4 ++--
 svgio/qa/cppunit/SvgImportTest.cxx            |    4 ++--
 svgio/source/svgreader/svgdocumenthandler.cxx |    2 +-
 svgio/source/svgreader/svgpatternnode.cxx     |    2 +-
 svgio/source/svgreader/svgstyleattributes.cxx |    2 +-
 svgio/source/svgreader/svgtextnode.cxx        |    2 +-
 svgio/source/svgreader/svgtools.cxx           |    4 ++--
 10 files changed, 13 insertions(+), 13 deletions(-)

New commits:
commit 65c69af584152a5f8f3d2f9752d9f051660b7755
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Thu Jul 20 15:44:23 2017 +0200

    loplugin:constparams in svgio
    
    Change-Id: I35dd8b1373ce3c46a10b1da1ddc6dc3722ffa760
    Reviewed-on: https://gerrit.libreoffice.org/40245
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svgio/inc/svgpatternnode.hxx b/svgio/inc/svgpatternnode.hxx
index f22439eae86a..4a3247542220 100644
--- a/svgio/inc/svgpatternnode.hxx
+++ b/svgio/inc/svgpatternnode.hxx
@@ -69,7 +69,7 @@ namespace svgio
             virtual void parseAttribute(const OUString& rTokenName, SVGToken aSVGToken, const OUString& aContent) override;
 
             /// global helpers
-            void getValuesRelative(double& rfX, double& rfY, double& rfW, double& rfH, const basegfx::B2DRange& rGeoRange, SvgNode& rUser) const;
+            void getValuesRelative(double& rfX, double& rfY, double& rfW, double& rfH, const basegfx::B2DRange& rGeoRange, SvgNode const & rUser) const;
 
             /// get pattern primitives buffered, uses decomposeSvgNode internally
             const drawinglayer::primitive2d::Primitive2DContainer& getPatternPrimitives() const;
diff --git a/svgio/inc/svgstyleattributes.hxx b/svgio/inc/svgstyleattributes.hxx
index ab9b0479bf13..7eb7261f39f5 100644
--- a/svgio/inc/svgstyleattributes.hxx
+++ b/svgio/inc/svgstyleattributes.hxx
@@ -289,7 +289,7 @@ namespace svgio
             /// helper which does the necessary with a given path
             void add_text(
                 drawinglayer::primitive2d::Primitive2DContainer& rTarget,
-                drawinglayer::primitive2d::Primitive2DContainer& rSource) const;
+                drawinglayer::primitive2d::Primitive2DContainer const & rSource) const;
             void add_path(
                 const basegfx::B2DPolyPolygon& rPath,
                 drawinglayer::primitive2d::Primitive2DContainer& rTarget,
diff --git a/svgio/inc/svgtextnode.hxx b/svgio/inc/svgtextnode.hxx
index db1f26076e03..589f806ec8a9 100644
--- a/svgio/inc/svgtextnode.hxx
+++ b/svgio/inc/svgtextnode.hxx
@@ -48,7 +48,7 @@ namespace svgio
             static void addTextPrimitives(
                 const SvgNode& rCandidate,
                 drawinglayer::primitive2d::Primitive2DContainer& rTarget,
-                drawinglayer::primitive2d::Primitive2DContainer& rSource);
+                drawinglayer::primitive2d::Primitive2DContainer const & rSource);
 
         public:
             SvgTextNode(
diff --git a/svgio/inc/svgtools.hxx b/svgio/inc/svgtools.hxx
index 7d339fac6230..c37dc5d2c274 100644
--- a/svgio/inc/svgtools.hxx
+++ b/svgio/inc/svgtools.hxx
@@ -194,8 +194,8 @@ namespace svgio
         sal_Int32 read_hex(sal_Unicode aChar);
         bool match_colorKeyword(basegfx::BColor& rColor, const OUString& rName, bool bCaseIndependent);
         bool read_color(const OUString& rCandidate, basegfx::BColor& rColor, bool bCaseIndependent, SvgNumber& rOpacity);
-        basegfx::B2DRange readViewBox(const OUString& rCandidate, InfoProvider& rInfoProvider);
-        basegfx::B2DHomMatrix readTransform(const OUString& rCandidate, InfoProvider& rInfoProvider);
+        basegfx::B2DRange readViewBox(const OUString& rCandidate, InfoProvider const & rInfoProvider);
+        basegfx::B2DHomMatrix readTransform(const OUString& rCandidate, InfoProvider const & rInfoProvider);
         bool readSingleNumber(const OUString& rCandidate, SvgNumber& aNum);
         bool readLocalUrl(const OUString& rCandidate, OUString& rURL);
         bool readSvgPaint(const OUString& rCandidate, SvgPaint& rSvgPaint, OUString& rURL, bool bCaseIndependent, SvgNumber& rOpacity);
diff --git a/svgio/qa/cppunit/SvgImportTest.cxx b/svgio/qa/cppunit/SvgImportTest.cxx
index 9a612f427114..da3e200a6285 100644
--- a/svgio/qa/cppunit/SvgImportTest.cxx
+++ b/svgio/qa/cppunit/SvgImportTest.cxx
@@ -36,7 +36,7 @@ using drawinglayer::primitive2d::Primitive2DContainer;
 
 class Test : public test::BootstrapFixture, public XmlTestTools
 {
-    void checkRectPrimitive(Primitive2DSequence& rPrimitive);
+    void checkRectPrimitive(Primitive2DSequence const & rPrimitive);
 
     void testStyles();
     void testTdf87309();
@@ -113,7 +113,7 @@ Primitive2DSequence Test::parseSvg(const char* aSource)
     return xSvgParser->getDecomposition(aInputStream, aPath);
 }
 
-void Test::checkRectPrimitive(Primitive2DSequence& rPrimitive)
+void Test::checkRectPrimitive(Primitive2DSequence const & rPrimitive)
 {
     Primitive2dXmlDump dumper;
     xmlDocPtr pDocument = dumper.dumpAndParse(comphelper::sequenceToContainer<Primitive2DContainer>(rPrimitive));
diff --git a/svgio/source/svgreader/svgdocumenthandler.cxx b/svgio/source/svgreader/svgdocumenthandler.cxx
index 4d7171e8fef8..208eb90c1634 100644
--- a/svgio/source/svgreader/svgdocumenthandler.cxx
+++ b/svgio/source/svgreader/svgdocumenthandler.cxx
@@ -50,7 +50,7 @@ using namespace com::sun::star;
 
 namespace
 {
-    svgio::svgreader::SvgCharacterNode* whiteSpaceHandling(svgio::svgreader::SvgNode* pNode, svgio::svgreader::SvgCharacterNode* pLast)
+    svgio::svgreader::SvgCharacterNode* whiteSpaceHandling(svgio::svgreader::SvgNode const * pNode, svgio::svgreader::SvgCharacterNode* pLast)
     {
         if(pNode)
         {
diff --git a/svgio/source/svgreader/svgpatternnode.cxx b/svgio/source/svgreader/svgpatternnode.cxx
index 6fddc16af0c2..50e2a38b6fe8 100644
--- a/svgio/source/svgreader/svgpatternnode.cxx
+++ b/svgio/source/svgreader/svgpatternnode.cxx
@@ -198,7 +198,7 @@ namespace svgio
             }
         }
 
-        void SvgPatternNode::getValuesRelative(double& rfX, double& rfY, double& rfW, double& rfH, const basegfx::B2DRange& rGeoRange, SvgNode& rUser) const
+        void SvgPatternNode::getValuesRelative(double& rfX, double& rfY, double& rfW, double& rfH, const basegfx::B2DRange& rGeoRange, SvgNode const & rUser) const
         {
             double fTargetWidth(rGeoRange.getWidth());
             double fTargetHeight(rGeoRange.getHeight());
diff --git a/svgio/source/svgreader/svgstyleattributes.cxx b/svgio/source/svgreader/svgstyleattributes.cxx
index 19e2bfd9bb91..7d61bd027caa 100644
--- a/svgio/source/svgreader/svgstyleattributes.cxx
+++ b/svgio/source/svgreader/svgstyleattributes.cxx
@@ -253,7 +253,7 @@ namespace svgio
 
         void SvgStyleAttributes::add_text(
             drawinglayer::primitive2d::Primitive2DContainer& rTarget,
-            drawinglayer::primitive2d::Primitive2DContainer& rSource) const
+            drawinglayer::primitive2d::Primitive2DContainer const & rSource) const
         {
             if(!rSource.empty())
             {
diff --git a/svgio/source/svgreader/svgtextnode.cxx b/svgio/source/svgreader/svgtextnode.cxx
index 16c9d4bf93ef..0760f2c184b5 100644
--- a/svgio/source/svgreader/svgtextnode.cxx
+++ b/svgio/source/svgreader/svgtextnode.cxx
@@ -88,7 +88,7 @@ namespace svgio
         void SvgTextNode::addTextPrimitives(
             const SvgNode& rCandidate,
             drawinglayer::primitive2d::Primitive2DContainer& rTarget,
-            drawinglayer::primitive2d::Primitive2DContainer& rSource)
+            drawinglayer::primitive2d::Primitive2DContainer const & rSource)
         {
             if(!rSource.empty())
             {
diff --git a/svgio/source/svgreader/svgtools.cxx b/svgio/source/svgreader/svgtools.cxx
index cb85a7e635f0..21257cd6a0d8 100644
--- a/svgio/source/svgreader/svgtools.cxx
+++ b/svgio/source/svgreader/svgtools.cxx
@@ -956,7 +956,7 @@ namespace svgio
             return false;
         }
 
-        basegfx::B2DRange readViewBox(const OUString& rCandidate, InfoProvider& rInfoProvider)
+        basegfx::B2DRange readViewBox(const OUString& rCandidate, InfoProvider const & rInfoProvider)
         {
             const sal_Int32 nLen(rCandidate.getLength());
 
@@ -997,7 +997,7 @@ namespace svgio
             return basegfx::B2DRange();
         }
 
-        basegfx::B2DHomMatrix readTransform(const OUString& rCandidate, InfoProvider& rInfoProvider)
+        basegfx::B2DHomMatrix readTransform(const OUString& rCandidate, InfoProvider const & rInfoProvider)
         {
             basegfx::B2DHomMatrix aMatrix;
             const sal_Int32 nLen(rCandidate.getLength());


More information about the Libreoffice-commits mailing list