[Libreoffice-commits] core.git: compilerplugins/clang
Julien Nabet
serval2412 at yahoo.fr
Sat Jul 22 12:16:43 UTC 2017
compilerplugins/clang/unusedfields.cxx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
New commits:
commit 1cf7a4c39e701023472a16467bd81aeacf5ff053
Author: Julien Nabet <serval2412 at yahoo.fr>
Date: Sat Jul 22 13:20:05 2017 +0200
Typo: "disposeAndClear", not "clearAndDispose"
Change-Id: I9f7f30fce9324f7ccb79e9a8ef0c13e091d7c3a3
Reviewed-on: https://gerrit.libreoffice.org/40304
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unusedfields.cxx b/compilerplugins/clang/unusedfields.cxx
index a775a979deb3..66c959d519a5 100644
--- a/compilerplugins/clang/unusedfields.cxx
+++ b/compilerplugins/clang/unusedfields.cxx
@@ -472,10 +472,10 @@ void UnusedFields::checkWriteOnly(const FieldDecl* fieldDecl, const Expr* member
if (startswith(name, "read") || name.find(">>=") != std::string::npos)
// this is a write-only call
;
- else if (name == "clear" || name == "dispose" || name == "clearAndDispose" || name == "swap")
+ else if (name == "clear" || name == "dispose" || name == "disposeAndClear" || name == "swap")
// we're abusing the write-only analysis here to look for fields which don't have anything useful
// being done to them, so we're ignoring things like std::vector::clear, std::vector::swap,
- // and VclPtr::clearAndDispose
+ // and VclPtr::disposeAndClear
;
else
bPotentiallyReadFrom = true;
More information about the Libreoffice-commits
mailing list