[Libreoffice-commits] core.git: xmlsecurity/inc xmlsecurity/source
Noel Grandin
noel.grandin at collabora.co.uk
Thu Jul 27 08:59:17 UTC 2017
xmlsecurity/inc/framework/saxeventkeeperimpl.hxx | 4 -
xmlsecurity/inc/xmlsec/xmlstreamio.hxx | 2
xmlsecurity/inc/xsecctl.hxx | 24 +++++-----
xmlsecurity/source/framework/saxeventkeeperimpl.cxx | 6 +-
xmlsecurity/source/helper/xsecverify.cxx | 22 ++++-----
xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx | 2
xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx | 2
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx | 2
xmlsecurity/source/xmlsec/xmlstreamio.cxx | 2
9 files changed, 33 insertions(+), 33 deletions(-)
New commits:
commit b064a22f716d81cf293c8428cf1c7862811041ed
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Thu Jul 27 10:03:53 2017 +0200
loplugin:constparams in xmlsecurity
Change-Id: I41f153af55262d201c0fb024460de0e9f1c14670
Reviewed-on: https://gerrit.libreoffice.org/40472
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx b/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx
index 160102b2cbb0..b232629b35b1 100644
--- a/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx
+++ b/xmlsecurity/inc/framework/saxeventkeeperimpl.hxx
@@ -187,10 +187,10 @@ private:
void removeElementMarkBuffer(sal_Int32 nId);
OUString printBufferNode(
- BufferNode* pBufferNode, sal_Int32 nIndent) const;
+ BufferNode const * pBufferNode, sal_Int32 nIndent) const;
static css::uno::Sequence< css::uno::Reference< css::xml::wrapper::XXMLElementWrapper > >
- collectChildWorkingElement(BufferNode* pBufferNode);
+ collectChildWorkingElement(BufferNode const * pBufferNode);
void smashBufferNode(
BufferNode* pBufferNode, bool bClearRoot) const;
diff --git a/xmlsecurity/inc/xmlsec/xmlstreamio.hxx b/xmlsecurity/inc/xmlsec/xmlstreamio.hxx
index 9483fdb25475..6847ebecf6de 100644
--- a/xmlsecurity/inc/xmlsec/xmlstreamio.hxx
+++ b/xmlsecurity/inc/xmlsec/xmlstreamio.hxx
@@ -28,7 +28,7 @@
XSECXMLSEC_DLLPUBLIC int xmlEnableStreamInputCallbacks() ;
XSECXMLSEC_DLLPUBLIC void xmlDisableStreamInputCallbacks() ;
XSECXMLSEC_DLLPUBLIC int xmlRegisterStreamInputCallbacks(
- css::uno::Reference< css::xml::crypto::XUriBinding >& aUriBinding
+ css::uno::Reference< css::xml::crypto::XUriBinding > const & aUriBinding
);
XSECXMLSEC_DLLPUBLIC int xmlUnregisterStreamInputCallbacks() ;
diff --git a/xmlsecurity/inc/xsecctl.hxx b/xmlsecurity/inc/xsecctl.hxx
index 0cab6691bb63..ec2762665eda 100644
--- a/xmlsecurity/inc/xsecctl.hxx
+++ b/xmlsecurity/inc/xsecctl.hxx
@@ -303,16 +303,16 @@ private:
sal_Int32 nDigestID );
void setReferenceCount() const;
- void setX509IssuerName( OUString& ouX509IssuerName );
- void setX509SerialNumber( OUString& ouX509SerialNumber );
- void setX509Certificate( OUString& ouX509Certificate );
- void setSignatureValue( OUString& ouSignatureValue );
- void setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValue );
- void setGpgKeyID( OUString& ouKeyID );
- void setGpgCertificate( OUString& ouGpgCert );
- void setGpgOwner( OUString& ouGpgOwner );
-
- void setDate( OUString& ouDate );
+ void setX509IssuerName( OUString const & ouX509IssuerName );
+ void setX509SerialNumber( OUString const & ouX509SerialNumber );
+ void setX509Certificate( OUString const & ouX509Certificate );
+ void setSignatureValue( OUString const & ouSignatureValue );
+ void setDigestValue( sal_Int32 nDigestID, OUString const & ouDigestValue );
+ void setGpgKeyID( OUString const & ouKeyID );
+ void setGpgCertificate( OUString const & ouGpgCert );
+ void setGpgOwner( OUString const & ouGpgOwner );
+
+ void setDate( OUString const & ouDate );
void setDescription(const OUString& rDescription);
void setCertDigest(const OUString& rCertDigest);
@@ -320,8 +320,8 @@ public:
void setSignatureBytes(const css::uno::Sequence<sal_Int8>& rBytes);
private:
- void setId( OUString& ouId );
- void setPropertyId( OUString& ouPropertyId );
+ void setId( OUString const & ouId );
+ void setPropertyId( OUString const & ouPropertyId );
css::uno::Reference< css::xml::crypto::sax::XReferenceResolvedListener > prepareSignatureToRead(
sal_Int32 nSecurityId );
diff --git a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
index e744285ef028..b241912a3514 100644
--- a/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
+++ b/xmlsecurity/source/framework/saxeventkeeperimpl.cxx
@@ -272,7 +272,7 @@ void SAXEventKeeperImpl::removeElementMarkBuffer(sal_Int32 nId)
}
OUString SAXEventKeeperImpl::printBufferNode(
- BufferNode* pBufferNode, sal_Int32 nIndent) const
+ BufferNode const * pBufferNode, sal_Int32 nIndent) const
/****** SAXEventKeeperImpl/printBufferNode ***********************************
*
* NAME
@@ -340,7 +340,7 @@ OUString SAXEventKeeperImpl::printBufferNode(
for( auto jj = vChildren->begin();
jj != vChildren->end(); ++jj )
{
- rc += printBufferNode(const_cast<BufferNode *>(*jj), nIndent+4);
+ rc += printBufferNode(*jj, nIndent+4);
}
delete vChildren;
@@ -349,7 +349,7 @@ OUString SAXEventKeeperImpl::printBufferNode(
}
cssu::Sequence< cssu::Reference< cssxw::XXMLElementWrapper > >
- SAXEventKeeperImpl::collectChildWorkingElement(BufferNode* pBufferNode)
+ SAXEventKeeperImpl::collectChildWorkingElement(BufferNode const * pBufferNode)
/****** SAXEventKeeperImpl/collectChildWorkingElement ************************
*
* NAME
diff --git a/xmlsecurity/source/helper/xsecverify.cxx b/xmlsecurity/source/helper/xsecverify.cxx
index e76e5afec92b..c60bbde22894 100644
--- a/xmlsecurity/source/helper/xsecverify.cxx
+++ b/xmlsecurity/source/helper/xsecverify.cxx
@@ -209,7 +209,7 @@ void XSecController::setReferenceCount() const
}
}
-void XSecController::setX509IssuerName( OUString& ouX509IssuerName )
+void XSecController::setX509IssuerName( OUString const & ouX509IssuerName )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -220,7 +220,7 @@ void XSecController::setX509IssuerName( OUString& ouX509IssuerName )
isi.signatureInfor.ouX509IssuerName = ouX509IssuerName;
}
-void XSecController::setX509SerialNumber( OUString& ouX509SerialNumber )
+void XSecController::setX509SerialNumber( OUString const & ouX509SerialNumber )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -231,7 +231,7 @@ void XSecController::setX509SerialNumber( OUString& ouX509SerialNumber )
isi.signatureInfor.ouX509SerialNumber = ouX509SerialNumber;
}
-void XSecController::setX509Certificate( OUString& ouX509Certificate )
+void XSecController::setX509Certificate( OUString const & ouX509Certificate )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -242,7 +242,7 @@ void XSecController::setX509Certificate( OUString& ouX509Certificate )
isi.signatureInfor.ouX509Certificate = ouX509Certificate;
}
-void XSecController::setSignatureValue( OUString& ouSignatureValue )
+void XSecController::setSignatureValue( OUString const & ouSignatureValue )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -253,7 +253,7 @@ void XSecController::setSignatureValue( OUString& ouSignatureValue )
isi.signatureInfor.ouSignatureValue = ouSignatureValue;
}
-void XSecController::setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValue )
+void XSecController::setDigestValue( sal_Int32 nDigestID, OUString const & ouDigestValue )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -272,7 +272,7 @@ void XSecController::setDigestValue( sal_Int32 nDigestID, OUString& ouDigestValu
reference.ouDigestValue = ouDigestValue;
}
-void XSecController::setGpgKeyID( OUString& ouKeyID )
+void XSecController::setGpgKeyID( OUString const & ouKeyID )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -283,7 +283,7 @@ void XSecController::setGpgKeyID( OUString& ouKeyID )
isi.signatureInfor.ouGpgKeyID = ouKeyID;
}
-void XSecController::setGpgCertificate( OUString& ouGpgCert )
+void XSecController::setGpgCertificate( OUString const & ouGpgCert )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -294,7 +294,7 @@ void XSecController::setGpgCertificate( OUString& ouGpgCert )
isi.signatureInfor.ouGpgCertificate = ouGpgCert;
}
-void XSecController::setGpgOwner( OUString& ouGpgOwner )
+void XSecController::setGpgOwner( OUString const & ouGpgOwner )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -305,7 +305,7 @@ void XSecController::setGpgOwner( OUString& ouGpgOwner )
isi.signatureInfor.ouGpgOwner = ouGpgOwner;
}
-void XSecController::setDate( OUString& ouDate )
+void XSecController::setDate( OUString const & ouDate )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -356,7 +356,7 @@ void XSecController::addEncapsulatedX509Certificate(const OUString& rEncapsulate
rInformation.signatureInfor.maEncapsulatedX509Certificates.insert(rEncapsulatedX509Certificate);
}
-void XSecController::setId( OUString& ouId )
+void XSecController::setId( OUString const & ouId )
{
if (m_vInternalSignatureInformations.empty())
{
@@ -367,7 +367,7 @@ void XSecController::setId( OUString& ouId )
isi.signatureInfor.ouSignatureId = ouId;
}
-void XSecController::setPropertyId( OUString& ouPropertyId )
+void XSecController::setPropertyId( OUString const & ouPropertyId )
{
if (m_vInternalSignatureInformations.empty())
{
diff --git a/xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx b/xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx
index 112aebc7f7d8..3dbcbd0c1eb3 100644
--- a/xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx
+++ b/xmlsecurity/source/xmlsec/certificateextension_xmlsecimpl.hxx
@@ -52,7 +52,7 @@ class CertificateExtension_XmlSecImpl : public ::cppu::WeakImplHelper<
return m_Extn.m_xExtnValue;
}
- void setCertExtn(unsigned char* value, unsigned int vlen, unsigned char* id, unsigned int idlen, bool critical)
+ void setCertExtn(unsigned char const * value, unsigned int vlen, unsigned char const * id, unsigned int idlen, bool critical)
{
m_Extn.setCertExtn(value, vlen, id, idlen, critical);
}
diff --git a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
index 3e2d85b739e4..5e2e36e18155 100644
--- a/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
+++ b/xmlsecurity/source/xmlsec/nss/sanextension_nssimpl.hxx
@@ -58,7 +58,7 @@ class SanExtensionImpl : public ::cppu::WeakImplHelper<
return m_Extn.m_xExtnValue;
}
- void setCertExtn(unsigned char* value, unsigned int vlen, unsigned char* id, unsigned int idlen, bool critical)
+ void setCertExtn(unsigned char const * value, unsigned int vlen, unsigned char const * id, unsigned int idlen, bool critical)
{
m_Extn.setCertExtn(value, vlen, id, idlen, critical);
}
diff --git a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
index e168fca4a674..c2f0f1da6213 100644
--- a/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
+++ b/xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx
@@ -348,7 +348,7 @@ const Sequence< sal_Int8>& X509Certificate_NssImpl::getUnoTunnelId() {
return theX509Certificate_NssImplUnoTunnelId::get().getSeq();
}
-OUString getAlgorithmDescription(SECAlgorithmID *aid)
+OUString getAlgorithmDescription(SECAlgorithmID const *aid)
{
SECOidTag tag;
tag = SECOID_GetAlgorithmTag(aid);
diff --git a/xmlsecurity/source/xmlsec/xmlstreamio.cxx b/xmlsecurity/source/xmlsec/xmlstreamio.cxx
index 52d66b1d0e4d..556cb3ce8fa6 100644
--- a/xmlsecurity/source/xmlsec/xmlstreamio.cxx
+++ b/xmlsecurity/source/xmlsec/xmlstreamio.cxx
@@ -181,7 +181,7 @@ XSECXMLSEC_DLLPUBLIC int xmlEnableStreamInputCallbacks()
}
XSECXMLSEC_DLLPUBLIC int xmlRegisterStreamInputCallbacks(
- css::uno::Reference< css::xml::crypto::XUriBinding >& aUriBinding
+ css::uno::Reference< css::xml::crypto::XUriBinding > const & aUriBinding
) {
if( !( enableXmlStreamIO & XMLSTREAMIO_INITIALIZED ) ) {
if( xmlEnableStreamInputCallbacks() < 0 )
More information about the Libreoffice-commits
mailing list