[Libreoffice-commits] core.git: chart2/source compilerplugins/clang
Noel Grandin
noel.grandin at collabora.co.uk
Thu Jul 27 11:24:10 UTC 2017
chart2/source/controller/dialogs/dlg_DataEditor.cxx | 2 -
chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx | 4 +--
chart2/source/controller/dialogs/tp_DataSource.cxx | 2 -
chart2/source/controller/drawinglayer/DrawViewWrapper.cxx | 4 +--
chart2/source/controller/inc/ChartController.hxx | 2 -
chart2/source/controller/inc/DrawViewWrapper.hxx | 2 -
chart2/source/controller/inc/SelectionHelper.hxx | 4 +--
chart2/source/controller/inc/dlg_DataEditor.hxx | 2 -
chart2/source/controller/main/ChartController_Properties.cxx | 2 -
chart2/source/controller/main/ChartController_Tools.cxx | 2 -
chart2/source/controller/main/ChartController_Window.cxx | 2 -
chart2/source/controller/main/DrawCommandDispatch.cxx | 2 -
chart2/source/controller/main/SelectionHelper.cxx | 6 ++--
chart2/source/controller/uitest/uiobject.cxx | 2 -
chart2/source/inc/LifeTime.hxx | 2 -
chart2/source/inc/RegressionCurveCalculator.hxx | 2 -
chart2/source/inc/RegressionCurveHelper.hxx | 14 +++++------
chart2/source/inc/StatisticsHelper.hxx | 2 -
chart2/source/inc/chartview/DrawModelWrapper.hxx | 2 -
chart2/source/model/filter/XMLFilter.cxx | 2 -
chart2/source/model/inc/XMLFilter.hxx | 2 -
chart2/source/tools/LifeTime.cxx | 2 -
chart2/source/tools/ModifyListenerHelper.cxx | 2 -
chart2/source/tools/RegressionCurveCalculator.cxx | 2 -
chart2/source/tools/RegressionCurveHelper.cxx | 14 +++++------
chart2/source/tools/StatisticsHelper.cxx | 2 -
chart2/source/view/axes/VCartesianAxis.cxx | 8 +++---
chart2/source/view/axes/VCartesianAxis.hxx | 8 +++---
chart2/source/view/axes/VPolarGrid.cxx | 2 -
chart2/source/view/axes/VPolarGrid.hxx | 2 -
chart2/source/view/charttypes/AreaChart.cxx | 10 +++----
chart2/source/view/charttypes/AreaChart.hxx | 10 +++----
chart2/source/view/charttypes/BarChart.cxx | 2 -
chart2/source/view/charttypes/BarChart.hxx | 2 -
chart2/source/view/charttypes/GL3DBarChart.cxx | 4 +--
chart2/source/view/charttypes/NetChart.cxx | 6 ++--
chart2/source/view/charttypes/NetChart.hxx | 6 ++--
chart2/source/view/charttypes/PieChart.cxx | 6 ++--
chart2/source/view/charttypes/PieChart.hxx | 6 ++--
chart2/source/view/charttypes/VSeriesPlotter.cxx | 14 +++++------
chart2/source/view/inc/GL3DBarChart.hxx | 4 +--
chart2/source/view/inc/GL3DRenderer.hxx | 4 +--
chart2/source/view/inc/PropertyMapper.hxx | 2 -
chart2/source/view/inc/VSeriesPlotter.hxx | 8 +++---
chart2/source/view/main/ChartView.cxx | 2 -
chart2/source/view/main/DrawModelWrapper.cxx | 2 -
chart2/source/view/main/GL3DRenderer.cxx | 4 +--
chart2/source/view/main/PropertyMapper.cxx | 2 -
compilerplugins/clang/constparams.cxx | 3 ++
49 files changed, 103 insertions(+), 100 deletions(-)
New commits:
commit 620d032b1807477ef1e2b547ce772c284aa0da50
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Thu Jul 27 12:04:27 2017 +0200
loplugin:constparams in chart2
Change-Id: Ic325b79f04e04aa19e08a60db30b982d90f04c80
Reviewed-on: https://gerrit.libreoffice.org/40480
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/chart2/source/controller/dialogs/dlg_DataEditor.cxx b/chart2/source/controller/dialogs/dlg_DataEditor.cxx
index 441b62e774ef..7a8019e0fa43 100644
--- a/chart2/source/controller/dialogs/dlg_DataEditor.cxx
+++ b/chart2/source/controller/dialogs/dlg_DataEditor.cxx
@@ -201,7 +201,7 @@ bool DataEditor::ApplyChangesToModel()
// travels/no longer travels over this window. _rMemFunc may be
// TaskPaneList::AddWindow or TaskPaneList::RemoveWindow
void DataEditor::notifySystemWindow(
- vcl::Window* pWindow, vcl::Window* pToRegister,
+ vcl::Window const * pWindow, vcl::Window* pToRegister,
const ::comphelper::mem_fun1_t<TaskPaneList, vcl::Window*>& rMemFunc )
{
OSL_ENSURE( pWindow, "Window must not be null!" );
diff --git a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
index 8fa025917989..9863f5ea615e 100644
--- a/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
+++ b/chart2/source/controller/dialogs/tp_3D_SceneAppearance.cxx
@@ -44,7 +44,7 @@ struct lcl_ModelProperties
{}
};
-lcl_ModelProperties lcl_getPropertiesFromModel( uno::Reference< frame::XModel > & xModel )
+lcl_ModelProperties lcl_getPropertiesFromModel( uno::Reference< frame::XModel > const & xModel )
{
lcl_ModelProperties aProps;
try
@@ -62,7 +62,7 @@ lcl_ModelProperties lcl_getPropertiesFromModel( uno::Reference< frame::XModel >
return aProps;
}
-void lcl_setShadeModeAtModel( uno::Reference< frame::XModel > & xModel, drawing::ShadeMode aShadeMode )
+void lcl_setShadeModeAtModel( uno::Reference< frame::XModel > const & xModel, drawing::ShadeMode aShadeMode )
{
try
{
diff --git a/chart2/source/controller/dialogs/tp_DataSource.cxx b/chart2/source/controller/dialogs/tp_DataSource.cxx
index 0d0e1cdef9d7..14d99d672ce3 100644
--- a/chart2/source/controller/dialogs/tp_DataSource.cxx
+++ b/chart2/source/controller/dialogs/tp_DataSource.cxx
@@ -115,7 +115,7 @@ OUString lcl_GetSelectedRolesRange( const SvTabListBox & rRoleListBox )
return aResult;
}
-OUString lcl_GetSequenceNameForLabel( ::chart::SeriesEntry * pEntry )
+OUString lcl_GetSequenceNameForLabel( ::chart::SeriesEntry const * pEntry )
{
OUString aResult( "values-y" );
if( pEntry &&
diff --git a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
index a683b2892368..1898a18797b3 100644
--- a/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
+++ b/chart2/source/controller/drawinglayer/DrawViewWrapper.cxx
@@ -49,7 +49,7 @@ namespace chart
namespace
{
- short lcl_getHitTolerance( OutputDevice* pOutDev )
+ short lcl_getHitTolerance( OutputDevice const * pOutDev )
{
const short HITPIX=2; //hit-tolerance in pixel
short nHitTolerance = 50;
@@ -307,7 +307,7 @@ SdrObject* DrawViewWrapper::getNamedSdrObject( const OUString& rName ) const
return nullptr;
}
-bool DrawViewWrapper::IsObjectHit( SdrObject* pObj, const Point& rPnt )
+bool DrawViewWrapper::IsObjectHit( SdrObject const * pObj, const Point& rPnt )
{
if(pObj)
{
diff --git a/chart2/source/controller/inc/ChartController.hxx b/chart2/source/controller/inc/ChartController.hxx
index 19ac675b14ae..29f74ad358e2 100644
--- a/chart2/source/controller/inc/ChartController.hxx
+++ b/chart2/source/controller/inc/ChartController.hxx
@@ -530,7 +530,7 @@ private:
css::uno::Reference< css::accessibility::XAccessibleContext >
impl_createAccessibleTextContext();
- void impl_PasteGraphic( css::uno::Reference< css::graphic::XGraphic > & xGraphic,
+ void impl_PasteGraphic( css::uno::Reference< css::graphic::XGraphic > const & xGraphic,
const ::Point & aPosition );
void impl_PasteShapes( SdrModel* pModel );
void impl_PasteStringAsTextShape( const OUString& rString, const css::awt::Point& rPosition );
diff --git a/chart2/source/controller/inc/DrawViewWrapper.hxx b/chart2/source/controller/inc/DrawViewWrapper.hxx
index 1561fd6819ef..91ffdf7eeb1b 100644
--- a/chart2/source/controller/inc/DrawViewWrapper.hxx
+++ b/chart2/source/controller/inc/DrawViewWrapper.hxx
@@ -76,7 +76,7 @@ public:
SfxItemSet getPositionAndSizeItemSetFromMarkedObject() const;
SdrObject* getNamedSdrObject( const OUString& rName ) const;
- static bool IsObjectHit( SdrObject* pObj, const Point& rPnt );
+ static bool IsObjectHit( SdrObject const * pObj, const Point& rPnt );
virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;
diff --git a/chart2/source/controller/inc/SelectionHelper.hxx b/chart2/source/controller/inc/SelectionHelper.hxx
index e6257a0e6044..b1c0c8cbef7e 100644
--- a/chart2/source/controller/inc/SelectionHelper.hxx
+++ b/chart2/source/controller/inc/SelectionHelper.hxx
@@ -59,7 +59,7 @@ public: //methods
void remindSelectionBeforeMouseDown();
bool isSelectionDifferentFromBeforeMouseDown() const;
- void adaptSelectionToNewPos( const Point& rMousePos, DrawViewWrapper* pDrawViewWrapper
+ void adaptSelectionToNewPos( const Point& rMousePos, DrawViewWrapper const * pDrawViewWrapper
, bool bIsRightMouse, bool bWaitingForDoubleClick );
void applySelection( DrawViewWrapper* pDrawViewWrapper );
@@ -92,7 +92,7 @@ public:
static OUString getHitObjectCID(
const Point& rMPos,
- DrawViewWrapper& rDrawViewWrapper,
+ DrawViewWrapper const & rDrawViewWrapper,
bool bGetDiagramInsteadOf_Wall=false );
static bool isRotateableObject( const OUString& rCID
diff --git a/chart2/source/controller/inc/dlg_DataEditor.hxx b/chart2/source/controller/inc/dlg_DataEditor.hxx
index d6e085899e4c..c6f74d6797b1 100644
--- a/chart2/source/controller/inc/dlg_DataEditor.hxx
+++ b/chart2/source/controller/inc/dlg_DataEditor.hxx
@@ -90,7 +90,7 @@ private:
@note this code is taken from dbaccess/source/ui/inc/UITools.hxx
*/
- static void notifySystemWindow(vcl::Window* pWindow,
+ static void notifySystemWindow(vcl::Window const * pWindow,
vcl::Window* pToRegister,
const ::comphelper::mem_fun1_t<TaskPaneList, vcl::Window*>& rMemFunc);
};
diff --git a/chart2/source/controller/main/ChartController_Properties.cxx b/chart2/source/controller/main/ChartController_Properties.cxx
index fcbfc3073f06..de3eebd88e76 100644
--- a/chart2/source/controller/main/ChartController_Properties.cxx
+++ b/chart2/source/controller/main/ChartController_Properties.cxx
@@ -71,7 +71,7 @@ namespace
wrapper::ItemConverter* createItemConverter(
const OUString & aObjectCID, const uno::Reference<frame::XModel>& xChartModel,
const uno::Reference<uno::XComponentContext>& xContext, SdrModel& rDrawModel,
- ExplicitValueProvider* pExplicitValueProvider, ReferenceSizeProvider* pRefSizeProvider )
+ ExplicitValueProvider* pExplicitValueProvider, ReferenceSizeProvider const * pRefSizeProvider )
{
wrapper::ItemConverter* pItemConverter=nullptr;
diff --git a/chart2/source/controller/main/ChartController_Tools.cxx b/chart2/source/controller/main/ChartController_Tools.cxx
index 38772a491eea..860cdde2bb9c 100644
--- a/chart2/source/controller/main/ChartController_Tools.cxx
+++ b/chart2/source/controller/main/ChartController_Tools.cxx
@@ -327,7 +327,7 @@ void ChartController::executeDispatch_Paste()
// note: aPosition is ignored for now. The object is always pasted centered to
// the page
void ChartController::impl_PasteGraphic(
- uno::Reference< graphic::XGraphic > & xGraphic,
+ uno::Reference< graphic::XGraphic > const & xGraphic,
const ::Point & /* aPosition */ )
{
DBG_TESTSOLARMUTEX();
diff --git a/chart2/source/controller/main/ChartController_Window.cxx b/chart2/source/controller/main/ChartController_Window.cxx
index e33db229fc59..dbbccd268591 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -109,7 +109,7 @@ bool lcl_GrowAndShiftLogic(
bool lcl_MoveObjectLogic(
RelativePosition & rInOutRelPos,
- RelativeSize & rObjectSize,
+ RelativeSize const & rObjectSize,
const awt::Size & rRefSize,
double fShiftLogicX,
double fShiftLogicY )
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx b/chart2/source/controller/main/DrawCommandDispatch.cxx
index 3d3803e4d266..0f281e8037a8 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -75,7 +75,7 @@ bool DrawCommandDispatch::isFeatureSupported( const OUString& rCommandURL )
return parseCommandURL( rCommandURL, &nFeatureId, &aBaseCommand, &aCustomShapeType );
}
-::basegfx::B2DPolyPolygon getPolygon(const char* pResId, SdrModel& rModel)
+::basegfx::B2DPolyPolygon getPolygon(const char* pResId, SdrModel const & rModel)
{
::basegfx::B2DPolyPolygon aReturn;
XLineEndListRef pLineEndList = rModel.GetLineEndList();
diff --git a/chart2/source/controller/main/SelectionHelper.cxx b/chart2/source/controller/main/SelectionHelper.cxx
index d77b2d6a2b7c..3d32d23f81de 100644
--- a/chart2/source/controller/main/SelectionHelper.cxx
+++ b/chart2/source/controller/main/SelectionHelper.cxx
@@ -38,7 +38,7 @@ using namespace ::com::sun::star;
namespace
{
-OUString lcl_getObjectName( SdrObject* pObj )
+OUString lcl_getObjectName( SdrObject const * pObj )
{
if(pObj)
return pObj->GetName();
@@ -156,7 +156,7 @@ void Selection::applySelection( DrawViewWrapper* pDrawViewWrapper )
}
}
-void Selection::adaptSelectionToNewPos( const Point& rMousePos, DrawViewWrapper* pDrawViewWrapper
+void Selection::adaptSelectionToNewPos( const Point& rMousePos, DrawViewWrapper const * pDrawViewWrapper
, bool bIsRightMouse, bool bWaitingForDoubleClick )
{
if( pDrawViewWrapper )
@@ -379,7 +379,7 @@ bool SelectionHelper::isDragableObjectHitTwice( const Point& rMPos
OUString SelectionHelper::getHitObjectCID(
const Point& rMPos,
- DrawViewWrapper& rDrawViewWrapper,
+ DrawViewWrapper const & rDrawViewWrapper,
bool bGetDiagramInsteadOf_Wall )
{
SolarMutexGuard aSolarGuard;
diff --git a/chart2/source/controller/uitest/uiobject.cxx b/chart2/source/controller/uitest/uiobject.cxx
index fa04a13d747f..d3c2cfd5cbd0 100644
--- a/chart2/source/controller/uitest/uiobject.cxx
+++ b/chart2/source/controller/uitest/uiobject.cxx
@@ -145,7 +145,7 @@ std::unique_ptr<UIObject> ChartWindowUIObject::get_child(const OUString& rID)
namespace {
-void recursiveAdd(chart::ObjectIdentifier& rID, std::set<OUString>& rChildren, const chart::ObjectHierarchy& rHierarchy)
+void recursiveAdd(chart::ObjectIdentifier const & rID, std::set<OUString>& rChildren, const chart::ObjectHierarchy& rHierarchy)
{
std::vector<chart::ObjectIdentifier> aChildIndentifiers = rHierarchy.getChildren(rID);
std::transform(aChildIndentifiers.begin(), aChildIndentifiers.end(), std::inserter(rChildren, rChildren.begin()),
diff --git a/chart2/source/inc/LifeTime.hxx b/chart2/source/inc/LifeTime.hxx
index 5a10d6b73e90..f129a06829d4 100644
--- a/chart2/source/inc/LifeTime.hxx
+++ b/chart2/source/inc/LifeTime.hxx
@@ -94,7 +94,7 @@ OOO_DLLPUBLIC_CHARTTOOLS bool impl_isDisposedOrClosed( bool bAssert=true )
/// @throws css::uno::Exception
OOO_DLLPUBLIC_CHARTTOOLS bool g_close_startTryClose(bool bDeliverOwnership);
/// @throws css::util::CloseVetoException
-OOO_DLLPUBLIC_CHARTTOOLS bool g_close_isNeedToCancelLongLastingCalls( bool bDeliverOwnership, css::util::CloseVetoException& ex );
+OOO_DLLPUBLIC_CHARTTOOLS bool g_close_isNeedToCancelLongLastingCalls( bool bDeliverOwnership, css::util::CloseVetoException const & ex );
OOO_DLLPUBLIC_CHARTTOOLS void g_close_endTryClose(bool bDeliverOwnership );
OOO_DLLPUBLIC_CHARTTOOLS void g_close_endTryClose_doClose();
/// @throws css::uno::RuntimeException
diff --git a/chart2/source/inc/RegressionCurveCalculator.hxx b/chart2/source/inc/RegressionCurveCalculator.hxx
index c5933e55aa11..18c220f981be 100644
--- a/chart2/source/inc/RegressionCurveCalculator.hxx
+++ b/chart2/source/inc/RegressionCurveCalculator.hxx
@@ -52,7 +52,7 @@ protected:
double fNumber,
const sal_Int32* pStringLength );
- static void addStringToEquation( OUStringBuffer& aStrEquation, sal_Int32& nLineLength, OUStringBuffer& aAddString, const sal_Int32* pMaxLength );
+ static void addStringToEquation( OUStringBuffer& aStrEquation, sal_Int32& nLineLength, OUStringBuffer const & aAddString, const sal_Int32* pMaxLength );
double m_fCorrelationCoeffitient;
diff --git a/chart2/source/inc/RegressionCurveHelper.hxx b/chart2/source/inc/RegressionCurveHelper.hxx
index 46ee61e4e0df..f268de036a8b 100644
--- a/chart2/source/inc/RegressionCurveHelper.hxx
+++ b/chart2/source/inc/RegressionCurveHelper.hxx
@@ -60,11 +60,11 @@ namespace RegressionCurveHelper
If set, this property-set will be used to apply a line color
*/
OOO_DLLPUBLIC_CHARTTOOLS void addMeanValueLine(
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xRegCnt,
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xRegCnt,
const css::uno::Reference<css::beans::XPropertySet>& xSeriesProp );
OOO_DLLPUBLIC_CHARTTOOLS void removeMeanValueLine(
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xRegCnt );
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xRegCnt );
/** Returns the first regression curve found that is not of type
mean-value line
@@ -97,7 +97,7 @@ namespace RegressionCurveHelper
OOO_DLLPUBLIC_CHARTTOOLS css::uno::Reference<css::chart2::XRegressionCurve>
addRegressionCurve(
SvxChartRegress eType,
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xCurveContainer,
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xCurveContainer,
const css::uno::Reference<css::uno::XComponentContext>& xContext,
const css::uno::Reference<css::beans::XPropertySet >& xPropertySource =
css::uno::Reference<css::beans::XPropertySet>(),
@@ -105,16 +105,16 @@ namespace RegressionCurveHelper
css::uno::Reference<css::beans::XPropertySet>() );
OOO_DLLPUBLIC_CHARTTOOLS bool removeAllExceptMeanValueLine(
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xCurveContainer );
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xCurveContainer );
OOO_DLLPUBLIC_CHARTTOOLS void removeEquations(
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xCurveContainer );
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xCurveContainer );
OOO_DLLPUBLIC_CHARTTOOLS css::uno::Reference<css::chart2::XRegressionCurve>
changeRegressionCurveType(
SvxChartRegress eType,
- css::uno::Reference<css::chart2::XRegressionCurveContainer>& xRegressionCurveContainer,
- css::uno::Reference<css::chart2::XRegressionCurve>& xRegressionCurve,
+ css::uno::Reference<css::chart2::XRegressionCurveContainer> const & xRegressionCurveContainer,
+ css::uno::Reference<css::chart2::XRegressionCurve> const & xRegressionCurve,
const css::uno::Reference<css::uno::XComponentContext>& xContext );
/// returns a calculator object for regression curves (used by the view)
diff --git a/chart2/source/inc/StatisticsHelper.hxx b/chart2/source/inc/StatisticsHelper.hxx
index f6410936ca3d..838c3bd59728 100644
--- a/chart2/source/inc/StatisticsHelper.hxx
+++ b/chart2/source/inc/StatisticsHelper.hxx
@@ -67,7 +67,7 @@ namespace StatisticsHelper
const OUString & rNewRange,
bool bPositiveValue,
bool bYError = true,
- OUString * pXMLRange = nullptr );
+ OUString const * pXMLRange = nullptr );
/// @return the newly created or existing error bar object
OOO_DLLPUBLIC_CHARTTOOLS css::uno::Reference< css::beans::XPropertySet >
diff --git a/chart2/source/inc/chartview/DrawModelWrapper.hxx b/chart2/source/inc/chartview/DrawModelWrapper.hxx
index 5c1852bc1236..c0dc7422a03f 100644
--- a/chart2/source/inc/chartview/DrawModelWrapper.hxx
+++ b/chart2/source/inc/chartview/DrawModelWrapper.hxx
@@ -82,7 +82,7 @@ public:
XPatternListRef GetPatternList() const;
SdrObject* getNamedSdrObject( const OUString& rName );
- static SdrObject* getNamedSdrObject( const OUString& rName, SdrObjList* pObjList );
+ static SdrObject* getNamedSdrObject( const OUString& rName, SdrObjList const * pObjList );
static bool removeShape( const css::uno::Reference< css::drawing::XShape >& xShape );
};
diff --git a/chart2/source/model/filter/XMLFilter.cxx b/chart2/source/model/filter/XMLFilter.cxx
index e34e2170f976..f5bddadbc2ee 100644
--- a/chart2/source/model/filter/XMLFilter.cxx
+++ b/chart2/source/model/filter/XMLFilter.cxx
@@ -409,7 +409,7 @@ ErrCode XMLFilter::impl_ImportStream(
const Reference< xml::sax::XParser > & xParser,
const Reference< lang::XMultiComponentFactory > & xFactory,
const Reference< document::XGraphicObjectResolver > & xGraphicObjectResolver,
- uno::Reference< beans::XPropertySet >& xImportInfo )
+ uno::Reference< beans::XPropertySet > const & xImportInfo )
{
ErrCode nWarning = ERRCODE_SFX_GENERAL;
diff --git a/chart2/source/model/inc/XMLFilter.hxx b/chart2/source/model/inc/XMLFilter.hxx
index 5eef0f5ac708..85c033c99a7e 100644
--- a/chart2/source/model/inc/XMLFilter.hxx
+++ b/chart2/source/model/inc/XMLFilter.hxx
@@ -106,7 +106,7 @@ private:
const css::uno::Reference< css::xml::sax::XParser > & xParser,
const css::uno::Reference< css::lang::XMultiComponentFactory > & xFactory,
const css::uno::Reference< css::document::XGraphicObjectResolver > & xGraphicObjectResolver,
- css::uno::Reference< css::beans::XPropertySet >& xPropSet );
+ css::uno::Reference< css::beans::XPropertySet > const & xPropSet );
/// @return a warning code, or 0 for successful operation
ErrCode impl_Export( const css::uno::Reference< css::lang::XComponent > & xDocumentComp,
diff --git a/chart2/source/tools/LifeTime.cxx b/chart2/source/tools/LifeTime.cxx
index 5df9f8f4715c..38891cad6be9 100644
--- a/chart2/source/tools/LifeTime.cxx
+++ b/chart2/source/tools/LifeTime.cxx
@@ -258,7 +258,7 @@ void CloseableLifeTimeManager::g_close_endTryClose(bool bDeliverOwnership )
impl_unregisterApiCall(false);
}
-bool CloseableLifeTimeManager::g_close_isNeedToCancelLongLastingCalls( bool bDeliverOwnership, util::CloseVetoException& ex )
+bool CloseableLifeTimeManager::g_close_isNeedToCancelLongLastingCalls( bool bDeliverOwnership, util::CloseVetoException const & ex )
{
//this method is called when no closelistener has had a veto during queryclosing
//the method returns false, if nothing stands against closing anymore
diff --git a/chart2/source/tools/ModifyListenerHelper.cxx b/chart2/source/tools/ModifyListenerHelper.cxx
index c6fd1d604773..79a377441253 100644
--- a/chart2/source/tools/ModifyListenerHelper.cxx
+++ b/chart2/source/tools/ModifyListenerHelper.cxx
@@ -31,7 +31,7 @@ namespace
{
void lcl_fireModifyEvent(
- ::cppu::OBroadcastHelper & rBroadcastHelper,
+ ::cppu::OBroadcastHelper const & rBroadcastHelper,
const Reference< uno::XWeak > & xEventSource,
const lang::EventObject * pEvent )
{
diff --git a/chart2/source/tools/RegressionCurveCalculator.cxx b/chart2/source/tools/RegressionCurveCalculator.cxx
index 6f2ab6a64288..4a1dc26a468d 100644
--- a/chart2/source/tools/RegressionCurveCalculator.cxx
+++ b/chart2/source/tools/RegressionCurveCalculator.cxx
@@ -194,7 +194,7 @@ OUString SAL_CALL RegressionCurveCalculator::getFormattedRepresentation(
}
void RegressionCurveCalculator::addStringToEquation(
- OUStringBuffer& aStrEquation, sal_Int32& nLineLength, OUStringBuffer& aAddString, const sal_Int32* pMaxWidth)
+ OUStringBuffer& aStrEquation, sal_Int32& nLineLength, OUStringBuffer const & aAddString, const sal_Int32* pMaxWidth)
{
if ( pMaxWidth && ( nLineLength + aAddString.getLength() > *pMaxWidth ) )
{ // wrap line
diff --git a/chart2/source/tools/RegressionCurveHelper.cxx b/chart2/source/tools/RegressionCurveHelper.cxx
index 4a3558d6a38e..5fa4a34076e7 100644
--- a/chart2/source/tools/RegressionCurveHelper.cxx
+++ b/chart2/source/tools/RegressionCurveHelper.cxx
@@ -293,7 +293,7 @@ uno::Reference< chart2::XRegressionCurve >
}
void RegressionCurveHelper::addMeanValueLine(
- uno::Reference< XRegressionCurveContainer > & xRegCnt,
+ uno::Reference< XRegressionCurveContainer > const & xRegCnt,
const uno::Reference< XPropertySet > & xSeriesProp )
{
if( !xRegCnt.is() ||
@@ -316,7 +316,7 @@ void RegressionCurveHelper::addMeanValueLine(
}
void RegressionCurveHelper::removeMeanValueLine(
- Reference< XRegressionCurveContainer > & xRegCnt )
+ Reference< XRegressionCurveContainer > const & xRegCnt )
{
if( !xRegCnt.is())
return;
@@ -346,7 +346,7 @@ void RegressionCurveHelper::removeMeanValueLine(
uno::Reference< chart2::XRegressionCurve > RegressionCurveHelper::addRegressionCurve(
SvxChartRegress eType,
- uno::Reference< XRegressionCurveContainer >& xRegressionCurveContainer,
+ uno::Reference< XRegressionCurveContainer > const & xRegressionCurveContainer,
const uno::Reference< XComponentContext >& /* xContext */,
const uno::Reference< beans::XPropertySet >& xPropertySource,
const uno::Reference< beans::XPropertySet >& xEquationProperties )
@@ -396,7 +396,7 @@ uno::Reference< chart2::XRegressionCurve > RegressionCurveHelper::addRegressionC
and returns true, if anything was removed
*/
bool RegressionCurveHelper::removeAllExceptMeanValueLine(
- uno::Reference< chart2::XRegressionCurveContainer > & xRegCnt )
+ uno::Reference< chart2::XRegressionCurveContainer > const & xRegCnt )
{
bool bRemovedSomething = false;
if( xRegCnt.is())
@@ -430,7 +430,7 @@ bool RegressionCurveHelper::removeAllExceptMeanValueLine(
}
void RegressionCurveHelper::removeEquations(
- uno::Reference< chart2::XRegressionCurveContainer > & xRegCnt )
+ uno::Reference< chart2::XRegressionCurveContainer > const & xRegCnt )
{
if( xRegCnt.is())
{
@@ -466,8 +466,8 @@ void RegressionCurveHelper::removeEquations(
uno::Reference< XRegressionCurve > RegressionCurveHelper::changeRegressionCurveType(
SvxChartRegress eType,
- uno::Reference< XRegressionCurveContainer > & xRegressionCurveContainer,
- uno::Reference< XRegressionCurve > & xRegressionCurve,
+ uno::Reference< XRegressionCurveContainer > const & xRegressionCurveContainer,
+ uno::Reference< XRegressionCurve > const & xRegressionCurve,
const uno::Reference< XComponentContext > & xContext )
{
xRegressionCurveContainer->removeRegressionCurve( xRegressionCurve );
diff --git a/chart2/source/tools/StatisticsHelper.cxx b/chart2/source/tools/StatisticsHelper.cxx
index f7f1ff7ef1d8..20e6f92887e9 100644
--- a/chart2/source/tools/StatisticsHelper.cxx
+++ b/chart2/source/tools/StatisticsHelper.cxx
@@ -270,7 +270,7 @@ void StatisticsHelper::setErrorDataSequence(
const OUString & rNewRange,
bool bPositiveValue,
bool bYError /* = true */,
- OUString * pXMLRange /* = 0 */ )
+ OUString const * pXMLRange /* = 0 */ )
{
Reference< chart2::data::XDataSink > xDataSink( xDataSource, uno::UNO_QUERY );
if( ! ( xDataSink.is() && xDataProvider.is()))
diff --git a/chart2/source/view/axes/VCartesianAxis.cxx b/chart2/source/view/axes/VCartesianAxis.cxx
index 6b355b3734b4..63d50e40e172 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -666,7 +666,7 @@ sal_Int32 VCartesianAxis::getTextLevelCount() const
bool VCartesianAxis::createTextShapes(
const Reference<drawing::XShapes>& xTarget, TickIter& rTickIter,
- AxisLabelProperties& rAxisLabelProperties, TickFactory2D* pTickFactory,
+ AxisLabelProperties& rAxisLabelProperties, TickFactory2D const * pTickFactory,
sal_Int32 nScreenDistanceBetweenTicks )
{
const bool bIsHorizontalAxis = pTickFactory->isHorizontalAxis();
@@ -881,7 +881,7 @@ bool VCartesianAxis::createTextShapes(
bool VCartesianAxis::createTextShapesSimple(
const Reference<drawing::XShapes>& xTarget, TickIter& rTickIter,
- AxisLabelProperties& rAxisLabelProperties, TickFactory2D* pTickFactory )
+ AxisLabelProperties& rAxisLabelProperties, TickFactory2D const * pTickFactory )
{
FixedNumberFormatter aFixedNumberFormatter(
m_xNumberFormatsSupplier, rAxisLabelProperties.nNumberFormatKey );
@@ -1511,7 +1511,7 @@ sal_Int32 VCartesianAxis::estimateMaximumAutoMainIncrementCount()
return nRet;
}
-void VCartesianAxis::doStaggeringOfLabels( const AxisLabelProperties& rAxisLabelProperties, TickFactory2D* pTickFactory2D )
+void VCartesianAxis::doStaggeringOfLabels( const AxisLabelProperties& rAxisLabelProperties, TickFactory2D const * pTickFactory2D )
{
if( !pTickFactory2D )
return;
@@ -1716,7 +1716,7 @@ void VCartesianAxis::updatePositions()
doStaggeringOfLabels( m_aAxisLabelProperties, pTickFactory2D );
}
-void VCartesianAxis::createTickMarkLineShapes( TickInfoArrayType& rTickInfos, const TickmarkProperties& rTickmarkProperties, TickFactory2D& rTickFactory2D, bool bOnlyAtLabels )
+void VCartesianAxis::createTickMarkLineShapes( TickInfoArrayType& rTickInfos, const TickmarkProperties& rTickmarkProperties, TickFactory2D const & rTickFactory2D, bool bOnlyAtLabels )
{
sal_Int32 nPointCount = rTickInfos.size();
drawing::PointSequenceSequence aPoints(2*nPointCount);
diff --git a/chart2/source/view/axes/VCartesianAxis.hxx b/chart2/source/view/axes/VCartesianAxis.hxx
index 15074393d90a..df15e4896198 100644
--- a/chart2/source/view/axes/VCartesianAxis.hxx
+++ b/chart2/source/view/axes/VCartesianAxis.hxx
@@ -120,7 +120,7 @@ private: //methods
bool createTextShapes(
const css::uno::Reference<css::drawing::XShapes >& xTarget,
TickIter& rTickIter, AxisLabelProperties& rAxisLabelProperties,
- TickFactory2D* pTickFactory, sal_Int32 nScreenDistanceBetweenTicks );
+ TickFactory2D const * pTickFactory, sal_Int32 nScreenDistanceBetweenTicks );
/**
* Variant of createTextShapes where none of auto-staggering and
@@ -130,9 +130,9 @@ private: //methods
bool createTextShapesSimple(
const css::uno::Reference<css::drawing::XShapes >& xTarget,
TickIter& rTickIter, AxisLabelProperties& rAxisLabelProperties,
- TickFactory2D* pTickFactory );
+ TickFactory2D const * pTickFactory );
- void createTickMarkLineShapes( TickInfoArrayType& rTickInfos, const TickmarkProperties& rTickmarkProperties, TickFactory2D& rTickFactory2D, bool bOnlyAtLabels );
+ void createTickMarkLineShapes( TickInfoArrayType& rTickInfos, const TickmarkProperties& rTickmarkProperties, TickFactory2D const & rTickFactory2D, bool bOnlyAtLabels );
TickFactory2D* createTickFactory2D();
void hideIdenticalScreenValues( TickInfoArraysType& rTickInfos ) const;
@@ -144,7 +144,7 @@ private: //methods
* positions based on the final stagger setting.
*/
void doStaggeringOfLabels( const AxisLabelProperties& rAxisLabelProperties
- , TickFactory2D* pTickFactory2D );
+ , TickFactory2D const * pTickFactory2D );
/**
* @return true if we can break a single line label text into multiple
diff --git a/chart2/source/view/axes/VPolarGrid.cxx b/chart2/source/view/axes/VPolarGrid.cxx
index 54e8f7b357a4..279f38c956f2 100644
--- a/chart2/source/view/axes/VPolarGrid.cxx
+++ b/chart2/source/view/axes/VPolarGrid.cxx
@@ -67,7 +67,7 @@ void VPolarGrid::createLinePointSequence_ForAngleAxis(
, TickInfoArraysType& rAllTickInfos
, const ExplicitIncrementData& rIncrement
, const ExplicitScaleData& rScale
- , PolarPlottingPositionHelper* pPosHelper
+ , PolarPlottingPositionHelper const * pPosHelper
, double fLogicRadius, double fLogicZ )
{
Reference< XScaling > xInverseScaling( nullptr );
diff --git a/chart2/source/view/axes/VPolarGrid.hxx b/chart2/source/view/axes/VPolarGrid.hxx
index f7c177071567..4391d7eca335 100644
--- a/chart2/source/view/axes/VPolarGrid.hxx
+++ b/chart2/source/view/axes/VPolarGrid.hxx
@@ -49,7 +49,7 @@ public:
, TickInfoArraysType& rAllTickInfos
, const ExplicitIncrementData& rIncrement
, const ExplicitScaleData& rScale
- , PolarPlottingPositionHelper* pPosHelper
+ , PolarPlottingPositionHelper const * pPosHelper
, double fLogicRadius, double fLogicZ );
private: //member
diff --git a/chart2/source/view/charttypes/AreaChart.cxx b/chart2/source/view/charttypes/AreaChart.cxx
index 2bedb8a64142..9ef01a23fbb2 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -240,7 +240,7 @@ void lcl_removeDuplicatePoints( drawing::PolyPolygonShape3D& rPolyPoly, Plotting
rPolyPoly=aTmp;
}
-bool AreaChart::create_stepped_line( drawing::PolyPolygonShape3D aStartPoly, chart2::CurveStyle eCurveStyle, PlottingPositionHelper* pPosHelper, drawing::PolyPolygonShape3D &aPoly )
+bool AreaChart::create_stepped_line( drawing::PolyPolygonShape3D aStartPoly, chart2::CurveStyle eCurveStyle, PlottingPositionHelper const * pPosHelper, drawing::PolyPolygonShape3D &aPoly )
{
sal_uInt32 nOuterCount = aStartPoly.SequenceX.getLength();
if ( !nOuterCount )
@@ -366,7 +366,7 @@ bool AreaChart::create_stepped_line( drawing::PolyPolygonShape3D aStartPoly, cha
}
bool AreaChart::impl_createLine( VDataSeries* pSeries
- , drawing::PolyPolygonShape3D* pSeriesPoly
+ , drawing::PolyPolygonShape3D const * pSeriesPoly
, PlottingPositionHelper* pPosHelper )
{
//return true if a line was created successfully
@@ -452,9 +452,9 @@ bool AreaChart::impl_createLine( VDataSeries* pSeries
}
bool AreaChart::impl_createArea( VDataSeries* pSeries
- , drawing::PolyPolygonShape3D* pSeriesPoly
- , drawing::PolyPolygonShape3D* pPreviousSeriesPoly
- , PlottingPositionHelper* pPosHelper )
+ , drawing::PolyPolygonShape3D const * pSeriesPoly
+ , drawing::PolyPolygonShape3D const * pPreviousSeriesPoly
+ , PlottingPositionHelper const * pPosHelper )
{
//return true if an area was created successfully
diff --git a/chart2/source/view/charttypes/AreaChart.hxx b/chart2/source/view/charttypes/AreaChart.hxx
index af8c4251c5b9..acc133667668 100644
--- a/chart2/source/view/charttypes/AreaChart.hxx
+++ b/chart2/source/view/charttypes/AreaChart.hxx
@@ -54,15 +54,15 @@ public:
private: //methods
void impl_createSeriesShapes();
bool impl_createArea( VDataSeries* pSeries
- , css::drawing::PolyPolygonShape3D* pSeriesPoly
- , css::drawing::PolyPolygonShape3D* pPreviousSeriesPoly
- , PlottingPositionHelper* pPosHelper );
+ , css::drawing::PolyPolygonShape3D const * pSeriesPoly
+ , css::drawing::PolyPolygonShape3D const * pPreviousSeriesPoly
+ , PlottingPositionHelper const * pPosHelper );
bool impl_createLine( VDataSeries* pSeries
- , css::drawing::PolyPolygonShape3D* pSeriesPoly
+ , css::drawing::PolyPolygonShape3D const * pSeriesPoly
, PlottingPositionHelper* pPosHelper );
static bool create_stepped_line( css::drawing::PolyPolygonShape3D aStartPoly
, css::chart2::CurveStyle eCurveStyle
- , PlottingPositionHelper* pPosHelper
+ , PlottingPositionHelper const * pPosHelper
, css::drawing::PolyPolygonShape3D &aPoly );
private: //member
diff --git a/chart2/source/view/charttypes/BarChart.cxx b/chart2/source/view/charttypes/BarChart.cxx
index 08b9d5a6c6bb..702b90f7569c 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -133,7 +133,7 @@ awt::Point BarChart::getLabelScreenPositionAndAlignment(
LabelAlignment& rAlignment, sal_Int32 nLabelPlacement
, double fScaledX, double fScaledLowerYValue, double fScaledUpperYValue, double fScaledZ
, double fScaledLowerBarDepth, double fScaledUpperBarDepth, double fBaseValue
- , BarPositionHelper* pPosHelper
+ , BarPositionHelper const * pPosHelper
) const
{
double fX = fScaledX;
diff --git a/chart2/source/view/charttypes/BarChart.hxx b/chart2/source/view/charttypes/BarChart.hxx
index d276fa531eab..da6071802a90 100644
--- a/chart2/source/view/charttypes/BarChart.hxx
+++ b/chart2/source/view/charttypes/BarChart.hxx
@@ -56,7 +56,7 @@ private: //methods
LabelAlignment& rAlignment, sal_Int32 nLabelPlacement
, double fScaledX, double fScaledLowerYValue, double fScaledUpperYValue, double fScaledZ
, double fScaledLowerBarDepth, double fScaledUpperBarDepth, double fBaseValue
- , BarPositionHelper* pPosHelper ) const;
+ , BarPositionHelper const * pPosHelper ) const;
virtual PlottingPositionHelper& getPlottingPositionHelper( sal_Int32 nAxisIndex ) const override;//nAxisIndex indicates whether the position belongs to the main axis ( nAxisIndex==0 ) or secondary axis ( nAxisIndex==1 )
diff --git a/chart2/source/view/charttypes/GL3DBarChart.cxx b/chart2/source/view/charttypes/GL3DBarChart.cxx
index 1eecec9f67f9..c0085bdf49df 100644
--- a/chart2/source/view/charttypes/GL3DBarChart.cxx
+++ b/chart2/source/view/charttypes/GL3DBarChart.cxx
@@ -1168,7 +1168,7 @@ void GL3DBarChart::updateRenderFPS()
glm::vec4(1.0f, 0.0f, 0.0f, 0.0f), glm::vec3(0.0f, 0.0f, 0.0f));
}
-int GL3DBarChart::calcTimeInterval(TimeValue &startTime, TimeValue &endTime)
+int GL3DBarChart::calcTimeInterval(TimeValue const &startTime, TimeValue const &endTime)
{
TimeValue aTime;
aTime.Seconds = endTime.Seconds - startTime.Seconds - 1;
@@ -1215,7 +1215,7 @@ void GL3DBarChart::updateDataUpdateFPS()
addScreenTextShape(maDataUpdateFPS, glm::vec2(-0.77f, 0.92f), 0.07f, true, glm::vec4(1.0f, 0.0f, 0.0f, 0.0f));
}
-void GL3DBarChart::recordBarHistory(sal_uInt32 &nBarID, float &nVal)
+void GL3DBarChart::recordBarHistory(sal_uInt32 nBarID, float nVal)
{
std::deque<float>& aList = maBarHistory[nBarID];
if(aList.size() == HISTORY_NUM)
diff --git a/chart2/source/view/charttypes/NetChart.cxx b/chart2/source/view/charttypes/NetChart.cxx
index ba896e3eb4e8..4ed5410c0729 100644
--- a/chart2/source/view/charttypes/NetChart.cxx
+++ b/chart2/source/view/charttypes/NetChart.cxx
@@ -118,7 +118,7 @@ drawing::Direction3D NetChart::getPreferredDiagramAspectRatio() const
bool NetChart::impl_createLine( VDataSeries* pSeries
, drawing::PolyPolygonShape3D* pSeriesPoly
- , PlottingPositionHelper* pPosHelper )
+ , PlottingPositionHelper const * pPosHelper )
{
//return true if a line was created successfully
uno::Reference< drawing::XShapes > xSeriesGroupShape_Shapes = getSeriesGroupShapeBackChild(pSeries, m_xSeriesTarget);
@@ -171,8 +171,8 @@ bool NetChart::impl_createLine( VDataSeries* pSeries
bool NetChart::impl_createArea( VDataSeries* pSeries
, drawing::PolyPolygonShape3D* pSeriesPoly
- , drawing::PolyPolygonShape3D* pPreviousSeriesPoly
- , PlottingPositionHelper* pPosHelper )
+ , drawing::PolyPolygonShape3D const * pPreviousSeriesPoly
+ , PlottingPositionHelper const * pPosHelper )
{
//return true if an area was created successfully
diff --git a/chart2/source/view/charttypes/NetChart.hxx b/chart2/source/view/charttypes/NetChart.hxx
index 626e9253097c..eecd2550b25a 100644
--- a/chart2/source/view/charttypes/NetChart.hxx
+++ b/chart2/source/view/charttypes/NetChart.hxx
@@ -55,11 +55,11 @@ private: //methods
void impl_createSeriesShapes();
bool impl_createArea( VDataSeries* pSeries
, css::drawing::PolyPolygonShape3D* pSeriesPoly
- , css::drawing::PolyPolygonShape3D* pPreviousSeriesPoly
- , PlottingPositionHelper* pPosHelper );
+ , css::drawing::PolyPolygonShape3D const * pPreviousSeriesPoly
+ , PlottingPositionHelper const * pPosHelper );
bool impl_createLine( VDataSeries* pSeries
, css::drawing::PolyPolygonShape3D* pSeriesPoly
- , PlottingPositionHelper* pPosHelper );
+ , PlottingPositionHelper const * pPosHelper );
private: //member
std::unique_ptr<PlottingPositionHelper> m_pMainPosHelper;
diff --git a/chart2/source/view/charttypes/PieChart.cxx b/chart2/source/view/charttypes/PieChart.cxx
index 72df0caf6566..84ad1938459d 100644
--- a/chart2/source/view/charttypes/PieChart.cxx
+++ b/chart2/source/view/charttypes/PieChart.cxx
@@ -217,7 +217,7 @@ bool PieChart::shouldSnapRectToUsedArea()
uno::Reference< drawing::XShape > PieChart::createDataPoint(
const uno::Reference<drawing::XShapes>& xTarget,
const uno::Reference<beans::XPropertySet>& xObjectProperties,
- tPropertyNameValueMap* pOverwritePropertiesMap,
+ tPropertyNameValueMap const * pOverwritePropertiesMap,
const ShapeParam& rParam )
{
//transform position:
@@ -995,7 +995,7 @@ bool PieChart::detectLabelOverlapsAndMove( const awt::Size& rPageSize )
/** Try to remove all overlaps that occur in the list of labels going from
* `pFirstBorder` to `pSecondBorder`
*/
-bool PieChart::tryMoveLabels( PieLabelInfo* pFirstBorder, PieLabelInfo* pSecondBorder
+bool PieChart::tryMoveLabels( PieLabelInfo const * pFirstBorder, PieLabelInfo const * pSecondBorder
, PieLabelInfo* pCenter
, bool bSingleCenter, bool& rbAlternativeMoveDirection, const awt::Size& rPageSize )
{
@@ -1263,7 +1263,7 @@ void PieChart::rearrangeLabelToAvoidOverlapIfRequested( const awt::Size& rPageSi
* 4. the top edge when 225 < alpha < 315.
*
**/
-bool PieChart::performLabelBestFitInnerPlacement(ShapeParam& rShapeParam, PieLabelInfo& rPieLabelInfo)
+bool PieChart::performLabelBestFitInnerPlacement(ShapeParam& rShapeParam, PieLabelInfo const & rPieLabelInfo)
{
SAL_INFO( "chart2.pie.label.bestfit.inside",
"** PieChart::performLabelBestFitInnerPlacement invoked **" );
diff --git a/chart2/source/view/charttypes/PieChart.hxx b/chart2/source/view/charttypes/PieChart.hxx
index dd6c5f2de600..1b39ba229ed0 100644
--- a/chart2/source/view/charttypes/PieChart.hxx
+++ b/chart2/source/view/charttypes/PieChart.hxx
@@ -68,7 +68,7 @@ private: //methods
createDataPoint(
const css::uno::Reference<css::drawing::XShapes>& xTarget,
const css::uno::Reference<css::beans::XPropertySet>& xObjectProperties,
- tPropertyNameValueMap* pOverWritePropertiesMap,
+ tPropertyNameValueMap const * pOverWritePropertiesMap,
const ShapeParam& rParam );
/** This method creates a text shape for a label of a data point.
@@ -102,11 +102,11 @@ private: //methods
bool detectLabelOverlapsAndMove(const css::awt::Size& rPageSize);//returns true when there might be more to do
void resetLabelPositionsToPreviousState();
struct PieLabelInfo;
- bool tryMoveLabels( PieLabelInfo* pFirstBorder, PieLabelInfo* pSecondBorder
+ bool tryMoveLabels( PieLabelInfo const * pFirstBorder, PieLabelInfo const * pSecondBorder
, PieLabelInfo* pCenter, bool bSingleCenter, bool& rbAlternativeMoveDirection
, const css::awt::Size& rPageSize );
- bool performLabelBestFitInnerPlacement(ShapeParam& rShapeParam, PieLabelInfo& rPieLabelInfo);
+ bool performLabelBestFitInnerPlacement(ShapeParam& rShapeParam, PieLabelInfo const & rPieLabelInfo);
static bool performLabelBestFitOuterPlacement(ShapeParam& rShapeParam, PieLabelInfo& rPieLabelInfo);
void performLabelBestFit(ShapeParam& rShapeParam, PieLabelInfo& rPieLabelInfo);
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index b4173b69fe41..589812594ff6 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -357,7 +357,7 @@ uno::Reference< drawing::XShapes > VSeriesPlotter::getErrorBarsGroupShape( VData
}
-OUString VSeriesPlotter::getLabelTextForValue( VDataSeries& rDataSeries
+OUString VSeriesPlotter::getLabelTextForValue( VDataSeries const & rDataSeries
, sal_Int32 nPointIndex
, double fValue
, bool bAsPercentage )
@@ -802,7 +802,7 @@ void lcl_AddErrorBottomLine( const drawing::Position3D& rPosition, ::basegfx::B2
::basegfx::B2DVector lcl_getErrorBarMainDirection(
const drawing::Position3D& rStart
, const drawing::Position3D& rBottomEnd
- , PlottingPositionHelper* pPosHelper
+ , PlottingPositionHelper const * pPosHelper
, const drawing::Position3D& rUnscaledLogicPosition
, bool bYError )
{
@@ -843,7 +843,7 @@ void lcl_AddErrorBottomLine( const drawing::Position3D& rPosition, ::basegfx::B2
return aMainDirection;
}
-drawing::Position3D lcl_transformMixedToScene( PlottingPositionHelper* pPosHelper
+drawing::Position3D lcl_transformMixedToScene( PlottingPositionHelper const * pPosHelper
, double fX /*scaled*/, double fY /*unscaled*/, double fZ /*unscaled*/, bool bClip )
{
if(!pPosHelper)
@@ -1024,7 +1024,7 @@ void VSeriesPlotter::createErrorBar_X( const drawing::Position3D& rUnscaledLogic
void VSeriesPlotter::createErrorBar_Y( const drawing::Position3D& rUnscaledLogicPosition
, VDataSeries& rVDataSeries, sal_Int32 nPointIndex
, const uno::Reference< drawing::XShapes >& xTarget
- , double* pfScaledLogicX )
+ , double const * pfScaledLogicX )
{
if(m_nDimension!=2)
return;
@@ -1043,7 +1043,7 @@ void VSeriesPlotter::createErrorBar_Y( const drawing::Position3D& rUnscaledLogic
}
}
-void VSeriesPlotter::createRegressionCurvesShapes( VDataSeries& rVDataSeries,
+void VSeriesPlotter::createRegressionCurvesShapes( VDataSeries const & rVDataSeries,
const uno::Reference< drawing::XShapes >& xTarget,
const uno::Reference< drawing::XShapes >& xEquationTarget,
bool bMaySkipPoints )
@@ -1192,7 +1192,7 @@ void VSeriesPlotter::createRegressionCurvesShapes( VDataSeries& rVDataSeries,
}
}
-sal_Int32 lcl_getOUStringMaxLineLength ( OUStringBuffer& aString )
+sal_Int32 lcl_getOUStringMaxLineLength ( OUStringBuffer const & aString )
{
const sal_Int32 nStringLength = aString.getLength();
sal_Int32 nMaxLineLength = 0;
@@ -1357,7 +1357,7 @@ void VSeriesPlotter::setMappedProperties(
const uno::Reference< drawing::XShape >& xTargetShape
, const uno::Reference< beans::XPropertySet >& xSource
, const tPropertyNameMap& rMap
- , tPropertyNameValueMap* pOverwriteMap )
+ , tPropertyNameValueMap const * pOverwriteMap )
{
uno::Reference< beans::XPropertySet > xTargetProp( xTargetShape, uno::UNO_QUERY );
PropertyMapper::setMappedProperties(xTargetProp,xSource,rMap,pOverwriteMap);
diff --git a/chart2/source/view/inc/GL3DBarChart.hxx b/chart2/source/view/inc/GL3DBarChart.hxx
index 8e83508b560f..753504ccf17a 100644
--- a/chart2/source/view/inc/GL3DBarChart.hxx
+++ b/chart2/source/view/inc/GL3DBarChart.hxx
@@ -102,12 +102,12 @@ private:
void updateRenderFPS();
void updateDataUpdateFPS();
DECL_LINK(UpdateTimerHdl, Timer*, void);
- static int calcTimeInterval(TimeValue &startTime, TimeValue &endTime);
+ static int calcTimeInterval(TimeValue const &startTime, TimeValue const &endTime);
float addScreenTextShape(OUString &nStr, const glm::vec2& rLeftOrRightTop, float nTextHeight, bool bLeftTopFlag,
const glm::vec4& rColor,
const glm::vec3& rPos = glm::vec3(0.0f, 0.0f, 0.0f),
sal_uInt32 nEvent = 0);
- void recordBarHistory(sal_uInt32 &nBarID, float &nVal);
+ void recordBarHistory(sal_uInt32 nBarID, float nVal);
void updateClickEvent();
void calcDistance(std::vector<sal_uInt32> &vectorNearest);
static float calcScrollDistance(const glm::mat4 &mvp, const glm::vec3& rPos);
diff --git a/chart2/source/view/inc/GL3DRenderer.hxx b/chart2/source/view/inc/GL3DRenderer.hxx
index 240fb955bb17..3a3f19a78bbf 100644
--- a/chart2/source/view/inc/GL3DRenderer.hxx
+++ b/chart2/source/view/inc/GL3DRenderer.hxx
@@ -248,11 +248,11 @@ private:
void AddNormalData(GLuint normalBuf);
void AddIndexData(GLuint indexBuf);
void RenderNonRoundedBar(const Extrude3DInfo& extrude3D);
- static bool GetSimilarVertexIndex(PackedVertex & packed,
+ static bool GetSimilarVertexIndex(PackedVertex const & packed,
std::map<PackedVertex,unsigned short> & VertexToOutIndex,
unsigned short & result
);
- static void SetVertex(PackedVertex &packed,
+ static void SetVertex(PackedVertex const &packed,
std::map<PackedVertex,unsigned short> &VertexToOutIndex,
std::vector<glm::vec3> &vertex,
std::vector<glm::vec3> &normal,
diff --git a/chart2/source/view/inc/PropertyMapper.hxx b/chart2/source/view/inc/PropertyMapper.hxx
index 5af3b7fdf27b..6d2b1508fd7b 100644
--- a/chart2/source/view/inc/PropertyMapper.hxx
+++ b/chart2/source/view/inc/PropertyMapper.hxx
@@ -49,7 +49,7 @@ public:
const css::uno::Reference< css::beans::XPropertySet >& xTarget
, const css::uno::Reference< css::beans::XPropertySet >& xSource
, const tPropertyNameMap& rMap
- , tPropertyNameValueMap* pOverwriteMap=nullptr );
+ , tPropertyNameValueMap const * pOverwriteMap=nullptr );
/**
* Fetch property values from the source object and map it to the
diff --git a/chart2/source/view/inc/VSeriesPlotter.hxx b/chart2/source/view/inc/VSeriesPlotter.hxx
index c66f992cf12a..65aa67de86b0 100644
--- a/chart2/source/view/inc/VSeriesPlotter.hxx
+++ b/chart2/source/view/inc/VSeriesPlotter.hxx
@@ -327,7 +327,7 @@ protected:
/// This method returns a text string representation of the passed numeric
/// value by exploiting a NumberFormatterWrapper object.
- OUString getLabelTextForValue( VDataSeries& rDataSeries
+ OUString getLabelTextForValue( VDataSeries const & rDataSeries
, sal_Int32 nPointIndex
, double fValue
, bool bAsPercentage );
@@ -366,9 +366,9 @@ protected:
void createErrorBar_Y( const css::drawing::Position3D& rUnscaledLogicPosition
, VDataSeries& rVDataSeries, sal_Int32 nPointIndex
, const css::uno::Reference< css::drawing::XShapes >& xTarget
- , double* pfScaledLogicX );
+ , double const * pfScaledLogicX );
- void createRegressionCurvesShapes( VDataSeries& rVDataSeries
+ void createRegressionCurvesShapes( VDataSeries const & rVDataSeries
, const css::uno::Reference< css::drawing::XShapes >& xTarget
, const css::uno::Reference< css::drawing::XShapes >& xEquationTarget
, bool bMaySkipPointsInRegressionCalculation );
@@ -383,7 +383,7 @@ protected:
const css::uno::Reference< css::drawing::XShape >& xTarget
, const css::uno::Reference< css::beans::XPropertySet >& xSource
, const tPropertyNameMap& rMap
- , tPropertyNameValueMap* pOverwriteMap=nullptr );
+ , tPropertyNameValueMap const * pOverwriteMap=nullptr );
virtual PlottingPositionHelper& getPlottingPositionHelper( sal_Int32 nAxisIndex ) const;//nAxisIndex indicates whether the position belongs to the main axis ( nAxisIndex==0 ) or secondary axis ( nAxisIndex==1 )
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index 20a4c1cb493c..965157e13fa9 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -2296,7 +2296,7 @@ bool getAvailablePosAndSizeForDiagram(
enum TitleAlignment { ALIGN_LEFT, ALIGN_TOP, ALIGN_RIGHT, ALIGN_BOTTOM, ALIGN_Z };
void changePositionOfAxisTitle( VTitle* pVTitle, TitleAlignment eAlignment
- , awt::Rectangle& rDiagramPlusAxesRect, const awt::Size & rPageSize )
+ , awt::Rectangle const & rDiagramPlusAxesRect, const awt::Size & rPageSize )
{
if(!pVTitle)
return;
diff --git a/chart2/source/view/main/DrawModelWrapper.cxx b/chart2/source/view/main/DrawModelWrapper.cxx
index d0dd9234aa16..580a762ecb2a 100644
--- a/chart2/source/view/main/DrawModelWrapper.cxx
+++ b/chart2/source/view/main/DrawModelWrapper.cxx
@@ -297,7 +297,7 @@ SdrObject* DrawModelWrapper::getNamedSdrObject( const OUString& rName )
return getNamedSdrObject( rName, GetPage(0) );
}
-SdrObject* DrawModelWrapper::getNamedSdrObject( const OUString& rObjectCID, SdrObjList* pSearchList )
+SdrObject* DrawModelWrapper::getNamedSdrObject( const OUString& rObjectCID, SdrObjList const * pSearchList )
{
if(!pSearchList || rObjectCID.isEmpty())
return nullptr;
diff --git a/chart2/source/view/main/GL3DRenderer.cxx b/chart2/source/view/main/GL3DRenderer.cxx
index 8c92ccd9a9b2..3ff7939aba2f 100644
--- a/chart2/source/view/main/GL3DRenderer.cxx
+++ b/chart2/source/view/main/GL3DRenderer.cxx
@@ -468,7 +468,7 @@ void OpenGL3DRenderer::AddIndexData(GLuint indexBuf)
glBindBuffer(GL_ELEMENT_ARRAY_BUFFER, 0);
}
-bool OpenGL3DRenderer::GetSimilarVertexIndex(PackedVertex & packed,
+bool OpenGL3DRenderer::GetSimilarVertexIndex(PackedVertex const & packed,
std::map<PackedVertex,unsigned short> & VertexToOutIndex,
unsigned short & result
)
@@ -485,7 +485,7 @@ bool OpenGL3DRenderer::GetSimilarVertexIndex(PackedVertex & packed,
}
}
-void OpenGL3DRenderer::SetVertex(PackedVertex &packed,
+void OpenGL3DRenderer::SetVertex(PackedVertex const &packed,
std::map<PackedVertex,unsigned short> &VertexToOutIndex,
std::vector<glm::vec3> &vertex,
std::vector<glm::vec3> &normal,
diff --git a/chart2/source/view/main/PropertyMapper.cxx b/chart2/source/view/main/PropertyMapper.cxx
index e35bd913129e..15bc0dbea5a6 100644
--- a/chart2/source/view/main/PropertyMapper.cxx
+++ b/chart2/source/view/main/PropertyMapper.cxx
@@ -51,7 +51,7 @@ void PropertyMapper::setMappedProperties(
const uno::Reference< beans::XPropertySet >& xTarget
, const uno::Reference< beans::XPropertySet >& xSource
, const tPropertyNameMap& rMap
- , tPropertyNameValueMap* pOverwriteMap )
+ , tPropertyNameValueMap const * pOverwriteMap )
{
if( !xTarget.is() || !xSource.is() )
return;
diff --git a/compilerplugins/clang/constparams.cxx b/compilerplugins/clang/constparams.cxx
index 9f43e90fdc02..76b1b91784a8 100644
--- a/compilerplugins/clang/constparams.cxx
+++ b/compilerplugins/clang/constparams.cxx
@@ -122,6 +122,9 @@ bool ConstParams::VisitFunctionDecl(FunctionDecl * functionDecl)
|| name == "ProcessEventsToSignal"
// external API
|| name == "Java_com_sun_star_sdbcx_comp_hsqldb_StorageNativeOutputStream_flush"
+ || name == "egiGraphicExport"
+ || name == "etiGraphicExport"
+ || name == "epsGraphicExport"
)
return true;
}
More information about the Libreoffice-commits
mailing list