[Libreoffice-commits] core.git: Makefile.in

Michael Stahl mstahl at redhat.com
Thu Jul 27 12:43:13 UTC 2017


 Makefile.in |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

New commits:
commit 1176ae51154c2298b44427270754d2ee1562a115
Author: Michael Stahl <mstahl at redhat.com>
Date:   Thu Jul 27 13:18:11 2017 +0200

    Makefile: fix fetching for the build platform
    
    The invocation of make fetch added in commit
    fe3fb5ecd3b66e32cc5aa64a2afffa572353740e didn't do anything because
    the force-restart didn't actually restart make because it touched
    "Makefile" but the make read "$(BUILDDIR)/Makefile", and make isn't
    smart enough to notice those are the same.
    
    Change-Id: I85cbcba3bf9c3c7b89d4ee33f772820d19542f4a
    Reviewed-on: https://gerrit.libreoffice.org/40482
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Michael Stahl <mstahl at redhat.com>

diff --git a/Makefile.in b/Makefile.in
index 4b7048438bc4..62adf2bb56b1 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -30,8 +30,11 @@ GIT_BUILD := $(if $(wildcard $(SRCDIR)/.git),T)
 #    need updated configuration
 ifeq (,$(MAKE_RESTARTS)$(if $(GIT_BUILD),,T)$(if $(filter-out help showmodules clean distclean,$(MAKECMDGOALS)),,T))
 
+# note: this must touch both Makefile and $(BUILDDIR)/Makefile, because make
+# may be invoked using either of these paths, and it will restart itself only
+# if the updated target is exactly the same path as the Makefile it is using
 .PHONY : force-restart
-Makefile: $(BUILDDIR)/config_host.mk $(BUILDDIR)/config_host_lang.mk force-restart
+Makefile $(BUILDDIR)/Makefile: $(BUILDDIR)/config_host.mk $(BUILDDIR)/config_host_lang.mk force-restart
 	@touch $@
 
 # run configure in an environment not polluted by config_host.mk


More information about the Libreoffice-commits mailing list