[Libreoffice-commits] core.git: avmedia/inc avmedia/source basic/source chart2/source comphelper/source cui/source editeng/source formula/source include/avmedia include/oox include/svtools include/svx include/vcl oox/inc oox/source sc/inc sc/qa sc/source sd/inc sd/source sfx2/inc sfx2/source starmath/source svtools/inc svtools/source svx/inc svx/source sw/inc sw/source UnoControls/source vcl/source xmloff/inc xmloff/source xmlsecurity/source
Noel Grandin
noel.grandin at collabora.co.uk
Mon Jun 5 07:23:13 UTC 2017
UnoControls/source/controls/OConnectionPointHelper.cxx | 2
UnoControls/source/inc/OConnectionPointHelper.hxx | 2
avmedia/inc/mediacontrol.hxx | 2
avmedia/source/framework/MediaControlBase.cxx | 8 +--
avmedia/source/framework/mediacontrol.cxx | 2
basic/source/classes/sbunoobj.cxx | 4 -
chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx | 25 +++++-----
chart2/source/controller/inc/uiobject.hxx | 4 -
chart2/source/controller/uitest/uiobject.cxx | 4 -
chart2/source/view/inc/3DChartObjects.hxx | 2
chart2/source/view/main/3DChartObjects.cxx | 2
comphelper/source/container/namecontainer.cxx | 4 -
cui/source/dialogs/scriptdlg.cxx | 2
cui/source/inc/scriptdlg.hxx | 2
editeng/source/editeng/eertfpar.cxx | 3 -
formula/source/core/api/FormulaCompiler.cxx | 4 -
include/avmedia/MediaControlBase.hxx | 8 +--
include/oox/core/relationshandler.hxx | 2
include/oox/drawingml/connectorshapecontext.hxx | 2
include/oox/drawingml/graphicshapecontext.hxx | 8 +--
include/oox/ppt/pptgraphicshapecontext.hxx | 2
include/oox/ppt/pptshapecontext.hxx | 2
include/oox/ppt/pptshapegroupcontext.hxx | 4 -
include/oox/ppt/slidefragmenthandler.hxx | 2
include/svtools/svlbitm.hxx | 4 -
include/svx/cube3d.hxx | 2
include/vcl/uitest/uiobject.hxx | 24 ++++-----
oox/inc/drawingml/table/tablecontext.hxx | 2
oox/inc/drawingml/textbody.hxx | 2
oox/source/core/relationshandler.cxx | 2
oox/source/drawingml/connectorshapecontext.cxx | 2
oox/source/drawingml/graphicshapecontext.cxx | 8 +--
oox/source/drawingml/table/tablecontext.cxx | 2
oox/source/drawingml/textbody.cxx | 2
oox/source/export/chartexport.cxx | 3 -
oox/source/export/shapes.cxx | 3 -
oox/source/ppt/layoutfragmenthandler.cxx | 3 -
oox/source/ppt/pptgraphicshapecontext.cxx | 2
oox/source/ppt/pptimport.cxx | 2
oox/source/ppt/pptshapecontext.cxx | 2
oox/source/ppt/pptshapegroupcontext.cxx | 4 -
oox/source/ppt/slidefragmenthandler.cxx | 2
sc/inc/textuno.hxx | 2
sc/qa/unit/subsequent_filters-test.cxx | 2
sc/source/filter/excel/xecontent.cxx | 4 -
sc/source/filter/excel/xeroot.cxx | 2
sc/source/filter/excel/xetable.cxx | 4 -
sc/source/filter/excel/xiroot.cxx | 2
sc/source/filter/inc/xecontent.hxx | 4 -
sc/source/filter/inc/xeroot.hxx | 2
sc/source/filter/inc/xetable.hxx | 4 -
sc/source/filter/inc/xiroot.hxx | 2
sc/source/filter/xcl97/xcl97rec.cxx | 4 -
sc/source/ui/Accessibility/AccessibleText.cxx | 12 ++--
sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx | 6 +-
sc/source/ui/condformat/condformatdlgitem.cxx | 4 +
sc/source/ui/inc/TableFillingAndNavigationTools.hxx | 6 +-
sc/source/ui/inc/cellsh.hxx | 2
sc/source/ui/inc/notemark.hxx | 2
sc/source/ui/inc/optsolver.hxx | 2
sc/source/ui/inc/solvrdlg.hxx | 2
sc/source/ui/inc/uiobject.hxx | 2
sc/source/ui/inc/undoblk.hxx | 4 -
sc/source/ui/miscdlgs/optsolver.cxx | 2
sc/source/ui/miscdlgs/solvrdlg.cxx | 2
sc/source/ui/uitest/uiobject.cxx | 2
sc/source/ui/undo/undoblk.cxx | 4 -
sc/source/ui/unoobj/textuno.cxx | 2
sc/source/ui/view/cellsh.cxx | 2
sc/source/ui/view/notemark.cxx | 2
sd/inc/CustomAnimationPreset.hxx | 2
sd/source/core/CustomAnimationPreset.cxx | 2
sd/source/filter/eppt/pptx-epptooxml.cxx | 3 -
sd/source/ui/framework/factories/ViewShellWrapper.cxx | 2
sd/source/ui/inc/framework/ViewShellWrapper.hxx | 2
sd/source/ui/inc/uiobject.hxx | 2
sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx | 2
sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx | 2
sd/source/ui/uitest/uiobject.cxx | 10 ++--
sfx2/inc/uitest/sfx_uiobject.hxx | 2
sfx2/source/doc/docfile.cxx | 5 +-
sfx2/source/notebookbar/DropdownBox.cxx | 2
sfx2/source/uitest/sfx_uiobject.cxx | 2
sfx2/source/view/viewfrm.cxx | 2
starmath/source/uiobject.cxx | 4 -
starmath/source/uiobject.hxx | 4 -
svtools/inc/uitest/uiobject.hxx | 6 +-
svtools/source/contnr/svlbitm.cxx | 2
svtools/source/uitest/uiobject.cxx | 8 +--
svx/inc/uiobject.hxx | 2
svx/source/engine3d/cube3d.cxx | 2
svx/source/uitest/uiobject.cxx | 2
sw/inc/unochart.hxx | 2
sw/inc/unoredline.hxx | 2
sw/source/core/access/accmap.cxx | 4 -
sw/source/core/unocore/unochart.cxx | 2
sw/source/core/unocore/unoredline.cxx | 2
sw/source/filter/ww8/docxattributeoutput.cxx | 2
sw/source/filter/ww8/docxattributeoutput.hxx | 2
sw/source/filter/ww8/wrtw8esh.cxx | 2
sw/source/filter/xml/xmlexpit.cxx | 3 -
sw/source/filter/xml/xmlimpit.cxx | 3 -
sw/source/filter/xml/xmliteme.cxx | 3 -
sw/source/filter/xml/xmlitemi.cxx | 4 -
sw/source/uibase/inc/uiobject.hxx | 2
sw/source/uibase/uitest/uiobject.cxx | 2
vcl/source/edit/textdat2.hxx | 4 -
vcl/source/edit/textdata.cxx | 4 -
vcl/source/uitest/uiobject.cxx | 24 ++++-----
vcl/source/uitest/uno/uiobject_uno.cxx | 3 -
xmloff/inc/animationimport.hxx | 2
xmloff/source/draw/animationimport.cxx | 2
xmloff/source/draw/shapeimport.cxx | 3 -
xmlsecurity/source/gpg/CertificateImpl.cxx | 2
xmlsecurity/source/gpg/CertificateImpl.hxx | 2
115 files changed, 214 insertions(+), 200 deletions(-)
New commits:
commit 17a2c9e8e2361de27013a25e51f3a3ca729f1b31
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date: Mon Jun 5 08:34:22 2017 +0200
clang-tidy performance-unnecessary-value-param
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/UnoControls/source/controls/OConnectionPointHelper.cxx b/UnoControls/source/controls/OConnectionPointHelper.cxx
index fff245e8341c..e54acbdf46fb 100644
--- a/UnoControls/source/controls/OConnectionPointHelper.cxx
+++ b/UnoControls/source/controls/OConnectionPointHelper.cxx
@@ -38,7 +38,7 @@ namespace unocontrols{
OConnectionPointHelper::OConnectionPointHelper(
Mutex& aMutex ,
OConnectionPointContainerHelper* pContainerImplementation ,
- Type aType
+ Type const & aType
) : m_aSharedMutex ( aMutex )
, m_oContainerWeakReference ( pContainerImplementation )
, m_pContainerImplementation ( pContainerImplementation )
diff --git a/UnoControls/source/inc/OConnectionPointHelper.hxx b/UnoControls/source/inc/OConnectionPointHelper.hxx
index 2e86fc29f302..77a788651b77 100644
--- a/UnoControls/source/inc/OConnectionPointHelper.hxx
+++ b/UnoControls/source/inc/OConnectionPointHelper.hxx
@@ -42,7 +42,7 @@ public:
OConnectionPointHelper( ::osl::Mutex& aMutex ,
OConnectionPointContainerHelper* pContainerImplementation ,
- css::uno::Type aType );
+ css::uno::Type const & aType );
virtual ~OConnectionPointHelper() override;
diff --git a/avmedia/inc/mediacontrol.hxx b/avmedia/inc/mediacontrol.hxx
index a6c247b7c687..99ad5ef91a01 100644
--- a/avmedia/inc/mediacontrol.hxx
+++ b/avmedia/inc/mediacontrol.hxx
@@ -51,7 +51,7 @@ public:
const Size& getMinSizePixel() const;
void setState( const MediaItem& rItem );
- void UpdateURLField(MediaItem maItem);
+ void UpdateURLField( MediaItem const & maItem );
protected:
diff --git a/avmedia/source/framework/MediaControlBase.cxx b/avmedia/source/framework/MediaControlBase.cxx
index 2aa829dc735f..390f08ff6dbc 100644
--- a/avmedia/source/framework/MediaControlBase.cxx
+++ b/avmedia/source/framework/MediaControlBase.cxx
@@ -39,7 +39,7 @@ MediaControlBase::MediaControlBase()
{
}
-void MediaControlBase::UpdateTimeField( MediaItem aMediaItem, double fTime )
+void MediaControlBase::UpdateTimeField( MediaItem const & aMediaItem, double fTime )
{
if( !aMediaItem.getURL().isEmpty())
{
@@ -57,7 +57,7 @@ void MediaControlBase::UpdateTimeField( MediaItem aMediaItem, double fTime )
}
}
-void MediaControlBase::UpdateVolumeSlider( MediaItem aMediaItem )
+void MediaControlBase::UpdateVolumeSlider( MediaItem const & aMediaItem )
{
if( aMediaItem.getURL().isEmpty() )
mpVolumeSlider->Disable();
@@ -70,7 +70,7 @@ void MediaControlBase::UpdateVolumeSlider( MediaItem aMediaItem )
}
}
-void MediaControlBase::UpdateTimeSlider( MediaItem aMediaItem )
+void MediaControlBase::UpdateTimeSlider( MediaItem const & aMediaItem )
{
if( aMediaItem.getURL().isEmpty() )
mpTimeSlider->Disable();
@@ -211,7 +211,7 @@ void MediaControlBase::UpdateToolBoxes(MediaItem aMediaItem)
}
}
-void MediaControlBase::SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem aItem, sal_uInt16 nId)
+void MediaControlBase::SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem const & aItem, sal_uInt16 nId)
{
switch( nId )
{
diff --git a/avmedia/source/framework/mediacontrol.cxx b/avmedia/source/framework/mediacontrol.cxx
index 44d9ce7ce030..bde107a71e24 100644
--- a/avmedia/source/framework/mediacontrol.cxx
+++ b/avmedia/source/framework/mediacontrol.cxx
@@ -168,7 +168,7 @@ const Size& MediaControl::getMinSizePixel() const
return maMinSize;
}
-void MediaControl::UpdateURLField(MediaItem tempItem)
+void MediaControl::UpdateURLField(MediaItem const & tempItem)
{
const OUString aURL( AvmResId(AVMEDIA_MEDIA_PATH) + ": " + tempItem.getURL() ) ;
mpMediaPath->SetText(aURL);
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index f0da35932f92..dc1ba44bd3e5 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -4219,7 +4219,7 @@ class ModuleInvocationProxy : public WeakImplHelper< XInvocation, XComponent >
::comphelper::OInterfaceContainerHelper2 m_aListeners;
public:
- ModuleInvocationProxy( const OUString& aPrefix, SbxObjectRef xScopeObj );
+ ModuleInvocationProxy( OUString const & aPrefix, SbxObjectRef const & xScopeObj );
// XInvocation
virtual Reference< XIntrospectionAccess > SAL_CALL getIntrospection() override;
@@ -4239,7 +4239,7 @@ public:
virtual void SAL_CALL removeEventListener( const Reference< XEventListener >& aListener ) override;
};
-ModuleInvocationProxy::ModuleInvocationProxy( const OUString& aPrefix, SbxObjectRef xScopeObj )
+ModuleInvocationProxy::ModuleInvocationProxy( OUString const & aPrefix, SbxObjectRef const & xScopeObj )
: m_aMutex()
, m_aPrefix( aPrefix + "_" )
, m_xScopeObj( xScopeObj )
diff --git a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
index 0f151a44a615..0f8bd60b38f6 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedStatisticProperties.cxx
@@ -34,6 +34,7 @@
#include <com/sun/star/chart/ChartRegressionCurveType.hpp>
#include <com/sun/star/chart2/data/XDataProvider.hpp>
#include <com/sun/star/chart2/data/XRangeXMLConversion.hpp>
+#include <utility>
using namespace ::com::sun::star;
using ::com::sun::star::uno::Any;
@@ -216,7 +217,7 @@ WrappedConstantErrorLowProperty::WrappedConstantErrorLowProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< double >( "ConstantErrorLow"
- , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType )
+ , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -266,7 +267,7 @@ WrappedConstantErrorHighProperty::WrappedConstantErrorHighProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< double >( "ConstantErrorHigh"
- , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType )
+ , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -312,7 +313,7 @@ public:
WrappedMeanValueProperty::WrappedMeanValueProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
- : WrappedStatisticProperty< bool >( "MeanValue", uno::Any( false ), spChart2ModelContact, ePropertyType )
+ : WrappedStatisticProperty< bool >( "MeanValue", uno::Any( false ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -353,7 +354,7 @@ WrappedErrorCategoryProperty::WrappedErrorCategoryProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< css::chart::ChartErrorCategory >( "ErrorCategory"
- , uno::Any( css::chart::ChartErrorCategory_NONE ), spChart2ModelContact, ePropertyType )
+ , uno::Any( css::chart::ChartErrorCategory_NONE ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -450,7 +451,7 @@ WrappedPercentageErrorProperty::WrappedPercentageErrorProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< double >( "PercentageError"
- , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType )
+ , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -500,7 +501,7 @@ WrappedErrorMarginProperty::WrappedErrorMarginProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< double >( "ErrorMargin"
- , uno::Any( 0.0 ), spChart2ModelContact, ePropertyType )
+ , uno::Any( 0.0 ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -547,7 +548,7 @@ WrappedErrorIndicatorProperty::WrappedErrorIndicatorProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< css::chart::ChartErrorIndicatorType >( "ErrorIndicator"
- , uno::Any( css::chart::ChartErrorIndicatorType_NONE ), spChart2ModelContact, ePropertyType )
+ , uno::Any( css::chart::ChartErrorIndicatorType_NONE ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -616,7 +617,7 @@ WrappedErrorBarStyleProperty::WrappedErrorBarStyleProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< sal_Int32 >( "ErrorBarStyle"
- , uno::Any( css::chart::ErrorBarStyle::NONE ), spChart2ModelContact, ePropertyType )
+ , uno::Any( css::chart::ErrorBarStyle::NONE ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -661,7 +662,7 @@ WrappedErrorBarRangePositiveProperty::WrappedErrorBarRangePositiveProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< OUString >( "ErrorBarRangePositive"
- , uno::Any( OUString() ), spChart2ModelContact, ePropertyType )
+ , uno::Any( OUString() ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -724,7 +725,7 @@ WrappedErrorBarRangeNegativeProperty::WrappedErrorBarRangeNegativeProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< OUString >( "ErrorBarRangeNegative"
- , uno::Any( OUString() ), spChart2ModelContact, ePropertyType )
+ , uno::Any( OUString() ), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -784,7 +785,7 @@ WrappedRegressionCurvesProperty::WrappedRegressionCurvesProperty(
std::shared_ptr< Chart2ModelContact > spChart2ModelContact,
tSeriesOrDiagramPropertyType ePropertyType )
: WrappedStatisticProperty< css::chart::ChartRegressionCurveType >( "RegressionCurves"
- , lcl_getRegressionDefault(), spChart2ModelContact, ePropertyType )
+ , lcl_getRegressionDefault(), std::move(spChart2ModelContact), ePropertyType )
{
}
@@ -852,7 +853,7 @@ WrappedStatisticPropertySetProperty::WrappedStatisticPropertySetProperty(
: (ePropertySetType == PROPERTY_SET_TYPE_ERROR_BAR)
? OUString("DataErrorProperties")
: OUString("DataMeanValueProperties")
- , uno::Any(), spChart2ModelContact, ePropertyType )
+ , uno::Any(), std::move(spChart2ModelContact), ePropertyType )
, m_eType( ePropertySetType )
{
}
diff --git a/chart2/source/controller/inc/uiobject.hxx b/chart2/source/controller/inc/uiobject.hxx
index 580db5ea71ba..31d1561b08f3 100644
--- a/chart2/source/controller/inc/uiobject.hxx
+++ b/chart2/source/controller/inc/uiobject.hxx
@@ -19,7 +19,7 @@ class ChartUIObject : public UIObject
{
public:
- ChartUIObject(VclPtr<chart::ChartWindow> xChartWindow,
+ ChartUIObject(const VclPtr<chart::ChartWindow>& xChartWindow,
const OUString& rCID);
StringMap get_state() override;
@@ -48,7 +48,7 @@ class ChartWindowUIObject : public WindowUIObject
public:
- ChartWindowUIObject(VclPtr<chart::ChartWindow> xChartWindow);
+ ChartWindowUIObject(const VclPtr<chart::ChartWindow>& xChartWindow);
virtual StringMap get_state() override;
diff --git a/chart2/source/controller/uitest/uiobject.cxx b/chart2/source/controller/uitest/uiobject.cxx
index 9bc0f05d7ce2..fa04a13d747f 100644
--- a/chart2/source/controller/uitest/uiobject.cxx
+++ b/chart2/source/controller/uitest/uiobject.cxx
@@ -20,7 +20,7 @@
#include <algorithm>
#include <iterator>
-ChartUIObject::ChartUIObject(VclPtr<chart::ChartWindow> xChartWindow,
+ChartUIObject::ChartUIObject(const VclPtr<chart::ChartWindow>& xChartWindow,
const OUString& rCID):
maCID(rCID),
mxChartWindow(xChartWindow)
@@ -92,7 +92,7 @@ OUString ChartUIObject::get_type() const
return OUString("ChartUIObject for type: ");
}
-ChartWindowUIObject::ChartWindowUIObject(VclPtr<chart::ChartWindow> xChartWindow):
+ChartWindowUIObject::ChartWindowUIObject(const VclPtr<chart::ChartWindow>& xChartWindow):
WindowUIObject(xChartWindow),
mxChartWindow(xChartWindow)
{
diff --git a/chart2/source/view/inc/3DChartObjects.hxx b/chart2/source/view/inc/3DChartObjects.hxx
index a8e30d1c1b1c..052fd1dd2783 100644
--- a/chart2/source/view/inc/3DChartObjects.hxx
+++ b/chart2/source/view/inc/3DChartObjects.hxx
@@ -105,7 +105,7 @@ class ScreenText : public Renderable3DObject
{
public:
ScreenText(OpenGL3DRenderer* pRenderer, TextCache& rTextCache,
- const OUString& rStr, glm::vec4 rColor, sal_uInt32 nId, bool bIs3dText = false);
+ const OUString& rStr, const glm::vec4& rColor, sal_uInt32 nId, bool bIs3dText = false);
virtual void render() override;
void setPosition(const glm::vec2& rTopLeft, const glm::vec2& rBottomRight,
diff --git a/chart2/source/view/main/3DChartObjects.cxx b/chart2/source/view/main/3DChartObjects.cxx
index ebedc36800dd..37f327bb9b9b 100644
--- a/chart2/source/view/main/3DChartObjects.cxx
+++ b/chart2/source/view/main/3DChartObjects.cxx
@@ -127,7 +127,7 @@ void Text::setPosition(const glm::vec3& rTopLeft, const glm::vec3& rTopRight, co
}
ScreenText::ScreenText(OpenGL3DRenderer* pRenderer, TextCache& rTextCache,
- const OUString& rStr, glm::vec4 rColor, sal_uInt32 nId, bool bIs3dText):
+ const OUString& rStr, const glm::vec4& rColor, sal_uInt32 nId, bool bIs3dText):
Renderable3DObject(pRenderer, nId),
maText(rTextCache.getText(rStr,bIs3dText)),
maColor(rColor)
diff --git a/comphelper/source/container/namecontainer.cxx b/comphelper/source/container/namecontainer.cxx
index 0b51ba050e75..23b87df8b94c 100644
--- a/comphelper/source/container/namecontainer.cxx
+++ b/comphelper/source/container/namecontainer.cxx
@@ -34,7 +34,7 @@ namespace comphelper
class NameContainer : public ::cppu::WeakImplHelper< css::container::XNameContainer >
{
public:
- explicit NameContainer( css::uno::Type aType );
+ explicit NameContainer( const css::uno::Type& aType );
// XNameContainer
virtual void SAL_CALL insertByName( const OUString& aName, const css::uno::Any& aElement ) override;
@@ -66,7 +66,7 @@ using namespace ::com::sun::star::container;
using namespace ::com::sun::star::lang;
-NameContainer::NameContainer( css::uno::Type aType )
+NameContainer::NameContainer( const css::uno::Type& aType )
: maType( aType )
{
}
diff --git a/cui/source/dialogs/scriptdlg.cxx b/cui/source/dialogs/scriptdlg.cxx
index a880d40ec975..7be590b167de 100644
--- a/cui/source/dialogs/scriptdlg.cxx
+++ b/cui/source/dialogs/scriptdlg.cxx
@@ -1405,7 +1405,7 @@ OUString GetErrorMessage( const css::uno::Any& aException )
}
-SvxScriptErrorDialog::SvxScriptErrorDialog( css::uno::Any aException )
+SvxScriptErrorDialog::SvxScriptErrorDialog( css::uno::Any const & aException )
: m_sMessage()
{
SolarMutexGuard aGuard;
diff --git a/cui/source/inc/scriptdlg.hxx b/cui/source/inc/scriptdlg.hxx
index d07e44cf765e..15189d447568 100644
--- a/cui/source/inc/scriptdlg.hxx
+++ b/cui/source/inc/scriptdlg.hxx
@@ -188,7 +188,7 @@ private:
public:
- SvxScriptErrorDialog( css::uno::Any aException );
+ SvxScriptErrorDialog( css::uno::Any const & aException );
virtual ~SvxScriptErrorDialog() override;
diff --git a/editeng/source/editeng/eertfpar.cxx b/editeng/source/editeng/eertfpar.cxx
index 6f93d8bf6280..43c093839e40 100644
--- a/editeng/source/editeng/eertfpar.cxx
+++ b/editeng/source/editeng/eertfpar.cxx
@@ -18,6 +18,7 @@
*/
#include <comphelper/string.hxx>
+#include <utility>
#include <vcl/wrkwin.hxx>
#include <vcl/dialog.hxx>
#include <vcl/msgbox.hxx>
@@ -68,7 +69,7 @@ RtfImportInfo::~RtfImportInfo()
EditRTFParser::EditRTFParser(
SvStream& rIn, EditSelection aSel, SfxItemPool& rAttrPool, EditEngine* pEditEngine) :
SvxRTFParser(rAttrPool, rIn, nullptr),
- aCurSel(aSel),
+ aCurSel(std::move(aSel)),
mpEditEngine(pEditEngine),
aRTFMapMode(MapUnit::MapTwip),
nDefFont(0),
diff --git a/formula/source/core/api/FormulaCompiler.cxx b/formula/source/core/api/FormulaCompiler.cxx
index ead0e05414b1..7da75874ea04 100644
--- a/formula/source/core/api/FormulaCompiler.cxx
+++ b/formula/source/core/api/FormulaCompiler.cxx
@@ -145,7 +145,7 @@ class OpCodeList
{
public:
- OpCodeList( sal_uInt16, FormulaCompiler::NonConstOpCodeMapPtr,
+ OpCodeList( sal_uInt16, const FormulaCompiler::NonConstOpCodeMapPtr&,
FormulaCompiler::SeparatorType = FormulaCompiler::SeparatorType::SEMICOLON_BASE );
private:
@@ -157,7 +157,7 @@ private:
ResStringArray maStringList;
};
-OpCodeList::OpCodeList( sal_uInt16 nRID, FormulaCompiler::NonConstOpCodeMapPtr xMap,
+OpCodeList::OpCodeList( sal_uInt16 nRID, const FormulaCompiler::NonConstOpCodeMapPtr& xMap,
FormulaCompiler::SeparatorType eSepType )
: meSepType(eSepType)
, maStringList(ResId(nRID, *ResourceManager::getResManager()))
diff --git a/include/avmedia/MediaControlBase.hxx b/include/avmedia/MediaControlBase.hxx
index bc73f64cf66a..29e1ab7b4fc4 100644
--- a/include/avmedia/MediaControlBase.hxx
+++ b/include/avmedia/MediaControlBase.hxx
@@ -72,10 +72,10 @@ protected:
static Image GetImage(sal_Int32 nImageId);
virtual void InitializeWidgets();
virtual void UpdateToolBoxes( MediaItem aMediaItem );
- void UpdateVolumeSlider( MediaItem aMediaItem );
- void UpdateTimeSlider( MediaItem aMediaItem );
- void UpdateTimeField( MediaItem aMediaItem, double fTime );
- void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem aItem, sal_uInt16 nId);
+ void UpdateVolumeSlider( MediaItem const & aMediaItem );
+ void UpdateTimeSlider( MediaItem const & aMediaItem );
+ void UpdateTimeField( MediaItem const & aMediaItem, double fTime );
+ void SelectPlayToolBoxItem( MediaItem& aExecItem, MediaItem const & aItem, sal_uInt16 nId);
};
}
diff --git a/include/oox/core/relationshandler.hxx b/include/oox/core/relationshandler.hxx
index 314e95a29b39..1aa84ad1aa48 100644
--- a/include/oox/core/relationshandler.hxx
+++ b/include/oox/core/relationshandler.hxx
@@ -44,7 +44,7 @@ class RelationsFragment : public FragmentHandler
public:
explicit RelationsFragment(
XmlFilterBase& rFilter,
- RelationsRef xRelations );
+ const RelationsRef& xRelations );
virtual css::uno::Reference< css::xml::sax::XFastContextHandler > SAL_CALL
createFastChildContext(
diff --git a/include/oox/drawingml/connectorshapecontext.hxx b/include/oox/drawingml/connectorshapecontext.hxx
index 71b5e50ff6bf..57982230bc34 100644
--- a/include/oox/drawingml/connectorshapecontext.hxx
+++ b/include/oox/drawingml/connectorshapecontext.hxx
@@ -34,7 +34,7 @@ namespace oox { namespace drawingml {
class OOX_DLLPUBLIC ConnectorShapeContext : public ShapeContext
{
public:
- ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr );
+ ConnectorShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pGroupShapePtr );
virtual ~ConnectorShapeContext() override;
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
};
diff --git a/include/oox/drawingml/graphicshapecontext.hxx b/include/oox/drawingml/graphicshapecontext.hxx
index 22218fdee265..403fdea79018 100644
--- a/include/oox/drawingml/graphicshapecontext.hxx
+++ b/include/oox/drawingml/graphicshapecontext.hxx
@@ -36,7 +36,7 @@ namespace oox { namespace drawingml {
class OOX_DLLPUBLIC GraphicShapeContext : public ShapeContext
{
public:
- GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr );
+ GraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr );
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
};
@@ -45,7 +45,7 @@ public:
class OOX_DLLPUBLIC GraphicalObjectFrameContext : public ShapeContext
{
public:
- GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr, bool bEmbedShapesInChart );
+ GraphicalObjectFrameContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr, bool bEmbedShapesInChart );
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
virtual void onEndElement() override;
@@ -59,7 +59,7 @@ private:
class OleObjectGraphicDataContext : public ShapeContext
{
public:
- OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+ OleObjectGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
virtual ~OleObjectGraphicDataContext() override;
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
@@ -72,7 +72,7 @@ class DiagramGraphicDataContext
: public ShapeContext
{
public:
- DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+ DiagramGraphicDataContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
virtual ~DiagramGraphicDataContext() override;
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
diff --git a/include/oox/ppt/pptgraphicshapecontext.hxx b/include/oox/ppt/pptgraphicshapecontext.hxx
index 44b0438f6bc9..ba01f726c552 100644
--- a/include/oox/ppt/pptgraphicshapecontext.hxx
+++ b/include/oox/ppt/pptgraphicshapecontext.hxx
@@ -36,7 +36,7 @@ class PPTGraphicShapeContext : public ::oox::drawingml::GraphicShapeContext
SlidePersistPtr mpSlidePersistPtr;
public:
- PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+ PPTGraphicShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
};
diff --git a/include/oox/ppt/pptshapecontext.hxx b/include/oox/ppt/pptshapecontext.hxx
index f3a643f9f175..c58296ff0ccd 100644
--- a/include/oox/ppt/pptshapecontext.hxx
+++ b/include/oox/ppt/pptshapecontext.hxx
@@ -36,7 +36,7 @@ class PPTShapeContext : public ::oox::drawingml::ShapeContext
SlidePersistPtr mpSlidePersistPtr;
public:
- PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr );
+ PPTShapeContext( ::oox::core::ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr );
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
};
diff --git a/include/oox/ppt/pptshapegroupcontext.hxx b/include/oox/ppt/pptshapegroupcontext.hxx
index 91d78e904b0c..011cdff62a86 100644
--- a/include/oox/ppt/pptshapegroupcontext.hxx
+++ b/include/oox/ppt/pptshapegroupcontext.hxx
@@ -47,8 +47,8 @@ public:
::oox::core::ContextHandler2Helper& rParent,
const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
const oox::ppt::ShapeLocation eShapeLocation,
- oox::drawingml::ShapePtr pMasterShapePtr,
- oox::drawingml::ShapePtr pGroupShapePtr );
+ const oox::drawingml::ShapePtr& pMasterShapePtr,
+ const oox::drawingml::ShapePtr& pGroupShapePtr );
virtual ::oox::core::ContextHandlerRef
onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
diff --git a/include/oox/ppt/slidefragmenthandler.hxx b/include/oox/ppt/slidefragmenthandler.hxx
index b6b4a3d57721..545a55bd1a56 100644
--- a/include/oox/ppt/slidefragmenthandler.hxx
+++ b/include/oox/ppt/slidefragmenthandler.hxx
@@ -37,7 +37,7 @@ namespace oox { namespace ppt {
class SlideFragmentHandler : public ::oox::core::FragmentHandler2
{
public:
- SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pPersistPtr, const ShapeLocation eShapeLocation );
+ SlideFragmentHandler( ::oox::core::XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pPersistPtr, const ShapeLocation eShapeLocation );
virtual ~SlideFragmentHandler() override;
virtual void finalizeImport() override;
diff --git a/include/svtools/svlbitm.hxx b/include/svtools/svlbitm.hxx
index c9db0cbf5a46..16106511a0b5 100644
--- a/include/svtools/svlbitm.hxx
+++ b/include/svtools/svlbitm.hxx
@@ -229,8 +229,8 @@ class SVT_DLLPUBLIC SvLBoxContextBmp : public SvLBoxItem
{
std::unique_ptr<SvLBoxContextBmp_Impl> m_pImpl;
public:
- SvLBoxContextBmp(Image aBmp1,
- Image aBmp2,
+ SvLBoxContextBmp(const Image& aBmp1,
+ const Image& aBmp2,
bool bExpanded);
SvLBoxContextBmp();
virtual ~SvLBoxContextBmp() override;
diff --git a/include/svx/cube3d.hxx b/include/svx/cube3d.hxx
index e065eef242c5..2cb6569b8e53 100644
--- a/include/svx/cube3d.hxx
+++ b/include/svx/cube3d.hxx
@@ -77,7 +77,7 @@ protected:
virtual sdr::contact::ViewContact* CreateObjectSpecificViewContact() override;
public:
- E3dCubeObj(E3dDefaultAttributes& rDefault, basegfx::B3DPoint aPos, const basegfx::B3DVector& r3DSize);
+ E3dCubeObj(E3dDefaultAttributes& rDefault, const basegfx::B3DPoint& aPos, const basegfx::B3DVector& r3DSize);
E3dCubeObj();
virtual sal_uInt16 GetObjIdentifier() const override;
diff --git a/include/vcl/uitest/uiobject.hxx b/include/vcl/uitest/uiobject.hxx
index 2edec77ae109..de413107903e 100644
--- a/include/vcl/uitest/uiobject.hxx
+++ b/include/vcl/uitest/uiobject.hxx
@@ -105,7 +105,7 @@ class UITEST_DLLPUBLIC WindowUIObject : public UIObject
public:
- WindowUIObject(VclPtr<vcl::Window> xWindow);
+ WindowUIObject(const VclPtr<vcl::Window>& xWindow);
virtual StringMap get_state() override;
@@ -138,7 +138,7 @@ class UITEST_DLLPUBLIC ButtonUIObject : public WindowUIObject
VclPtr<Button> mxButton;
public:
- ButtonUIObject(VclPtr<Button> xButton);
+ ButtonUIObject(const VclPtr<Button>& xButton);
virtual ~ButtonUIObject() override;
virtual StringMap get_state() override;
@@ -159,7 +159,7 @@ class UITEST_DLLPUBLIC DialogUIObject : public WindowUIObject
public:
- DialogUIObject(VclPtr<Dialog> xDialog);
+ DialogUIObject(const VclPtr<Dialog>& xDialog);
virtual ~DialogUIObject() override;
virtual StringMap get_state() override;
@@ -177,7 +177,7 @@ class UITEST_DLLPUBLIC EditUIObject : public WindowUIObject
public:
- EditUIObject(VclPtr<Edit> xEdit);
+ EditUIObject(const VclPtr<Edit>& xEdit);
virtual ~EditUIObject() override;
virtual void execute(const OUString& rAction,
@@ -199,7 +199,7 @@ private:
VclPtr<CheckBox> mxCheckBox;
public:
- CheckBoxUIObject(VclPtr<CheckBox> xCheckbox);
+ CheckBoxUIObject(const VclPtr<CheckBox>& xCheckbox);
virtual ~CheckBoxUIObject() override;
virtual void execute(const OUString& rAction,
@@ -220,7 +220,7 @@ private:
VclPtr<RadioButton> mxRadioButton;
public:
- RadioButtonUIObject(VclPtr<RadioButton> xCheckbox);
+ RadioButtonUIObject(const VclPtr<RadioButton>& xCheckbox);
virtual ~RadioButtonUIObject() override;
virtual void execute(const OUString& rAction,
@@ -240,7 +240,7 @@ class UITEST_DLLPUBLIC TabPageUIObject : public WindowUIObject
private:
VclPtr<TabPage> mxTabPage;
public:
- TabPageUIObject(VclPtr<TabPage> xTabPage);
+ TabPageUIObject(const VclPtr<TabPage>& xTabPage);
virtual ~TabPageUIObject() override;
virtual void execute(const OUString& rAction,
@@ -262,7 +262,7 @@ private:
public:
- ListBoxUIObject(VclPtr<ListBox> xListBox);
+ ListBoxUIObject(const VclPtr<ListBox>& xListBox);
virtual ~ListBoxUIObject() override;
virtual void execute(const OUString& rAction,
@@ -287,7 +287,7 @@ private:
public:
- ComboBoxUIObject(VclPtr<ComboBox> xListBox);
+ ComboBoxUIObject(const VclPtr<ComboBox>& xListBox);
virtual ~ComboBoxUIObject() override;
virtual void execute(const OUString& rAction,
@@ -309,7 +309,7 @@ private:
public:
- SpinUIObject(VclPtr<SpinButton> xSpinButton);
+ SpinUIObject(const VclPtr<SpinButton>& xSpinButton);
virtual ~SpinUIObject() override;
virtual void execute(const OUString& rAction,
@@ -330,7 +330,7 @@ class UITEST_DLLPUBLIC SpinFieldUIObject : public EditUIObject
public:
- SpinFieldUIObject(VclPtr<SpinField> xEdit);
+ SpinFieldUIObject(const VclPtr<SpinField>& xEdit);
virtual ~SpinFieldUIObject() override;
virtual void execute(const OUString& rAction,
@@ -352,7 +352,7 @@ private:
public:
- TabControlUIObject(VclPtr<TabControl> mxTabControl);
+ TabControlUIObject(const VclPtr<TabControl>& mxTabControl);
virtual ~TabControlUIObject() override;
virtual void execute(const OUString& rAction,
diff --git a/oox/inc/drawingml/table/tablecontext.hxx b/oox/inc/drawingml/table/tablecontext.hxx
index 00545a8e8d64..4157347e73ce 100644
--- a/oox/inc/drawingml/table/tablecontext.hxx
+++ b/oox/inc/drawingml/table/tablecontext.hxx
@@ -29,7 +29,7 @@ class TableProperties;
class TableContext : public ShapeContext
{
public:
- TableContext( ::oox::core::ContextHandler2Helper& rParent, ShapePtr pShapePtr );
+ TableContext( ::oox::core::ContextHandler2Helper& rParent, const ShapePtr& pShapePtr );
virtual ~TableContext() override;
virtual ::oox::core::ContextHandlerRef onCreateContext( ::sal_Int32 Element, const ::oox::AttributeList& rAttribs ) override;
diff --git a/oox/inc/drawingml/textbody.hxx b/oox/inc/drawingml/textbody.hxx
index 043529723e76..c2b0c5acc762 100644
--- a/oox/inc/drawingml/textbody.hxx
+++ b/oox/inc/drawingml/textbody.hxx
@@ -40,7 +40,7 @@ class TextBody
{
public:
TextBody();
- TextBody( TextBodyPtr pBody );
+ TextBody( const TextBodyPtr& pBody );
~TextBody();
const TextParagraphVector& getParagraphs() const { return maParagraphs; }
diff --git a/oox/source/core/relationshandler.cxx b/oox/source/core/relationshandler.cxx
index b848002f754f..e5228313a690 100644
--- a/oox/source/core/relationshandler.cxx
+++ b/oox/source/core/relationshandler.cxx
@@ -50,7 +50,7 @@ OUString lclGetRelationsPath( const OUString& rFragmentPath )
} // namespace
-RelationsFragment::RelationsFragment( XmlFilterBase& rFilter, RelationsRef xRelations ) :
+RelationsFragment::RelationsFragment( XmlFilterBase& rFilter, const RelationsRef& xRelations ) :
FragmentHandler( rFilter, lclGetRelationsPath( xRelations->getFragmentPath() ), xRelations ),
mxRelations( xRelations )
{
diff --git a/oox/source/drawingml/connectorshapecontext.cxx b/oox/source/drawingml/connectorshapecontext.cxx
index 284d193a3182..26946dd163c1 100644
--- a/oox/source/drawingml/connectorshapecontext.cxx
+++ b/oox/source/drawingml/connectorshapecontext.cxx
@@ -42,7 +42,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace drawingml {
ConnectorShapeContext::ConnectorShapeContext( ContextHandler2Helper& rParent,
- ShapePtr pMasterShapePtr, ShapePtr pGroupShapePtr )
+ const ShapePtr& pMasterShapePtr, const ShapePtr& pGroupShapePtr )
: ShapeContext( rParent, pMasterShapePtr, pGroupShapePtr )
{
}
diff --git a/oox/source/drawingml/graphicshapecontext.cxx b/oox/source/drawingml/graphicshapecontext.cxx
index fa59e0a3c046..db77409cb0bb 100644
--- a/oox/source/drawingml/graphicshapecontext.cxx
+++ b/oox/source/drawingml/graphicshapecontext.cxx
@@ -71,7 +71,7 @@ namespace drawingml {
// CT_Picture
-GraphicShapeContext::GraphicShapeContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr )
+GraphicShapeContext::GraphicShapeContext( ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr )
: ShapeContext( rParent, pMasterShapePtr, pShapePtr )
{
}
@@ -121,7 +121,7 @@ ContextHandlerRef GraphicShapeContext::onCreateContext( sal_Int32 aElementToken,
// CT_GraphicalObjectFrameContext
-GraphicalObjectFrameContext::GraphicalObjectFrameContext( ContextHandler2Helper& rParent, ShapePtr pMasterShapePtr, ShapePtr pShapePtr, bool bEmbedShapesInChart ) :
+GraphicalObjectFrameContext::GraphicalObjectFrameContext( ContextHandler2Helper& rParent, const ShapePtr& pMasterShapePtr, const ShapePtr& pShapePtr, bool bEmbedShapesInChart ) :
ShapeContext( rParent, pMasterShapePtr, pShapePtr ),
mbEmbedShapesInChart( bEmbedShapesInChart ),
mpParent(&rParent)
@@ -177,7 +177,7 @@ void GraphicalObjectFrameContext::onEndElement()
}
}
-OleObjectGraphicDataContext::OleObjectGraphicDataContext( ContextHandler2Helper& rParent, ShapePtr xShape ) :
+OleObjectGraphicDataContext::OleObjectGraphicDataContext( ContextHandler2Helper& rParent, const ShapePtr& xShape ) :
ShapeContext( rParent, ShapePtr(), xShape ),
mrOleObjectInfo( xShape->setOleObjectType() )
{
@@ -237,7 +237,7 @@ ContextHandlerRef OleObjectGraphicDataContext::onCreateContext( sal_Int32 nEleme
return nullptr;
}
-DiagramGraphicDataContext::DiagramGraphicDataContext( ContextHandler2Helper& rParent, ShapePtr pShapePtr )
+DiagramGraphicDataContext::DiagramGraphicDataContext( ContextHandler2Helper& rParent, const ShapePtr& pShapePtr )
: ShapeContext( rParent, ShapePtr(), pShapePtr )
{
pShapePtr->setDiagramType();
diff --git a/oox/source/drawingml/table/tablecontext.cxx b/oox/source/drawingml/table/tablecontext.cxx
index 93308773d989..2cfe580f8abe 100644
--- a/oox/source/drawingml/table/tablecontext.cxx
+++ b/oox/source/drawingml/table/tablecontext.cxx
@@ -31,7 +31,7 @@ using namespace ::com::sun::star;
namespace oox { namespace drawingml { namespace table {
-TableContext::TableContext( ContextHandler2Helper& rParent, ShapePtr pShapePtr )
+TableContext::TableContext( ContextHandler2Helper& rParent, const ShapePtr& pShapePtr )
: ShapeContext( rParent, ShapePtr(), pShapePtr )
, mrTableProperties( *pShapePtr->getTableProperties().get() )
{
diff --git a/oox/source/drawingml/textbody.cxx b/oox/source/drawingml/textbody.cxx
index 8efb70d1cdd0..306bcf3ba384 100644
--- a/oox/source/drawingml/textbody.cxx
+++ b/oox/source/drawingml/textbody.cxx
@@ -36,7 +36,7 @@ TextBody::TextBody()
{
}
-TextBody::TextBody( TextBodyPtr pBody )
+TextBody::TextBody( const TextBodyPtr& pBody )
{
if( pBody.get() ) {
maTextProperties = pBody->maTextProperties;
diff --git a/oox/source/export/chartexport.cxx b/oox/source/export/chartexport.cxx
index a079566182a4..25d70e8ee442 100644
--- a/oox/source/export/chartexport.cxx
+++ b/oox/source/export/chartexport.cxx
@@ -89,6 +89,7 @@
#include <comphelper/processfactory.hxx>
#include <comphelper/random.hxx>
#include <comphelper/sequence.hxx>
+#include <utility>
#include <xmloff/SchXMLSeriesHelper.hxx>
#include "ColorPropertySet.hxx"
@@ -430,7 +431,7 @@ sal_Int32 lcl_generateRandomValue()
}
ChartExport::ChartExport( sal_Int32 nXmlNamespace, FSHelperPtr pFS, Reference< frame::XModel >& xModel, XmlFilterBase* pFB, DocumentType eDocumentType )
- : DrawingML( pFS, pFB, eDocumentType )
+ : DrawingML( std::move(pFS), pFB, eDocumentType )
, mnXmlNamespace( nXmlNamespace )
, mnSeriesCount(0)
, mxChartModel( xModel )
diff --git a/oox/source/export/shapes.cxx b/oox/source/export/shapes.cxx
index 7d94310e0a11..7d3090c1cd65 100644
--- a/oox/source/export/shapes.cxx
+++ b/oox/source/export/shapes.cxx
@@ -81,6 +81,7 @@
#include <comphelper/classids.hxx>
#include <comphelper/storagehelper.hxx>
#include <sot/exchange.hxx>
+#include <utility>
#include <vcl/cvtgrf.hxx>
#include <unotools/fontcvt.hxx>
#include <vcl/graph.hxx>
@@ -360,7 +361,7 @@ bool URLTransformer::isExternalURL(const OUString& /*rURL*/) const
mAny >>= variable;
ShapeExport::ShapeExport( sal_Int32 nXmlNamespace, FSHelperPtr pFS, ShapeHashMap* pShapeMap, XmlFilterBase* pFB, DocumentType eDocumentType, DMLTextExport* pTextExport )
- : DrawingML( pFS, pFB, eDocumentType, pTextExport )
+ : DrawingML( std::move(pFS), pFB, eDocumentType, pTextExport )
, m_nEmbeddedObjects(0)
, mnShapeIdMax( 1 )
, mnPictureIdMax( 1 )
diff --git a/oox/source/ppt/layoutfragmenthandler.cxx b/oox/source/ppt/layoutfragmenthandler.cxx
index 09af2df9e1cc..deaaf5387529 100644
--- a/oox/source/ppt/layoutfragmenthandler.cxx
+++ b/oox/source/ppt/layoutfragmenthandler.cxx
@@ -29,6 +29,7 @@
#include <oox/helper/attributelist.hxx>
#include <oox/token/namespaces.hxx>
#include <oox/token/tokens.hxx>
+#include <utility>
using namespace ::com::sun::star;
using namespace ::oox::core;
@@ -43,7 +44,7 @@ namespace oox { namespace ppt {
LayoutFragmentHandler::LayoutFragmentHandler( XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pMasterPersistPtr )
throw()
-: SlideFragmentHandler( rFilter, rFragmentPath, pMasterPersistPtr, Layout )
+: SlideFragmentHandler( rFilter, rFragmentPath, std::move(pMasterPersistPtr), Layout )
{
}
diff --git a/oox/source/ppt/pptgraphicshapecontext.cxx b/oox/source/ppt/pptgraphicshapecontext.cxx
index 152872ffbdc8..826fad39ef68 100644
--- a/oox/source/ppt/pptgraphicshapecontext.cxx
+++ b/oox/source/ppt/pptgraphicshapecontext.cxx
@@ -48,7 +48,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace ppt {
// CT_Shape
-PPTGraphicShapeContext::PPTGraphicShapeContext( ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr )
+PPTGraphicShapeContext::PPTGraphicShapeContext( ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr )
: oox::drawingml::GraphicShapeContext( rParent, pMasterShapePtr, pShapePtr )
, mpSlidePersistPtr( rSlidePersistPtr )
{
diff --git a/oox/source/ppt/pptimport.cxx b/oox/source/ppt/pptimport.cxx
index 474abb6278e2..6e3717fc9f10 100644
--- a/oox/source/ppt/pptimport.cxx
+++ b/oox/source/ppt/pptimport.cxx
@@ -87,7 +87,7 @@ PowerPointImport::~PowerPointImport()
}
/// Visits the relations from pRelations which are of type rType.
-static void visitRelations(PowerPointImport& rImport, core::RelationsRef pRelations, const OUString& rType, std::vector<OUString>& rImageFragments)
+static void visitRelations(PowerPointImport& rImport, const core::RelationsRef& pRelations, const OUString& rType, std::vector<OUString>& rImageFragments)
{
if (core::RelationsRef pRelationsOfType = pRelations->getRelationsFromTypeFromOfficeDoc(rType))
{
diff --git a/oox/source/ppt/pptshapecontext.cxx b/oox/source/ppt/pptshapecontext.cxx
index 81e0cbb71fa8..d3348dcb1c1c 100644
--- a/oox/source/ppt/pptshapecontext.cxx
+++ b/oox/source/ppt/pptshapecontext.cxx
@@ -50,7 +50,7 @@ using namespace ::com::sun::star::xml::sax;
namespace oox { namespace ppt {
// CT_Shape
-PPTShapeContext::PPTShapeContext( ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, oox::drawingml::ShapePtr pMasterShapePtr, oox::drawingml::ShapePtr pShapePtr )
+PPTShapeContext::PPTShapeContext( ContextHandler2Helper& rParent, const SlidePersistPtr& rSlidePersistPtr, const oox::drawingml::ShapePtr& pMasterShapePtr, const oox::drawingml::ShapePtr& pShapePtr )
: oox::drawingml::ShapeContext( rParent, pMasterShapePtr, pShapePtr )
, mpSlidePersistPtr( rSlidePersistPtr )
{
diff --git a/oox/source/ppt/pptshapegroupcontext.cxx b/oox/source/ppt/pptshapegroupcontext.cxx
index 0847eb8bd331..4ad250a15cff 100644
--- a/oox/source/ppt/pptshapegroupcontext.cxx
+++ b/oox/source/ppt/pptshapegroupcontext.cxx
@@ -54,8 +54,8 @@ PPTShapeGroupContext::PPTShapeGroupContext(
ContextHandler2Helper& rParent,
const oox::ppt::SlidePersistPtr& rSlidePersistPtr,
const ShapeLocation eShapeLocation,
- oox::drawingml::ShapePtr pMasterShapePtr,
- oox::drawingml::ShapePtr pGroupShapePtr )
+ const oox::drawingml::ShapePtr& pMasterShapePtr,
+ const oox::drawingml::ShapePtr& pGroupShapePtr )
: ShapeGroupContext( rParent, pMasterShapePtr, pGroupShapePtr )
, mpSlidePersistPtr( rSlidePersistPtr )
, meShapeLocation( eShapeLocation )
diff --git a/oox/source/ppt/slidefragmenthandler.cxx b/oox/source/ppt/slidefragmenthandler.cxx
index 5b8a8b836377..9d6fcf16aa99 100644
--- a/oox/source/ppt/slidefragmenthandler.cxx
+++ b/oox/source/ppt/slidefragmenthandler.cxx
@@ -54,7 +54,7 @@ using namespace ::com::sun::star::container;
namespace oox { namespace ppt {
-SlideFragmentHandler::SlideFragmentHandler( XmlFilterBase& rFilter, const OUString& rFragmentPath, SlidePersistPtr pPersistPtr, const ShapeLocation eShapeLocation )
+SlideFragmentHandler::SlideFragmentHandler( XmlFilterBase& rFilter, const OUString& rFragmentPath, const SlidePersistPtr& pPersistPtr, const ShapeLocation eShapeLocation )
: FragmentHandler2( rFilter, rFragmentPath )
, mpSlidePersistPtr( pPersistPtr )
, meShapeLocation( eShapeLocation )
diff --git a/sc/inc/textuno.hxx b/sc/inc/textuno.hxx
index 3d6f5f1908d8..0a33daa6a3f0 100644
--- a/sc/inc/textuno.hxx
+++ b/sc/inc/textuno.hxx
@@ -152,7 +152,7 @@ private:
public:
ScHeaderFooterTextObj(
- css::uno::WeakReference<css::sheet::XHeaderFooterContent> xContent, ScHeaderFooterPart nP, const EditTextObject* pTextObj);
+ const css::uno::WeakReference<css::sheet::XHeaderFooterContent>& xContent, ScHeaderFooterPart nP, const EditTextObject* pTextObj);
virtual ~ScHeaderFooterTextObj() override;
const EditTextObject* GetTextObject() const;
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index 63b1279cd266..e2980ba7f164 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -1225,7 +1225,7 @@ struct ValDataTestParams
ValDataTestParams( ScValidationMode eMode, ScConditionMode eOp,
const OUString& aExpr1, const OUString& aExpr2, ScDocument& rDoc,
- ScAddress aPos, const OUString& aETitle, const OUString& aEMsg,
+ const ScAddress& aPos, const OUString& aETitle, const OUString& aEMsg,
ScValidErrorStyle eEStyle, sal_uLong nIndex ):
eValMode(eMode), eCondOp(eOp), aStrVal1(aExpr1),
aStrVal2(aExpr2), rDocument(rDoc), aPosition(aPos),
diff --git a/sc/source/filter/excel/xecontent.cxx b/sc/source/filter/excel/xecontent.cxx
index 706dcb67b9ec..4df9300152b4 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -1197,7 +1197,7 @@ OString generateGUIDString()
}
-XclExpCondfmt::XclExpCondfmt( const XclExpRoot& rRoot, const ScConditionalFormat& rCondFormat, XclExtLstRef xExtLst, sal_Int32& rIndex ) :
+XclExpCondfmt::XclExpCondfmt( const XclExpRoot& rRoot, const ScConditionalFormat& rCondFormat, const XclExtLstRef& xExtLst, sal_Int32& rIndex ) :
XclExpRecord( EXC_ID_CONDFMT ),
XclExpRoot( rRoot )
{
@@ -1478,7 +1478,7 @@ void XclExpIconSet::SaveXml( XclExpXmlStream& rStrm )
rWorksheet->endElement( XML_cfRule );
}
-XclExpCondFormatBuffer::XclExpCondFormatBuffer( const XclExpRoot& rRoot, XclExtLstRef xExtLst ) :
+XclExpCondFormatBuffer::XclExpCondFormatBuffer( const XclExpRoot& rRoot, const XclExtLstRef& xExtLst ) :
XclExpRoot( rRoot )
{
if( const ScConditionalFormatList* pCondFmtList = GetDoc().GetCondFormList(GetCurrScTab()) )
diff --git a/sc/source/filter/excel/xeroot.cxx b/sc/source/filter/excel/xeroot.cxx
index f2851a5e6712..a3a43b1b076b 100644
--- a/sc/source/filter/excel/xeroot.cxx
+++ b/sc/source/filter/excel/xeroot.cxx
@@ -53,7 +53,7 @@ using namespace ::com::sun::star;
// Global data ================================================================
XclExpRootData::XclExpRootData( XclBiff eBiff, SfxMedium& rMedium,
- tools::SvRef<SotStorage> xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc ) :
+ const tools::SvRef<SotStorage>& xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc ) :
XclRootData( eBiff, rMedium, xRootStrg, rDoc, eTextEnc, true )
{
SvtSaveOptions aSaveOpt;
diff --git a/sc/source/filter/excel/xetable.cxx b/sc/source/filter/excel/xetable.cxx
index 1f3c400b336f..1f95b7a8f45d 100644
--- a/sc/source/filter/excel/xetable.cxx
+++ b/sc/source/filter/excel/xetable.cxx
@@ -117,7 +117,7 @@ void XclExpRangeFmlaBase::WriteRangeAddress( XclExpStream& rStrm ) const
// Array formulas =============================================================
-XclExpArray::XclExpArray( XclTokenArrayRef xTokArr, const ScRange& rScRange ) :
+XclExpArray::XclExpArray( const XclTokenArrayRef& xTokArr, const ScRange& rScRange ) :
XclExpRangeFmlaBase( EXC_ID3_ARRAY, 14 + xTokArr->GetSize(), rScRange ),
mxTokArr( xTokArr )
{
@@ -179,7 +179,7 @@ XclExpArrayRef XclExpArrayBuffer::FindArray( const ScTokenArray& rScTokArr, cons
// Shared formulas ============================================================
-XclExpShrfmla::XclExpShrfmla( XclTokenArrayRef xTokArr, const ScAddress& rScPos ) :
+XclExpShrfmla::XclExpShrfmla( const XclTokenArrayRef& xTokArr, const ScAddress& rScPos ) :
XclExpRangeFmlaBase( EXC_ID_SHRFMLA, 10 + xTokArr->GetSize(), rScPos ),
mxTokArr( xTokArr ),
mnUsedCount( 1 )
diff --git a/sc/source/filter/excel/xiroot.cxx b/sc/source/filter/excel/xiroot.cxx
index 23cfb0b3c4fd..d3988d2207a5 100644
--- a/sc/source/filter/excel/xiroot.cxx
+++ b/sc/source/filter/excel/xiroot.cxx
@@ -40,7 +40,7 @@
// Global data ================================================================
XclImpRootData::XclImpRootData( XclBiff eBiff, SfxMedium& rMedium,
- tools::SvRef<SotStorage> xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc ) :
+ const tools::SvRef<SotStorage>& xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc ) :
XclRootData( eBiff, rMedium, xRootStrg, rDoc, eTextEnc, false ),
mxDocImport(new ScDocumentImport(rDoc)),
mbHasCodePage( false ),
diff --git a/sc/source/filter/inc/xecontent.hxx b/sc/source/filter/inc/xecontent.hxx
index 8ad6da320c06..41d29b660a11 100644
--- a/sc/source/filter/inc/xecontent.hxx
+++ b/sc/source/filter/inc/xecontent.hxx
@@ -227,7 +227,7 @@ class ScConditionalFormat;
class XclExpCondfmt : public XclExpRecord, protected XclExpRoot
{
public:
- explicit XclExpCondfmt( const XclExpRoot& rRoot, const ScConditionalFormat& rCondFormat, XclExtLstRef xExtLst, sal_Int32& rIndex );
+ explicit XclExpCondfmt( const XclExpRoot& rRoot, const ScConditionalFormat& rCondFormat, const XclExtLstRef& xExtLst, sal_Int32& rIndex );
virtual ~XclExpCondfmt() override;
/** Returns true, if this conditional format contains at least one cell range and CF record. */
@@ -300,7 +300,7 @@ class XclExpCondFormatBuffer : public XclExpRecordBase, protected XclExpRoot
{
public:
/** Constructs CONDFMT and CF records containing the conditional formats of the current sheet. */
- explicit XclExpCondFormatBuffer( const XclExpRoot& rRoot, XclExtLstRef xExtLst );
+ explicit XclExpCondFormatBuffer( const XclExpRoot& rRoot, const XclExtLstRef& xExtLst );
/** Writes all contained CONDFMT records with their CF records. */
virtual void Save( XclExpStream& rStrm ) override;
diff --git a/sc/source/filter/inc/xeroot.hxx b/sc/source/filter/inc/xeroot.hxx
index 6ccfda12691f..e2e753c29b47 100644
--- a/sc/source/filter/inc/xeroot.hxx
+++ b/sc/source/filter/inc/xeroot.hxx
@@ -104,7 +104,7 @@ struct XclExpRootData : public XclRootData
OStringBuffer maStringBuf; /// buffer to avoid massive OUString allocations
explicit XclExpRootData( XclBiff eBiff, SfxMedium& rMedium,
- tools::SvRef<SotStorage> xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc );
+ const tools::SvRef<SotStorage>& xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc );
virtual ~XclExpRootData() override;
};
diff --git a/sc/source/filter/inc/xetable.hxx b/sc/source/filter/inc/xetable.hxx
index 1cf60bc8a69c..70fd2d14e2de 100644
--- a/sc/source/filter/inc/xetable.hxx
+++ b/sc/source/filter/inc/xetable.hxx
@@ -108,7 +108,7 @@ class ScTokenArray;
class XclExpArray : public XclExpRangeFmlaBase
{
public:
- explicit XclExpArray( XclTokenArrayRef xTokArr, const ScRange& rScRange );
+ explicit XclExpArray( const XclTokenArrayRef& xTokArr, const ScRange& rScRange );
/** Creates and returns the token array for a corresponding FORMULA cell record. */
virtual XclTokenArrayRef CreateCellTokenArray( const XclExpRoot& rRoot ) const override;
@@ -153,7 +153,7 @@ class XclExpShrfmla : public XclExpRangeFmlaBase
{
public:
/** Creates a SHRFMLA record that consists of the passed cell address only. */
- explicit XclExpShrfmla( XclTokenArrayRef xTokArr, const ScAddress& rScPos );
+ explicit XclExpShrfmla( const XclTokenArrayRef& xTokArr, const ScAddress& rScPos );
/** Extends the cell range to include the passed cell address. */
void ExtendRange( const ScAddress& rScPos );
diff --git a/sc/source/filter/inc/xiroot.hxx b/sc/source/filter/inc/xiroot.hxx
index 389df5c7fcb4..89e90f6afd38 100644
--- a/sc/source/filter/inc/xiroot.hxx
+++ b/sc/source/filter/inc/xiroot.hxx
@@ -118,7 +118,7 @@ struct XclImpRootData : public XclRootData
bool mbHasBasic; /// true = document contains VB project.
explicit XclImpRootData( XclBiff eBiff, SfxMedium& rMedium,
- tools::SvRef<SotStorage> xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc );
+ const tools::SvRef<SotStorage>& xRootStrg, ScDocument& rDoc, rtl_TextEncoding eTextEnc );
virtual ~XclImpRootData() override;
};
diff --git a/sc/source/filter/xcl97/xcl97rec.cxx b/sc/source/filter/xcl97/xcl97rec.cxx
index 0cf972fdccd3..30fc08bd9af4 100644
--- a/sc/source/filter/xcl97/xcl97rec.cxx
+++ b/sc/source/filter/xcl97/xcl97rec.cxx
@@ -598,7 +598,7 @@ class VmlCommentExporter : public VMLExport
tools::Rectangle maTo;
public:
- VmlCommentExporter ( sax_fastparser::FSHelperPtr p, ScAddress aScPos, SdrCaptionObj* pCaption, bool bVisible, tools::Rectangle &aFrom, tools::Rectangle &aTo );
+ VmlCommentExporter ( const sax_fastparser::FSHelperPtr& p, const ScAddress& aScPos, SdrCaptionObj* pCaption, bool bVisible, tools::Rectangle &aFrom, tools::Rectangle &aTo );
protected:
virtual void Commit( EscherPropertyContainer& rProps, const tools::Rectangle& rRect ) override;
using VMLExport::StartShape;
@@ -607,7 +607,7 @@ protected:
virtual void EndShape( sal_Int32 nShapeElement ) override;
};
-VmlCommentExporter::VmlCommentExporter( sax_fastparser::FSHelperPtr p, ScAddress aScPos, SdrCaptionObj* pCaption,
+VmlCommentExporter::VmlCommentExporter( const sax_fastparser::FSHelperPtr& p, const ScAddress& aScPos, SdrCaptionObj* pCaption,
bool bVisible, tools::Rectangle &aFrom, tools::Rectangle &aTo )
: VMLExport( p )
, maScPos( aScPos )
diff --git a/sc/source/ui/Accessibility/AccessibleText.cxx b/sc/source/ui/Accessibility/AccessibleText.cxx
index 16d4d3142bd7..5b6f8df55add 100644
--- a/sc/source/ui/Accessibility/AccessibleText.cxx
+++ b/sc/source/ui/Accessibility/AccessibleText.cxx
@@ -397,13 +397,13 @@ class ScPreviewCellViewForwarder : public ScPreviewViewForwarder
ScAddress maCellPos;
public:
ScPreviewCellViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos);
+ const ScAddress& aCellPos);
virtual tools::Rectangle GetVisArea() const override;
};
ScPreviewCellViewForwarder::ScPreviewCellViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos)
+ const ScAddress& aCellPos)
:
ScPreviewViewForwarder(pViewShell),
maCellPos(aCellPos)
@@ -433,14 +433,14 @@ class ScPreviewHeaderCellViewForwarder : public ScPreviewViewForwarder
bool mbColHeader;
public:
ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos,
+ const ScAddress& aCellPos,
bool bColHeader);
virtual tools::Rectangle GetVisArea() const override;
};
ScPreviewHeaderCellViewForwarder::ScPreviewHeaderCellViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos,
+ const ScAddress& aCellPos,
bool bColHeader)
:
ScPreviewViewForwarder(pViewShell),
@@ -472,14 +472,14 @@ class ScPreviewNoteViewForwarder : public ScPreviewViewForwarder
bool mbNoteMark;
public:
ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos,
+ const ScAddress& aCellPos,
bool bNoteMark);
virtual tools::Rectangle GetVisArea() const override;
};
ScPreviewNoteViewForwarder::ScPreviewNoteViewForwarder(ScPreviewShell* pViewShell,
- ScAddress aCellPos,
+ const ScAddress& aCellPos,
bool bNoteMark)
:
ScPreviewViewForwarder(pViewShell),
diff --git a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
index 91a886423b2d..501e97b46319 100644
--- a/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
+++ b/sc/source/ui/StatisticsDialogs/TableFillingAndNavigationTools.cxx
@@ -90,7 +90,7 @@ void FormulaTemplate::applyNumber(const OUString& aVariable, sal_Int32 aValue)
mTemplate = mTemplate.replaceAll(aVariable, OUString::number(aValue));
}
-AddressWalker::AddressWalker(ScAddress aInitialAddress) :
+AddressWalker::AddressWalker(const ScAddress& aInitialAddress) :
mCurrentAddress(aInitialAddress),
mMinimumAddress(aInitialAddress),
mMaximumAddress(aInitialAddress)
@@ -148,7 +148,7 @@ void AddressWalker::push(SCCOL aRelativeCol, SCROW aRelativeRow, SCTAB aRelative
mAddressStack.push_back(mCurrentAddress);
}
-AddressWalkerWriter::AddressWalkerWriter(ScAddress aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
+AddressWalkerWriter::AddressWalkerWriter(const ScAddress& aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
formula::FormulaGrammar::Grammar eGrammar ) :
AddressWalker(aInitialAddress),
mpDocShell(pDocShell),
@@ -263,7 +263,7 @@ ScAddress DataCellIterator::getRelative(int aDelta)
// DataRangeIterator
-DataRangeIterator::DataRangeIterator(ScRange aInputRange) :
+DataRangeIterator::DataRangeIterator(const ScRange& aInputRange) :
mInputRange(aInputRange),
mIndex(0)
{}
diff --git a/sc/source/ui/condformat/condformatdlgitem.cxx b/sc/source/ui/condformat/condformatdlgitem.cxx
index dc038c806ba5..0bd3fcc99d72 100644
--- a/sc/source/ui/condformat/condformatdlgitem.cxx
+++ b/sc/source/ui/condformat/condformatdlgitem.cxx
@@ -8,13 +8,15 @@
*/
+#include <utility>
+
#include "scitems.hxx"
#include "condformatdlgitem.hxx"
ScCondFormatDlgItem::ScCondFormatDlgItem(std::shared_ptr<ScConditionalFormatList> pCondFormats,
sal_Int32 nItem, bool bManaged):
SfxPoolItem(SCITEM_CONDFORMATDLGDATA),
- mpCondFormats(pCondFormats),
+ mpCondFormats(std::move(pCondFormats)),
mnItem(nItem),
meDialogType(condformat::dialog::CONDITION),
mbManaged(bManaged)
diff --git a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
index 0d8d066f94ff..b1d7a54d9a32 100644
--- a/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
+++ b/sc/source/ui/inc/TableFillingAndNavigationTools.hxx
@@ -61,7 +61,7 @@ public:
ScAddress mMinimumAddress;
ScAddress mMaximumAddress;
- AddressWalker(ScAddress aInitialAddress);
+ AddressWalker(const ScAddress& aInitialAddress);
ScAddress current(SCCOL aRelativeCol = 0, SCROW aRelativeRow = 0, SCTAB aRelativeTab = 0);
@@ -81,7 +81,7 @@ public:
ScDocument* mpDocument;
formula::FormulaGrammar::Grammar meGrammar;
- AddressWalkerWriter(ScAddress aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
+ AddressWalkerWriter(const ScAddress& aInitialAddress, ScDocShell* pDocShell, ScDocument* pDocument,
formula::FormulaGrammar::Grammar eGrammar );
void writeFormula(const OUString& aFormula);
@@ -117,7 +117,7 @@ protected:
sal_Int32 mIndex;
public:
- DataRangeIterator(ScRange aInputRange);
+ DataRangeIterator(const ScRange& aInputRange);
virtual ~DataRangeIterator();
virtual bool hasNext() = 0;
diff --git a/sc/source/ui/inc/cellsh.hxx b/sc/source/ui/inc/cellsh.hxx
index 5a3ee9ed6f37..50cd54eecccd 100644
--- a/sc/source/ui/inc/cellsh.hxx
+++ b/sc/source/ui/inc/cellsh.hxx
@@ -80,7 +80,7 @@ private:
static void InitInterface_Impl();
public:
- ScCellShell( ScViewData* pData, VclPtr<vcl::Window> pFrameWin );
+ ScCellShell( ScViewData* pData, const VclPtr<vcl::Window>& pFrameWin );
virtual ~ScCellShell() override;
void Execute(SfxRequest &);
diff --git a/sc/source/ui/inc/notemark.hxx b/sc/source/ui/inc/notemark.hxx
index bf427a66de0e..f01cd52e603f 100644
--- a/sc/source/ui/inc/notemark.hxx
+++ b/sc/source/ui/inc/notemark.hxx
@@ -53,7 +53,7 @@ private:
public:
ScNoteMarker( vcl::Window* pWin, vcl::Window* pRight, vcl::Window* pBottom, vcl::Window* pDiagonal,
- ScDocument* pD, ScAddress aPos, const OUString& rUser,
+ ScDocument* pD, const ScAddress& aPos, const OUString& rUser,
const MapMode& rMap, bool bLeftEdge, bool bForce, bool bKeyboard );
~ScNoteMarker();
diff --git a/sc/source/ui/inc/optsolver.hxx b/sc/source/ui/inc/optsolver.hxx
index a46978b3c19e..1edbdecad7be 100644
--- a/sc/source/ui/inc/optsolver.hxx
+++ b/sc/source/ui/inc/optsolver.hxx
@@ -94,7 +94,7 @@ class ScOptSolverDlg : public ScAnyRefDlg
{
public:
ScOptSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
- ScDocShell* pDocSh, ScAddress aCursorPos );
+ ScDocShell* pDocSh, const ScAddress& aCursorPos );
virtual ~ScOptSolverDlg() override;
virtual void dispose() override;
diff --git a/sc/source/ui/inc/solvrdlg.hxx b/sc/source/ui/inc/solvrdlg.hxx
index 3879d66a813e..2739b24e0634 100644
--- a/sc/source/ui/inc/solvrdlg.hxx
+++ b/sc/source/ui/inc/solvrdlg.hxx
@@ -40,7 +40,7 @@ class ScSolverDlg : public ScAnyRefDlg
public:
ScSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
ScDocument* pDocument,
- ScAddress aCursorPos );
+ const ScAddress& aCursorPos );
virtual ~ScSolverDlg() override;
virtual void dispose() override;
diff --git a/sc/source/ui/inc/uiobject.hxx b/sc/source/ui/inc/uiobject.hxx
index a76e4b315977..b316aa58a13c 100644
--- a/sc/source/ui/inc/uiobject.hxx
+++ b/sc/source/ui/inc/uiobject.hxx
@@ -21,7 +21,7 @@ class ScGridWinUIObject : public WindowUIObject
public:
- ScGridWinUIObject(VclPtr<ScGridWindow> xGridWin);
+ ScGridWinUIObject(const VclPtr<ScGridWindow>& xGridWin);
virtual StringMap get_state() override;
diff --git a/sc/source/ui/inc/undoblk.hxx b/sc/source/ui/inc/undoblk.hxx
index b5cc4ad789c1..1dd470ff264f 100644
--- a/sc/source/ui/inc/undoblk.hxx
+++ b/sc/source/ui/inc/undoblk.hxx
@@ -134,7 +134,7 @@ class ScUndoCut: public ScBlockUndo
public:
ScUndoCut( ScDocShell* pNewDocShell,
ScRange aRange, // adjusted for merged cells
- ScAddress aOldEnd, // end position without adjustment
+ const ScAddress& aOldEnd, // end position without adjustment
const ScMarkData& rMark, // selected sheets
ScDocument* pNewUndoDoc );
virtual ~ScUndoCut() override;
@@ -214,7 +214,7 @@ class ScUndoDragDrop: public ScMoveUndo
{
public:
ScUndoDragDrop( ScDocShell* pNewDocShell,
- const ScRange& rRange, ScAddress aNewDestPos, bool bNewCut,
+ const ScRange& rRange, const ScAddress& aNewDestPos, bool bNewCut,
ScDocument* pUndoDocument,
bool bScenario );
virtual ~ScUndoDragDrop() override;
diff --git a/sc/source/ui/miscdlgs/optsolver.cxx b/sc/source/ui/miscdlgs/optsolver.cxx
index 8296542b6440..7c7eb3fd5704 100644
--- a/sc/source/ui/miscdlgs/optsolver.cxx
+++ b/sc/source/ui/miscdlgs/optsolver.cxx
@@ -177,7 +177,7 @@ ScOptSolverSave::ScOptSolverSave( const OUString& rObjective, bool bMax, bool bM
// class ScOptSolverDlg
ScOptSolverDlg::ScOptSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
- ScDocShell* pDocSh, ScAddress aCursorPos )
+ ScDocShell* pDocSh, const ScAddress& aCursorPos )
: ScAnyRefDlg(pB, pCW, pParent, "SolverDialog", "modules/scalc/ui/solverdlg.ui")
, maInputError(ScGlobal::GetRscString(STR_INVALIDINPUT))
diff --git a/sc/source/ui/miscdlgs/solvrdlg.cxx b/sc/source/ui/miscdlgs/solvrdlg.cxx
index 1d41b94d08f8..06d4a75366ac 100644
--- a/sc/source/ui/miscdlgs/solvrdlg.cxx
+++ b/sc/source/ui/miscdlgs/solvrdlg.cxx
@@ -41,7 +41,7 @@ namespace
ScSolverDlg::ScSolverDlg( SfxBindings* pB, SfxChildWindow* pCW, vcl::Window* pParent,
ScDocument* pDocument,
- ScAddress aCursorPos )
+ const ScAddress& aCursorPos )
: ScAnyRefDlg(pB, pCW, pParent, "GoalSeekDialog", "modules/scalc/ui/goalseekdlg.ui")
, theFormulaCell(aCursorPos)
diff --git a/sc/source/ui/uitest/uiobject.cxx b/sc/source/ui/uitest/uiobject.cxx
index 462915db0ac8..c5cb60dcdcc0 100644
--- a/sc/source/ui/uitest/uiobject.cxx
+++ b/sc/source/ui/uitest/uiobject.cxx
@@ -43,7 +43,7 @@ ScRange get_range_from_string(const OUString& rStr)
}
-ScGridWinUIObject::ScGridWinUIObject(VclPtr<ScGridWindow> xGridWin):
+ScGridWinUIObject::ScGridWinUIObject(const VclPtr<ScGridWindow>& xGridWin):
WindowUIObject(xGridWin),
mxGridWindow(xGridWin)
{
diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx
index 1c2757c40897..a13a3a50f1eb 100644
--- a/sc/source/ui/undo/undoblk.cxx
+++ b/sc/source/ui/undo/undoblk.cxx
@@ -740,7 +740,7 @@ bool ScUndoDeleteMulti::CanRepeat(SfxRepeatTarget& rTarget) const
}
ScUndoCut::ScUndoCut( ScDocShell* pNewDocShell,
- ScRange aRange, ScAddress aOldEnd, const ScMarkData& rMark,
+ ScRange aRange, const ScAddress& aOldEnd, const ScMarkData& rMark,
ScDocument* pNewUndoDoc ) :
ScBlockUndo( pNewDocShell, ScRange(aRange.aStart, aOldEnd), SC_UNDO_AUTOHEIGHT ),
aMarkData( rMark ),
@@ -1112,7 +1112,7 @@ bool ScUndoPaste::CanRepeat(SfxRepeatTarget& rTarget) const
}
ScUndoDragDrop::ScUndoDragDrop( ScDocShell* pNewDocShell,
- const ScRange& rRange, ScAddress aNewDestPos, bool bNewCut,
+ const ScRange& rRange, const ScAddress& aNewDestPos, bool bNewCut,
ScDocument* pUndoDocument, bool bScenario ) :
ScMoveUndo( pNewDocShell, pUndoDocument, nullptr, SC_UNDO_REFLAST ),
mnPaintExtFlags( 0 ),
diff --git a/sc/source/ui/unoobj/textuno.cxx b/sc/source/ui/unoobj/textuno.cxx
index 8d06f5ed5471..ef67bfc77a39 100644
--- a/sc/source/ui/unoobj/textuno.cxx
+++ b/sc/source/ui/unoobj/textuno.cxx
@@ -260,7 +260,7 @@ void ScHeaderFooterTextData::UpdateData(EditEngine& rEditEngine)
}
ScHeaderFooterTextObj::ScHeaderFooterTextObj(
- uno::WeakReference<sheet::XHeaderFooterContent> xContent, ScHeaderFooterPart nP, const EditTextObject* pTextObj) :
+ const uno::WeakReference<sheet::XHeaderFooterContent>& xContent, ScHeaderFooterPart nP, const EditTextObject* pTextObj) :
aTextData(xContent, nP, pTextObj)
{
// ScHeaderFooterTextData acquires rContent
diff --git a/sc/source/ui/view/cellsh.cxx b/sc/source/ui/view/cellsh.cxx
index 3a6a46e03e0b..2bc601a1ae72 100644
--- a/sc/source/ui/view/cellsh.cxx
+++ b/sc/source/ui/view/cellsh.cxx
@@ -75,7 +75,7 @@ void ScCellShell::InitInterface_Impl()
GetStaticInterface()->RegisterPopupMenu("cell");
}
-ScCellShell::ScCellShell(ScViewData* pData, VclPtr<vcl::Window> frameWin) :
+ScCellShell::ScCellShell(ScViewData* pData, const VclPtr<vcl::Window>& frameWin) :
ScFormatShell(pData),
pImpl( new CellShell_Impl() ),
bPastePossible(false),
diff --git a/sc/source/ui/view/notemark.cxx b/sc/source/ui/view/notemark.cxx
index 52dc58ef26d0..348cfddcecc9 100644
--- a/sc/source/ui/view/notemark.cxx
+++ b/sc/source/ui/view/notemark.cxx
@@ -35,7 +35,7 @@
#define SC_NOTEMARK_SHORT 70
ScNoteMarker::ScNoteMarker( vcl::Window* pWin, vcl::Window* pRight, vcl::Window* pBottom, vcl::Window* pDiagonal,
- ScDocument* pD, ScAddress aPos, const OUString& rUser,
+ ScDocument* pD, const ScAddress& aPos, const OUString& rUser,
const MapMode& rMap, bool bLeftEdge, bool bForce, bool bKeyboard ) :
pWindow( pWin ),
pRightWin( pRight ),
diff --git a/sd/inc/CustomAnimationPreset.hxx b/sd/inc/CustomAnimationPreset.hxx
index 94f7448d62ae..e9f46362a58b 100644
--- a/sd/inc/CustomAnimationPreset.hxx
+++ b/sd/inc/CustomAnimationPreset.hxx
@@ -42,7 +42,7 @@ class CustomAnimationPreset
friend class CustomAnimationPresets;
public:
- CustomAnimationPreset( CustomAnimationEffectPtr pEffect );
+ CustomAnimationPreset( const CustomAnimationEffectPtr& pEffect );
void add( const CustomAnimationEffectPtr& pEffect );
diff --git a/sd/source/core/CustomAnimationPreset.cxx b/sd/source/core/CustomAnimationPreset.cxx
index 41ae7cfd8b24..b1b21b3c7145 100644
--- a/sd/source/core/CustomAnimationPreset.cxx
+++ b/sd/source/core/CustomAnimationPreset.cxx
@@ -124,7 +124,7 @@ void implImportLabels( const Reference< XMultiServiceFactory >& xConfigProvider,
}
}
-CustomAnimationPreset::CustomAnimationPreset( CustomAnimationEffectPtr pEffect )
+CustomAnimationPreset::CustomAnimationPreset( const CustomAnimationEffectPtr& pEffect )
{
maPresetId = pEffect->getPresetId();
maProperty = pEffect->getProperty();
diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx b/sd/source/filter/eppt/pptx-epptooxml.cxx
index 68c0b6efa62e..b0e2b238008f 100644
--- a/sd/source/filter/eppt/pptx-epptooxml.cxx
+++ b/sd/source/filter/eppt/pptx-epptooxml.cxx
@@ -68,6 +68,7 @@
#include <com/sun/star/document/XDocumentProperties.hpp>
#include <com/sun/star/document/XDocumentPropertiesSupplier.hpp>
+#include <utility>
// presentation namespaces
#define PNMSS FSNS(XML_xmlns, XML_a), OUStringToOString(this->getNamespaceURL(OOX_NS(dml)), RTL_TEXTENCODING_UTF8).getStr(), \
@@ -211,7 +212,7 @@ int PowerPointExport::GetPPTXLayoutId( int nOffset )
PowerPointShapeExport::PowerPointShapeExport( FSHelperPtr pFS, ShapeHashMap* pShapeMap,
PowerPointExport* pFB )
- : ShapeExport( XML_p, pFS, pShapeMap, pFB )
+ : ShapeExport( XML_p, std::move(pFS), pShapeMap, pFB )
, mrExport( *pFB )
, mePageType(UNDEFINED)
, mbMaster(false)
diff --git a/sd/source/ui/framework/factories/ViewShellWrapper.cxx b/sd/source/ui/framework/factories/ViewShellWrapper.cxx
index b0daeff82be6..44113c264096 100644
--- a/sd/source/ui/framework/factories/ViewShellWrapper.cxx
+++ b/sd/source/ui/framework/factories/ViewShellWrapper.cxx
@@ -52,7 +52,7 @@ using ::com::sun::star::awt::XWindow;
namespace sd { namespace framework {
ViewShellWrapper::ViewShellWrapper (
- std::shared_ptr<ViewShell> pViewShell,
+ const std::shared_ptr<ViewShell>& pViewShell,
const Reference<XResourceId>& rxViewId,
const Reference<awt::XWindow>& rxWindow)
: ViewShellWrapperInterfaceBase(MutexOwner::maMutex),
diff --git a/sd/source/ui/inc/framework/ViewShellWrapper.hxx b/sd/source/ui/inc/framework/ViewShellWrapper.hxx
index 6105da021f71..8d96a20e9e04 100644
--- a/sd/source/ui/inc/framework/ViewShellWrapper.hxx
+++ b/sd/source/ui/inc/framework/ViewShellWrapper.hxx
@@ -64,7 +64,7 @@ public:
to the ViewShell object.
*/
ViewShellWrapper (
- ::std::shared_ptr<ViewShell> pViewShell,
+ const ::std::shared_ptr<ViewShell>& pViewShell,
const css::uno::Reference<css::drawing::framework::XResourceId>& rxViewId,
const css::uno::Reference<css::awt::XWindow>& rxWindow);
virtual ~ViewShellWrapper() override;
diff --git a/sd/source/ui/inc/uiobject.hxx b/sd/source/ui/inc/uiobject.hxx
index 70d8db549dfe..221ad1847122 100644
--- a/sd/source/ui/inc/uiobject.hxx
+++ b/sd/source/ui/inc/uiobject.hxx
@@ -24,7 +24,7 @@ class ImpressWindowUIObject : public WindowUIObject
{
public:
- ImpressWindowUIObject(VclPtr<sd::Window> xWindow);
+ ImpressWindowUIObject(const VclPtr<sd::Window>& xWindow);
virtual StringMap get_state() override;
diff --git a/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx b/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
index 276dc2cd791b..75402f6eb9db 100644
--- a/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
+++ b/sd/source/ui/slidesorter/view/SlsLayeredDevice.cxx
@@ -155,7 +155,7 @@ private:
//===== LayeredDevice =========================================================
-LayeredDevice::LayeredDevice (VclPtr<sd::Window> pTargetWindow)
+LayeredDevice::LayeredDevice (const VclPtr<sd::Window>& pTargetWindow)
: mpTargetWindow(pTargetWindow),
mpLayers(new LayerContainer()),
mpBackBuffer(VclPtr<VirtualDevice>::Create(*mpTargetWindow)),
diff --git a/sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx b/sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
index 487f97963774..c2ca22e706d1 100644
--- a/sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
+++ b/sd/source/ui/slidesorter/view/SlsLayeredDevice.hxx
@@ -42,7 +42,7 @@ class LayeredDevice
{
public:
- explicit LayeredDevice (VclPtr<sd::Window> pTargetWindow);
+ explicit LayeredDevice (const VclPtr<sd::Window>& pTargetWindow);
~LayeredDevice ();
void Invalidate (
diff --git a/sd/source/ui/uitest/uiobject.cxx b/sd/source/ui/uitest/uiobject.cxx
index 68575ccc75fd..a17f98bb5ad7 100644
--- a/sd/source/ui/uitest/uiobject.cxx
+++ b/sd/source/ui/uitest/uiobject.cxx
@@ -19,7 +19,7 @@
class ImpressSdrObject : public SdrUIObject
{
public:
- ImpressSdrObject(VclPtr<sd::Window> xImpressWin, const OUString& rName);
+ ImpressSdrObject(const VclPtr<sd::Window>& xImpressWin, const OUString& rName);
SdrObject* get_object() override;
@@ -31,7 +31,7 @@ private:
namespace {
-sd::DrawViewShell* getViewShell(VclPtr<sd::Window> xWindow)
+sd::DrawViewShell* getViewShell(const VclPtr<sd::Window>& xWindow)
{
sd::DrawViewShell* pViewShell = dynamic_cast<sd::DrawViewShell*>(xWindow->GetViewShell());
assert(pViewShell);
@@ -47,7 +47,7 @@ OUString getObjectName(SdrObject* pObject)
return pObject->GetName();
}
-SdrObject* getObject(VclPtr<sd::Window> xWindow, const OUString& rName)
+SdrObject* getObject(const VclPtr<sd::Window>& xWindow, const OUString& rName)
{
SdrPage* pPage = getViewShell(xWindow)->getCurrentPage();
@@ -68,7 +68,7 @@ SdrObject* getObject(VclPtr<sd::Window> xWindow, const OUString& rName)
}
-ImpressSdrObject::ImpressSdrObject(VclPtr<sd::Window> xImpressWin, const OUString& rName):
+ImpressSdrObject::ImpressSdrObject(const VclPtr<sd::Window>& xImpressWin, const OUString& rName):
mxWindow(xImpressWin),
maName(rName)
{
@@ -79,7 +79,7 @@ SdrObject* ImpressSdrObject::get_object()
return getObject(mxWindow, maName);
}
-ImpressWindowUIObject::ImpressWindowUIObject(VclPtr<sd::Window> xWindow):
+ImpressWindowUIObject::ImpressWindowUIObject(const VclPtr<sd::Window>& xWindow):
WindowUIObject(xWindow),
mxWindow(xWindow)
{
diff --git a/sfx2/inc/uitest/sfx_uiobject.hxx b/sfx2/inc/uitest/sfx_uiobject.hxx
index 2feb03135236..b240a2745aa3 100644
--- a/sfx2/inc/uitest/sfx_uiobject.hxx
+++ b/sfx2/inc/uitest/sfx_uiobject.hxx
@@ -20,7 +20,7 @@ private:
public:
- SfxTabDialogUIObject(VclPtr<SfxTabDialog> xTabDialog);
+ SfxTabDialogUIObject(const VclPtr<SfxTabDialog>& xTabDialog);
virtual ~SfxTabDialogUIObject() override;
diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index 01108b65f849..30d7eb19b0a7 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -74,6 +74,7 @@
#include <framework/interaction.hxx>
#include <unotools/streamhelper.hxx>
#include <unotools/localedatawrapper.hxx>
+#include <utility>
#include <vcl/msgbox.hxx>
#include <svl/stritem.hxx>
#include <svl/eitem.hxx>
@@ -2906,7 +2907,7 @@ SfxMedium::SfxMedium(const OUString &rName, StreamMode nOpenMode, std::shared_pt
pImpl(new SfxMedium_Impl)
{
pImpl->m_pSet = pInSet;
- pImpl->m_pFilter = pFilter;
+ pImpl->m_pFilter = std::move(pFilter);
pImpl->m_aLogicName = rName;
pImpl->m_nStorOpenMode = nOpenMode;
Init_Impl();
@@ -2920,7 +2921,7 @@ SfxMedium::SfxMedium(const OUString &rName, const OUString &rReferer, StreamMode
if (s->GetItem(SID_REFERER) == nullptr) {
s->Put(SfxStringItem(SID_REFERER, rReferer));
}
- pImpl->m_pFilter = pFilter;
+ pImpl->m_pFilter = std::move(pFilter);
pImpl->m_aLogicName = rName;
pImpl->m_nStorOpenMode = nOpenMode;
Init_Impl();
diff --git a/sfx2/source/notebookbar/DropdownBox.cxx b/sfx2/source/notebookbar/DropdownBox.cxx
index 981a220b0959..aba34a36ab72 100644
--- a/sfx2/source/notebookbar/DropdownBox.cxx
+++ b/sfx2/source/notebookbar/DropdownBox.cxx
@@ -37,7 +37,7 @@ private:
ScopedVclPtr<DropdownBox> m_pParent;
public:
- explicit Popup(VclPtr<DropdownBox> pParent)
+ explicit Popup(const VclPtr<DropdownBox>& pParent)
: FloatingWindow(pParent, "Popup", "sfx/ui/notebookbarpopup.ui")
, m_pParent(pParent)
{
diff --git a/sfx2/source/uitest/sfx_uiobject.cxx b/sfx2/source/uitest/sfx_uiobject.cxx
index 062910287adc..cdc7698fdabe 100644
--- a/sfx2/source/uitest/sfx_uiobject.cxx
+++ b/sfx2/source/uitest/sfx_uiobject.cxx
@@ -12,7 +12,7 @@
#include <sfx2/tabdlg.hxx>
-SfxTabDialogUIObject::SfxTabDialogUIObject(VclPtr<SfxTabDialog> xTabDialog):
+SfxTabDialogUIObject::SfxTabDialogUIObject(const VclPtr<SfxTabDialog>& xTabDialog):
WindowUIObject(xTabDialog),
mxTabDialog(xTabDialog)
{
diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx
index 0b41dd8ef095..de0cacabdba3 100644
--- a/sfx2/source/view/viewfrm.cxx
+++ b/sfx2/source/view/viewfrm.cxx
@@ -187,7 +187,7 @@ void SfxEditDocumentDialog::dispose()
}
/// Is this read-only object shell opened via .uno:SignPDF?
-static bool IsSignPDF(SfxObjectShellRef xObjSh)
+static bool IsSignPDF(const SfxObjectShellRef& xObjSh)
{
if (!xObjSh.is())
return false;
diff --git a/starmath/source/uiobject.cxx b/starmath/source/uiobject.cxx
index d505ed9d95eb..51b0733ff545 100644
--- a/starmath/source/uiobject.cxx
+++ b/starmath/source/uiobject.cxx
@@ -12,7 +12,7 @@
#include "ElementsDockingWindow.hxx"
-ElementUIObject::ElementUIObject(VclPtr<SmElementsControl> xElementSelector,
+ElementUIObject::ElementUIObject(const VclPtr<SmElementsControl>& xElementSelector,
const OUString& rID):
mxElementsSelector(xElementSelector),
maID(rID)
@@ -52,7 +52,7 @@ void ElementUIObject::execute(const OUString& rAction,
}
}
-ElementSelectorUIObject::ElementSelectorUIObject(VclPtr<SmElementsControl> xElementSelector):
+ElementSelectorUIObject::ElementSelectorUIObject(const VclPtr<SmElementsControl>& xElementSelector):
WindowUIObject(xElementSelector),
mxElementsSelector(xElementSelector)
{
diff --git a/starmath/source/uiobject.hxx b/starmath/source/uiobject.hxx
index 004f1ab79dd1..ecfef8abe627 100644
--- a/starmath/source/uiobject.hxx
+++ b/starmath/source/uiobject.hxx
@@ -24,7 +24,7 @@ private:
public:
- ElementUIObject(VclPtr<SmElementsControl> xElementSelector,
+ ElementUIObject(const VclPtr<SmElementsControl>& xElementSelector,
const OUString& rID);
virtual StringMap get_state() override;
@@ -43,7 +43,7 @@ private:
public:
- explicit ElementSelectorUIObject(VclPtr<SmElementsControl> xElementSelector);
+ explicit ElementSelectorUIObject(const VclPtr<SmElementsControl>& xElementSelector);
virtual StringMap get_state() override;
diff --git a/svtools/inc/uitest/uiobject.hxx b/svtools/inc/uitest/uiobject.hxx
index e8ed0af640af..d8a525c206ee 100644
--- a/svtools/inc/uitest/uiobject.hxx
+++ b/svtools/inc/uitest/uiobject.hxx
@@ -17,7 +17,7 @@ class SvSimpleTable;
class TreeListUIObject : public WindowUIObject
{
public:
- TreeListUIObject(VclPtr<SvTreeListBox> xTreeList);
+ TreeListUIObject(const VclPtr<SvTreeListBox>& xTreeList);
virtual StringMap get_state() override;
@@ -43,7 +43,7 @@ class TreeListEntryUIObject : public UIObject
{
public:
- TreeListEntryUIObject(VclPtr<SvTreeListBox> xTreeList, SvTreeListEntry* pEntry);
+ TreeListEntryUIObject(const VclPtr<SvTreeListBox>& xTreeList, SvTreeListEntry* pEntry);
virtual StringMap get_state() override;
@@ -66,7 +66,7 @@ private:
class SimpleTableUIObject : public TreeListUIObject
{
public:
- SimpleTableUIObject(VclPtr<SvSimpleTable> xTable);
+ SimpleTableUIObject(const VclPtr<SvSimpleTable>& xTable);
virtual StringMap get_state() override;
diff --git a/svtools/source/contnr/svlbitm.cxx b/svtools/source/contnr/svlbitm.cxx
index f520b747a8c1..ae3e14481534 100644
--- a/svtools/source/contnr/svlbitm.cxx
+++ b/svtools/source/contnr/svlbitm.cxx
@@ -401,7 +401,7 @@ struct SvLBoxContextBmp_Impl
// ***************************************************************
-SvLBoxContextBmp::SvLBoxContextBmp(Image aBmp1, Image aBmp2,
+SvLBoxContextBmp::SvLBoxContextBmp(const Image& aBmp1, const Image& aBmp2,
bool bExpanded)
:m_pImpl( new SvLBoxContextBmp_Impl )
{
diff --git a/svtools/source/uitest/uiobject.cxx b/svtools/source/uitest/uiobject.cxx
index f36d57e153c4..19ab911876af 100644
--- a/svtools/source/uitest/uiobject.cxx
+++ b/svtools/source/uitest/uiobject.cxx
@@ -13,7 +13,7 @@
#include <svtools/treelistbox.hxx>
#include <svtools/simptabl.hxx>
-TreeListUIObject::TreeListUIObject(VclPtr<SvTreeListBox> xTreeList):
+TreeListUIObject::TreeListUIObject(const VclPtr<SvTreeListBox>& xTreeList):
WindowUIObject(xTreeList),
mxTreeList(xTreeList)
{
@@ -21,7 +21,7 @@ TreeListUIObject::TreeListUIObject(VclPtr<SvTreeListBox> xTreeList):
namespace {
-bool isCheckBoxList(VclPtr<SvTreeListBox> xTreeList)
+bool isCheckBoxList(const VclPtr<SvTreeListBox>& xTreeList)
{
return (xTreeList->GetTreeFlags() & SvTreeFlags::CHKBTN) == SvTreeFlags::CHKBTN;
}
@@ -90,7 +90,7 @@ std::unique_ptr<UIObject> TreeListUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new TreeListUIObject(pTreeList));
}
-TreeListEntryUIObject::TreeListEntryUIObject(VclPtr<SvTreeListBox> xTreeList, SvTreeListEntry* pEntry):
+TreeListEntryUIObject::TreeListEntryUIObject(const VclPtr<SvTreeListBox>& xTreeList, SvTreeListEntry* pEntry):
mxTreeList(xTreeList),
mpEntry(pEntry)
{
@@ -161,7 +161,7 @@ OUString TreeListEntryUIObject::get_type() const
return OUString("TreeListEntry");
}
-SimpleTableUIObject::SimpleTableUIObject(VclPtr<SvSimpleTable> xTable):
+SimpleTableUIObject::SimpleTableUIObject(const VclPtr<SvSimpleTable>& xTable):
TreeListUIObject(xTable),
mxTable(xTable)
{
diff --git a/svx/inc/uiobject.hxx b/svx/inc/uiobject.hxx
index 6159a26f98a8..e0baae6815b0 100644
--- a/svx/inc/uiobject.hxx
+++ b/svx/inc/uiobject.hxx
@@ -18,7 +18,7 @@ class SvxShowCharSetUIObject : public WindowUIObject
public:
- SvxShowCharSetUIObject(VclPtr<SvxShowCharSet> xCharSet);
+ SvxShowCharSetUIObject(const VclPtr<SvxShowCharSet>& xCharSet);
virtual StringMap get_state() override;
diff --git a/svx/source/engine3d/cube3d.cxx b/svx/source/engine3d/cube3d.cxx
index 5f493084007e..ec456e463e7c 100644
--- a/svx/source/engine3d/cube3d.cxx
+++ b/svx/source/engine3d/cube3d.cxx
@@ -35,7 +35,7 @@ sdr::contact::ViewContact* E3dCubeObj::CreateObjectSpecificViewContact()
}
-E3dCubeObj::E3dCubeObj(E3dDefaultAttributes& rDefault, basegfx::B3DPoint aPos, const basegfx::B3DVector& r3DSize)
+E3dCubeObj::E3dCubeObj(E3dDefaultAttributes& rDefault, const basegfx::B3DPoint& aPos, const basegfx::B3DVector& r3DSize)
: E3dCompoundObject(rDefault)
{
// Set Defaults
diff --git a/svx/source/uitest/uiobject.cxx b/svx/source/uitest/uiobject.cxx
index 701eb7ef891c..8ad4827df260 100644
--- a/svx/source/uitest/uiobject.cxx
+++ b/svx/source/uitest/uiobject.cxx
@@ -12,7 +12,7 @@
#include <svx/charmap.hxx>
-SvxShowCharSetUIObject::SvxShowCharSetUIObject(VclPtr<SvxShowCharSet> xCharSet):
+SvxShowCharSetUIObject::SvxShowCharSetUIObject(const VclPtr<SvxShowCharSet>& xCharSet):
WindowUIObject(xCharSet),
mxCharSet(xCharSet)
{
diff --git a/sw/inc/unochart.hxx b/sw/inc/unochart.hxx
index c5168a45e3a8..38e3b34e6a2c 100644
--- a/sw/inc/unochart.hxx
+++ b/sw/inc/unochart.hxx
@@ -264,7 +264,7 @@ protected:
public:
SwChartDataSequence( SwChartDataProvider &rProvider,
SwFrameFormat &rTableFormat,
- std::shared_ptr<SwUnoCursor> pTableCursor );
+ const std::shared_ptr<SwUnoCursor>& pTableCursor );
virtual ~SwChartDataSequence() override;
static const css::uno::Sequence< sal_Int8 > & getUnoTunnelId();
diff --git a/sw/inc/unoredline.hxx b/sw/inc/unoredline.hxx
index c1be37289a6a..bcf65d6ecefd 100644
--- a/sw/inc/unoredline.hxx
+++ b/sw/inc/unoredline.hxx
@@ -37,7 +37,7 @@ class SwXRedlineText :
virtual const SwStartNode *GetStartNode() const override;
public:
- SwXRedlineText(SwDoc* pDoc, SwNodeIndex aNodeIndex);
+ SwXRedlineText(SwDoc* pDoc, const SwNodeIndex& aNodeIndex);
virtual css::uno::Any SAL_CALL queryInterface( const css::uno::Type& aType ) override;
virtual void SAL_CALL acquire( ) throw() override {OWeakObject::acquire();}
diff --git a/sw/source/core/access/accmap.cxx b/sw/source/core/access/accmap.cxx
index 895a4bfd9c7e..6848f479c35b 100644
--- a/sw/source/core/access/accmap.cxx
+++ b/sw/source/core/access/accmap.cxx
@@ -522,12 +522,12 @@ public:
size_t size() const { return maEvents.size(); }
std::list<SwAccessibleEvent_Impl>::iterator begin() { return maEvents.begin(); }
std::list<SwAccessibleEvent_Impl>::iterator end() { return maEvents.end(); }
- std::list<SwAccessibleEvent_Impl>::iterator insert( std::list<SwAccessibleEvent_Impl>::iterator aIter,
+ std::list<SwAccessibleEvent_Impl>::iterator insert( const std::list<SwAccessibleEvent_Impl>::iterator& aIter,
const SwAccessibleEvent_Impl& rEvent )
{
return maEvents.insert( aIter, rEvent );
}
- std::list<SwAccessibleEvent_Impl>::iterator erase( std::list<SwAccessibleEvent_Impl>::iterator aPos )
+ std::list<SwAccessibleEvent_Impl>::iterator erase( const std::list<SwAccessibleEvent_Impl>::iterator& aPos )
{
return maEvents.erase( aPos );
}
diff --git a/sw/source/core/unocore/unochart.cxx b/sw/source/core/unocore/unochart.cxx
index 85bfea52418c..aebcff0a7700 100644
--- a/sw/source/core/unocore/unochart.cxx
+++ b/sw/source/core/unocore/unochart.cxx
@@ -1856,7 +1856,7 @@ uno::Sequence< OUString > SAL_CALL SwChartDataSource::getSupportedServiceNames(
SwChartDataSequence::SwChartDataSequence(
SwChartDataProvider &rProvider,
SwFrameFormat &rTableFormat,
- std::shared_ptr<SwUnoCursor> pTableCursor ) :
+ const std::shared_ptr<SwUnoCursor>& pTableCursor ) :
SwClient( &rTableFormat ),
m_aEvtListeners( GetChartMutex() ),
m_aModifyListeners( GetChartMutex() ),
diff --git a/sw/source/core/unocore/unoredline.cxx b/sw/source/core/unocore/unoredline.cxx
index 80d1adb4d405..10791acf54b2 100644
--- a/sw/source/core/unocore/unoredline.cxx
+++ b/sw/source/core/unocore/unoredline.cxx
@@ -48,7 +48,7 @@
using namespace ::com::sun::star;
-SwXRedlineText::SwXRedlineText(SwDoc* _pDoc, SwNodeIndex aIndex) :
+SwXRedlineText::SwXRedlineText(SwDoc* _pDoc, const SwNodeIndex& aIndex) :
SwXText(_pDoc, CursorType::Redline),
aNodeIndex(aIndex)
{
diff --git a/sw/source/filter/ww8/docxattributeoutput.cxx b/sw/source/filter/ww8/docxattributeoutput.cxx
index add0ba01426b..ba3bf43875c8 100644
--- a/sw/source/filter/ww8/docxattributeoutput.cxx
+++ b/sw/source/filter/ww8/docxattributeoutput.cxx
@@ -8577,7 +8577,7 @@ void DocxAttributeOutput::CharGrabBag( const SfxGrabBagItem& rItem )
}
}
-DocxAttributeOutput::DocxAttributeOutput( DocxExport &rExport, FSHelperPtr pSerializer, oox::drawingml::DrawingML* pDrawingML )
+DocxAttributeOutput::DocxAttributeOutput( DocxExport &rExport, const FSHelperPtr& pSerializer, oox::drawingml::DrawingML* pDrawingML )
: m_rExport( rExport ),
m_pSerializer( pSerializer ),
m_rDrawingML( *pDrawingML ),
diff --git a/sw/source/filter/ww8/docxattributeoutput.hxx b/sw/source/filter/ww8/docxattributeoutput.hxx
index a4f3fe8fbc58..712ae06b9589 100644
--- a/sw/source/filter/ww8/docxattributeoutput.hxx
+++ b/sw/source/filter/ww8/docxattributeoutput.hxx
@@ -942,7 +942,7 @@ private:
std::map<SvxBoxItemLine, css::table::BorderLine2> m_aTableStyleConf;
public:
- DocxAttributeOutput( DocxExport &rExport, ::sax_fastparser::FSHelperPtr pSerializer, oox::drawingml::DrawingML* pDrawingML );
+ DocxAttributeOutput( DocxExport &rExport, const ::sax_fastparser::FSHelperPtr& pSerializer, oox::drawingml::DrawingML* pDrawingML );
virtual ~DocxAttributeOutput() override;
diff --git a/sw/source/filter/ww8/wrtw8esh.cxx b/sw/source/filter/ww8/wrtw8esh.cxx
index da6023a18345..fce28149f983 100644
--- a/sw/source/filter/ww8/wrtw8esh.cxx
+++ b/sw/source/filter/ww8/wrtw8esh.cxx
@@ -2439,7 +2439,7 @@ void SwEscherEx::FinishEscher()
namespace
{
template<typename OrientType>
- void lcl_SetRelationOrient(OrientType& rOrient, const sw::WW8AnchorConv eConv, std::function<void()> fDefault)
+ void lcl_SetRelationOrient(OrientType& rOrient, const sw::WW8AnchorConv eConv, const std::function<void()>& fDefault)
{
switch(eConv)
{
diff --git a/sw/source/filter/xml/xmlexpit.cxx b/sw/source/filter/xml/xmlexpit.cxx
index b4a4ec33c02d..91b2a1456241 100644
--- a/sw/source/filter/xml/xmlexpit.cxx
+++ b/sw/source/filter/xml/xmlexpit.cxx
@@ -24,6 +24,7 @@
#include <svl/itempool.hxx>
#include <svl/poolitem.hxx>
#include <svl/itemset.hxx>
+#include <utility>
#include <xmloff/xmluconv.hxx>
#include <xmloff/attrlist.hxx>
#include <xmloff/nmspmap.hxx>
@@ -278,7 +279,7 @@ const SfxPoolItem* SvXMLExportItemMapper::GetItem( const SfxItemSet& rSet,
SvXMLExportItemMapper::SvXMLExportItemMapper( SvXMLItemMapEntriesRef rMapEntries )
{
- mrMapEntries = rMapEntries;
+ mrMapEntries = std::move(rMapEntries);
}
SvXMLExportItemMapper::~SvXMLExportItemMapper()
diff --git a/sw/source/filter/xml/xmlimpit.cxx b/sw/source/filter/xml/xmlimpit.cxx
index adec1835221d..d7eeb7926372 100644
--- a/sw/source/filter/xml/xmlimpit.cxx
+++ b/sw/source/filter/xml/xmlimpit.cxx
@@ -20,6 +20,7 @@
#include "xmlimpit.hxx"
#include <sax/tools/converter.hxx>
+#include <utility>
#include <xmloff/xmluconv.hxx>
#include <svl/itempool.hxx>
#include <svl/poolitem.hxx>
@@ -71,7 +72,7 @@ SvXMLImportItemMapper::~SvXMLImportItemMapper()
void
SvXMLImportItemMapper::setMapEntries( SvXMLItemMapEntriesRef rMapEntries )
{
- mrMapEntries = rMapEntries;
+ mrMapEntries = std::move(rMapEntries);
}
// fills the given itemset with the attributes in the given list
diff --git a/sw/source/filter/xml/xmliteme.cxx b/sw/source/filter/xml/xmliteme.cxx
index f9f22ca9e21b..5f7ede99c079 100644
--- a/sw/source/filter/xml/xmliteme.cxx
+++ b/sw/source/filter/xml/xmliteme.cxx
@@ -22,6 +22,7 @@
#include <hintids.hxx>
#include <rtl/ustring.hxx>
#include <rtl/ustrbuf.hxx>
+#include <utility>
#include <xmloff/xmluconv.hxx>
#include "xmlexpit.hxx"
#include <xmloff/nmspmap.hxx>
@@ -85,7 +86,7 @@ public:
SwXMLTableItemMapper_Impl::SwXMLTableItemMapper_Impl(
SvXMLItemMapEntriesRef rMapEntries,
SwXMLExport& rExp ) :
- SvXMLExportItemMapper( rMapEntries ),
+ SvXMLExportItemMapper( std::move(rMapEntries) ),
aBrushItemExport( rExp ),
nAbsWidth( USHRT_MAX )
{
diff --git a/sw/source/filter/xml/xmlitemi.cxx b/sw/source/filter/xml/xmlitemi.cxx
index fe218c4c1627..1c43e5c4bffc 100644
--- a/sw/source/filter/xml/xmlitemi.cxx
+++ b/sw/source/filter/xml/xmlitemi.cxx
@@ -57,7 +57,7 @@ class SwXMLImportTableItemMapper_Impl: public SvXMLImportItemMapper
public:
- explicit SwXMLImportTableItemMapper_Impl(SvXMLItemMapEntriesRef rMapEntries);
+ explicit SwXMLImportTableItemMapper_Impl(const SvXMLItemMapEntriesRef& rMapEntries);
virtual bool handleSpecialItem( const SvXMLItemMapEntry& rEntry,
SfxPoolItem& rItem,
@@ -87,7 +87,7 @@ private:
};
SwXMLImportTableItemMapper_Impl::SwXMLImportTableItemMapper_Impl(
- SvXMLItemMapEntriesRef rMapEntries ) :
+ const SvXMLItemMapEntriesRef& rMapEntries ) :
SvXMLImportItemMapper( rMapEntries )
{
Reset();
diff --git a/sw/source/uibase/inc/uiobject.hxx b/sw/source/uibase/inc/uiobject.hxx
index 08310ba17473..3270452b1ea7 100644
--- a/sw/source/uibase/inc/uiobject.hxx
+++ b/sw/source/uibase/inc/uiobject.hxx
@@ -19,7 +19,7 @@ class SwEditWinUIObject : public WindowUIObject
{
public:
- SwEditWinUIObject(VclPtr<SwEditWin> xEditWin);
+ SwEditWinUIObject(const VclPtr<SwEditWin>& xEditWin);
virtual StringMap get_state() override;
diff --git a/sw/source/uibase/uitest/uiobject.cxx b/sw/source/uibase/uitest/uiobject.cxx
index eb1f23677fd9..3aadd94d179c 100644
--- a/sw/source/uibase/uitest/uiobject.cxx
+++ b/sw/source/uibase/uitest/uiobject.cxx
@@ -13,7 +13,7 @@
#include "view.hxx"
#include "wrtsh.hxx"
-SwEditWinUIObject::SwEditWinUIObject(VclPtr<SwEditWin> xEditWin):
+SwEditWinUIObject::SwEditWinUIObject(const VclPtr<SwEditWin>& xEditWin):
WindowUIObject(xEditWin),
mxEditWin(xEditWin)
{
diff --git a/vcl/source/edit/textdat2.hxx b/vcl/source/edit/textdat2.hxx
index d74541e7e75b..d715845d45e6 100644
--- a/vcl/source/edit/textdat2.hxx
+++ b/vcl/source/edit/textdat2.hxx
@@ -87,8 +87,8 @@ public:
std::vector<TETextPortion*>::const_iterator end() const;
bool empty() const;
std::size_t size() const;
- std::vector<TETextPortion*>::iterator erase( std::vector<TETextPortion*>::iterator aIter );
- std::vector<TETextPortion*>::iterator insert( std::vector<TETextPortion*>::iterator aIter,
+ std::vector<TETextPortion*>::iterator erase( const std::vector<TETextPortion*>::iterator& aIter );
+ std::vector<TETextPortion*>::iterator insert( const std::vector<TETextPortion*>::iterator& aIter,
TETextPortion* pTP );
void push_back( TETextPortion* pTP );
diff --git a/vcl/source/edit/textdata.cxx b/vcl/source/edit/textdata.cxx
index ea6bd1d1ef0e..f3a65d5275e0 100644
--- a/vcl/source/edit/textdata.cxx
+++ b/vcl/source/edit/textdata.cxx
@@ -93,12 +93,12 @@ std::size_t TETextPortionList::size() const
return maPortions.size();
}
-std::vector<TETextPortion*>::iterator TETextPortionList::erase( std::vector<TETextPortion*>::iterator aIter )
+std::vector<TETextPortion*>::iterator TETextPortionList::erase( const std::vector<TETextPortion*>::iterator& aIter )
{
return maPortions.erase( aIter );
}
-std::vector<TETextPortion*>::iterator TETextPortionList::insert( std::vector<TETextPortion*>::iterator aIter,
+std::vector<TETextPortion*>::iterator TETextPortionList::insert( const std::vector<TETextPortion*>::iterator& aIter,
TETextPortion* pTP )
{
return maPortions.insert( aIter, pTP );
diff --git a/vcl/source/uitest/uiobject.cxx b/vcl/source/uitest/uiobject.cxx
index 6f0ff412e98e..70637a0e8a66 100644
--- a/vcl/source/uitest/uiobject.cxx
+++ b/vcl/source/uitest/uiobject.cxx
@@ -262,7 +262,7 @@ OUString to_string(const Size& rSize)
}
-WindowUIObject::WindowUIObject(VclPtr<vcl::Window> xWindow):
+WindowUIObject::WindowUIObject(const VclPtr<vcl::Window>& xWindow):
mxWindow(xWindow)
{
}
@@ -525,7 +525,7 @@ std::unique_ptr<UIObject> WindowUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new WindowUIObject(pWindow));
}
-ButtonUIObject::ButtonUIObject(VclPtr<Button> xButton):
+ButtonUIObject::ButtonUIObject(const VclPtr<Button>& xButton):
WindowUIObject(xButton),
mxButton(xButton)
{
@@ -565,7 +565,7 @@ std::unique_ptr<UIObject> ButtonUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new ButtonUIObject(pButton));
}
-DialogUIObject::DialogUIObject(VclPtr<Dialog> xDialog):
+DialogUIObject::DialogUIObject(const VclPtr<Dialog>& xDialog):
WindowUIObject(xDialog),
mxDialog(xDialog)
{
@@ -595,7 +595,7 @@ std::unique_ptr<UIObject> DialogUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new DialogUIObject(pDialog));
}
-EditUIObject::EditUIObject(VclPtr<Edit> xEdit):
+EditUIObject::EditUIObject(const VclPtr<Edit>& xEdit):
WindowUIObject(xEdit),
mxEdit(xEdit)
{
@@ -668,7 +668,7 @@ std::unique_ptr<UIObject> EditUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new EditUIObject(pEdit));
}
-CheckBoxUIObject::CheckBoxUIObject(VclPtr<CheckBox> xCheckbox):
+CheckBoxUIObject::CheckBoxUIObject(const VclPtr<CheckBox>& xCheckbox):
WindowUIObject(xCheckbox),
mxCheckBox(xCheckbox)
{
@@ -708,7 +708,7 @@ std::unique_ptr<UIObject> CheckBoxUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new CheckBoxUIObject(pCheckBox));
}
-RadioButtonUIObject::RadioButtonUIObject(VclPtr<RadioButton> xRadioButton):
+RadioButtonUIObject::RadioButtonUIObject(const VclPtr<RadioButton>& xRadioButton):
WindowUIObject(xRadioButton),
mxRadioButton(xRadioButton)
{
@@ -746,7 +746,7 @@ std::unique_ptr<UIObject> RadioButtonUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new RadioButtonUIObject(pRadioButton));
}
-TabPageUIObject::TabPageUIObject(VclPtr<TabPage> xTabPage):
+TabPageUIObject::TabPageUIObject(const VclPtr<TabPage>& xTabPage):
WindowUIObject(xTabPage),
mxTabPage(xTabPage)
{
@@ -777,7 +777,7 @@ OUString TabPageUIObject::get_name() const
return OUString("TabPageUIObject");
}
-ListBoxUIObject::ListBoxUIObject(VclPtr<ListBox> xListBox):
+ListBoxUIObject::ListBoxUIObject(const VclPtr<ListBox>& xListBox):
WindowUIObject(xListBox),
mxListBox(xListBox)
{
@@ -851,7 +851,7 @@ std::unique_ptr<UIObject> ListBoxUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new ListBoxUIObject(pListBox));
}
-ComboBoxUIObject::ComboBoxUIObject(VclPtr<ComboBox> xComboBox):
+ComboBoxUIObject::ComboBoxUIObject(const VclPtr<ComboBox>& xComboBox):
WindowUIObject(xComboBox),
mxComboBox(xComboBox)
{
@@ -909,7 +909,7 @@ std::unique_ptr<UIObject> ComboBoxUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new ComboBoxUIObject(pComboBox));
}
-SpinUIObject::SpinUIObject(VclPtr<SpinButton> xSpinButton):
+SpinUIObject::SpinUIObject(const VclPtr<SpinButton>& xSpinButton):
WindowUIObject(xSpinButton),
mxSpinButton(xSpinButton)
{
@@ -947,7 +947,7 @@ OUString SpinUIObject::get_name() const
return OUString("SpinUIObject");
}
-SpinFieldUIObject::SpinFieldUIObject(VclPtr<SpinField> xSpinField):
+SpinFieldUIObject::SpinFieldUIObject(const VclPtr<SpinField>& xSpinField):
EditUIObject(xSpinField),
mxSpinField(xSpinField)
{
@@ -1000,7 +1000,7 @@ std::unique_ptr<UIObject> SpinFieldUIObject::create(vcl::Window* pWindow)
return std::unique_ptr<UIObject>(new SpinFieldUIObject(pSpinField));
}
-TabControlUIObject::TabControlUIObject(VclPtr<TabControl> xTabControl):
... etc. - the rest is truncated
More information about the Libreoffice-commits
mailing list